February 2009 - Wine-Devel - list.winehq.org

Re: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

by Paul Vriens

Juan Lang wrote: > This removes the unused variables in the last version. > --Juan > > > ------------------------------------------------------------------------ > > I think that these failures are also because of "not enough rights" (people running winetest as a normal user). So just removing them is probably not the best approach? -- Cheers, Paul.

Feb. 12, 2009

Re: mshtml: Implement IHTMLStyle get/put minHeight (resend)

by Jacek Caban

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put minHeight > [get|set]_nsstyle_attr_var functions were introduces to avoid the code duplication like you do. You should use them (and probably implement VT_I4 handling in set_nsstyle_attr_var). Jacek

Feb. 12, 2009

Re: Is the test.winehq.org front page too pessimistic?

by Paul Vriens

John Klehm wrote: > On Thu, Feb 12, 2009 at 8:27 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> I do it for my own boxes (see attachment). The spikes (up and down) are >> mainly >> when I didn't run the tests on all my boxes. But you can see the overall >> trend. >> > > Nice. :) What are you using to generate that? > > --John Klehm > Google Chart API : http://code.google.com/apis/chart/ -- Cheers, Paul.

Feb. 12, 2009

Re: Is the test.winehq.org front page too pessimistic?

by John Klehm

On Thu, Feb 12, 2009 at 8:27 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > I do it for my own boxes (see attachment). The spikes (up and down) are > mainly > when I didn't run the tests on all my boxes. But you can see the overall > trend. > Nice. :) What are you using to generate that? --John Klehm

Feb. 12, 2009

Re: mshtml: Implement IHTMLStyle_put_textDecorationUnderline (resend)

by Jacek Caban

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle_put_textDecorationUnderline + + return set_style_attr(This, STYLEID_TEXT_DECORATION, v == VARIANT_TRUE ? valUnderline : emptyW, 0); You shouldn't compare v to VARIANT_TRUE. The correct way to deal with bool values is 'v ? valUnderline : emptyW'. Jacek

Feb. 12, 2009

Re: ntdll: Avoid Potential Infinite Loop

by John Klehm

On Thu, Feb 12, 2009 at 2:30 AM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > Something like "We think your product is superlative .... but someone may > wonder if your code not finding this bug in our code might be a bug in your > code." > Well I don't think coverity claims 100% of bugs will be found. :) > > SERVER_START_REQ( get_token_groups ) > { > TOKEN_GROUPS *groups = tokeninfo; > > + > req->handle = wine_server_obj_handle( token ); > Unneeded whitespace change. Regards, --John Klehm

Feb. 12, 2009

Re: Is the test.winehq.org front page too pessimistic?

by Paul Vriens

John Klehm wrote: > On Wed, Feb 11, 2009 at 3:58 PM, Juan Lang <juan.lang(a)gmail.com> wrote: >> My own feeling is that there are far fewer failing tests now than >> there used to be, and I'd sure like to see that reflected somewhere at >> a quick glance. Thoughts? > > Maybe a test.winehq.org/trends page showing some nice (hopefully > upwards) trend graphs of number of succeeding tests? > > --John Klehm > > > I do it for my own boxes (see attachment). The spikes (up and down) are mainly when I didn't run the tests on all my boxes. But you can see the overall trend. -- Cheers, Paul.

Feb. 12, 2009

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

by Huw Davies

On Thu, Feb 12, 2009 at 01:40:54PM +0100, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/font.c | 20 ++++++++++---------- >> 1 files changed, 10 insertions(+), 10 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> > Looks a lot like: > > http://www.winehq.org/pipermail/wine-patches/2009-February/069297.html > > Maybe we should use yours as it has less changes to the code. Doh, I just saw that patch after I sent mine! Huw.

Feb. 12, 2009

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

by Paul Vriens

Huw Davies wrote: > --- > dlls/gdi32/tests/font.c | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > > ------------------------------------------------------------------------ > > Looks a lot like: http://www.winehq.org/pipermail/wine-patches/2009-February/069297.html Maybe we should use yours as it has less changes to the code. -- Cheers, Paul.

Feb. 12, 2009

Re: Download page requires too much scrolling...

by Scott Ritchie

Dan Kegel wrote: > While I was generating screenshots for my presentation, > I noticed that http://www.winehq.org/download/ has too > much clutter at the top. I don't mind the Codeweavers > ad, but it's not good that users have to scroll down > to see the useful part of the page... > > Good point, I've submitted a patch to remove some clutter. We don't actually need to tell people in text that they're getting some files from sourceforge, for instance. Thanks, Scott Ritchie

Feb. 12, 2009