February 2009 - Wine-Devel - list.winehq.org

Re: dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

by Vitaliy Margolen

Vincent Pelletier wrote: > Le Saturday 07 February 2009 19:25:56 Vitaliy Margolen, vous avez écrit : >> So I'd suggest copying name into both places. > > Ok. > >> And append "evdev?" at the end so we can tell how it's handled. > > See attached patch. > First version I locally wrote only stored an additional int in joydev, but: > - maybe it's not a good idea to compute the concatenation on each > fill_joystick_dideviceinstance[AW] call > - ...I just don't know how to append to a widechar string (MSDN list of > widechar funcs) > > Sorry didn't reply earlier - no this is not what I meant. Native returns the same string for both. So just drop the device path all together. Make it the name returned from the kernel + "evdev%d" ala "USB" native adds. Vitaliy.

Feb. 10, 2009

Re: [try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

by Ben Klein

2009/2/10 Vincent Pelletier <plr.vincent(a)gmail.com>: > Le Monday 09 February 2009 22:22:02 Vincent Pelletier, vous avez écrit : >> Same patch as first proposed on wine-devel, no reaction so I guess it's >> correct. > > Miss. > Was to be posted on wine-patches. (I resent it there already) Umm ... I just took a quick look. You're adding a new field to the JoyDev struct called instance_name, which if I read right will store the input device path, but what happens to the existing device field? It looks like it's just taking up space, not actually getting a value stored in it.

Feb. 10, 2009

Re: itss: Replace malloc() with HeapAlloc()

by Nikolay Sivov

Andrew Talbot wrote: > Changelog: > itss: Replace malloc() with HeapAlloc(). > > diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c > index b5fdfc7..0ffeeb6 100644 > --- a/dlls/itss/lzx.c > +++ b/dlls/itss/lzx.c > @@ -36,15 +36,17 @@ > ***************************************************************************/ > > #include "lzx.h" > +#include <stdarg.h> > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > > +#include "windef.h" > +#include "winbase.h" > + > /* sized types */ > typedef unsigned char UBYTE; /* 8 bits exactly */ > typedef unsigned short UWORD; /* 16 bits (or more) */ > -typedef unsigned int ULONG; /* 32 bits (or more) */ > -typedef signed int LONG; /* 32 bits (or more) */ > > /* some constants defined by the LZX specification */ > #define LZX_MIN_MATCH (2) > @@ -178,8 +180,8 @@ struct LZXstate *LZXinit(int window) > if (window < 15 || window > 21) return NULL; > > /* allocate state and associated window */ > - pState = malloc(sizeof(struct LZXstate)); > - if (!(pState->window = malloc(wndsize))) > + pState = HeapAlloc(GetProcessHeap(), 0, sizeof(struct LZXstate)); > + if (!(pState->window = HeapAlloc(GetProcessHeap(), 0, wndsize))) > { > free(pState); > return NULL; > Why didn't you replace corresponding free() calls?

Feb. 9, 2009

Re: comctl32/tests: [try 2] Make the test dpi and Theme aware: use SM_CYSIZE

by Detlef Riekenberg

On Mo, 2009-02-09 at 19:09 +0100, Paul Vriens wrote: > This patch introduced a lot of failures on specifically some XP and W2K3 boxes. grrr... > Could you have a look? Yes. I try to reproduce the failures. -- By by ... Detlef

Feb. 9, 2009

Re: [try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

by Vincent Pelletier

Le Monday 09 February 2009 22:22:02 Vincent Pelletier, vous avez écrit : > Same patch as first proposed on wine-devel, no reaction so I guess it's > correct. Miss. Was to be posted on wine-patches. (I resent it there already) -- Vincent Pelletier

Feb. 9, 2009

[try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

by Vincent Pelletier

Le Saturday 07 February 2009 14:16:15 Vincent Pelletier, vous avez écrit : > If not, please tell me and I will extend the patch to generate a "Joystick > %i" name, or maybe put joydevs[id].name in both fields. Same patch as first proposed on wine-devel, no reaction so I guess it's correct. -- Vincent Pelletier

Feb. 9, 2009

Re: comctl32/tests: [try 2] Make the test dpi and Theme aware: use SM_CYSIZE

by Paul Vriens

Detlef Riekenberg wrote: > try 2: without the check for win9x > > > The status test failed on installations with 120 dpi. > > After a lot of "try and error" from 72 to 144 dpi with > different formula for the min height, different results on my machine > and a failing XP machine at 96dpi, I found the reason: > > The minimal height depends on the appearance setting > "[In]Active Title Bar", which is SM_CYSIZE. > > The test now pass on win98se, win2k and Wine with a different height > for the title bar (tested from 18 to 30). > > To reduce the test log size, I moved the dump of the current tested > font name from a trace to the ok. > > > Why is MS so stupid and use BYTE in ENUMLOGFONTEXA and > WCHAR in ENUMLOGFONTEXW for the strings in wingdi.h, > while MSDN document them as TCHAR? > > > > > ------------------------------------------------------------------------ > > Hi Detlef, This patch introduced a lot of failures on specifically some XP and W2K3 boxes. Could you have a look? -- Cheers, Paul.

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by IneedAname

On Mon, 9 Feb 2009 07:35:20 -0700 (GMT-07:00) James Mckenzie <jjmckenzie51(a)earthlink.net> wrote: > Yes, there are legit reasons to run as root, one of them is the now famous ICMP 'Ping' unavailability issue in Linux. Experts know about this and how to work around it. Newbies, used to Windows and how it works, just figure that this is restricted to administrators, and switch to root to get around it. The proper command, as I have learned through years of UNIX administration, is 'su -' but newbies don't know this and most just use 'su'. Can you point me at a guide for using ICMP 'Ping' without root? Sorry for being a noob.

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by James Mckenzie

Michael Stefaniuc <mstefani(a)redhat.com> wrote: >Sent: Feb 9, 2009 7:39 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >> sudo rm -rf .wine >Solution is sudo chmod -R $username.$groupname .wine > Correct. However, this is not the solution given on Wine Users. >> User now upset because everything they did is gone. >Not if you do it right. > I agree, but some users are very sensitive and are worse that a colicy baby. The problem is that we should not need to direct users to run as root to perform any function. Some Linux distributions restrict network functions, such as ICMP, to only root. This is sillines in my opinion and actually employs poor security practices. However, a new that receives a message like the following "You must be an Administrator to run this program" when attempting to run a program in Wine will think "Administrator == root" and try to run the program as root. The program does not run, and they are futher frustrated. Also, some new users think, incorrectly, that running Wine as root will give them more permissions. It does not and should not. Again, the warning should address this. What I don't want to see, and I agree with AJ, is the disablement of running Wine as the root user. There are situations where this is necessary. A short notification message is all that is necessary and Austin's change does exactly that. James McKenzie

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by Austin English

On Mon, Feb 9, 2009 at 9:58 AM, James Mckenzie <jjmckenzie51(a)earthlink.net> wrote: > Aurimas Fišeras <aurimas(a)gmail.com> wrote: >>Sent: Feb 9, 2009 7:45 AM >>To: James Mckenzie <jjmckenzie51(a)earthlink.net> >>Cc: wine-devel(a)winehq.org >>Subject: Re: ntdll: add a warning about running wine as root (resend) >> >>James Mckenzie wrote: >>> Alexandre Julliard <julliard(a)winehq.org> wrote: >>>[...] >>> New wine installation: >>> >>> su (no dash so root's environment is not picked up) >>> wine notepad >>> install various programs and use them. >>> exit >>> >>> User logs in a second time after learning how to properly use Wine. >>> Attempt to do anything with Wine in user space. Cannot do due to permissions problems. >>> >>> The solution: >>> >>> sudo rm -rf .wine >>No, the solution is >>sudo chown -R user:user .wine > > Correct. However, this is not being given as the solution. > > Also, if the user is on an alternate wine prefix this would change to: > > sudo chown -R <username>:users $WINEPREFIX > > Is this in the FAQ somewhere? > > James McKenzie > > > > > It is now (before, just said sudo rm -rf ~/.wine). -- -Austin

Feb. 9, 2009