February 2009 - Wine-Devel - list.winehq.org

Re: ntdll: add a warning about running wine as root (resend)

by Austin English

On Mon, Feb 9, 2009 at 8:17 AM, James Mckenzie <jjmckenzie51(a)earthlink.net> wrote: > Alexandre Julliard <julliard(a)winehq.org> >>Sent: Feb 9, 2009 5:56 AM >>To: Austin English <austinenglish(a)gmail.com> >>Cc: wine-devel(a)winehq.org >>Subject: Re: ntdll: add a warning about running wine as root (resend) >> >>Austin English <austinenglish(a)gmail.com> writes: >> >>> Didn't receive any feedback on this one last time. Been seeing this a >>> bit recently in the forums, so adding a warning. No actual >>> functionality lost. >> >>We've been through this before. There are legitimate reasons for running >>as root, and we don't want to have any sort of warning or message box >>getting in the way. >> > First, I respect the fact that AJ does not "want a box getting in the way". but I feel that clicking through a box as an experienced user is nothing but an additional mouse click. > > Second, the problem is that newbies, figuring that their favorite program will not run as an ordinary user, gets a wiff that root has more privileges, will attempt run as root totally hosing their Wine directory. This then starts the 'you should not run Wine as root' mantra on Wine-Users. This then causes the newbie to question why did I go to Linux/Wine when I had a perfectly running Windows system? > > Third, I agree that we need a warning for running as root, selectable to be disabled for those of us who are knowledgible enough to know what to do if we hose up our user space Wine directory. This satisfies the 'don't do this unless you are really sure what you are doing' cases and leaves the experts to do what we need to do. > > Austin, can you send me, via private mail, a .plan to implement this functionality for testing. > > AJ, unless you want to scare off newbies, we need this functionality. I understand that we don't want to upset the apple cart with experts, but the newbies running root is getting very old. We need the newbies to try things, but running as root has been tested throughly and we all know that this busts Wine. Newbies don't need to be exposed to this. > > James McKenzie > > As James has pointed out, something should be done about all the users running as root on the forums/Bugzilla that don't need to be. Perhaps adding a registry key to disable the warning? Or only once per WINEPREFIX? It's only output in the terminal, not as a messagebox and is not very obtrusive...one could make the same argument about the Gecko/Mozilla warning that is shown with each new WINEPREFIX. Mousepad (default XFCE text editor) does something similar, a small red bar at the top of each document when ran as root/sudo. I've seen a few other programs doing similar things (not sure of others off hand. While I understand that there's (sometimes) a legitimate need for it, we've made similar accommodations in the past, e.g., disabling moving the c drive in winecfg to prevent hosing windows partitions, but allowing those who can do so manually in terminal to do so. This is similar, but even LESS obtrusive. It's only a bit of text to say, "Hey, probably a bad idea, you might hose your system by giving windows programs full access...you've been warned." -- -Austin

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by Alexandre Julliard

James Mckenzie <jjmckenzie51(a)earthlink.net> writes: > Second, the problem is that newbies, figuring that their favorite > program will not run as an ordinary user, gets a wiff that root has > more privileges, will attempt run as root totally hosing their Wine > directory. This then starts the 'you should not run Wine as root' > mantra on Wine-Users. This then causes the newbie to question why did > I go to Linux/Wine when I had a perfectly running Windows system? Please explain how running as root will screw their Wine directory. If that's really true, surely it should be fixed instead of simply throwing out a warning and proceeding. -- Alexandre Julliard julliard(a)winehq.org

Feb. 9, 2009

Re: EVE online losing its Linux Client

by James Mckenzie

François Guerraz <kubrick(a)fgv6.net> wrote: >Sent: Feb 9, 2009 1:32 AM >To: Chris Robinson <chris.kcat(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: EVE online losing its Linux Client > >On 9/02/09 3:55, Chris Robinson wrote: >> On Sunday 08 February 2009 6:17:38 pm Zachary Goldberg wrote: >> >A great thing would be that they officially support Wine. > >Also, if the Mac Wine would have worked better (I know it's Apple crappy >X11 fault and native Mac's API drivers cocoa language's fault... but >users don't care), it's very likely that they dropped their mac "native" >client. Since there is not a great Wine audience for the Mac, the Eve Online Mac client should not be abandoned just for that reason. The real reason may be that there is not a great deal of demand for an on-line game interface for the Mac. Most Mac users loath having to use X11 for any purpose, and a game tops the list. James McKenzie

Feb. 9, 2009

Re: OFC and MFC and Winelib

by Austin English

On Mon, Feb 9, 2009 at 3:08 AM, King InuYasha <ngompa13(a)gmail.com> wrote: > Hello, I was doing my random web browsing when I stumbled on an issue with > source code with MSVC++ 2005 Express, and I was searching for a solution. I > think I found one, but it hasn't been maintained for years from what I can > gather. Since you guys do have winelib for the purpose of building Win32 > source code, I thought that I could suggest that the people that do maintain > Winelib could take over this project and import it into Wine's git > repository. > The project is called the Open Foundation Classes, and it aims to be "100% > compatible with the MFC and will be improved in various ways. All not > compatible parts are signed with a prefix." The link for OFC > is: https://sourceforge.net/projects/ofc/ > It has a CVS (blech) repository which is obviously linked in the SF project > page. > > > Doesn't look like they have much done. Been around for 8.5 years, and are still in Pre-Alpha stage of development according to summary page. Last commit of source code was 4 years ago... -- -Austin

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by James Mckenzie

Alexandre Julliard <julliard(a)winehq.org> >Sent: Feb 9, 2009 5:56 AM >To: Austin English <austinenglish(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >Austin English <austinenglish(a)gmail.com> writes: > >> Didn't receive any feedback on this one last time. Been seeing this a >> bit recently in the forums, so adding a warning. No actual >> functionality lost. > >We've been through this before. There are legitimate reasons for running >as root, and we don't want to have any sort of warning or message box >getting in the way. > First, I respect the fact that AJ does not "want a box getting in the way". but I feel that clicking through a box as an experienced user is nothing but an additional mouse click. Second, the problem is that newbies, figuring that their favorite program will not run as an ordinary user, gets a wiff that root has more privileges, will attempt run as root totally hosing their Wine directory. This then starts the 'you should not run Wine as root' mantra on Wine-Users. This then causes the newbie to question why did I go to Linux/Wine when I had a perfectly running Windows system? Third, I agree that we need a warning for running as root, selectable to be disabled for those of us who are knowledgible enough to know what to do if we hose up our user space Wine directory. This satisfies the 'don't do this unless you are really sure what you are doing' cases and leaves the experts to do what we need to do. Austin, can you send me, via private mail, a .plan to implement this functionality for testing. AJ, unless you want to scare off newbies, we need this functionality. I understand that we don't want to upset the apple cart with experts, but the newbies running root is getting very old. We need the newbies to try things, but running as root has been tested throughly and we all know that this busts Wine. Newbies don't need to be exposed to this. James McKenzie

Feb. 9, 2009

Re: oleaut32: Fix SAFEARRAY marshalling on 64-bit platforms.

by Rob Shearman

2009/2/9 Alexandre Julliard <julliard(a)winehq.org>: > Rob Shearman <robertshearman(a)gmail.com> writes: > >> @@ -874,8 +874,8 @@ unsigned char * WINAPI LPSAFEARRAY_UserMarshal(ULONG *pFlags, unsigned char *Buf >> >> *(ULONG *)Buffer = ulCellCount; >> Buffer += sizeof(ULONG); >> - *(ULONG_PTR *)Buffer = (ULONG_PTR)psa->pvData; >> - Buffer += sizeof(ULONG_PTR); >> + *(ULONG *)Buffer = (ULONG)(ULONG_PTR)psa->pvData; >> + Buffer += sizeof(ULONG); > > Wouldn't this break if the pointer happens to be 4Gb-aligned? It would write 0 into memory, yes, but the value written here isn't used during unmarshalling so it is fine and I believe this matches what native does. If we wanted to relax the tests, we could change this to "*(ULONG *)Buffer = psa->pvData ? 0x2 : 0x0" and check the value during unmarshalling to be totally correct with the NDR-formatted data that we are writing. -- Rob Shearman

Feb. 9, 2009

Re: [1/2] d3dxof: Cleanup IDirectXFileImpl_CreateEnumObject a bit

by Alexandre Julliard

Christian Costa <titan.costa(a)wanadoo.fr> writes: > commit a9d8c3f6e21439bb638e958674f9da6a648661b2 > Author: Christian Costa <titan.costa(a)wanadoo.fr> > Date: Sun Feb 8 13:25:45 2009 +0100 > > Cleanup IDirectXFileImpl_CreateEnumObject a bit. This doesn't work here: ../../../tools/runtest -q -P wine -M d3dxof.dll -T ../../.. -p d3dxof_test.exe.so d3dxof.c && touch d3dxof.ok d3dxof.c:113: Test failed: IDirectXFileEnumObject_GetNextDataObject: 88760362 wine: Unhandled page fault on read access to 0x3839c385 at address 0x6016fd1e (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

Feb. 9, 2009

Re: oleaut32: Fix SAFEARRAY marshalling on 64-bit platforms.

by Alexandre Julliard

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -874,8 +874,8 @@ unsigned char * WINAPI LPSAFEARRAY_UserMarshal(ULONG *pFlags, unsigned char *Buf > > *(ULONG *)Buffer = ulCellCount; > Buffer += sizeof(ULONG); > - *(ULONG_PTR *)Buffer = (ULONG_PTR)psa->pvData; > - Buffer += sizeof(ULONG_PTR); > + *(ULONG *)Buffer = (ULONG)(ULONG_PTR)psa->pvData; > + Buffer += sizeof(ULONG); Wouldn't this break if the pointer happens to be 4Gb-aligned? -- Alexandre Julliard julliard(a)winehq.org

Feb. 9, 2009

Re: ntdll: add a warning about running wine as root (resend)

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > Didn't receive any feedback on this one last time. Been seeing this a > bit recently in the forums, so adding a warning. No actual > functionality lost. We've been through this before. There are legitimate reasons for running as root, and we don't want to have any sort of warning or message box getting in the way. -- Alexandre Julliard julliard(a)winehq.org

Feb. 9, 2009

user32:menu test

by Ge van Geldorp

> From: Florian Köberle [mailto:florian(a)fkoeberle.de] > > I ran the test 30 times using the same way you did without > any failure.I used a vm with 1 CPU assigned too. Installed > is a Windows XP with SP2. > > If I start the test twice so that two tests are running > parallel then I get test failures too, but: > > Do we really have the requirement that tests must be able to > run in parallel? Sorry about late reply, I've been away. No, I don't think we have the requirement that tests must be able to run in parallel. The only reason I brought that up is because that seems to be a good way to make the failure consistently reproduceable. Ge.

Feb. 9, 2009