February 2009 - Wine-Devel - list.winehq.org

Re: shell32: Make ILGetDisplayNameExA() static and fix its documentation.

by Francois Gouget

Please don't apply. I should have removed the WINAPI when making the function static. I'll resend a patch. > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index 5f26265..2792bc6 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -75,7 +75,7 @@ static LPWSTR _ILGetTextPointerW(LPCITEMIDLIST pidl); > * RETURNS > * True if the display name could be retrieved successfully, False otherwise > */ > -BOOL WINAPI ILGetDisplayNameExA(LPSHELLFOLDER psf, LPCITEMIDLIST pidl, LPSTR path, DWORD type) > +static BOOL WINAPI ILGetDisplayNameExA(LPSHELLFOLDER psf, LPCITEMIDLIST pidl, LPSTR path, DWORD type) > { > BOOL ret = FALSE; > WCHAR wPath[MAX_PATH]; -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

Feb. 9, 2009

Re: wininet: print better stubs for the internet options ie7 uses

by Dmitry Timoshkov

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 363f7a4..7db635d 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -2367,8 +2367,35 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption, > case INTERNET_OPTION_DISABLE_AUTODIAL: > FIXME("Option INTERNET_OPTION_DISABLE_AUTODIAL; STUB\n"); > break; > - case 86: > - FIXME("86\n"); > + case 65: > + FIXME("INTERNET_OPTION_HTTP_DECODING; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case INTERNET_OPTION_COOKIES_3RD_PARTY: > + FIXME("INTERNET_OPTION_COOKIES_3RD_PARTY; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case INTERNET_OPTION_SEND_UTF8_SERVERNAME_TO_PROXY: > + FIXME("INTERNET_OPTION_SEND_UTF8_SERVERNAME_TO_PROXY; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 100: > + FIXME("INTERNET_OPTION_CODEPAGE_PATH; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 101: > + FIXME("INTERNET_OPTION_CODEPAGE_EXTRA; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > + break; > + case 102: > + FIXME("INTERNET_OPTION_IDN; STUB\n"); > + INTERNET_SetLastError(ERROR_INTERNET_INVALID_OPTION); > + ret = FALSE; > break; All the numeric values above should be defined and constants in wininet.h. -- Dmitry.

Feb. 9, 2009

Re: ioports.c change -> buffer overflow ... bug?

by Florian Tobias Schandinat

Marcus Meissner schrieb: > Hi Florian, > > You are calling get_timer_val(3) in ioports.c > (if (chan == 3) ... going down to get_timer_val(chan)) > > Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, > > Is your code right? The change comes from this commit: > > commit edbd4885542e4545439906df950a68dc48e70839 > Author: Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> > Date: Tue Feb 3 18:26:04 2009 +0100 > > winedos: Improve PIT emulation. > > Ciao, Marcus Sorry, I forgot to adjust the calls in readback case where the channel information is stored in different bits. Thanks for reporting, the attached patch should fix it. Greetings, Florian Tobias Schandinat

Feb. 9, 2009

OFC and MFC and Winelib

by King InuYasha

Hello, I was doing my random web browsing when I stumbled on an issue with source code with MSVC++ 2005 Express, and I was searching for a solution. I think I found one, but it hasn't been maintained for years from what I can gather. Since you guys do have winelib for the purpose of building Win32 source code, I thought that I could suggest that the people that do maintain Winelib could take over this project and import it into Wine's git repository. The project is called the Open Foundation Classes, and it aims to be "100% compatible with the MFC and will be improved in various ways. All not compatible parts are signed with a prefix." The link for OFC is: https://sourceforge.net/projects/ofc/ It has a CVS (blech) repository which is obviously linked in the SF project page.

Feb. 9, 2009

Re: EVE online losing its Linux Client

by Chris Robinson

On Monday 09 February 2009 12:32:51 am François Guerraz wrote: > Unfortunately they don't seem to recommend Wine, neither they announce > Wine as a supported platform. According to http://www.linuxgames.com/archives/11565 they state Wine as the first option for running EVE Online under Linux. Given the, arguable careful, language of the message (stating low numbers of "Linux client" users, as opposed to low numbers of Linux users), it doesn't seem as though they're completely turning their back to Linux. So maybe it isn't an "official" recommendation, but I think it's close enough.

Feb. 9, 2009

Re: EVE online losing its Linux Client

by François Guerraz

On 9/02/09 3:55, Chris Robinson wrote: > On Sunday 08 February 2009 6:17:38 pm Zachary Goldberg wrote: > >> http://games.slashdot.org/article.pl?sid=09/02/08/206252&from=rss >> >> It seems that a game studio found that Wine worked so well that they >> have given up their efforts to maintain a native client. While >> encouraging that Wine works so well, there is a very interesting >> debate which could be had as to whether or not this kind of affect is >> desirable. >> > > Their "native Linux client" was the Windows client on top of Cedega. They're > stopping support for the official client running on Cedega, and instead > recommending Wine. > > > Hi, Unfortunately they don't seem to recommend Wine, neither they announce Wine as a supported platform. They just drop Linux support because of "the lack of interest for the Linux client" that no one was using because the game worked far much better with Wine :) A great thing would be that they officially support Wine. Also, if the Mac Wine would have worked better (I know it's Apple crappy X11 fault and native Mac's API drivers cocoa language's fault... but users don't care), it's very likely that they dropped their mac "native" client. François

Feb. 9, 2009

ioports.c change -> buffer overflow ... bug?

by Marcus Meissner

Hi Florian, You are calling get_timer_val(3) in ioports.c (if (chan == 3) ... going down to get_timer_val(chan)) Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, Is your code right? The change comes from this commit: commit edbd4885542e4545439906df950a68dc48e70839 Author: Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> Date: Tue Feb 3 18:26:04 2009 +0100 winedos: Improve PIT emulation. Ciao, Marcus

Feb. 9, 2009

Re: EVE online losing its Linux Client

by Ben Klein

2009/2/9 Zachary Goldberg <zgold(a)bluesata.com>: > 2009/2/8 Chris Robinson <chris.kcat(a)gmail.com>: >> Their "native Linux client" was the Windows client on top of Cedega. They're >> stopping support for the official client running on Cedega, and instead >> recommending Wine. >> > > Hm, interesting. Little room for sadness then, party all around! Great! Who's bringing the tequila? :D Reminds me of a so-called Linux version of the Sims shipped with certain versions of Mandrake. That was also Sims + Cedega, and from what I recall reading, it broke a lot.

Feb. 9, 2009

[Fwd: Re: [Wine] imagicos]

by James McKenzie

Sent to wrong mailing list. Comment stands. Apple is almost as bad as Microsoft with trademark enforcement. James McKenzie -------- Original Message -------- Subject: Re: [Wine] imagicos Date: Sun, 08 Feb 2009 19:58:52 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: IneedAname <wineappdb(a)googlemail.com> CC: Wine <wine-users(a)winehq.org> References: <COL113-W24AF1F36974642B52CBF95ABBE0(a)phx.gbl> <d7e40be30902061716r3c4270c3kc2566b41c6724d32(a)mail.gmail.com> <COL113-W31685C183F8C6E91FA9A38ABBE0(a)phx.gbl> <20090207032351.1a709d63(a)test-main> IneedAname wrote: > > This whole thing would be funny if it was not for: > > Read cost. > http://www.imagicos.com/why.html > > Rip off! > http://www.imagicos.com/get.html > > And possible trademark infringment (iMagic OS X) . This might turn out to be an interesting legal battle. I won't be 'buying' a copy anywhere. James McKenzie

Feb. 9, 2009

Re: EVE online losing its Linux Client

by Zachary Goldberg

2009/2/8 Chris Robinson <chris.kcat(a)gmail.com>: > Their "native Linux client" was the Windows client on top of Cedega. They're > stopping support for the official client running on Cedega, and instead > recommending Wine. > Hm, interesting. Little room for sadness then, party all around!

Feb. 9, 2009