February 2009 - Wine-Devel - list.winehq.org

Re: shdocvw: Correct OnAmbientPropertyChange regession

by Alistair Leslie-Hughes

"Jacek Caban" <jacek(a)codeweavers.com> wrote in message news:4988D589.9080708(a)codeweavers.com... > Alistair Leslie-Hughes wrote: >> Hi, >> After testing on XP, it appears that OnAmbientPropertyChange when >> passwed DISP_UNKNOWN doesnt check all properties. >> >> Changelog: >> shdocvw: Correct OnAmbientPropertyChange regession > > + CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); > + CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT); > + CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE); > + CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL); > + CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT); > + CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE); > > > > These checks don't make sense here. If you don't set these calls as > expected, CHECK_EXPECT will fail when they are called. > Hi Jacek. I was unsure about the SET_EXPECT. Thanks Best Regards Alistair Leslie-Hughes

Feb. 4, 2009

Re: shdocvw: Correct OnAmbientPropertyChange regession

by Jacek Caban

Alistair Leslie-Hughes wrote: > Hi, > After testing on XP, it appears that OnAmbientPropertyChange when > passwed DISP_UNKNOWN doesnt check all properties. > > Changelog: > shdocvw: Correct OnAmbientPropertyChange regession + CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE); + CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE); These checks don't make sense here. If you don't set these calls as expected, CHECK_EXPECT will fail when they are called. Jacek

Feb. 3, 2009

Re: Fixing AppDB once and for all

by IneedAname

On Tue, 3 Feb 2009 23:02:12 +0100 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > What if we add a small questionnaire which will then pick the approprite > Gold/Silver ... rating? That what I like to see.

Feb. 3, 2009

Re: Fixing AppDB once and for all

by Austin English

On Tue, Feb 3, 2009 at 11:44 AM, Zachary Goldberg <zgold(a)bluesata.com> wrote: > All, > > So it seems to be almost every other day now when somebody mentions > how broken the appdb rating system is. This "broken-ness" has had > several high level discussions on Wine-Devel. There have also been > many, many proposed solutions to this problem. > > I do not wish to discuss these problems or these solutions in this > thread. It is time something was done about this. By done I mean > agreed upon (probably the harder part) then implemented in code and > published to the winehq server(s). > > I'de like to arrange an IRC discussion for all those interested in > finalizing an attack plan, and then assigning the responsibility of > doing it to somebody who is capable and has the time (perhaps myself). > > Lets (arbitrarily) set a time for the chat at: > > When: 11PM UTC (6PM EST) 2/6/09 (Friday) > Where: #winehackers > > If this arbitrary time seems to be poorly chosen for a large number of > people then please propose an alternative well in advance so all are > aware of it. > > --Zach > > > Thanks for taking the initiative! Count me in. -- -Austin

Feb. 3, 2009

Re: Fixing AppDB once and for all

by Branan Riley

On Tue, Feb 3, 2009 at 9:44 AM, Zachary Goldberg <zgold(a)bluesata.com> wrote: > All, > > So it seems to be almost every other day now when somebody mentions > how broken the appdb rating system is. This "broken-ness" has had > several high level discussions on Wine-Devel. There have also been > many, many proposed solutions to this problem. > > I do not wish to discuss these problems or these solutions in this > thread. It is time something was done about this. By done I mean > agreed upon (probably the harder part) then implemented in code and > published to the winehq server(s). > > I'de like to arrange an IRC discussion for all those interested in > finalizing an attack plan, and then assigning the responsibility of > doing it to somebody who is capable and has the time (perhaps myself). > > Lets (arbitrarily) set a time for the chat at: > > When: 11PM UTC (6PM EST) 2/6/09 (Friday) > Where: #winehackers > > If this arbitrary time seems to be poorly chosen for a large number of > people then please propose an alternative well in advance so all are > aware of it. > > --Zach I have some thoughts on the subject. I'll try to be there Branan

Feb. 3, 2009

Re: Fixing AppDB once and for all

by James Mckenzie

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 12:27 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Devel <wine-devel(a)winehq.org>, Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Re: Fixing AppDB once and for all > >2009/2/3 James Mckenzie <jjmckenzie51(a)earthlink.net>: >> This would be too early for people on the West Coast of the United States by about three hours. >> >> No time will be satisfactory for all people who work on this project. >> >> What I feel is necessary at this point is to collect who lives in what time zone so that we incovience as few people as possible. >> >> Since this would be Saturday in Asia, this time may work for the majority of the people on this list. >> >> Also, will there be a transcript of the discussion and where will it be placed since this has a major impact on the functionality of the Applications Database. >> >> James McKenzie >> >> > >I have made a wiki on winehq with an agenda which will be updated with >the results (and maybe transcript?) of the conversation. > >http://wiki.winehq.org/AppDBUpgrades Thank you for your forward thinking and thoughtfulness. I look forward to reading the Wiki and reviewing what is determined during the IRC conversation as I will not be able to attend. James McKenzie

Feb. 3, 2009

Re: Fixing AppDB once and for all

by Scott Ritchie

Zachary Goldberg wrote: > All, > > So it seems to be almost every other day now when somebody mentions > how broken the appdb rating system is. This "broken-ness" has had > several high level discussions on Wine-Devel. There have also been > many, many proposed solutions to this problem. > > I do not wish to discuss these problems or these solutions in this > thread. It is time something was done about this. By done I mean > agreed upon (probably the harder part) then implemented in code and > published to the winehq server(s). > > I'de like to arrange an IRC discussion for all those interested in > finalizing an attack plan, and then assigning the responsibility of > doing it to somebody who is capable and has the time (perhaps myself). > > Lets (arbitrarily) set a time for the chat at: > > When: 11PM UTC (6PM EST) 2/6/09 (Friday) > Where: #winehackers > > If this arbitrary time seems to be poorly chosen for a large number of > people then please propose an alternative well in advance so all are > aware of it. > > --Zach Zach, I completely agree with this strong-armed measure. Let's get it done. :) Thanks, Scott Ritchie

Feb. 3, 2009

Re: wine honor roll slashdotted

by Austin English

On Tue, Feb 3, 2009 at 4:18 PM, Diaa Sami <diaasami(a)gmail.com> wrote: > Sorry for this off-topic message but can someone add HFS(Http File > Server - http://www.rejetto.com/hfs/ ) to the list ? > > Thanks > > > It's a wiki, you could've done so yourself...but I've added it. -- -Austin

Feb. 3, 2009

Re: wine honor roll slashdotted

by Diaa Sami

Sorry for this off-topic message but can someone add HFS(Http File Server - http://www.rejetto.com/hfs/ ) to the list ? Thanks

Feb. 3, 2009

Re: MSVCRT: Still problems in ASCII Mode

by Dan Kegel

Thanks. Please don't use rand() in testcases, though. Would a constant 'a' suffice in this case? Which app did you find this in, btw? On Tue, Feb 3, 2009 at 1:55 PM, Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > Hello, > > it seems that in ASCII mode, fseek() may disturb reading. Appended patch > adds a todo_wine. > > Bye > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- > diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c > index 9032e51..2a72212 100644 > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -306,7 +306,8 @@ static void test_asciimode(void) > { > FILE *fp; > char buf[64]; > - int c, i, j; > + int c, i, j, done, count1, count2; > + > > /* Simple test of CR CR LF handling. Test both fgets and fread code paths, they're different! */ > fp = fopen("ascii.tst", "wb"); > @@ -372,6 +373,46 @@ static void test_asciimode(void) > ok((c = fgetc(fp)) == '1', "fgetc fails to read next char when positioned on \\r\n"); > fclose(fp); > > + fp= fopen("ascii.tst","wb"); > + for (i=0; i<1000; i++) > + { > + unsigned char c = (rand()+ ' ') & 0x7f; > + if (isgraph(c) || (c == ' ')) > + fputc(c, fp); > + else if ((c == '\r') || (c == '\n')) > + fputs("\r\n", fp); > + } > + fclose(fp); > + > + done = 0; > + count1 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count1 ++; > + } > + fclose(fp); > + > + done = 0; > + count2 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + fseek(fp, 0, SEEK_CUR); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count2 ++; > + } > + fclose(fp); > + todo_wine ok((count1 == count2), "fseek caused short read %d vs %d\n", count2, count1); > unlink("ascii.tst"); > } > >

Feb. 3, 2009