February 2009 - Wine-Devel - list.winehq.org

Fixing AppDB once and for all

by Zachary Goldberg

All, So it seems to be almost every other day now when somebody mentions how broken the appdb rating system is. This "broken-ness" has had several high level discussions on Wine-Devel. There have also been many, many proposed solutions to this problem. I do not wish to discuss these problems or these solutions in this thread. It is time something was done about this. By done I mean agreed upon (probably the harder part) then implemented in code and published to the winehq server(s). I'de like to arrange an IRC discussion for all those interested in finalizing an attack plan, and then assigning the responsibility of doing it to somebody who is capable and has the time (perhaps myself). Lets (arbitrarily) set a time for the chat at: When: 11PM UTC (6PM EST) 2/6/09 (Friday) Where: #winehackers If this arbitrary time seems to be poorly chosen for a large number of people then please propose an alternative well in advance so all are aware of it. --Zach

Feb. 3, 2009

Re: winedos: Improve PIT emulation.

by Florian Tobias Schandinat

Alexandre Julliard schrieb: > Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> writes: > >> + /* Convert: time counter -> PIT counter >> + * GetSystemTimeAsFileTime: 10000000 Hz >> + * PIT frequency: 1193182 Hz */ >> + val = (DWORD)(val - delta*1193182./10000000.) % (maxval + 1); > > You should probably use QueryPerformanceCounter as it already uses the > correct frequency. Thanks, will change it and resend the patch with some minor changes.

Feb. 3, 2009

Re: ideas and questions for implementation of MessageMode in Named Pipes

by Luke Kenneth Casson Leighton

mwhaaahahah, i just came up with a _horrible_ idea :) how about: ripping out the use of unix-pipes altogether, and replacing them with tdb (trivial database) in a mmap'd file? the nice thing about tdb is that it's LGPL'd. the messages could be saved and transferred via shared memory; tdb is multi-readable / multi-writeable, and it would save a bitch-awful job of implementing a shared memory sockets emulation layer (which i _have_ seen done, once). l.

Feb. 3, 2009

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN (try 2)

by Jacek Caban

Paul Vriens wrote: > Alistair Leslie-Hughes wrote: > >> Hi, >> Added Tests >> >> Changelog: >> shdocvw: OnAmbientPropertyChange should refresh all properties with >> a DISPID_UNKNOWN >> >> Best Regards >> Alistair Leslie-Hughes >> >> >> >> >> >> ------------------------------------------------------------------------ >> >> >> > Hi, > > These new tests fails on W98, NT4, W2K3 and Vista (no other reports are in yet). > Could you have a look? > Alistair, also your patch leaves tests in wrong state after call to test_ambient_unknown with false is_clientsite. Jacek

Feb. 3, 2009

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN (try 2)

by Paul Vriens

Alistair Leslie-Hughes wrote: > Hi, > Added Tests > > Changelog: > shdocvw: OnAmbientPropertyChange should refresh all properties with > a DISPID_UNKNOWN > > Best Regards > Alistair Leslie-Hughes > > > > > > ------------------------------------------------------------------------ > > Hi, These new tests fails on W98, NT4, W2K3 and Vista (no other reports are in yet). Could you have a look? -- Cheers, Paul.

Feb. 3, 2009

Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)

by Dmitry Timoshkov

"Florian Tobias Schandinat" <FlorianSchandinat(a)gmx.de> wrote: > this test shows a difference between Win9X and NT. (tested on Win98SE > and WinXP) Some apps expect the Win9X behaviour to work. I don't know > what's the right way to fix it. Any advice or patch is welcome. How do that apps work under NT based Windows versions like XP or Vista? -- Dmitry.

Feb. 3, 2009

Re: Stub DDE interface for Progman.exe

by Dmitry Timoshkov

"Jeremiah Flerchinger" <jeremiah.flerchinger(a)gmail.com> wrote: > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in > shell32.dll. Both will need to be extended and a 3rd progman interface > will need to be added in user32. Progman DDE interface should be implemented by shell32.dll, nowhere else. -- Dmitry.

Feb. 3, 2009

Re: propsys: Stub for PSRegisterPropertySchema (resent)

by Nikolay Sivov

Alexandre Julliard wrote: > Nikolay Sivov <bunglehead(a)gmail.com> writes: > > >> @@ -0,0 +1,34 @@ >> +/* >> + * Property schema routines >> + * >> + * Copyright 2009 Nikolay Sivov >> + * >> + * This library is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2.1 of the License, or (at your option) any later version. >> + * >> + * This library is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * Lesser General Public License for more details. >> + * >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with this library; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA >> + */ >> + >> +#include <stdarg.h> >> + >> +#include "windef.h" >> +#include "winbase.h" >> +#include "wine/debug.h" >> + >> +WINE_DEFAULT_DEBUG_CHANNEL(propsys); >> + >> +HRESULT WINAPI PSRegisterPropertySchema(PCWSTR path) >> +{ >> + FIXME("stub\n"); >> + >> + return E_NOTIMPL; >> +} >> > > I don't think you need a new file for this. If someday there's a lot of > code in there it can be split off to a separate file then. > > Ok. Patch sent.

Feb. 3, 2009

Re: Stub DDE interface for Progman.exe

by Austin English

On Mon, Feb 2, 2009 at 11:24 PM, Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> wrote: > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in > shell32.dll. Both will need to be extended and a 3rd progman interface > will need to be added in user32. > --- > programs/progman/main.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 148 insertions(+), 0 deletions(-) > > diff --git a/programs/progman/main.c b/programs/progman/main.c > index 83a346c..51dbcff 100644 > --- a/programs/progman/main.c > +++ b/programs/progman/main.c > @@ -56,6 +154,12 @@ int PASCAL WinMain (HINSTANCE hInstance, HINSTANCE prev, LPSTR cmdline, int show > Globals.hGroups = 0; > Globals.hActiveGroup = 0; > > + /**/ > + DdeInitializeW(&dwDDEInst, DdeCallback, APPCLASS_STANDARD, 0); > + hszProgmanTopic = DdeCreateStringHandleW(dwDDEInst, wszProgman, CP_WINUNICODE); > + hszProgmanService = DdeCreateStringHandleW(dwDDEInst, wszProgman, CP_WINUNICODE); > + DdeNameService(dwDDEInst, hszProgmanService, 0, DNS_REGISTER); > + Empty comment. > + case WM_DDE_TERMINATE: > + printf("Progman.exe: WM_DDE_TERMINATE stub \n"); > +// PostMessage( (HWND)wParam, WM_DDE_TERMINATE, (WPARAM)hWnd, 0); > + break; > } > return(DefFrameProc(hWnd, Globals.hMDIWnd, msg, wParam, lParam)); > } C++ comments are not allowed. Thanks for helping Wine! -- -Austin

Feb. 3, 2009

Re: propsys: Stub for PSRegisterPropertySchema (resent)

by Alexandre Julliard

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -0,0 +1,34 @@ > +/* > + * Property schema routines > + * > + * Copyright 2009 Nikolay Sivov > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(propsys); > + > +HRESULT WINAPI PSRegisterPropertySchema(PCWSTR path) > +{ > + FIXME("stub\n"); > + > + return E_NOTIMPL; > +} I don't think you need a new file for this. If someday there's a lot of code in there it can be split off to a separate file then. -- Alexandre Julliard julliard(a)winehq.org

Feb. 3, 2009