February 2009 - Wine-Devel - list.winehq.org

Re: Simple but awesome demos of Wine?

by Tomasz Sałaciński

Hello, In case of games, I'd suggest Prey - game works perfectly under WINE, and have some very nice graphics. There is a demo available somewhere. And I agree with someone who previously posted that you should try Flatout 2 (though NFS: Carbon and both Underground I & II work fine for me too). You can try Oblivion too (does have a demo, but requires a decent graphics card and lots of memory). All games have a demo version, so you don't have to own them. If you want to show some apps, try Photoshop. This is the app that most Linux users miss. Photoshop is big, advanced app that works almost fine (with few glitches, unfortunately it works slower than on Windows because of lack of DIB engine). Cheers

Feb. 2, 2009

Re: [2/2] mshtml: Add support for IHTMLStyle4 interface

by Jacek Caban

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle4 interface > --- dlls/mshtml/Makefile.in | 1 + dlls/mshtml/htmlstyle.c | 4 ++ dlls/mshtml/htmlstyle.h | 3 + dlls/mshtml/htmlstyle4.c | 135 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/tests/dom.c | 7 +++ 5 files changed, 150 insertions(+), 0 deletions(-) create mode 100644 dlls/mshtml/htmlstyle4.c This interface has very few methods so it doesn't make sense to add new file for it. Jacek

Feb. 2, 2009

Re: [1/2] mshtml: Add support for IHTMLStyle3 interface

by Jacek Caban

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle3 interface > + + hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle3, (void**)&style3); + ok(hres == S_OK, "Could not get IHTMLStyle3 iface: %08x\n", hres); + if(SUCCEEDED(hres)) { + IHTMLStyle3_Release(style3); + } Please use style_iids to test QueryInterface calls. Jacek

Feb. 2, 2009

Re: Simplify dlls/comctl32/rebar.c

by Francois Gouget

On Fri, 30 Jan 2009, Gerald Pfeifer wrote: > (It's not clear which parameters we'd really need if it is ever fully > implemented.) > > ChangeLog: > Simplify. [...] > > Index: dlls/comctl32/rebar.c [...] > @@ -3618,7 +3618,6 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > > /* case RB_SETCOLORSCHEME: */ > /* case RB_SETPALETTE: */ > -/* return REBAR_GetPalette (infoPtr, wParam, lParam); */ > > case RB_SETPARENT: Once the commented out return has been removed it looks like RB_SETCOLORSCHEME and RB_SETPALETTE are meant to fall through to RB_SETPARENT, which does not seem right... So I'd leave a comment there, maybe /* return ...; */. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

Feb. 2, 2009

Re: Anything wrong with this patch?

by Jérôme Gardou

Austin English a écrit : > On Fri, Jan 23, 2009 at 5:37 PM, Jérôme Gardou <jerome.gardou(a)gmail.com> wrote: > >> Ben Klein a écrit : >> >>> 2009/1/24 Austin English <austinenglish(a)gmail.com>: >>> >>> >>>> On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou <jerome.gardou(a)gmail.com> >>>> wrote: >>>> >>>> >>>>> Ben Klein a écrit : >>>>> >>>>> >>>>>> I just looked at bug 15616. Maybe you should look at it too. >>>>>> >>>>>> Also, please hit "Reply to all" so your message gets sent to the >>>>>> mailing list too :) >>>>>> >>>>>> >>>>>> >>>>> Of course... Austin English already noticed my patch. Austin, any idea >>>>> why it was rejected? >>>>> >>>>> Sorry for the "reply to all", I forgot it this time... >>>>> >>>>> >>>>> >>>> I don't know. I only noticed the empty patch. AJ would be the one to ask. >>>> >>>> Off hand though, I'd say if you're going to add support for .acm, you >>>> should also allow for other native files. iexplore.exe is one >>>> candidate, but probably controversial. There are other file extension >>>> types missing, I'm sure, though not sure which types off hand. >>>> >>>> >>>> >>> Is it really about "supporting"? As AJ points out in his comment, >>> nothing stops you from writing in the .acm file, which is almost >>> certainly faster than scrolling through the whole list to find it >>> anyway. >>> >>> Isn't the list of DLLs in winecfg long enough already? >>> >>> >>> >>> >> I like to type the beginning of a dll, and just press <tab> to get its full >> name. It is only a matter of comfort. :) >> >> > > That, and developers are probably aren't using this much anyway. Most > of us avoid native dlls, but when using them A) use winetricks or B) > use WINEDLLOVERRIDES. > > Users would find it more convenient, and arguably, they should be able > to. I don't see any reason we shouldn't allow .acm's. Sys/drv probably > not. Exe, debatable. > > I resent the patch quite some time ago, but it's still unaccepted... http://www.winehq.org/pipermail/wine-patches/2009-January/068325.html

Feb. 2, 2009

Re: d3d9/tests : LockRect acquires the lock if D3DLOCK_NOSYSLOCK is not specified.

by Jérôme Gardou

Forget this one please.

Feb. 2, 2009

Re: [2/2] mlang: Export a couple of functions by ordinal.

by Dmitry Timoshkov

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > IE7 imports these and possibly others by ordinal. > > -Hans > > diff --git a/dlls/mlang/mlang.spec b/dlls/mlang/mlang.spec > index 1e8f022..689ad27 100644 > --- a/dlls/mlang/mlang.spec > +++ b/dlls/mlang/mlang.spec > @@ -1,14 +1,15 @@ > +112 stdcall ConvertINetUnicodeToMultiByte(ptr long ptr ptr ptr ptr) > +120 stdcall LcidToRfc1766A(long ptr long) > +121 stdcall LcidToRfc1766W(long ptr long) > + > @ stdcall ConvertINetMultiByteToUnicode(ptr long ptr ptr ptr ptr) > @ stub ConvertINetReset > @ stdcall ConvertINetString(ptr long long ptr ptr ptr ptr) > -@ stdcall ConvertINetUnicodeToMultiByte(ptr long ptr ptr ptr ptr) > @ stdcall -private DllCanUnloadNow() > @ stdcall -private DllGetClassObject(ptr ptr ptr) > @ stdcall -private DllRegisterServer() > @ stdcall -private DllUnregisterServer() > @ stdcall GetGlobalFontLinkObject() > @ stdcall IsConvertINetStringAvailable(long long) > -@ stdcall LcidToRfc1766A(long ptr long) > -@ stdcall LcidToRfc1766W(long ptr long) > @ stdcall Rfc1766ToLcidA(ptr str) > @ stdcall Rfc1766ToLcidW(ptr wstr) I've compared the exports of win98 and winxp versions of mlang.dll and they have exactly the same ordinals assigned. So it should be safe to assign ordinals to all mlang exports (it's worth to mention that PSDK doesn't ship an mlang.lib). -- Dmitry.

Feb. 2, 2009

Re: BOOL WINAPI versus BOOL in d3dx9 and d3dx8

by paulo lesgaz

--- En date de : Dim 1.2.09, Tony Wasserka <tony.wasserka(a)freenet.de> a écrit : De: Tony Wasserka <tony.wasserka(a)freenet.de> Objet: Re: BOOL WINAPI versus BOOL in d3dx9 and d3dx8 À: wine-devel(a)winehq.org Cc: jeremielapuree(a)yahoo.fr Date: Dimanche 1 Février 2009, 14h45 > Hi, > > the declaration of IntersectionTri is > BOOL IntersectionTri(.....) in d3dx8mesh.h and BOOL WINAPI? IntersectionTri(.....) in d3dx9mesh.h . > > Is the latter one compatible with the former one (so I can forward d3dx9 function to the d3dx8 one) > or must I implement them separately? > > David It's already forwarded in d3dx9_36.spec to d3dx8, so you don't need to implement it twice. I was pretty careful when creating that specfile, i.e. it's in 99% safe to trust it ;) As a rule of thumb, every d3dx9 function which has no device (or any other D3D9 specific interface) parameter and has the exact same parameter list can safely be forwarded to d3dx8. However, are you sure it's only BOOL in d3dx8? AFAIK, dll functions always have to be WINAPI, as the calling convention gets screwed up otherwise... Best regards, Tony Yes, in the directx8 sdk the prototype is BOOL, not BOOL WINAPI. David

Feb. 2, 2009

Re: wined3d and winex11 hand in hand...

by Jérôme Gardou

Dmitry Timoshkov a écrit : > > "Jérôme Gardou" <jerome.gardou(a)gmail.com> wrote: > >> Quite oddly enough, wined3d and winex11 don't communicate with each >> other at all (well, wined3d uses WGL in gdi32, and gdi32 is based on >> winex11), and this leads to problems which are tricky to resolve... For >> instance, when a d3d application wants to disable screensavers, > > And how exactly does it "want" to do that? > By setting presentationparameters->windowed = false and using D3DCREATE_SCREENSAVER in BehaviorFlags when creating a device. >> there is >> no way to do this through the windows api, but xlib provides >> XSetScreenSaver which is axactly what we need there. > > http://www.google.com/search?q=how+to+disable+screen+saver+under+windows+pr… > > > http://support.microsoft.com/kb/126627 Good catch. I will try this way. >> Would it be a good way to do this, as in user32 and gdi32, to create a >> driver structure holding each function pointer we would need, and >> forward them to stub if unavailable? > > Have you looked how it's currently implemented? > Yes. I don't see any major problem with this design.

Feb. 2, 2009

Re: Simple but awesome demos of Wine?

by Tom Wickline

Hello Dan, I would suggest maybe a demo of CrossOver Office and Office 2003 or 2007. Yes, I'm aware of Open Office but many business still prefer Microsoft Office and Outlook.. It also shows that there is a support channel available for large install bases. Just my $.02 Tom On Mon, Feb 2, 2009 at 1:48 AM, Dan Kegel <dank(a)kegel.com> wrote: > > This show is a big opportunity for us to > introduce Wine to a large audience, so > any help here would be appreciated. >

Feb. 2, 2009