March 2009 - Wine-Devel - list.winehq.org

Re: [2/2](try 2)advapi: handle fully qualified account names for well known sids in LookupAccountName

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2667,11 +2669,23 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, LPCWSTR lpAccountName, PSI > } > > /* Check well known SIDs first */ > + if (strchrW(lpAccountName,'\\')) > + { > + lpAccountNamePtr = strrchrW(lpAccountName,'\\'); > + lpAccountNamePtr++; > + lpDomainNamePtr = lpAccountName; > + } > + else > + lpAccountNamePtr = lpAccountName; > > for (i = 0; i < (sizeof(ACCOUNT_SIDS) / sizeof(ACCOUNT_SIDS[0])); i++) > { > - if (!strcmpiW(lpAccountName, ACCOUNT_SIDS[i].account) || > - (ACCOUNT_SIDS[i].alias && !strcmpiW(lpAccountName, ACCOUNT_SIDS[i].alias))) > + /* check domain first */ > + if (lpDomainNamePtr && strncmpiW(lpDomainNamePtr, ACCOUNT_SIDS[i].domain, strlenW(ACCOUNT_SIDS[i].domain))) > + continue; You always need to check that the next char is a terminator when using functions like strncmpiW. -- Alexandre Julliard julliard(a)winehq.org

March 30, 2009

Re: mciqtz32: Implement driver messages

by Detlef Riekenberg

On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: > That said, I don't understand then why we don't just convert wine's > code (in > several steps off course) and avoid troubles particularity switch from > one > style to another depending on the dll we are working on. Changing only the indention is not desired, as the history is falsified (Original Author and date/time of the the last code-change). Expect patches with unrelated indention changes to be rejected. > I recently implemented d3dxof using a 2 spaces indentation style. > I don't know either how this code could have gone into git. :-| Parts of the old code use 4 SPACE, other parts use 2 SPACE, but the Styple was not enforced tha hard in the old days. > So next time I will convert d3dxof to 4 spaces and see what happens > to > the patch. ;-) I suggest to ask Julliard before you start with that. He might exceptional accept that style changes only Patch, as you did the major part of the code in that dll. -- By by ... Detlef

March 30, 2009

Re: [RFC] Port of Stefan Dösinger's ARB_vertex_program fixed-function vertex pipeline replacement to 1.1.18

by Henri Verbeet

2009/3/30 Paul TBBle Hampson <Paul.Hampson(a)pobox.com>: > Any suggestions on the work that is needed? Apart from the above > GL_INVALID_VALUE, I'm unaware of any failures apart from it being slow. > I'd need to do a proper review, but eg. "can_convert_d3dcolor" is something that needs a bit more thought to be properly integrated. Properly handling GL_VERTEX_PROGRAM_POINT_SIZE_ARB looks like another, although that should probably be done separately from this patch set in the first place (that's essentially bug 8826).

March 30, 2009

Re: [RFC] Port of Stefan Dösinger's ARB_vertex_program fixed-function vertex pipeline replacement to 1.1.18

by Paul TBBle Hampson

On Sun, Mar 29, 2009 at 02:23:42PM +0200, Henri Verbeet wrote: > 2009/3/29 Paul TBBle Hampson <Paul.Hampson(a)pobox.com>: >> fixme:d3d_surface:surface_upload_data >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexSubImage2D @ ../../../dlls/wined3d/surface.c / 349 > These are a problem, I think. Co-incidentally, I just saw some of these errors from an unpatched 1.1.17 build in Warhammer Online, which is a D3D9X-based game. I'll look into it, but I'm actually having trouble getting 3DMark2000 to do it again, I suspect it's just me running low on video ram, since I'd just had an error to that effect in Warhammer Online when I saw this error in that. > 2009/3/29 Stefan Dösinger <stefandoesinger(a)gmx.at>: >> Its probably a reasonable goal to get this in, but disabled by default until >> the performance problems are resolved(I guess that lighting is the main >> bottleneck). That will make it easier for others to implement vertex blending >> in a proper fashion. >> That said, I don't really remember the state of the code, and if it is clean >> enough to be committed. > It will need some work, but I think getting it merged is a good idea. Any suggestions on the work that is needed? Apart from the above GL_INVALID_VALUE, I'm unaware of any failures apart from it being slow. I guess a registry entry check in select_vertex_implementation would be a good start. -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

March 30, 2009

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

by Andreas Rosenberg

>Were you intending to send this to wine-patches? Yes. Sorry for posting on the wrong list.

March 30, 2009

Advice on where to place new private methods and access to private methods across modules.

by Damian Dixon

Hi, I am working on creating a patch for X11DRV_AlphaBlend to allow Bitmap's with no DIBSECTION to work. The code to do this is fairly generic so I created a new method: DIB_CreateDIBSectionFromBitmap. I initially placed this in winex11.drv/dib.c, however the method required access to private methods in gdi32/dib.c. I then considered moving the method to gdi32, however again access to private methods seems to be an issue. I would prefer not to duplicate code across the dib.c files. Is there an accepted approach for acessing support methods across the modules? or should I just duplicate the necessary methods? Thanks Damian

March 30, 2009

Re: 16bit code generation

by King InuYasha

On Sun, Mar 29, 2009 at 7:39 PM, Hin-Tak Leung <hintak_leung(a)yahoo.co.uk>wrote: > > I wonder how bad is it to port some old version of djgpp forward? > ( http://www.delorie.com/djgpp/history.html ) - it is a fork of gcc as far > as I see and did support 16-bit code generation at one time? > > > It is a fork of GCC, but as stated earlier, it produces only 32-bit code. Still, it isn't impossible to make a 32-bit compiler generate 16-bit code, is it? I know Visual C++ (1.52) was like that, and while it would definitely not be trivial, perhaps adding in Win16 support to MinGW/DJGPPv2 GCC would be a better way to go rather than porting an old version of DJGPP. Nobody really wants to maintain an old version of GCC and from what I'm seeing, DJGPP v1 uses a pretty old version of GCC (2.x I believe). DJGPP v2's latest version uses GCC 4.3.2, so it might be possible to work with that and add 16-bit DOS/Win16 code generation.

March 30, 2009

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

by Jeff Latimer

Andreas Rosenberg wrote: > ------------------------------------------------------------------------ > > Were you intending to send this to wine-patches?

March 30, 2009

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

by Andreas Rosenberg

March 30, 2009

Re: Patch for specifying video card name and driver

by Henri Verbeet

2009/3/30 John Whitlock <John-Whitlock(a)ieee.org>: > This patch adds the ability to specify the name and driver for the video > card using registry keys (Current_user/Software/Wine/Direct3D). This is > similar to existing code in wined3d, and has been used since 1.1.8 to get > Fallout 3 working. > Either you didn't write this, or you made the exact same errors as in the other patch doing the same thing I already commented on.

March 30, 2009