March 2009 - Wine-Devel - list.winehq.org

Re: wined3d [try3]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled

by Henri Verbeet

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > + hrc = IWineD3DDeviceParent_CreateDepthStencilSurface(This->device_parent, > + NULL, > + pPresentationParameters->BackBufferWidth, > + pPresentationParameters->BackBufferHeight, > + pPresentationParameters->AutoDepthStencilFormat, > + pPresentationParameters->MultiSampleType, > + pPresentationParameters->MultiSampleQuality, > + FALSE, > + &This->auto_depth_stencil_buffer); Even though I don't think any implementation of IWineD3DDeviceParent_CreateDepthStencilSurface actually uses the second parameter, you should pass "This->parent" rather than NULL there. > + if (SUCCEEDED(hrc)) > + IWineD3DDevice_SetDepthStencilSurface(iface, This->auto_depth_stencil_buffer); This is redundant, the code a couple of lines down will also set the depth stencil. > + else { > + ERR("Failed to create the auto depth stencil\n");· > + return WINED3DERR_INVALIDCALL; > + } You're leaking the swapchain here. Also, not trying to be picky, but could you please fix the indentation?

March 29, 2009

Re: GetTempFileName should return 0 when the path isn't valid

by Oskar Eisemuth

Hello >> GetTempFileName should check the path and should return zero if it isn't a directory. >> See Bug 17875 >> >> --- >> dlls/kernel32/path.c | 10 ++++++++++ >> 1 files changed, 10 insertions(+), 0 deletions(-) > > Can you add a testcase for this? That would need something like an non existent subpath or path? I guess it would be something like a copy of NONDIR_SHORT. sprintf(tmpstr,"%s%s",tmppath, NONDIR_SHORT); ok((id=GetTempFileNameA(tempstr,"path",0,newdir)),"GetTempFileNameA failed\n"); -- Oskar

March 29, 2009

Re: GetTempFileName should return 0 when the path isn't valid

by Austin English

On Sun, Mar 29, 2009 at 11:37 AM, Oskar Eisemuth <patchnow(a)gmail.com> wrote: > GetTempFileName should check the path and should return zero if it isn't a directory. > See Bug 17875 > > --- > dlls/kernel32/path.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > > Can you add a testcase for this? -- -Austin

March 29, 2009

Re: mciqtz32: Implement driver messages

by Christian Costa

I din't know wine has a indentation style. This is good news. That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. I recently implemented d3dxof using a 2 spaces indentation style. I don't even know what led me to use this style because I prefer 4 spaces. Maybe there was few lines using it and I sticked to this style. I don't remember. I don't know either how this code could have gone into git. :-| So next time I will convert d3dxof to 4 spaces and see what happens to the patch. ;-) Bye, Christian Detlef Riekenberg a écrit : > On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: > >> There are some discrepancies in the indentation and I don't mind >> removing tabs but what's >> wrong with them, they are commonly use in wine depending on one's >> taste. >> > > Wine use 4 SPACE for indention. > There is old code that use 2 or 3 SPACE, some old locations use TAB > (width 8) and also some locations with TAB and SPACE mixed can be found. > > The rule is to stay with the same style as used in the file before > (2, 3 or 4 SPACE), but never mix SPACE and TAB in touched lines. > > For new files, there is no old style to cover with, so 4 SPACE > indention is expected. > > >

March 29, 2009

Re: winetricks:

by Austin English

2009/3/29 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this patch let winetricks only overwrite d3dx9_36.dll, because all other > d3dx9_xx.dlls should be redirected by wine's implementation, so this > shouldn't be needed for this dlls. I don't think this is needed. If you look at the updated winetricks (http://winezeug.googlecode.com/svn/trunk/winetricks) there's a keyword (d3dx9) that only overrides these dlls. The current directx is for sledgehammer approach (a warning against it has been added). -- -Austin

March 29, 2009

Re: winetricks: update d3dx redist package.

by Austin English

2009/3/29 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this patch updates the DirectX redist package in winetricks to version > Mar09. Please rediff against http://winezeug.googlecode.com/svn/trunk/winetricks. A lot has changed since the last winetricks release (the one on kegel.com) -- -Austin

March 29, 2009

GSoC: Improving DOS graphics

by Daniel Kraft

Hi, I would be interested in working on WINE for Google Summer of Code (as I would like to get into WINE and learn more about it from the developer's side of view; I imagine this is a very educational and interesting experience in addition to being simply an interesting free software project to work on). On the ideas list is a project about improving handling of DOS graphics mode, this sounds interesting to me. I've got good experience with C, C++ and other programming languages as well as programming in general, but so far no knowledge at all about WINE apart from using it. Do you think this would be a good project to apply for and get into WINE? (Thus both useful for the community as well as a good point for me without WINE experience so far.) Regarding free software in general, I've already worked with some projects including Mozilla and GCC, so I should be familiar with standard development practices involved. Thank you very much, Daniel

March 29, 2009

Re: mciqtz32: Implement driver messages

by Detlef Riekenberg

On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: > There are some discrepancies in the indentation and I don't mind > removing tabs but what's > wrong with them, they are commonly use in wine depending on one's > taste. Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPACE, some old locations use TAB (width 8) and also some locations with TAB and SPACE mixed can be found. The rule is to stay with the same style as used in the file before (2, 3 or 4 SPACE), but never mix SPACE and TAB in touched lines. For new files, there is no old style to cover with, so 4 SPACE indention is expected. -- By by ... Detlef

March 29, 2009

Fwd: How to "bottle" applications for distribution with wine?

by David Gerard

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/29 Subject: Re: How to "bottle" applications for distribution with wine? To: Ben Klein <shacklein(a)gmail.com> 2009/3/29 Ben Klein <shacklein(a)gmail.com>: > He's asking if it's possible to bundle a minimal Wine with some native > app (e.g. EVE "Linux version" which was EVE for Windows with Cedega, > and the same basic principle for the "Linux version" of the Sims > shipped with some Mandrakes). > The only thing I can think of is to calculate the maximum set of > required DLLs for the application, and only ship those, but it's > probably not worth it. It's better in general to use a system-wide > Wine, due to the general-purpose nature of Wine. Mm. Look at Picasa for Linux, which really does package pretty much a whole Wine with the app. (I just run the Windows version in my system Wine ;-) ) So it won't be smaller, but it will be a single package. Are there notes anywhere on how Picasa packages Wine? - d.

March 29, 2009

strange git object

by Eric Pouech

while updating my git tree, I ran (actually not finished downloading) this pack: Resuming fetch of pack 119463f192a563f17ac18ff9b717fbe57199eed7 at byte 95266539 which size looks quite enormous to me... any idea of what's going on ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

March 29, 2009