April 2009 - Wine-Devel - list.winehq.org

Re: Wine registry question

by Damjan Jovanovic

On Fri, Apr 3, 2009 at 11:33 AM, Rob Shearman <robertshearman(a)gmail.com> wrote: > 2009/4/2 Damjan Jovanovic <damjan.jov(a)gmail.com>: >> Hi Hello >> I've noticed that Wine doesn't merge HKCU\Classes\Root into HKCR >> (http://bugs.winehq.org/show_bug.cgi?id=17019) >> >> Is this for compatibility with older Windows versions, or is it a Wine bug? > > It's not a bug, it's just a missing feature and one that isn't trivial > to implement. For example, in which component should this be done - in > the server, in advapi32 code or when loading the user's registry hive > (should be userenv, but actually done in the server)? What happens if > there are two keys or values with the same name in both > HKCU\Software\Classes and HKLM\Software\Classes? Does a delete from > HKCR delete the key/value in the underlying view? If you add a > key/value to a key that exists in HKCR and you don't have permission > because it is from HKLM\Software\Classes if it added instead to > HKCU\Software\Classes? How do you amalgamate change notification from > both HKCU\Software\Classes and HKLM\Software\Classes? Yes it's tricky, but the Windows behavior seems well documented (http://msdn.microsoft.com/en-us/library/ms724498(VS.85).aspx) > -- > Rob Shearman > Damjan Jovanovic

April 3, 2009

Re: Wine registry question

by Rob Shearman

2009/4/2 Damjan Jovanovic <damjan.jov(a)gmail.com>: > Hi > > I've noticed that Wine doesn't merge HKCU\Classes\Root into HKCR > (http://bugs.winehq.org/show_bug.cgi?id=17019) > > Is this for compatibility with older Windows versions, or is it a Wine bug? It's not a bug, it's just a missing feature and one that isn't trivial to implement. For example, in which component should this be done - in the server, in advapi32 code or when loading the user's registry hive (should be userenv, but actually done in the server)? What happens if there are two keys or values with the same name in both HKCU\Software\Classes and HKLM\Software\Classes? Does a delete from HKCR delete the key/value in the underlying view? If you add a key/value to a key that exists in HKCR and you don't have permission because it is from HKLM\Software\Classes if it added instead to HKCU\Software\Classes? How do you amalgamate change notification from both HKCU\Software\Classes and HKLM\Software\Classes? -- Rob Shearman

April 3, 2009

Registry keys for serial ports

by Stefan Leichter

Hello Alexandre, you said in http://www.winehq.org/pipermail/wine-devel/2008-November/070691.html that registry entries for the serial ports should be created from the information received from hal. i 'm planing to implement this code. But before i start coding i like to know where the code should be created. Should the code go into kernel32/oldconfig.c, should i start creating serenum.sys is there any other place? Bye Stefan

April 3, 2009

Re: (resubmit) user32: In COMBO_WindowPosChanging() do not change the height of the the dropped rectangle, if the new height is too small

by Rein Klazes

On Thu, 02 Apr 2009 17:21:37 +0200, you wrote: >It doesn't work here: > >../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so combo.c && touch combo.ok >combo.c:143: Tests skipped: Invalid Marlett font heights >combo.c:143: Tests skipped: Invalid Marlett font heights >combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 >combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 >make[2]: *** [combo.ok] Error 2 Same thing here. I don't know why I put the todo there. New patch sent. Rein.

April 3, 2009

Re: Windows 7

by Stefan Dösinger

Am Donnerstag, 2. April 2009 13:07:18 schrieb Fred .: > Yeah, I know. > It is on the way though. It will be released. > So I would like to be able to choose Windows 7. Feel free to send a patch ;-)

April 2, 2009

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something

by Nikolay Sivov

Joris Huizer wrote: > > --- On Thu, 4/2/09, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > > >> From: Nikolay Sivov <bunglehead(a)gmail.com> >> Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something >> To: wine-devel(a)winehq.org, joris_huizer(a)yahoo.com >> Date: Thursday, April 2, 2009, 2:04 PM >> >>> Joris Huizer wrote: >>> >> Hi, Joris. Thanks for spotting this, but changes you've >> made will fail on Windows. I've just sent a corrected >> version with one test more. >> Here it is if you're interested: >> http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html >> >> >> > > No problem :-) > Sorry I didn't test with Windows just as I don't have it available; > I wasn't sure what would be the proper action, to send a best-guess patch or personal email - any ideas on this in general? > > regards, Joris > The best way for me is send a mail to wine-devel with commit subject line (cause speaking of that case wrong patch was already committed) that any developer could review it and send a fix. Patch author could be easily unavailable so personal mailing will delay a fix. A patch to wine-patches is also acceptable of course.

April 2, 2009

Re: [1/4]winemaker: winresrc.h is the right name in actual wine(try10)

by André Hentschel

Austin English schrieb: > On Thu, Apr 2, 2009 at 2:58 PM, Dawncrow <webmaster(a)dawncrow.de> wrote: > >> --- >> tools/winemaker | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> >> >> >> >> >> > > Your patch lacks your real name. > > Sry for the noise, selected the wrong account, the four patches after these are with my name.

April 2, 2009

Re: [1/4]winemaker: winresrc.h is the right name in actual wine(try10)

by Austin English

On Thu, Apr 2, 2009 at 2:58 PM, Dawncrow <webmaster(a)dawncrow.de> wrote: > --- > tools/winemaker | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > > > Your patch lacks your real name. -- -Austin

April 2, 2009

Wine registry question

by Damjan Jovanovic

Hi I've noticed that Wine doesn't merge HKCU\Classes\Root into HKCR (http://bugs.winehq.org/show_bug.cgi?id=17019) Is this for compatibility with older Windows versions, or is it a Wine bug? Damjan Jovanovic

April 2, 2009

Re: include: Add declaration of sockaddr_storage to winsock2.h.

by Alexandre Julliard

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -437,6 +437,18 @@ typedef struct _CSADDR_INFO { > } CSADDR_INFO, *PCSADDR_INFO, *LPCSADDR_INFO; > #endif > > +#define _SS_MAXSIZE 128 > +#define _SS_ALIGNSIZE (sizeof(__int64)) > +#define _SS_PAD1SIZE (_SS_ALIGNSIZE - sizeof(short)) > +#define _SS_PAD2SIZE (_SS_MAXSIZE - 2 * _SS_ALIGNSIZE) > + > +typedef struct WS(sockaddr_storage) { > + short ss_family; > + char __ss_pad1[_SS_PAD1SIZE]; > + __int64 __ss_align; > + char __ss_pad2[_SS_PAD2SIZE]; > +} SOCKADDR_STORAGE, *PSOCKADDR_STORAGE, *LPSOCKADDR_STORAGE; This is apparently in ws2def.h in the Vista SDK. Also the #defines need a WS prefix too. -- Alexandre Julliard julliard(a)winehq.org

April 2, 2009