April 2009 - Wine-Devel - list.winehq.org

Re: mshtml/tests: Fix tests on Windows

by Reece Dunn

2009/4/1 Ge van Geldorp <ge(a)gse.nl>: > Modify load_state only in ReadyState_Changed callback. > > Changelog: > Fix tests on Windows > > --- > dlls/mshtml/tests/htmldoc.c | 28 +++++++++++++++++++++++----- > 1 files changed, 23 insertions(+), 5 deletions(-) > mode change 100644 => 100755 dlls/mshtml/tests/htmldoc.c Is there a reason for the mode change? - Reece

April 1, 2009

Re: [1/5] resend include: bring in6_addr into line with the MS definition

by Jeff Latimer

Alexandre Julliard wrote: > Jeff Latimer <lats(a)yless4u.com.au> writes: > > >> diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h >> index a38ccda..9ddb3d1 100644 >> --- a/include/ws2tcpip.h >> +++ b/include/ws2tcpip.h >> @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { >> struct WS(in_addr) imsf_slist[1]; >> }; >> >> -typedef struct WS(in_addr6) >> -{ >> - WS(u_char) s6_addr[16]; /* IPv6 address */ >> +struct WS(in6_addr) { >> + union { >> + WS(u_char) Byte[16]; >> + WS(u_short) Word[8]; >> + } u; >> } IN6_ADDR, *PIN6_ADDR, *LPIN6_ADDR; >> >> +#define in_addr6 WS(in6_addr) >> + >> +#define _S6_un u >> +#define _S6_u8 Byte >> +#ifndef USE_WS_PREFIX >> +#define s6_addr _S6_un._S6_u8 >> +#else >> +#define WS_s6_addr _S6_un._S6_u8 >> +#endif >> + >> +#define s6_bytes u.Byte >> +#define s6_words u.Word >> > > This doesn't seem to match the PSDK, I don't see anything like this in > ws2tcpip.h. > What is the policy for selecting the Platform SDK? Do we always use the latest (in this case Vista) PSDK? There does not appear to any guidance on this matter on the various Wine sites. Jeff The following is from WS2tcpip.h in the XP PSDK that I have. I think it looks similar to what I submitted. Have I got the wrong PSDK? /* IPv6 definitions */ #ifndef s6_addr struct in6_addr { union { u_char Byte[16]; u_short Word[8]; } u; }; #define in_addr6 in6_addr /* ** Defines to match RFC 2553. */ #define _S6_un u #define _S6_u8 Byte #define s6_addr _S6_un._S6_u8 /* ** Defines for our implementation. */ #define s6_bytes u.Byte #define s6_words u.Word #endif

April 1, 2009

Re: advapi32/tests: Skip some tests using English names when running on non-English locales

by Paul Vriens

Ge van Geldorp wrote: > Account names are localized. Similar to existing skip in line 1806. > > Changelog: > Skip some tests using English names when running on non-English locales > > --- > dlls/advapi32/tests/security.c | 45 > ++++++++++++++++++++++----------------- > 1 files changed, 25 insertions(+), 20 deletions(-) > > > > > > ------------------------------------------------------------------------ > > Hi Ge, Aric sent a patch yesterday to address this: http://www.winehq.org/pipermail/wine-patches/2009-March/071373.html Besides that I don't think there is a need for this big indented block. You could have just done : if() { skip() return; } -- Cheers, Paul.

April 1, 2009

GSoC proposal

by cocofan

I'm a student interested in applying for Google summer of code and I was looking over your ideas. I'm familiar with wine as a user (for running an occasional windows app I'm forced to run) and I notice one of your ideas is getting old DOS games to run under wine. I'm a big fan of the original Lemmings DOS game but can't get it to work under wine (it doesn't respond to the pressing of keys or mouse clicks when the storyboard is up). Would it be possible to work on getting Lemmings to work. I'm not sure this is a problem with VGA though but I wouldn't mine working on some other old DOS classics (I kind of miss them). Also, how detailed you do want the timeline/milestones to be? I'm not familiar with the code yet and won't be by the deadline (which is Friday). I'm in the process of getting and compiling the code from the 'git' repository though. Dona Hertel

April 1, 2009