May 2009 - Wine-Devel - list.winehq.org

"How Not To Develop On Windows"

by Dan Kegel

http://pdh11.blogspot.com/2009/05/how-not-to-develop-on-windows.html is a partial guide to developing Windows GUI apps on Linux using mingw and test them with Wine. Seems like an expanded version of this might belong on the Wine wiki...

May 31, 2009

Re: winecfg: Update WinXP version to SP3

by Austin English

On Sun, May 31, 2009 at 1:36 PM, Vitaliy Margolen <wine-patches(a)kievinfo.com> wrote: > --- > programs/winecfg/appdefaults.c | 2 +- > tools/wine.inf.in | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) You forgot to update ntdll/version.c -- -Austin

May 31, 2009

Re: DIB engine

by Stephan Rose

On Sun, 2009-05-31 at 12:23 -0700, Dan Kegel wrote: > On Sun, May 31, 2009 at 12:45 AM, Stephan Rose <kermos(a)somrek.net> wrote: > >> If you're looking for something better specified, try finishing off > >> gdiplus. > > ... I'll check into gdiplus missing bits sometime next week. :) > > > > My name's Andrew Eikum, I'm an undergraduate Computer > > Science student at the University of Minnesota. > > I contacted a Wine dev a few weeks ago asking for a small > > project to use to get familiar with Wine. I was pointed > > towards the gdiplus section and told to begin stubbing > > out the missing functions, to facilitate debugging. > > After familiarizing myself with how Wine's DLLs are built, > > and with Git, I'm now making quick progress. I expect to > > have a (huge) patchset ready in the next week or two with > > most of the gdiplus functions stubbed. > > Excellent! (And Stephan, there's more than enough work > to go around, don't worry that Andrew's going to do it all :-) Hahaha, not worried. Btw, I seem to have a handle on the stringformat alignment bug. By the looks of it I may have a patch for that sometime over the next couple days. Don't know if I will make it today as I have a roughly 5'6" brunette incentive to do something other than write code tonight. :) Stephan

May 31, 2009

Re: DIB engine

by Dan Kegel

On Sun, May 31, 2009 at 12:45 AM, Stephan Rose <kermos(a)somrek.net> wrote: >> If you're looking for something better specified, try finishing off >> gdiplus. > ... I'll check into gdiplus missing bits sometime next week. :) > > My name's Andrew Eikum, I'm an undergraduate Computer > Science student at the University of Minnesota. > I contacted a Wine dev a few weeks ago asking for a small > project to use to get familiar with Wine. I was pointed > towards the gdiplus section and told to begin stubbing > out the missing functions, to facilitate debugging. > After familiarizing myself with how Wine's DLLs are built, > and with Git, I'm now making quick progress. I expect to > have a (huge) patchset ready in the next week or two with > most of the gdiplus functions stubbed. Excellent! (And Stephan, there's more than enough work to go around, don't worry that Andrew's going to do it all :-) > After that, I plan to begin work on implementing some of > the functions. My degree's emphasis is computer graphics, > so working on gdiplus will give me a chance to learn more > about the field as well as apply what I already know. > I'm looking forward to working with other Wine devs on > gdiplus, and other parts of Wine in the future. That's great to hear. Looking forward to seeing your patches. BTW, don't forget to look at http://wiki.winehq.org/GdiPlus, which has a few notes that might be helpful. My archive of Lei's notes at http://kegel.com/wine/sweng/2008/project.html from last year might be useful, too - it was tailored for people new to wine who want to contribute to gdiplus. (Though its big list of bugs is mostly all fixed now, I think only four remain.) - Dan

May 31, 2009

Re: Its Alive! Patchwatcher is reborn.

by Zachary Goldberg

On Sun, May 31, 2009 at 2:59 PM, Dan Kegel <dank(a)kegel.com> wrote: > Congratulations! It's nice to see it running again! > > Are you running it all on one node, or are you > using the distributed mode? I am using the distributed version of the code but for now its just on one machine. I was actually able to get it mostly working using just the provided wine-slave and master.sh. Over the summer I will look into seeing if I can scale it out a bit to a dedicated linux &&/|| windows slave . It seems plenty fast enough to keep up with wine-patches running just in Wine for now. > > Have you been watching patchwatcher's mailbox > for partial patch series? That was the biggest > chore of running Patchwatcher. > At one point they blocked the pipeline of > incoming patches, not sure if I fixed that. > Having patches back up is bad because they rapidly > go stale. > - Dan > I have seen the stale problem (I had the mailbox enabled several days before I let it start processing patches...). I haven't been but will now look out for a partial series. I will be away for the next 2 weeks starting Wednesday so there is a high probability it hangs sometime while I'm gone. It'll provide a good test case when I'm back to try and find a solution in-code =P -Zach

May 31, 2009

Re: DIB engine

by Austin English

On Sun, May 31, 2009 at 2:11 PM, Andrew Eikum <andrew(a)brightnightgames.com> wrote: > I am definitely doing small commits and following the WineGit wiki page. > One concern I have is that the number of patches will probably be over 50 > or even 75 -- I'm not sure if it'd be better to submit them all in one go as > they're pretty much all alike (just stubbing), or just do batches of 5-10 > every couple days as I finish them (so it's not a deluge of patches). Any > suggestions? No need to wait, go ahead and submit a couple. Since you're new to wine, it may take a couple days for them to get committed. Once you've got your feet wet and a few patches submitted, go ahead and submit a few more (5-10) a day. Try to avoid flooding wine-patches. The patches don't depend on each other, and it's not a huge rush to get them all in. And no need to wait to stub everything before sending implementations. If you've got it ready, and it works (add testcases to verify), send it in. Don't sit on your good patches, share them with everyone else :-). -- -Austin

May 31, 2009

Re: DIB engine

by Andrew Eikum

Austin English wrote: > On Sun, May 31, 2009 at 11:16 AM, Andrew <andrew(a)brightnightgames.com> wrote: > >> My name's Andrew Eikum, I'm an undergraduate Computer Science student at the >> University of Minnesota. I contacted a Wine dev a few weeks ago asking for >> a small project to use to get familiar with Wine. I was pointed towards the >> gdiplus section and told to begin stubbing out the missing functions, to >> facilitate debugging. After familiarizing myself with how Wine's DLLs are >> built, and with Git, I'm now making quick progress. I expect to have a >> (huge) patchset ready in the next week or two with most of the gdiplus >> functions stubbed. >> >> After that, I plan to begin work on implementing some of the functions. My >> degree's emphasis is computer graphics, so working on gdiplus will give me a >> chance to learn more about the field as well as apply what I already know. >> I'm looking forward to working with other Wine devs on gdiplus, and other >> parts of Wine in the future. >> > > Welcome to Wine! > > Be sure when sending patches to break them into small sets, with one > change per patch. It makes it much easier to review that way, and if > your patch causes a regression, much easier to identify which part if > it's in multiple patches. > Thanks for the welcome! I am definitely doing small commits and following the WineGit wiki page. One concern I have is that the number of patches will probably be over 50 or even 75 -- I'm not sure if it'd be better to submit them all in one go as they're pretty much all alike (just stubbing), or just do batches of 5-10 every couple days as I finish them (so it's not a deluge of patches). Any suggestions?

May 31, 2009

re: Its Alive! Patchwatcher is reborn.

by Dan Kegel

Congratulations! It's nice to see it running again! Are you running it all on one node, or are you using the distributed mode? Have you been watching patchwatcher's mailbox for partial patch series? That was the biggest chore of running Patchwatcher. At one point they blocked the pipeline of incoming patches, not sure if I fixed that. Having patches back up is bad because they rapidly go stale. - Dan

May 31, 2009

Re: DIB engine

by Austin English

On Sun, May 31, 2009 at 11:16 AM, Andrew <andrew(a)brightnightgames.com> wrote: > My name's Andrew Eikum, I'm an undergraduate Computer Science student at the > University of Minnesota. I contacted a Wine dev a few weeks ago asking for > a small project to use to get familiar with Wine. I was pointed towards the > gdiplus section and told to begin stubbing out the missing functions, to > facilitate debugging. After familiarizing myself with how Wine's DLLs are > built, and with Git, I'm now making quick progress. I expect to have a > (huge) patchset ready in the next week or two with most of the gdiplus > functions stubbed. > > After that, I plan to begin work on implementing some of the functions. My > degree's emphasis is computer graphics, so working on gdiplus will give me a > chance to learn more about the field as well as apply what I already know. > I'm looking forward to working with other Wine devs on gdiplus, and other > parts of Wine in the future. Welcome to Wine! Be sure when sending patches to break them into small sets, with one change per patch. It makes it much easier to review that way, and if your patch causes a regression, much easier to identify which part if it's in multiple patches. -- -Austin

May 31, 2009

Re: DIB engine

by Andrew

Stephan Rose wrote: > On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote: > >> Stephan Rose wrote: >> >>> My ears perked up when the two words DIB and spec were put >>> together in the same sentence. One frustration I encountered >>> when wanting to contribute to wine a little over two years ago >>> was that nobody seemed to be able to say "Hey, this is what >>> we are missing/need, here are the specs, go implement". >>> ... >>> So if anyone can drop a full spec into my lap which outlines >>> everything I need to write and where (given I adhere to things >>> as I should of course) I won't have any issues getting that accepted later on... >>> >> I don't think such manna is likely to fall from heaven any time soon. >> If it was that easy to spec, we would have been done by now. >> >> If you're looking for something better specified, try finishing off >> gdiplus. That's a somewhat well defined graphics package, >> and Wine's implementation has a few missing bits yet, last >> I checked. >> > > Ok, then judging from the last few posts i'll leave DIB be for now > seeing how there still seems to be some figuring out to do and I'll > check into gdiplus missing bits sometime next week. :) > > Thanks, > > Stephan I suppose this is as good a time as any to introduce myself. My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed. After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.

May 31, 2009