May 2009 - Wine-Devel - list.winehq.org

Re: Its Alive! Patchwatcher is reborn.

by Zachary Goldberg

On Sun, May 31, 2009 at 3:27 AM, Kai Blin <kai.blin(a)gmail.com> wrote: > On Sunday 31 May 2009 09:05:36 Zachary Goldberg wrote: >> All, >> >> As you may have noticed in the last WWN I have been working on getting >> patchwatcher back up on a rather nice server whose cpu time is >> graciously donated by STWing (stwing.org) I've got it running at the >> moment at >> >> http://winepatch.stwing.upenn.edu/results2/ > > The most notable issue is that most patches fail to apply and apply claims > they're reversed patches. Are you sure you're using git am the right way? > > Cheers, > Kai > > -- > Kai Blin > WorldForge developer http://www.worldforge.org/ > Wine developer http://wiki.winehq.org/KaiBlin > Samba team member http://www.samba.org/samba/team/ > -- > Will code for cotton. > The code wasn't correctly checking for previously applied patches. Does it look more reasonable now in the number of patch application failures? -Zach

May 31, 2009

re: DIB engine

by Stephan Rose

On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote: > Stephan Rose wrote: > > My ears perked up when the two words DIB and spec were put > > together in the same sentence. One frustration I encountered > > when wanting to contribute to wine a little over two years ago > > was that nobody seemed to be able to say "Hey, this is what > > we are missing/need, here are the specs, go implement". > >... > > So if anyone can drop a full spec into my lap which outlines > > everything I need to write and where (given I adhere to things > > as I should of course) I won't have any issues getting that accepted later on... > > I don't think such manna is likely to fall from heaven any time soon. > If it was that easy to spec, we would have been done by now. > > If you're looking for something better specified, try finishing off > gdiplus. That's a somewhat well defined graphics package, > and Wine's implementation has a few missing bits yet, last > I checked. Ok, then judging from the last few posts i'll leave DIB be for now seeing how there still seems to be some figuring out to do and I'll check into gdiplus missing bits sometime next week. :) Thanks, Stephan

May 31, 2009

Re: Its Alive! Patchwatcher is reborn.

by Kai Blin

On Sunday 31 May 2009 09:05:36 Zachary Goldberg wrote: > All, > > As you may have noticed in the last WWN I have been working on getting > patchwatcher back up on a rather nice server whose cpu time is > graciously donated by STWing (stwing.org) I've got it running at the > moment at > > http://winepatch.stwing.upenn.edu/results2/ The most notable issue is that most patches fail to apply and apply claims they're reversed patches. Are you sure you're using git am the right way? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

May 31, 2009

Its Alive! Patchwatcher is reborn.

by Zachary Goldberg

All, As you may have noticed in the last WWN I have been working on getting patchwatcher back up on a rather nice server whose cpu time is graciously donated by STWing (stwing.org) I've got it running at the moment at http://winepatch.stwing.upenn.edu/results2/ There are still many, many kinks to be worked out before I would use this as reliable and/or before I even think about enabling sending to patch authors. But if you're curious thats where the results are going and will likely be in the future. -Zach p.s. Kudos to Dan Kegel for a great walkthrough in the PW readme.txt, and of course for putting patchwatcher together in the first place!

May 31, 2009

Re: WIne DIB

by James McKenzie

Ben Klein wrote: > Stop making new threads about this! We've already had too many DIB > Engine threads! > > > +1. Please keep all of the traffic on the DIB engine to one thread. James McKenzie

May 31, 2009

Re: WIne DIB

by Ben Klein

Stop making new threads about this! We've already had too many DIB Engine threads!

May 31, 2009

Re: DIB engine

by David Gerard

2009/5/30 Dan Kegel <dank(a)kegel.com>: > If you're looking for something better specified, try finishing off > gdiplus. That's a somewhat well defined graphics package, > and Wine's implementation has a few missing bits yet, last > I checked. OH YES PLEASE. (lots of apps missing bits of this - check over bugzilla and everything in it that's been stubbed) - d.

May 30, 2009

re: DIB engine

by Dan Kegel

Stephan Rose wrote: > My ears perked up when the two words DIB and spec were put > together in the same sentence. One frustration I encountered > when wanting to contribute to wine a little over two years ago > was that nobody seemed to be able to say "Hey, this is what > we are missing/need, here are the specs, go implement". >... > So if anyone can drop a full spec into my lap which outlines > everything I need to write and where (given I adhere to things > as I should of course) I won't have any issues getting that accepted later on... I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now. If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked. - Dan

May 30, 2009

WIne DIB

by chris ahrendt

On 05/30/2009 12:59 PM, wine-devel-request(a)winehq.org wrote: > Ben Klein ha scritto: > >> >> You would be surprised at how much of Wine is NOT a hack internally. >> Wine doesn't do hacks, > > Well, well.... there are some, indeed. > Of course, it's better not add new ones :-) > > hence AJ's reluctance to include the current >> DIB proposal in Wine (to make it "correct" later will require a lot of >> hacking, as Max has objected). > > Again, my engine isn't a hack. Nor you'll need hacks to embed it on > gdi32. > Even more, some parts will be simplified because of direct access to > internal > gdi32 structures, which can't be done (without hacks....) in current > implementation. > The *only* semi-hack is the direct access of gdifont struct from > inside winedib.... > it could also be avoided, but with much useless code added. > Useless because it will be so once embedded in gdi32. >> >>> Do we even have an architectural document or guidelines to reference? >> >> This was also raised on the existing thread. No. This is a problem. >> The best we have so far is "DIB engine should be integrated into >> GDI32". This is not a problem, because both Max and AJ share this >> goal, but if I understand correctly, Max doesn't want to invest the >> effort (which is a lot) until the current design is validated by >> inclusion into upstream source. > > You got exactly the point :-) > To be precise, the effort isn't so huge, but summed with the effort of > maintaining > all in sync with current tree the global effort would be great (and > dumb, imho). >> >> >> Welcome aboard! I suggest that if you'd like to help out with the DIB >> engine (with the goal of getting it included to Wine upstream source), >> that you take a look at the code on bugzilla page #421 and talk to >> Massimo about how you might adapt it for integration into GDI32. >> > There's not too much to adapt.... moving the engine inside gdi32 is > (IMHO) > not complicated at all. More a writing effort than a coding one. > But, *before*, I guess winex11.drv (and any possible driver that does > DIBs internally) > should be patched stripping DIB handling *and* adding some stuffs for > mixed transfers. > Again, not an huge work, for somebody that knows well drivers internals. > It could also be done later, if wished... but logically that would be > the first step. > > Ciao > > Max > > Ok Max then document what you think the effort would be and what is needed to migrate your DIB engine into GDI32 Then We could send it to AJ for approval and go from there. This would be documenting the Delta which should allow AJ to go line item by line item and say yes or no to each or what needs to do. How long would that take you to do Max? Once that is done we would have a defined plan etc and going forward it would be documented. Chris

May 30, 2009

Re: Wineconf 2009 and funding

by Steven Edwards

On Sat, May 30, 2009 at 11:30 AM, Austin English <austinenglish(a)gmail.com> wrote: > Like Steven/Roderick said, we can increase that quite a bit if we > start fundraising early (now). I and Aleksey Bragin will be attending to represent ReactOS. I've asked their developers, users and advocates to contribute a little change to both projects donation links. I think this is a good chance for those of us with relationships to other projects that directly affect or benefit from Wine to contribute something back. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

May 30, 2009