June 2009 - Wine-Devel - list.winehq.org

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)

by Henri Verbeet

2009/6/30 Stefan Dösinger <stefandoesinger(a)gmx.at>: > Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: > > Is there a particular reason why you reordered many elements in struct > arb_ps_np2fixup_info? > > > I'd guess for alignment.

June 30, 2009

Re: [3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)

by Stefan Dösinger

Am Monday 29 June 2009 21:41:58 schrieb Tobias Jakobi: + const UINT max_lconsts = gl_info->ps_arb_max_local_constants; Please use the GL_LIMITS macro for consistency

June 30, 2009

Re: [4/7] [wined3d] add NP2 fixup code to shader_hw_sample (ARB) (resend)

by Stefan Dösinger

Am Monday 29 June 2009 21:42:20 schrieb Tobias Jakobi: > + if (flags) FIXME("Only ordinary sampling from NP2 textures is supported.\n"); Why does projected sampling not work? Is this a limit of Tex_rect or the NP2 fixup code? TXB certainly does not work because tex_rect doesn't support mipmapping Its fine with me if projected texturing is just not implemented in this patchset currently, I'm just curious. If it is not a GL limit it should just work with the code you wrote, unless I am missing something.

June 30, 2009

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)

by Stefan Dösinger

Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: Is there a particular reason why you reordered many elements in struct arb_ps_np2fixup_info?

June 30, 2009

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree

by Michael Stefaniuc

Austin English wrote: > On Mon, Jun 29, 2009 at 10:37 PM, Detlef Riekenberg<wine.dev(a)web.de> wrote: >> On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: >>> With this patch, they are treated like other programs, e.g., winhlp32, >>> and installed, so one can use: >>> $ wine view >>> and get the same effect. >> That parts of configure.ac are created by tools/make_makefiles >> >> tools/make_makefiles-50-# Programs that we don't want to install at all >> tools/make_makefiles-51-my %dont_install = >> tools/make_makefiles-52-( >> tools/make_makefiles:53: "cmdlgtst" => 1, >> tools/make_makefiles-54- "view" => 1, >> tools/make_makefiles-55- "winetest" => 1, >> tools/make_makefiles-56-); > > Good to know, thanks. But AJ told me on IRC he won't accept it, since > he doesn't think those binaries should be used outside of the tree. Right, those aren't needed by users. I really wonder what purpose cmdlgtest serves this days and if it shouldn't be just removed. bye michael

June 30, 2009

Re: oleaut32: Build language resource files separately

by Michael Stefaniuc

Alexandre Julliard wrote: > Michael Stefaniuc <mstefani(a)redhat.com> writes: > >> Well, Alexandre did the first patch for programs/clock >> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… >> so it must be right ;). It increases the resilience as errors in one >> language rc file do not propagate to the other languages. There might be >> some other reason but I forgot. Alexandre asked me if I could do it as >> it is an easy search and replace style janitorial job. > > Another reason is that it makes it possible to update the makefile > automatically when a resource file is added. > > BTW 8-bit chars are mangled in most of your patches... I really *HATE* mutt's handling of 8bit emails. It always detects the character set wrong aka as UTF-8 and git checks that the file really is UTF-8. I'm resending the affected files. thanks bye michael

June 30, 2009

Re: oleaut32: Build language resource files separately

by Michael Stefaniuc

Paul Vriens wrote: > Michael Stefaniuc wrote: >> Hello Nikolay, >> >> Nikolay Sivov wrote: >>> Michael Stefaniuc wrote: >>>> instead of including them from an other rc file. >>>> --- >>>> >>> What is the purpose of these changes? I'm not talking it's wring :), >>> just interested. >> Well, Alexandre did the first patch for programs/clock >> http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… >> >> so it must be right ;). It increases the resilience as errors in one >> language rc file do not propagate to the other languages. There might be >> some other reason but I forgot. Alexandre asked me if I could do it as >> it is an easy search and replace style janitorial job. >> >> > Well the next steps could be: > > - unify the names of the resource files <dll>_<countrycode>.rc I hate those names. <countrycode>.rc is so much easier to find and access. > - have make_makefiles do the real work so we don't have to change the > makefile manually. > > (not sure if that first step is needed or if we could just check for all > .rc files). Well, we had at one point in time commented out included of language rc files. If a big change invalidates a rc file (doesn't build anymore) it is easy to workaround by temporary removing the culprit rc file from the Makefile.in. If instead all rc files are build and linked automatically one would have to git rm the broken rc files. bye michael

June 30, 2009

Re: oleaut32: Build language resource files separately

by Alexandre Julliard

Michael Stefaniuc <mstefani(a)redhat.com> writes: > Well, Alexandre did the first patch for programs/clock > http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… > so it must be right ;). It increases the resilience as errors in one > language rc file do not propagate to the other languages. There might be > some other reason but I forgot. Alexandre asked me if I could do it as > it is an easy search and replace style janitorial job. Another reason is that it makes it possible to update the makefile automatically when a resource file is added. BTW 8-bit chars are mangled in most of your patches... -- Alexandre Julliard julliard(a)winehq.org

June 30, 2009

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.

by Huw Davies

On Tue, Jun 30, 2009 at 12:40:54PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/metafile.c | 80 +++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 80 insertions(+), 0 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> > Hi Huw, > > Could you use CreateEnhMetaFileA here: > > + SetRect(&rc, 1000,2000, 3000, 6000); > + emf_dc = CreateEnhMetaFileW(display_dc, NULL, &rc, NULL); > > The W-version is not implemented on Win9x so this test would crash. Hi Paul, Yup, resent. Thanks! Huw.

June 30, 2009

Re: oleaut32: Build language resource files separately

by Paul Vriens

Michael Stefaniuc wrote: > Hello Nikolay, > > Nikolay Sivov wrote: >> Michael Stefaniuc wrote: >>> instead of including them from an other rc file. >>> --- >>> >> What is the purpose of these changes? I'm not talking it's wring :), >> just interested. > Well, Alexandre did the first patch for programs/clock > http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… > so it must be right ;). It increases the resilience as errors in one > language rc file do not propagate to the other languages. There might be > some other reason but I forgot. Alexandre asked me if I could do it as > it is an easy search and replace style janitorial job. > > bye > michael > > Well the next steps could be: - unify the names of the resource files <dll>_<countrycode>.rc - have make_makefiles do the real work so we don't have to change the makefile manually. (not sure if that first step is needed or if we could just check for all .rc files). -- Cheers, Paul.

June 30, 2009