June 2009 - Wine-Devel - list.winehq.org

Re: Fw: Need a temporary list moderator

by John Klehm

On Mon, Jun 1, 2009 at 9:42 AM, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > Am Monday 01 June 2009 16:13:43 schrieb Luke Bratch: >> --- On Thu, 28/5/09, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: >> > In a couple of weeks I'm going to be travelling around >> > India for about a month, from 14th June - 17th July, so I'll >> > need somebody to cover list moderation during that period. >> > >> > It's a simple task; you just need to bring up a web page >> > for each list a couple of times per day, and single out any >> > genuine messages that are awaiting approval, discarding the >> > rest. >> > >> > You'll need to do it almost every day for the whole month, >> > otherwise people will start to wonder where their mail is >> > getting to.... :) >> > >> > If you are interested, please email me directly. >> >> No responses so far - anybody? >> >> Luke > > Hi Luke, > > i can do parts of the job but not all. I can't do it before the 16th June, and > i know for sure that i have at least one business trip (two days) during the > rest of the time, but i can't say now when it will be. > I can help out some as well. I will be out in the woods from 6/12 to 6/19 though. --John Klehm

June 1, 2009

gdiplus: GdipDrawString

by Stephan Rose

Ok was playing a bit with DrawString on sunday trying to get string alignments to work. I've got horizontal alignments working by simply setting drawcoord.right which currently is left uninitialized and then passing DT_CENTER and DT_RIGHT as needed to DrawTextW. So far, that worked. However, I can't do that for vertical alignments because the code manually does the line breaking and therefore draws each line individually. So my question is, why? Why aren't we letting DrawTextW do the line breaking and just letting it draw with the appropriate rect? Is the linebreaking different? Or does DrawTextW not have the proper support for rotations? As it stands right now, if necessary, I can easily enough calculate the offsets myself for doing horizontal alignments instead of using DT_CENTER and DT_RIGHT. But for vertical, this is a bit problematic. I don't know how many lines of text there are going to be until the text has already been drawn. Kind of a prerequisite for vertical alignment however. That means that if I just want to brute force it, I'd have to duplicate the drawing loop and once only have it measure the string / count lines. That then allows me to calculate the proper offset and I could then just rerun the thing again with the new position and it'd work. A bit more better solution would be to store the line break info in a small array (indices into the string should do that tell me where each line ends) to simply the drawing loop. That would require a dynamic array though which brings me to another question, what should I use? is stuff like std::vector ok or should I use something else? If of course there's a way we can just have DrawTextW handle the line breaking, I don't even need to care about any of the above. Can then just calculate the proper bounding rect and hand all the issues off to DrawTextW. Thoughts? Thanks, Stephan

June 1, 2009

Re: Regular users right on bugzilla

by Austin English

On Mon, Jun 1, 2009 at 3:22 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Since there's been some discussion about bugzilla recently... > > Is there any reason regular users aren't allowed to change keywords, > component and dependencies on bugs they don't own on Bugzilla? > Maybe marking as duplicate as well. I don't think it'd do any harm to > allow those rights to every registered user. Please don't do this. -- -Austin

June 1, 2009

Re: Fw: Need a temporary list moderator

by Austin English

On Mon, Jun 1, 2009 at 9:13 AM, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: > > --- On Thu, 28/5/09, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: >> In a couple of weeks I'm going to be travelling around >> India for about a month, from 14th June - 17th July, so I'll >> need somebody to cover list moderation during that period. >> >> It's a simple task; you just need to bring up a web page >> for each list a couple of times per day, and single out any >> genuine messages that are awaiting approval, discarding the >> rest. >> >> You'll need to do it almost every day for the whole month, >> otherwise people will start to wonder where their mail is >> getting to.... :) >> >> If you are interested, please email me directly. > > No responses so far - anybody? > > Luke > > > > I can do it. -- -Austin

June 1, 2009

Re: Fw: Need a temporary list moderator

by Stefan Leichter

Am Monday 01 June 2009 16:13:43 schrieb Luke Bratch: > --- On Thu, 28/5/09, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: > > In a couple of weeks I'm going to be travelling around > > India for about a month, from 14th June - 17th July, so I'll > > need somebody to cover list moderation during that period. > > > > It's a simple task; you just need to bring up a web page > > for each list a couple of times per day, and single out any > > genuine messages that are awaiting approval, discarding the > > rest. > > > > You'll need to do it almost every day for the whole month, > > otherwise people will start to wonder where their mail is > > getting to.... :) > > > > If you are interested, please email me directly. > > No responses so far - anybody? > > Luke Hi Luke, i can do parts of the job but not all. I can't do it before the 16th June, and i know for sure that i have at least one business trip (two days) during the rest of the time, but i can't say now when it will be. Stefan

June 1, 2009

Fw: Need a temporary list moderator

by Luke Bratch

--- On Thu, 28/5/09, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: > In a couple of weeks I'm going to be travelling around > India for about a month, from 14th June - 17th July, so I'll > need somebody to cover list moderation during that period. > > It's a simple task; you just need to bring up a web page > for each list a couple of times per day, and single out any > genuine messages that are awaiting approval, discarding the > rest. > > You'll need to do it almost every day for the whole month, > otherwise people will start to wonder where their mail is > getting to.... :) > > If you are interested, please email me directly. No responses so far - anybody? Luke

June 1, 2009

Re: Regular users right on bugzilla

by Rosanne DiMesio

On Mon, 01 Jun 2009 12:03:21 +0100 Ken Sharp <kennybobs(a)o2.co.uk> wrote: > > > Most developers already have that access, and if they don't, they can > just ask for it. > > I think the reason all users can't do it, is because most users don't > know what they're doing. It's bad enough correcting all the mistakes > they make now, the last thing we need is every user doing whatever they > like whenever they like. Ask the poor triage guys who have to change > nearly every bug. > > +1 -- Rosanne DiMesio <dimesio(a)earthlink.net>

June 1, 2009

Re: Regular users right on bugzilla

by Ken Sharp

Top posting is the devil. Jerome Leclanche wrote: > Fair enough for duplicates. Still, component and keywords can't do any > harm, can they? > I often see a bug with attached patch, or a regression, not properly > marked as such, and want to fix it but I'm unable to; and it's usually > not worth the extra spam and bothering someone else. > I think you can send an email to wine-bugs asking for this to be changed? Or IRC, or -devel... there are many places to ask. The problem with keywords is people putting "fixme" in just because there's a fixme in the console output. It's rarely related. (Annoyingly, some people do the opposite to me) :P And "patch" doesn't mean there's a patch attached, it means there's been a patch sent and it's waiting for approval (according to the help section in Bugzilla). I foresee many issues with this proposal. It's also annoying getting, "I see this too when I press X and then blah and then this..." when the cause is already found, and when a user can just CC themselves or vote for a bug. The cause, fix or workaround ends up buried under a load of junk.

June 1, 2009

Re: [2/3] kernel32: fix QueryFullProcessImageNameW for output buffer being null

by Alexandre Julliard

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -3155,6 +3155,12 @@ > NTSTATUS status; > DWORD needed; > > + if(!lpExeName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > + This is not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so process.c && touch process.ok process.c:1670: Test failed: Expected GetLastError() to be 122 (ERROR_INSUFFICIENT_BUFFER) is 87 make[2]: *** [process.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

June 1, 2009

Re: Regular users right on bugzilla

by Jerome Leclanche

Fair enough for duplicates. Still, component and keywords can't do any harm, can they? I often see a bug with attached patch, or a regression, not properly marked as such, and want to fix it but I'm unable to; and it's usually not worth the extra spam and bothering someone else. On Mon, Jun 1, 2009 at 2:30 PM, Ben Klein <shacklein(a)gmail.com> wrote: > 2009/6/1 Ken Sharp <kennybobs(a)o2.co.uk>: >> >> >> André Hentschel wrote: >>> >>> Jerome Leclanche schrieb: >>>> >>>> Since there's been some discussion about bugzilla recently... >>>> >>>> Is there any reason regular users aren't allowed to change keywords, >>>> component and dependencies on bugs they don't own on Bugzilla? >>>> Maybe marking as duplicate as well. I don't think it'd do any harm to >>>> allow those rights to every registered user. >>>> >>>> Cheers >>>> >>>> Jerome >>>> >>> Maybe not to all users, there are always spammers, etc. >>> But the idea is great, maybe we can give these rights just to the >>> developers(everyone, who sent more than X patches). >>> That makes more sense for me. >>> Technical that means, every developer sends a mail somewhere with a >>> keyword "bugzilla-mod" or something and the e-mail-adresses are compared >>> with the registrations of wine-dev and wine-patches or with the commits in >>> git. >>> >>> >>> >> >> Most developers already have that access, and if they don't, they can just >> ask for it. >> >> I think the reason all users can't do it, is because most users don't know >> what they're doing. It's bad enough correcting all the mistakes they make >> now, the last thing we need is every user doing whatever they like whenever >> they like. Ask the poor triage guys who have to change nearly every bug. > > You beat me to it. Devs can ask for bugzilla "admin" rights by asking > an appropriate admin or asking on -devel (I saw one just recently). I > also agree with not giving extra control to all registered users (btw, > I'm just a regular user on bugzilla; I've had to request bugs be > marked DUP rather than set it myself :) ). It's bad enough they can > change the status of their own bugs from INVALID to UNCONFIRMED (which > I have seen all too often). > > "This is not a bug in Wine. Talk to <insert project here>. Closing invalid." > "No, this IS a bug in Wine because Windows behaves differently! Reopening." > > > -- J. Leclanche / Adys

June 1, 2009