July 2009 - Wine-Devel - list.winehq.org

Re: gdi32: Ensure child fonts have names

by Dmitry Timoshkov

"Aric Stewart" <aric(a)codeweavers.com> wrote: > load_child_font calls neither WineEngCreateFontInstance nor GetEnumStructs. > > It allocates the the child font structure above in the function sets the > few fields it thinks it needs and then goes on. I see no evidence that > it is being expected to have been set at any other point. Then child->font->name should be initialized explicitly, 'if ()' check is redundant. Setting it to child->font->font_desc.lf.lfFaceName looks also incorrect, other places set it to face->family->FamilyName. -- Dmitry.

July 31, 2009

Re: gdi32: Ensure child fonts have names

by Aric Stewart

load_child_font calls neither WineEngCreateFontInstance nor GetEnumStructs. It allocates the the child font structure above in the function sets the few fields it thinks it needs and then goes on. I see no evidence that it is being expected to have been set at any other point. -aric Dmitry Timoshkov wrote: > "Aric Stewart" <aric(a)codeweavers.com> wrote: > >> @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, >> CHILD_FONT *child) >> child->font->scale_y = font->scale_y; >> hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); >> hfontlist->hfont = CreateFontIndirectW(&font->font_desc.lf); >> + /* ensure the child font has a name */ >> + if (!child->font->name) >> + child->font->name = >> strdupW(child->font->font_desc.lf.lfFaceName); > > It doesn't look like an appropriate place for this. Font name is > initialized > explicitly in both WineEngCreateFontInstance() and GetEnumStructs(). How it > could be possible that it's NULL in the above case? >

July 31, 2009

Re: gdi32: Ensure child fonts have names

by Dmitry Timoshkov

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, CHILD_FONT *child) > child->font->scale_y = font->scale_y; > hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); > hfontlist->hfont = CreateFontIndirectW(&font->font_desc.lf); > + /* ensure the child font has a name */ > + if (!child->font->name) > + child->font->name = strdupW(child->font->font_desc.lf.lfFaceName); It doesn't look like an appropriate place for this. Font name is initialized explicitly in both WineEngCreateFontInstance() and GetEnumStructs(). How it could be possible that it's NULL in the above case? -- Dmitry.

July 31, 2009

Re: RFC XRender add support for dibsections in more color depths

by Roderick Colenbrander

On Fri, Jul 31, 2009 at 9:25 AM, Austin English<austinenglish(a)gmail.com> wrote: > On Thu, Jul 23, 2009 at 3:51 PM, Roderick > Colenbrander<thunderbird2k(a)gmail.com> wrote: >> Hi, >> >> For some weeks I have been working on moving more 2D rendering to >> XRender. XRender has three advantages for Wine. First of all it allows >> us to perform more rendering operations using X which we previously >> did using a combination of software rendering and back-forth copying >> between the Xserver. Second XRender offers depth conversion (this >> gives us proper alpha support in Wine and allows us to bypass DIB >> color conversion in some cases!). Third XRender brings us more >> hardware acceleration and that way more performance. >> >> The patch attached to this thread adds support for dibsections in >> additional color depths. On Xservers running at 24-bit this patch >> offers us dibsections in 1-bit/15-bit/16-bit/24-bit/32-bit. (32-bit is >> for proper alpha support) Big parts of the Wine X11 Driver make >> assumptions about having only two color depths around (1-bit and >> screen_depth e.g. 24-bit). I would like to request that people apply >> the current patch to latest git (in combination with the Office2007 >> patch which I posted to wine-patches). Please report any 2D rendering >> issues you see and also mention possible Wine crashes due to X errors >> like BadMatch. Try as much programs as possible. >> >> Thanks in advance, >> Roderick Colenbrander >> >> >> >> > > Still fails the gimp test in appinstall. It's just this patch on top > of git, nothing else right? > > -- > -Austin > Yeah it is just this patch on top of git. At what point does gimp fail for you? I tried to open some images including the png gimp splash screen and I'm seeing no issues. To be certain that you are using the right patch I have reattached it (this time with the white space trailing issues fixed). Just to be sure what display drivers are you using and what videocard? Roderick

July 31, 2009

Re: RFC XRender add support for dibsections in more color depths

by Austin English

On Thu, Jul 23, 2009 at 3:51 PM, Roderick Colenbrander<thunderbird2k(a)gmail.com> wrote: > Hi, > > For some weeks I have been working on moving more 2D rendering to > XRender. XRender has three advantages for Wine. First of all it allows > us to perform more rendering operations using X which we previously > did using a combination of software rendering and back-forth copying > between the Xserver. Second XRender offers depth conversion (this > gives us proper alpha support in Wine and allows us to bypass DIB > color conversion in some cases!). Third XRender brings us more > hardware acceleration and that way more performance. > > The patch attached to this thread adds support for dibsections in > additional color depths. On Xservers running at 24-bit this patch > offers us dibsections in 1-bit/15-bit/16-bit/24-bit/32-bit. (32-bit is > for proper alpha support) Big parts of the Wine X11 Driver make > assumptions about having only two color depths around (1-bit and > screen_depth e.g. 24-bit). I would like to request that people apply > the current patch to latest git (in combination with the Office2007 > patch which I posted to wine-patches). Please report any 2D rendering > issues you see and also mention possible Wine crashes due to X errors > like BadMatch. Try as much programs as possible. > > Thanks in advance, > Roderick Colenbrander > > > > Still fails the gimp test in appinstall. It's just this patch on top of git, nothing else right? -- -Austin

July 31, 2009

Re: RFC XRender add support for dibsections in more color depths

by Austin English

On Wed, Jul 29, 2009 at 3:18 PM, Roderick Colenbrander<thunderbird2k(a)gmail.com> wrote: > Hi Reece, > > The only thing required is a git version of Wine and XRender libraries > on your system. After that any app can be tested. On decent drivers > like Nvidia you'll notice heavily improved 2D performance (e.g. useful > for theming). When using a Geforce6/7 try to set 'nvidia-setings -a > InitialPixmapPlacement=2' which makes sure all pixmaps are placed in > video memory. Still fails the gimp test in appinstall. Everything else passes. It's just this patch on top of git, right? No other patches? -- -Austin

July 31, 2009

Re: Wine to be used as botnet testbed

by David Gerard

2009/7/29 Maik Schulz <ladenlokalvelbert(a)gmail.com>: > More in the linked New York Times article, Sandia National Labs plans to > have a Dell super computer run 1 million Linux instances using Wine to host > and study a botnet: > http://www.nytimes.com/2009/07/28/science/28comp.html?_r=1 > Does someone on the list have more detailed information on or is even > involved with it? How about we post about this on winehq.org as well? Would > be a departure from posing only about new releases and WWN issues, but it > could make winehq.org more interesting for users... I'd volunteer... Now we wait till malware starts detecting Wine, and we can file bugs saying that the malware is not sufficiently suported in Wine because it behaves differently to how it does Windows ;-p - d.

July 30, 2009

Re: winecfg: Add toggle for systray visibility

by Roderick Colenbrander

Hi Andrew, Good that you have removed the unneeded changes. I'm wondering where the support in winex11.drv is for the winecfg option you added. My git version doesn't have it and I can't remember seeing patches for it (though I might have missed them). If these patches indeed have not been submitted, I would urge you to submit those first. Regards, Roderick On Wed, Jul 29, 2009 at 8:20 PM, Andrew Eikum<aeikum(a)codeweavers.com> wrote: > --- > programs/winecfg/En.rc | 2 ++ > programs/winecfg/resource.h | 1 + > programs/winecfg/theme.c | 19 +++++++++++++++++++ > 3 files changed, 22 insertions(+), 0 deletions(-) > > > > > >

July 30, 2009

Re: [6/6] hnetcfg: Register interfaces.

by Nikolay Sivov

Austin English wrote: > On Thu, Jul 30, 2009 at 10:36 AM, Hans Leidekker<hans(a)codeweavers.com> wrote: > >> On Thursday 30 July 2009 05:17:07 pm you wrote: >> >> >>> What is this series for, if you don't mind my asking? >>> >>> The iTunes installer/other applications looking for the XP firewall? >>> >> Yes, this brings the iTunes installer to the next bug ;-) >> > > Great work! Which bug is that? > This one probably http://bugs.winehq.org/show_bug.cgi?id=15533

July 30, 2009

Re: New Wine Gecko 1.0.0 RC

by Jacek Caban

Hi André, André Hentschel wrote: > Works great as fire as i tested it. Great, thanks for testing. > Nice to see HTML5 in wines iexplore, really great and crazy! So we can > call next release of Wine HTML5-ready :) I'd file a bug report: "Wine treats HTML5 differently than IE" :) Jacek

July 30, 2009