August 2009 - Wine-Devel - list.winehq.org

Re: oleaut32: use WIC to decode JPEG images

by Vincent Povirk

Of course it would probably help if I remembered to attach the patch. On Mon, Aug 31, 2009 at 5:08 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > This needs an updated prefix to work. > > > > -- Vincent Povirk

Aug. 31, 2009

Re: What's wrong with my patch?

by Juan Lang

> I saw that AJ committed patches sent before and after my email, so I > assumed he goes through them in order. It also depends on whether your patch is obviously correct, and your "Julliard rank." Since you're new around here, it's likely your patch will be subject to more scrutiny. Plus Andrew pointed out that your email address was invalid in the patch, which means automatic rejection. Fix what Andrew says, wait at least a day, and ask for feedback if you don't get any response after that. Good luck, --Juan

Aug. 31, 2009

Re: What's wrong with my patch?

by Jan de Mooij

On Mon, Aug 31, 2009 at 6:25 PM, Juan Lang<juan.lang(a)gmail.com> wrote: > Well, you haven't waited nearly long enough. Sending it in today and > expecting it to be committed the same day is a bit much. I saw that AJ committed patches sent before and after my email, so I assumed he goes through them in order. Sorry about that. Thanks, Jan

Aug. 31, 2009

Re: What's wrong with my patch?

by Andrew Eikum

Jan de Mooij wrote: > Hello. > > Subject says it all. I suppose the tests I added may fail on other > locales, but there is no other way to test my patch? > Should i send it without the tests? > > Thanks in advance. > > Jan I can't speak much to the patch itself, but the patch file you attached has an invalid email address. You should set user.name and user.email in .git/config. See `man git-config` for more info. Also, #defining the ID for the apply button without #undefing it seems wrong. I'd use a const INT in the test_buttons method so the scope is taken care of automatically. Andrew

Aug. 31, 2009

Re: What's wrong with my patch?

by Juan Lang

Hi Jan, > Subject says it all. Well, you haven't waited nearly long enough. Sending it in today and expecting it to be committed the same day is a bit much. --Juan

Aug. 31, 2009

What's wrong with my patch?

by Jan de Mooij

Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan ---------- Forwarded message ---------- From: Jan de Mooij <jandemooij(a)gmail.com> Date: Mon, Aug 31, 2009 at 2:24 PM Subject: comctl32/propsheet: update position of hidden buttons too To: wine-patches(a)winehq.org eMule iterates all buttons to find the left-most button, and then uses the x and y position for its own buttons. This currently fails in Wine because we don't update the position of the hidden buttons. Tests pass on Vista and Wine (2 failures without this change) Fixes bug 11345 - http://bugs.winehq.org/show_bug.cgi?id=11345

Aug. 31, 2009

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

by David Laight

On Mon, Aug 31, 2009 at 12:03:11PM +0200, Alexandre Julliard wrote: > Eric Pouech <eric.pouech(a)orange.fr> writes: > > > @@ -250,3 +250,25 @@ int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, > > #endif > > return 0; > > } > > + > > +/****************************************************************** > > + * strtol (MSVCRT.@) > > + */ > > +long int MSVCRT_strtol(const char* nptr, char** end, int base) > > +{ > > + /* wrapper to forward libc error code to msvcrt's error codes */ > > + long ret = strtol(nptr, end, base); > > + msvcrt_set_unix_errno(); > > + return ret; > > +} > > You can't simply use long here, you need to handle the difference in the > size of long between Win32 and Unix. You also need to an 'errno = 0' before the strtol() call. strtol() will only change errno if there is a numeric overflow. In the overflow cases the return value will be LONG_MIN or LONG_MAX and errno is set to ERANGE. No other errno values should appear. I thought that the only 'size' difference is that 64bit windows has a 32bit long ? So values outside 32bits need truncating and ERANGE set ?? David -- David Laight: david(a)l8s.co.uk

Aug. 31, 2009

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

by Alexandre Julliard

Eric Pouech <eric.pouech(a)orange.fr> writes: >> >> You can't simply use long here, you need to handle the difference in the >> size of long between Win32 and Unix. >> > but that's what we currently do ! > A+ Sure, but that needs to be fixed. Since you are reimplementing it you should do it right. -- Alexandre Julliard julliard(a)winehq.org

Aug. 31, 2009

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

by Eric Pouech

> > You can't simply use long here, you need to handle the difference in the > size of long between Win32 and Unix. > > but that's what we currently do ! A+ -- Eric Pouech

Aug. 31, 2009

Re: [4/7] [try 2] mapi32: Load and store MAPI function pointers after loading MAPI providers

by Henri Verbeet

2009/8/31 Owen Rudge <orudge(a)codeweavers.com>: > + mapiFunctions.MAPIAddress = (void*) get_mapi_function("MAPIAddress"); That's redundant now. Since you load the pointers all at once, you don't need get_mapi_function() to do the NULL check on the module. You can just enclose the entire block in an if and use GetProcAddress().

Aug. 31, 2009