September 2009 - Wine-Devel

Compile error on current Git

by Paul Vriens

Hi, Anyone else seeing this: make[2]: Entering directory `/wine/wine-git/dlls/system.drv16' ccache gcc -m32 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Wcast-qual -Wlogical-op -o system.o system.c ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./system.drv16.spec system.o -Wb,--subsystem,win16 -o system.drv16.so -lkernel32 ../../libs/port/libwine_port.a system.o: In function `call_timer_proc16': system.c:(.text+0x54a): undefined reference to `NtCurrentTeb' collect2: ld returned 1 exit status winegcc: ccache failed make[2]: *** [system.drv16.so] Error 2 make[2]: Leaving directory `/wine/wine-git/dlls/system.drv16' make[1]: *** [system.drv16] Error 2 (Fedora 11, gcc 4.4.1) -- Cheers, Paul.

Sept. 30, 2009

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

by Paul Vriens

On 09/30/2009 09:41 AM, Mike Kaplinskiy wrote: > On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens<paul.vriens.wine(a)gmail.com> wrote: >> On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: >>> >>> --- >>> dlls/ws2_32/tests/sock.c | 46 >>> +++++++++++++++++++++++++++++++++++++--------- >>> 1 files changed, 37 insertions(+), 9 deletions(-) >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >> Hi Mike, >> >> This one has introduced a test failure on Win98 and WinMe. >> >> Could you have a look? Let me know if you want me to run extra tests on >> these boxes. >> >> -- >> Cheers, >> >> Paul. >> > > Paul, > > I'm tempted to say that's a bug in 98/ME - seems like an accepted > socket is holding a reference to the listener that accepted it. Could > you test the patch? It just closes the accepted sockets before doing > the next test. No difference, still fails at the same place. > > I think regardless though, we should mark it as broken on 95/ME. I'll > send a patch in the next few days. Thanks, Paul.

Sept. 30, 2009

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

by Mike Kaplinskiy

On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: >> >> --- >> dlls/ws2_32/tests/sock.c | 46 >> +++++++++++++++++++++++++++++++++++++--------- >> 1 files changed, 37 insertions(+), 9 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> > Hi Mike, > > This one has introduced a test failure on Win98 and WinMe. > > Could you have a look? Let me know if you want me to run extra tests on > these boxes. > > -- > Cheers, > > Paul. > Paul, I'm tempted to say that's a bug in 98/ME - seems like an accepted socket is holding a reference to the listener that accepted it. Could you test the patch? It just closes the accepted sockets before doing the next test. I think regardless though, we should mark it as broken on 95/ME. I'll send a patch in the next few days. Mike.

Sept. 30, 2009

Re: [PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

by Paul Vriens

On 09/29/2009 12:36 PM, Nikolay Sivov wrote: > Changelog: > - be sure we have a single view calendar for hittesting > > > ------------------------------------------------------------------------ > > Hi Nikolay, This one introduces a test failure on several platforms: monthcal.c:1002: Test failed: Expected 10000, got 10002 I fixed it on my NT4 box by checking the point more to the left (see attached). I somehow doubt it's the correct fix though. Aren't these tests with more-or-less fixed points error-prone (aka, locale/font/dpi dependent)? -- Cheers, Paul.

Sept. 30, 2009

Re: firefox build success on visual c++ 2005 on wine!

by Dan Kegel

On Thu, Sep 24, 2009 at 9:46 PM, Dan Kegel <dank(a)kegel.com> wrote: > Now that AJ fixed http://bugs.winehq.org/show_bug.cgi?id=19783, > the firefox build procedure runs all the way through > to the end (at least in release mode; debug builds still fail). And the resulting firefox works in wine, too! I'm using it to post this message in gmail. It does hang on exit, and it does seem to output these two lines entirely too often: fixme:file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented fixme:advapi:SetNamedSecurityInfoW L"C:\\users\\dank\\Application Data\\Mozilla\\Firefox\\Profiles\\v80k2mcj.default\\sessionstore.js" 1 536870916 (nil) (nil) 0x17569c (nil) and it renders < as [unicode char 003C], but other than that it seems fine. Even plays youtube ok. - Dan

Sept. 30, 2009

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

by Paul Vriens

On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: > --- > dlls/ws2_32/tests/sock.c | 46 +++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 37 insertions(+), 9 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Mike, This one has introduced a test failure on Win98 and WinMe. Could you have a look? Let me know if you want me to run extra tests on these boxes. -- Cheers, Paul.

Sept. 30, 2009

Re: ddraw: set dwBackBufferCount=0 in CreateSurface for backbuffer

by Stefan Dösinger

Am 29.09.2009 um 15:09 schrieb Markus Stockhausen: > Sorry for the incomplete topic of my first mail. > > <patch.diff> The patch looks ok to me

Sept. 29, 2009

Re: wininet(1/3): Only initialize SSL_CTX once

by Juan Lang

Hi Hans, > The bug reporter sees long delays between torrents starting up after > applying these patches, which makes we wonder if the ssl lock effectively > serializes secure https requests? There isn't a single SSL lock. There's an interlocked exchange for assigning SSL_CTX, which should only be created once except in a race between threads. There's a critical section to protect against two threads initializing the SSL library at the same time. Finally, there are a number of SSL locks (CRYPTO_num_locks() many, specifically) that OpenSSL uses. When I was debugging it, there are at least 16 of them. So I don't think serialization of locks is the root cause of the slowdown. > Would patch 1 and 3 not be sufficient to fix the utorrent crash? I don't think so. Other apps have had similar crashes with the equivalent of patch 2 not applied, and the OpenSSL man page warns of random crashes due to failing to implement and set these callbacks. --Juan

Sept. 29, 2009

Re: set caps.dwBackBufferCount=0 for backbuffer surface

by Paul Vriens

On 09/29/2009 03:33 PM, Markus Stockhausen wrote: > Am Dienstag, den 29.09.2009, 15:10 +0200 schrieb Paul Vriens: >> On 09/29/2009 03:01 PM, Markus Stockhausen wrote: >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >> Hi Markus, >> >> Please stick to the coding style of the file, or at least the >> surrounding code (implementation and test). >> > > Hi Paul, > > what do You think of (I'm a little bit confused)? > > Thanks > > Markus > Things like: + desc2.dwBackBufferCount=0; (spaces before and after the equal sign) + hr = IDirectDrawSurface7_GetSurfaceDesc(surface2,&ddsd2); (space after the comma) -- Cheers, Paul.

Sept. 29, 2009

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)

by Ilya Shpigor

On Monday 28 September 2009 19:36:05 you wrote: > Could you please add a test for that? Test for this patch has been sent: comctl32/tests: Add test for setting the tooltips position by parent -- Best regards, Ilya Shpigor.

Sept. 29, 2009