September 2009 - Wine-Devel

programs: add extrac32 tool

by Kirill K. Smirnov

Hi, +int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ extrac32 is a console application, isn't it? Why not wmain() instead? And get rid of rather complex ParseCmdLine(). + if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK) ExtCabCallback, 0 )) + WINE_FIXME( "Can not extract cab file:%s!!!\n", wine_dbgstr_w( pszCabFile ) ); This is an error, not a FIXME + if(!argv) + { + WINE_FIXME("Error!Can not get cmd line\n" ); + return 0; + } not a FIXME + if (argc < 2) + { + WINE_FIXME( "No options\n" ); + return 1; + } not a FIXME + if (fArgc != 1) + WINE_FIXME( "Invalid usage for /C flag - two filenames expected\n" ); not a FIXME -- Kirill

Sept. 29, 2009

Re: [TRY 4] user32/tests: Add tests for STM_SETIMAGE and STM_SETICONmessage processing

by Dmitry Timoshkov

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)hbm); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ICON, (LPARAM)hicon); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETICON, (WPARAM)hicon, 0); > + todo_wine ok_sequence(WmSetIconErrStaticSeq, "STM_SETICON on a static", FALSE); > + > + flush_sequence(); > + SendMessageW(hwnd, STM_SETIMAGE, (WPARAM)IMAGE_ENHMETAFILE, (LPARAM)hemf); > + todo_wine ok_sequence(WmSetImageErrStaticSeq, "STM_SETIMAGE on a static", FALSE); You should use SendMessageA instead of SendMessageW to make the test run under Win9x as well. Testing the return value of SendMessage would be also helpful. -- Dmitry.

Sept. 29, 2009

Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().

by Rico Schüller

Am 28.09.2009 15:08, schrieb Henri Verbeet: >> static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index) >> { >> - FIXME("iface %p, index %u stub!\n", iface, index); >> + struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface; >> >> - return NULL; >> + TRACE("iface %p, index %u\n", iface, index); >> + >> + if(index>= This->member_count) return NULL; >> + >> + return This->members[index].name; >> } >> > You can't do this yet, it needs to work for types created by > parse_fx10_type() as well. The same goes for patches 7-11. Patches 1-5 > look ok to me, and can stand on their own. > > > > I'll improve the whole patch set. Cheers Rico

Sept. 28, 2009

Review Request: Patch to selectively bind to interfaces while still allowing broadcast packets

by Erich Hoover

Attached is a patch I have been working to fix Bug #7929 (C&C 3 network does not work). This patch replaces interface-specific bind requests (on UDP datagrams only) with a global bind and stores the interface index. The patch then uses IP_PKTINFO to set the outgoing interface and filter incoming packets based on interface (checking against the stored interface index from the initial bind). Additionally, the patch peeks at packets in "select" and asynchronous I/O operations to ensure that spurious wakeups do not occur when a packet comes in from the wrong interface. I intend to split the patch into the following pieces: 1) UDP broadcast tests (used for making sure everything works) 2) The "bare essentials" (storing and retrieving the interface index, and setting/filtering the interface) 3) Ensure "select" does not wake up on packets with an interface mismatch 4) Ensure Async WSARecv does not wake up on packets with an interface mismatch 5) Ensure Async ReadFile does not wake up on packets with an interface mismatch I would greatly appreciate any comments people have on this patch. Thanks so much! Erich Hoover ehoover(a)mines.edu

Sept. 28, 2009

Re: [PATCH 3/4] mshtml: Add helper function get_url_components

by Andrew Eikum

Detlef Riekenberg wrote: > On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: >> +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW >> *url) >> +{ >> + const WCHAR *doc_url; > >> + if(!InternetCrackUrlW(doc_url, 0, 0, url)) { >> + FIXME("InternetCrackUrlW failed\n"); > > Such a FIXME does not help to find the reason. > Dumping doc_url helps, but might add personal data to the log > Thanks for the comments. I've resent the patches with most of your corrections added. Andrew

Sept. 28, 2009

Patch for [Bug 14222] RpcBindingSetAuthInfo(Ex) fails with RPC_C_AUTHN_GSS_NEGOTIATE

by Stefan Kuhr

Hello everyone, please find attached a patch for Bug 14222. IIRC I sent a similar patch a year ago or so and never received feedback why it was rejected. Austin encouraged me to send it again, so please if it is unacceptable, let me know why. The patch will make RPC clients work that are written for Windows 2000 (and later), where the negotiate provider performs an automatic fallback to NTLM, if Kerberos is not possible, both in workgroup and domain scenarios. Currently, Wine doesn't have a negotiate and a Kerberos provider. This patch allows clients requesting Negotiate to get the NTLM provider and will still work, even if one day negotiate and Kerberos providers will be added to Wine. Cheers, -- Stefan

Sept. 28, 2009

Re: comctl32/tests: Fix monthcal test on NT4

by Nikolay Sivov

Greg Geldorp wrote: > Hi Nikolay, > > >> Ge van Geldorp wrote: >> >>> Changelog: >>> comctl32/tests: Fix monthcal test on NT4 >>> >> Hi, Ge. >> >> This one interfere with a mine, sent yesterday: >> >> http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html >> >> Could you wait a bit? I hope this could fix some failures. >> > > Sure. I'll resend after your patch is in (if my fix is still needed). > > Ge. > This patch wasn't committed for some reason, I'll try again with it. The main problem with this is that we are creating control of size that leads to display two calendars, and builtin doesn't support this yet. First of all we need to reduce control size to get a single calendar.

Sept. 28, 2009

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)

by Nikolay Sivov

Could you please add a test for that?

Sept. 28, 2009

Re: d3d9: Don't release the parent device before destroying its children

by Allan Tong

On Mon, Sep 28, 2009 at 10:51 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > 2009/9/28 Allan Tong <actong88(a)gmail.com>: >> Note that this patch only changes d3d9. >> > Could you write one for d3d8 as well? Otherwise I'll send one tomorrow. Will do. - Allan

Sept. 28, 2009

Re: d3d9: Don't release the parent device before destroying its children

by Henri Verbeet

2009/9/28 Allan Tong <actong88(a)gmail.com>: > I assume this was done to avoid referencing freed memory, but I'm not > sure if there was any other reason for this. > Not referencing potentially freed memory was the only reason. > Note that this patch only changes d3d9. > Could you write one for d3d8 as well? Otherwise I'll send one tomorrow.

Sept. 28, 2009