September 2009 - Wine-Devel

Re: ole32/tests: fix clipboard tests on Windows

by Alexandre Julliard

"Ge van Geldorp" <ggeldorp(a)vmware.com> writes: > @@ -417,18 +417,23 @@ static HRESULT DataObjectImpl_CreateComplex(LPDATAOBJECT *lplpdataobj) > InitFormatEtc(obj->fmtetc[1], cf_stream, TYMED_ISTREAM); > InitFormatEtc(obj->fmtetc[2], cf_storage, TYMED_ISTORAGE); > InitFormatEtc(obj->fmtetc[3], cf_another, TYMED_ISTORAGE|TYMED_ISTREAM|TYMED_HGLOBAL); > - memset(&dm, 0, sizeof(dm)); > - dm.dmSize = sizeof(dm); > - dm.dmDriverExtra = 0; > - lstrcpyW(dm.dmDeviceName, device_name); > - obj->fmtetc[3].ptd = HeapAlloc(GetProcessHeap(), 0, FIELD_OFFSET(DVTARGETDEVICE, tdData) + sizeof(device_name) + dm.dmSize + dm.dmDriverExtra); > - obj->fmtetc[3].ptd->tdSize = FIELD_OFFSET(DVTARGETDEVICE, tdData) + sizeof(device_name) + dm.dmSize + dm.dmDriverExtra; > - obj->fmtetc[3].ptd->tdDriverNameOffset = FIELD_OFFSET(DVTARGETDEVICE, tdData); > - obj->fmtetc[3].ptd->tdDeviceNameOffset = 0; > - obj->fmtetc[3].ptd->tdPortNameOffset = 0; > - obj->fmtetc[3].ptd->tdExtDevmodeOffset = obj->fmtetc[3].ptd->tdDriverNameOffset + sizeof(device_name); > - lstrcpyW((WCHAR*)obj->fmtetc[3].ptd->tdData, device_name); > - memcpy(obj->fmtetc[3].ptd->tdData + sizeof(device_name), &dm, dm.dmSize + dm.dmDriverExtra); > + if (! broken(TRUE)) /* Windows messes up ptd when doing OleGetClipboard() */ > + { If that case is really unconditionally broken on Windows it doesn't make sense to test it at all. -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2009

Re: [PATCH 12/12] d3d10/tests: Add test_effect_constant_buffer_type test.

by Henri Verbeet

2009/9/28 Rico Schüller <kgbricola(a)web.de>: > + ID3D10Effect* effect; I'd prefer it if that was written as "ID3D10Effect *effect;" > + ok(SUCCEEDED(hr), "ID3D10EffectType::GetDesc failed!\n"); Please print the actual error code as well. > + ok(type_desc.Elements == 0, "Elements is %i, expected 0\n", type_desc.Elements); > + ok(type_desc.Members == 2, "Members is %i, expected 2\n", type_desc.Members); > + ok(type_desc.Rows == 0, "Rows is %i, expected 0\n", type_desc.Rows); > + ok(type_desc.Columns == 0, "Columns is %i, expected 0\n", type_desc.Columns); These are unsigned variables. > + string = type->lpVtbl->GetMemberName(type, 0); > + ok(strcmp(string, "f1") == 0, "GetMemberName(0) is \"%s\", expected \"f1\"\n", string); You should probably use wine_dbgstr_a() for this.

Sept. 28, 2009

Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().

by Henri Verbeet

> static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index) > { > - FIXME("iface %p, index %u stub!\n", iface, index); > + struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface; > > - return NULL; > + TRACE("iface %p, index %u\n", iface, index); > + > + if(index >= This->member_count) return NULL; > + > + return This->members[index].name; > } You can't do this yet, it needs to work for types created by parse_fx10_type() as well. The same goes for patches 7-11. Patches 1-5 look ok to me, and can stand on their own.

Sept. 28, 2009

Re: user32: Add check for the need to redraw static control afterSTM_SETIMAGE and STM_SETICON

by Ilya Shpigor

> First thing to do (as usual) is to add the test to show the drawing > behaviour. Ok. I will make TRY 4 of tests. -- Best regards, Ilya Shpigor.

Sept. 28, 2009

Re: comctl32/tests: Fix monthcal test on NT4

by Greg Geldorp

Hi Nikolay, > Ge van Geldorp wrote: > > Changelog: > > comctl32/tests: Fix monthcal test on NT4 > Hi, Ge. > > This one interfere with a mine, sent yesterday: > > http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html > > Could you wait a bit? I hope this could fix some failures. Sure. I'll resend after your patch is in (if my fix is still needed). Ge.

Sept. 28, 2009

Re: comctl32/tests: Fix monthcal test on NT4

by Nikolay Sivov

Ge van Geldorp wrote: > Ignore MCHT_TITLEBK, title elements might be adjacent without any > background in between. > > Changelog: > comctl32/tests: Fix monthcal test on NT4 > > --- > dlls/comctl32/tests/monthcal.c | 17 +++++++++-------- > 1 files changed, 9 insertions(+), 8 deletions(-) > Hi, Ge. This one interfere with a mine, sent yesterday: http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html Could you wait a bit? I hope this could fix some failures.

Sept. 28, 2009

Re: user32: Add check for the need to redraw static control afterSTM_SETIMAGE and STM_SETICON

by Dmitry Timoshkov

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > Yes, MSDN tells about 0. The -1 value is used for detecting the errors inside > Wine and blocking the static controls redrawing. Then the 0 value is returned > to application: > > - STATIC_TryPaintFcn( hwnd, full_style ); > + if (lResult != -1) > + STATIC_TryPaintFcn( hwnd, full_style ); > + else > + lResult = 0; > > Tests for checking STM_SETIMAGE and STM_SETICON messages processing had been > sent above: > > [TRY 3] user32/tests: Add tests for STM_SETIMAGE and STM_SETICON message > processing > > Is there a better way to block this redrawing? First thing to do (as usual) is to add the test to show the drawing behaviour. -- Dmitry.

Sept. 28, 2009

Re: user32: Add check for the need to redraw static control after STM_SETIMAGE and STM_SETICON

by Ilya Shpigor

On Saturday 26 September 2009 12:09:30 Nikolay Sivov wrote: > --- > + if ((style & SS_TYPEMASK) != SS_ICON) return (HICON)-1; > ... > + if ((style & SS_TYPEMASK) != SS_BITMAP) return (HBITMAP)-1; > ... > + if ((style & SS_TYPEMASK) != SS_ENHMETAFILE) return (HENHMETAFILE)-1; > --- > > Add tests for that please (MSDN tells about 0 return value on error). Yes, MSDN tells about 0. The -1 value is used for detecting the errors inside Wine and blocking the static controls redrawing. Then the 0 value is returned to application: - STATIC_TryPaintFcn( hwnd, full_style ); + if (lResult != -1) + STATIC_TryPaintFcn( hwnd, full_style ); + else + lResult = 0; Tests for checking STM_SETIMAGE and STM_SETICON messages processing had been sent above: [TRY 3] user32/tests: Add tests for STM_SETIMAGE and STM_SETICON message processing Is there a better way to block this redrawing? -- Best regards, Ilya Shpigor.

Sept. 28, 2009

Re: Running 13 months locales

by Mikołaj Zalewski

> If it does support Gregorian only there's nothing to worry about. > Actually I don't know how to test this, if we're talking about some > Asian locales like Chinese or Japanese are you experienced with that? > > A best way will be to test under Linux with native comctl32 but I'm > not sure builtin kernel32 (and maybe something else) is capable to > support such locale features. The last time I checked (something like one year ago), our kernel32 calendar function were hardcoded for Gregorian Calendar. Thus, to check this, you would need native Windows, change the locale to several Asian or Arabic ones (in Regional Settings, this shouldn't change the UI language) and create a monthcal control. If it still displays a Gregorian calendar, then, I think, no implementation is necessary. You could also check if there is no monthcal message to choose the calendar (locales can support multiple calendars. But AFAIR all support also the Gregorian one), but I think I've been checking this once and there wasn't (however, I might have been checking the datetime control instead). Mikołaj

Sept. 27, 2009

RE: newbie question

by Nicklas Börjesson

>Hello All, > >can somebody tell weather it is possible to run NT service on Wine, >especially written in Delphi VCL(TService) Regarding Delphi: TService implements the typical mechanisms of any windows service, it is actually a pretty simple wrapper, since services are pretty simple things. The fact that it is compiled under Delphi should not matter at all. So if services runs under wine, your service should as well. Unless, of course you use some unusual APIs. //Nicklas PS. Another thing for you to consider is using Free Pascal instead of Delphi(or both) and try to make the code reasonably portable so that you can run it as a native daemon under *n*x if you want to. Non-GUI applications are usually comparatively easy to port and maintain. DS.

Sept. 27, 2009