January 2010 - Wine-Devel - list.winehq.org

New valgrind results - with fixes for two kinds of false positives

by Dan Kegel

Julian kindly pointed out that --vex-iropt-precise-memory-exns=yes is needed to avoid false positives in tricky signal handlers like the one involved in GetBitmapBits(). Adding that didn't slow things down much if any, and got rid of lots of valgrind-specific GetBitmapBits() crashes. Also, I applied what seems like an obvious fix for the subheap_notify_free_all false positives (see http://bugs.winehq.org/show_bug.cgi?id=21553 ), and it got rid of them. I've updated http://wiki.winehq.org/Wine_and_Valgrind correspondingly (and made it a bunch clearer, too). Current results at http://kegel.com/wine/valgrind/logs/2010-01-31-09.46/ Current stats: http://kegel.com/wine/valgrind/logs/2010-01-31-09.46.errs.txt 1 Invalid free/ delete / delete[] 2 Source and destination overlap in memcpy 2 Syscall param writev 3 Use of uninitialised value of size 4 6 Invalid write of size 4 7 Invalid read of size 2 12 Invalid write of size 1 22 Invalid read of size 4 48 Conditional jump or move depends on uninitialised value 78 Invalid read of size 1 283 XXX bytes in XXX blocks are definitely lost total: 464 *All* of the "Invalid read of size 1" errors are in the heap tests, so I'll suppress them for the next run. So we're at 386 warnings currently, a bit better than last time I reported figures, http://www.winehq.org/pipermail/wine-devel/2010-January/080989.html

Jan. 31, 2010

Re: [d3d10core/tests] Fix a test failure when no adapters are present

by Henri Verbeet

Paul Vriens wrote: > So is this patch good to go or do we do prefer broken() as I wasn't able > to reproduce? > > Patch is currently marked as 'Pending': > > http://source.winehq.org/patches/data/57834 > The patch would be ok with me. The configuration is suspicious, but the patch itself is correct. Henri

Jan. 31, 2010

Re: [d3d10core/tests] Fix a test failure when no adapters are present

by Paul Vriens

On 01/29/2010 10:54 AM, Paul Vriens wrote: > On 01/28/2010 05:48 PM, Henri Verbeet wrote: >> Paul Vriens wrote: >>> Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 >>> capable adapter (instead of any adapter)? >>> >> Possibly, but my understanding was that on Vista and higher DXGI is >> shared across pretty much the entire graphics subsystem. >> >> Henri > > I did some tests with VMware Workstation 7.0 and Vista Ultimate but > wasn't able to provoke this particular error. I tried with an installed > SDK (to get d3d10ref.dll) and with and without the accelerated option. > > Maybe it's when using the old VMware drivers in the guest on a host with > a higher version of VMware? I did see some exclamation marks on the > VMware tools icon in the screenshot on winetestbot (which could indicate > that a newer version of the tools/drivers is available). > > (Can't say anything about VirtualBox) > So is this patch good to go or do we do prefer broken() as I wasn't able to reproduce? Patch is currently marked as 'Pending': http://source.winehq.org/patches/data/57834 -- Cheers, Paul.

Jan. 31, 2010

Re: Winehq donation and DATA COMPRESSION

by Wolfram Sang

> BTW I've done some cabinet.dll stuff some years ago. > Can anybody give me a hint to some easy-to-understand data compression > documentation? You mean in general? http://en.wikipedia.org/wiki/Data_Compression Should have enough links for the specific sub-topics. Regards, Wolfram

Jan. 30, 2010

Re: Winehq donation and DATA COMPRESSION

by Tom Wickline

On Sat, Jan 30, 2010 at 9:58 PM, Gerold Jens Wucherpfennig < gjwucherpfennig(a)gmx.net> wrote: > > Hi, I've donated some bucks to winehq by PayPal and want to spend more... > :) > Can I decide for which things will be spend? > The money goes to support future Wine Conference expenses. In the past money has been given to developers to help cover their transportation and lodging. And toward the end of the conference their has always been a group meal with lots of beer. :) When donating money, how much of it will go to PayPal? > https://www.paypal.com/cgi-bin/webscr?cmd=_display-fees-outside Is there a better way than using PayPal (by the donate link of the winehq > front-page)? > Paypal is the easiest way, but I'm sure if you mailed a certified cheque or money order to Jeremy it wouldn't be rejected :) Cheers, Tom > > BTW I've done some cabinet.dll stuff some years ago. > Can anybody give me a hint to some easy-to-understand data compression > documentation? > I want to complete the cabinet.dll archive creation compression, > if I get the required knowledge. It's so difficult... :-( > > > Thanks and Bye, > > Gerold > > -- http://www.freewear.org/?search=FW0044+FW0045

Jan. 30, 2010

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)

by Reece Dunn

On 30 January 2010 16:44, Geoffrey Hausheer <winedevel9605(a)phracturedblue.com> wrote: > On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote: >> >> Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer: >> > Is there anything I can do to move this patch forward? I've fixed all >> > the >> > issues that have been raised so far. I have no dea what it is waiting >> > on, >> > and if there is anything I can do to get it committed or if it is just a >> > question of being patient. As I said previously I'd happily write a >> > test >> > for it, but I couldn't find any examples of how to test a modal dialog >> > box >> > in Wine, so I just don't know what the right way to do that is. >> >> According to http://source.winehq.org/patches/ the patch is pending. You >> may >> have more luck if you send some test cases for the unit tests first. >> > Which, as I tried to explain in my mail, I have no idea how to do because > the function is basically (from user-space) atomic and implements a Modal > dialog box, and I haven't seen any Wine tests that deal with anything > remotely like that. So I am at a loss as to how to write tests for this > function. If that is what is needed to get it committed, then I need > guidance as to how to go about it. You can create tests that are marked as winetest_interactive: if ( ! winetest_interactive ) { skip("these tests require user interaction to work."); return } This is used in several places in the tests (e.g. dinput/tests/joystick.c) to provide visual/interactive checks for functionality that cannot otherwise be tested. Alternatively, does the API provide a way to hook into the modal dialog, like comdlg32 does? If so, you could use that to drive the tests. - Reece

Jan. 30, 2010

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)

by Geoffrey Hausheer

On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote: > Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer: > > Is there anything I can do to move this patch forward? I've fixed all > the > > issues that have been raised so far. I have no dea what it is waiting > on, > > and if there is anything I can do to get it committed or if it is just a > > question of being patient. As I said previously I'd happily write a test > > for it, but I couldn't find any examples of how to test a modal dialog > box > > in Wine, so I just don't know what the right way to do that is. > > According to http://source.winehq.org/patches/ the patch is pending. You > may > have more luck if you send some test cases for the unit tests first. > > Which, as I tried to explain in my mail, I have no idea how to do because the function is basically (from user-space) atomic and implements a Modal dialog box, and I haven't seen any Wine tests that deal with anything remotely like that. So I am at a loss as to how to write tests for this function. If that is what is needed to get it committed, then I need guidance as to how to go about it.

Jan. 30, 2010

Re: [PATCH] shlwapi/tests: ChrCmpI* not present on Win95B (winetestbot)

by Nikolay Sivov

On 1/30/2010 18:25, Detlef Riekenberg wrote: > > @@ -608,9 +610,13 @@ static void test_StrCmpA(void) > static const char str2[] = {'a','B','c','d','e','f'}; > ok(0 != StrCmpNA(str1, str2, 6), "StrCmpNA is case-insensitive\n"); > ok(0 == StrCmpNIA(str1, str2, 6), "StrCmpNIA is case-sensitive\n"); > - ok(!ChrCmpIA('a', 'a'), "ChrCmpIA doesn't work at all!\n"); > - ok(!ChrCmpIA('b', 'B'), "ChrCmpIA is not case-insensitive\n"); > - ok(ChrCmpIA('a', 'z'), "ChrCmpIA believes that a == z!\n"); > + if (pChrCmpIA) { > + ok(!pChrCmpIA('a', 'a'), "ChrCmpIA doesn't work at all!\n"); > + ok(!pChrCmpIA('b', 'B'), "ChrCmpIA is not case-insensitive\n"); > + ok(pChrCmpIA('a', 'z'), "ChrCmpIA believes that a == z!\n"); > + } > + else > + win_skip("ChrCmpIW() is not available\n"); > > Should be ChrCmpIA() in message.

Jan. 30, 2010

new valgrind results...

by Dan Kegel

This is with an almost-unpatched trunk (the only patch is my tweak to handle bogus environment variables), so it's now using Alexandre's heap patches rather than mine. There are some interesting new warnings, not sure quite what to make of them yet. Logs at http://kegel.com/wine/valgrind/logs/2010-01-29-20.52/ Stats at http://kegel.com/wine/valgrind/logs/2010-01-29-20.52.errs.txt 2 Source and destination overlap in memcpy 2 Syscall param writev 3 Use of uninitialised value of size 4 7 Invalid read of size 2 10 Invalid write of size 4 20 Invalid write of size 1 29 Invalid free/ delete / delete[] 30 Invalid read of size 4 46 Conditional jump or move depends on uninitialised value 86 Invalid read of size 1 279 XXX bytes in XXX blocks are definitely lost total: 514

Jan. 30, 2010

Winehq donation and DATA COMPRESSION

by Gerold Jens Wucherpfennig

Hi, I've donated some bucks to winehq by PayPal and want to spend more... Can I decide for which things will be spend? When donating money, how much of it will go to PayPal? Is there a better way than using PayPal (by the donate link of the winehq front-page)? BTW I've done some cabinet.dll stuff some years ago. Can anybody give me a hint to some easy-to-understand data compression documentation? I want to complete the cabinet.dll archive creation compression, if I get the required knowledge. It's so difficult... :-( Thanks and Bye, Gerold

Jan. 30, 2010