January 2010 - Wine-Devel - list.winehq.org

Re: msi: Fix crash with access to component

by André Hentschel

Hans Leidekker schrieb: > On Saturday 30 January 2010 12:55:21 André Hentschel wrote: > >> --- >> dlls/msi/files.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/dlls/msi/files.c b/dlls/msi/files.c >> index 7e74dca..afeb451 100644 >> --- a/dlls/msi/files.c >> +++ b/dlls/msi/files.c >> @@ -363,6 +363,8 @@ static UINT ITERATE_DuplicateFiles(MSIRECORD *row, LPVOID param) >> { >> TRACE("Skipping copy due to disabled component %s\n", >> debugstr_w(component)); >> + if (!comp) >> + return ERROR_INSTALL_FAILURE; >> >> /* the action taken was the same as the current install state */ >> comp->Action = comp->Installed; > > Where do you see that crash? Are you sure ERROR_INSTALL_FAILURE is appropriate? > > -Hans thought twice(and digging into the code some more), maybe returning a success is a better idea. -- Best Regards, André Hentschel

Jan. 30, 2010

Re: msi: Fix crash with access to component

by Hans Leidekker

On Saturday 30 January 2010 12:55:21 André Hentschel wrote: > --- > dlls/msi/files.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 7e74dca..afeb451 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -363,6 +363,8 @@ static UINT ITERATE_DuplicateFiles(MSIRECORD *row, LPVOID param) > { > TRACE("Skipping copy due to disabled component %s\n", > debugstr_w(component)); > + if (!comp) > + return ERROR_INSTALL_FAILURE; > > /* the action taken was the same as the current install state */ > comp->Action = comp->Installed; Where do you see that crash? Are you sure ERROR_INSTALL_FAILURE is appropriate? -Hans

Jan. 30, 2010

Re: Student Interested in Google Summer of Code 2010

by Gerald Pfeifer

On Fri, 29 Jan 2010, Austin English wrote: > Flex isn't GLPv3, it's got a BSD license: > http://flex.sourceforge.net/manual/Copyright.html#Copyright You're right, and I had actually checked that a few weeks ago and confused it with something else now. Excellent. Please do file a PR against FreeBSD and let me know the number off-list. I may have an idea... :-) Gerald

Jan. 29, 2010

Re: Student Interested in Google Summer of Code 2010

by Austin English

On Fri, Jan 29, 2010 at 1:44 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > On Fri, 29 Jan 2010, Austin English wrote: >> Right. But it's a bug in the sense that FreeBSD is shipping an >> _extremely_ old version of flex ;-). > > True. > >> Can you put in a request to update flex for FreeBSD 8.1/9.0? Or >> should I register/file a bug? > > Filing a request is fine, if you want to do so. Just don't hold > your breath, there is a lot of FUD around GPLv3 in BSD-land¹ and > anything with a GPLv3 license in the base system will need core > (team) approval and a heck of a lot of a reason. Flex isn't GLPv3, it's got a BSD license: http://flex.sourceforge.net/manual/Copyright.html#Copyright Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. Neither the name of the University nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED “AS IS” AND WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. -- -Austin

Jan. 29, 2010

Re: Student Interested in Google Summer of Code 2010

by Loïc Hoguin

On 01/29/2010 07:17 PM, Tony Wasserka wrote: > Am 28.01.2010 21:42, schrieb Loïc Hoguin: >> >> What would be the solution then to have a chance to get Tony's work >> committed if he can't/won't do the rest of the work himself > FWIW, I handed in my skilled-work paper today, so I've had some spare > time today again. I just prepared a patch which implements point > filtering for ARGB surfaces in D3DXLoadSurfaceFromMemory. If (and only > if) that one goes in, I can submit the D3DXFilterTexture implementation > which is needed for my font code to work properly. I'm going to send it > to wine-patches today or tomorrow probably then. Good news, thanks for your hard work! I hope my question didn't sound offensive, I only used this as an example in hopes it could get me a general answer over this issue. I have seen it pop up a few times the last month alone and so far I haven't seen a straight answer other than it'd be "hard" to get a commit if the author is different than the committer. Looking forward to your patches. -- Loïc Hoguin mel: essen(a)dev-extend.eu web: http://dev-extend.eu

Jan. 29, 2010

Re: Student Interested in Google Summer of Code 2010

by Gerald Pfeifer

On Fri, 29 Jan 2010, Austin English wrote: > Right. But it's a bug in the sense that FreeBSD is shipping an > _extremely_ old version of flex ;-). True. > Can you put in a request to update flex for FreeBSD 8.1/9.0? Or > should I register/file a bug? Filing a request is fine, if you want to do so. Just don't hold your breath, there is a lot of FUD around GPLv3 in BSD-land¹ and anything with a GPLv3 license in the base system will need core (team) approval and a heck of a lot of a reason. Gerald ¹ Personally I do agree that GPLv3 was not very helpful, alas it's not the end of the world, either.

Jan. 29, 2010

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)

by Stefan Leichter

Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer: > Is there anything I can do to move this patch forward? I've fixed all the > issues that have been raised so far. I have no dea what it is waiting on, > and if there is anything I can do to get it committed or if it is just a > question of being patient. As I said previously I'd happily write a test > for it, but I couldn't find any examples of how to test a modal dialog box > in Wine, so I just don't know what the right way to do that is. According to http://source.winehq.org/patches/ the patch is pending. You may have more luck if you send some test cases for the unit tests first. Stefan

Jan. 29, 2010

Re: relay log problem

by Stefan Leichter

Am Friday 29 January 2010 01:20:24 schrieb Henri Verbeet: > On 29 January 2010 00:21, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > > On 01/28/2010 10:59 PM, Henri Verbeet wrote: > >> On 28 January 2010 22:39, Stefan Leichter<Stefan.Leichter(a)camline.com> > >> > >> wrote: > >>> Is this a know problem? Is a work around available? > >> > >> Yeah, that's a known problem. As a workaround you can use ">>" > >> (append) instead of ">" to redirect to the file. You'll still need the > >> "2>&1" to redirect stderr to stdout, of course. > > > > That won't workaround the problem. > > Seems to work for me. For me too Thanks for the tip

Jan. 29, 2010

Re: Student Interested in Google Summer of Code 2010

by Tony Wasserka

Am 28.01.2010 21:42, schrieb Loïc Hoguin: > > What would be the solution then to have a chance to get Tony's work > committed if he can't/won't do the rest of the work himself FWIW, I handed in my skilled-work paper today, so I've had some spare time today again. I just prepared a patch which implements point filtering for ARGB surfaces in D3DXLoadSurfaceFromMemory. If (and only if) that one goes in, I can submit the D3DXFilterTexture implementation which is needed for my font code to work properly. I'm going to send it to wine-patches today or tomorrow probably then.

Jan. 29, 2010

Re: Student Interested in Google Summer of Code 2010

by Austin English

On Thu, Jan 28, 2010 at 7:03 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > On Wed, 27 Jan 2010, Tom Wickline wrote: >> The version check fails on FreeBSD 8 even tho flex-2.5.35_3 is >> installed from ports. >> >> # flex --version >> flex version 2.5.4 >> >> The version check passes on Linux and OpenSolaris but FreeBSD has a >> harder time with it. >> >> Gerald has a workaround for this.. Shall I call it a bug? since a >> newer version is actually installed but the version check fails. > > It's not a bug in Wine or Wine's configure scripts. What happens on > your system, or any "standard" FreeBSD system with the flex package > installed is that the default path has /usr/bin before /usr/local/bin, > so /usr/bin/flex which is 2.5.4 (as per your example) is found before, > or should I say: instead, /usr/local/bin/flex which is the good one. Right. But it's a bug in the sense that FreeBSD is shipping an _extremely_ old version of flex ;-). Can you put in a request to update flex for FreeBSD 8.1/9.0? Or should I register/file a bug? -- -Austin

Jan. 29, 2010