January 2010 - Wine-Devel - list.winehq.org

Re: [rfc] initial conformance test for programs/cmd

by Eric Pouech

Dan Kegel a écrit : > How's this look? I've only tested it lightly, but it should > be pretty close; with this, "make test" ought to recurse > down into programs/cmd/tests and run the cmd tests, too. > > Shortcomings: > - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround > - I think I can turn on echo again in tests/*.cmd, that was another workaround > - I have yet to add a way to specify that a test is todo_wine > > Feedback welcome. I'll try to submit something tomorrow > that takes care of the above known issues and any issues > anyone else points out. > > (I'm actually kind of amazed the build machinery changes work, > I didn't really take the time to understand all of the gears and pulleys.) > > ------------------------------------------------------------------------ > > what I don't like in current design: - it requires external files to the generic .c file (but putting it into a resource would do) - but more importantly, you cannot simply have a result that depends on some test conditions or previous results (for example "date"...) - also it won't allow to use some "interactive" features of cmd (like filename completion on tab) so I'd better like an approach where you decide, command by command, which input strings you send to cmd and how to interpret the final result out of the shell. the file approach you're currently using could be of course implemented on top of this first layer A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Jan. 2, 2010

merge wine-website's Todo

by Thomas Heckel

Hi, the last days I had some free time and tried to make some cleanups to the wiki. I mainly worked on the pages related to quality assurance because my little contributions was to Austin's AppInstall which is on this topic. I hope this way I can contribute to the project. At the moment I stumbled over this old page at the website: http://www.winehq.org/status/todo It seems to me this would be a good candidate to be merged into wiki too. What do you think? Bye -- Thomas Heckel

Jan. 2, 2010

Re: Is native dbghelp useful?

by Eric Pouech

Austin English a écrit : > I noticed Microsoft's got dbghelp in a download available...would the > native dll be useful to anyone? E.g., should I add it to winetricks? > > http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4b2-0885-47f4… > > -- > -Austin > > > > > for most of the cases no, as it'll mean you won't get any debug information for the built-in modules so I don't think it's useful (except for testing dbghelp itself, but you don't need to add it to winetricks for that) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Jan. 2, 2010

Re: Is native dbghelp useful?

by Maarten Lankhorst

Hi Austin, Austin English schreef: > I noticed Microsoft's got dbghelp in a download available...would the > native dll be useful to anyone? E.g., should I add it to winetricks? > > http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4b2-0885-47f4… > Probably not, since it wouldn't understand wine's dlls :) Cheers, Maarten.

Jan. 2, 2010

Re: [4/6] WineD3D: Add GL_APPLE_flush_buffer_range

by Henri Verbeet

2010/1/1 Stefan Dösinger <stefan(a)codeweavers.com>: > +typedef void (WINE_GLAPI *PGLBUFFERPARAMETERIAPPLE) (GLenum target, GLenum pname, GLint param); > +typedef void (WINE_GLAPI *PGLFLUSHMAPPEDBUFFERRANGEAPPLE) (GLenum target, ptrdiff_t offset, ptrdiff_t size); Any reason for not using the same naming convention as the rest of the file? Also, "ptrdiff_t" doesn't match the spec at http://www.opengl.org/registry/specs/APPLE/flush_buffer_range.txt.

Jan. 2, 2010

Re: [PATCH] wined3d: Do not try to use not available texture stages in set_tex_op_nvr

by Henri Verbeet

A +d3d,+d3d_caps log would probably be a good start.

Jan. 2, 2010

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

by Jeff Latimer

On 02/01/10 21:42, Nikolay Sivov wrote: > On 1/2/2010 12:48, Jeff Latimer wrote: >> --- >> dlls/comctl32/listview.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > Actually setting buffer count is noop here, cause buffer pointer is > not set up for dispInfo.item. Because it is tied up with callbacks, I have observed that the callback routine in the app may be the issue here. It looks to be used in at least one case. > A test required for this - let's say check that an ownerdata listview > send LVN_GETDISPINFO before text update and the same thing for > callback text (don't remember now maybe similar tests are already in). > I can do a test but not for 2 weeks (summer holidays).

Jan. 2, 2010

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

by Jeff Latimer

On 02/01/10 21:34, Nikolay Sivov wrote: > On 1/2/2010 12:48, Jeff Latimer wrote: >> --- >> dlls/comctl32/listview.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> + dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; > What does this '2' mean? +1 adds the trailing null and +2 allows for the original text to be greater than the edited text. I thought that one extra byte would allow the test to complete in all cases.

Jan. 2, 2010

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

by Nikolay Sivov

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. A test required for this - let's say check that an ownerdata listview send LVN_GETDISPINFO before text update and the same thing for callback text (don't remember now maybe similar tests are already in).

Jan. 2, 2010

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

by Nikolay Sivov

On 1/2/2010 12:48, Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > + dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; > What does this '2' mean?

Jan. 2, 2010