January 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] wined3d: Do not try to use not available texture stages in set_tex_op_nvr

by Christian Costa

Stefan Dösinger a écrit : >> + if (stage > (gl_info->limits.texture_stages-1)) >> + { >> + ERR("Texture stage %d invalid (only %d availables)\n", stage, gl_info->limits.texture_stages); >> + return; >> + } >> > In which situations does this occur? I guess its on some older nvidia GPU. > > I don't like the ERR here. If this occurs because an app ignores the d3d limits, then this should be a WARN. If this code is called because some other wined3d code doesn't honor the limits this should be fixed elsewhere. If this code is called correctly, and catching the limit violation in the state setter is the correct thing to do this should be a TRACE(e.g. the state handler is called because device creation dirtifies all states). > > Yeah. A rather old one... ;-) I don't know this code much but I would say it is partly 2 and 3. Is a FIXME suitable then ? This would be much more informative that just GL errors.

Jan. 1, 2010

Re: avifile tests

by Julius Schwartzenberg

Hi Vitaliy, Thanks a lot for your feedback! Vitaliy Margolen wrote: > Julius Schwartzenberg wrote: > You don't need to use memcpy to copy structures. Simple assignment is > enough. Eg: cah->mah = defmah; I didn't know that. I fixed it now here :) > For tests you should always specify full path. Here you probably want to get > system's tmp directory. I understand I need to use the GetTempFileName and GetTempPath functions for this. I'll solve this too. Since I will probably have to resend the patch, I'll be sure to include your suggestions then! Regards, Julius

Jan. 1, 2010

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends

by Julius Schwartzenberg

Paul Vriens wrote: > On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote: >> This patch depends on Detlef Riekenberg's patch from June 2008 and >> expects it to have been applied: >> http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html >> >> It was not committed due to bug 14085: >> http://bugs.winehq.org/show_bug.cgi?id=14085 > > Can't you just submit that initial test framework with the 3 imports (if > all 3 are indeed needed)? The bug will of course not be closed but at > least some of your work could be committed. My work (and Detlef's too I think) only needs avifil32 and importing that, as Detlef suggested, was the way I was able to test things. I understand that Alexandre would not accept such a patch though. Otherwise I would say Detlef's patch should be submitted with this import so that my patches can be committed on top of that. I think it was also stupid of me to send all the patches as a serie, while they do not actually depend on each other. I'm not sure though how I would submit the patches next time. Should I send the tests depending on each other in a separate serie from the actual fixes or is the right way actually to send a fix with it's test in the same serie? Thanks, Julius

Jan. 1, 2010

Re: [PATCH] wined3d: Do not try to use not available texture stages in set_tex_op_nvr

by Stefan Dösinger

> + if (stage > (gl_info->limits.texture_stages-1)) > + { > + ERR("Texture stage %d invalid (only %d availables)\n", stage, gl_info->limits.texture_stages); > + return; > + } In which situations does this occur? I guess its on some older nvidia GPU. I don't like the ERR here. If this occurs because an app ignores the d3d limits, then this should be a WARN. If this code is called because some other wined3d code doesn't honor the limits this should be fixed elsewhere. If this code is called correctly, and catching the limit violation in the state setter is the correct thing to do this should be a TRACE(e.g. the state handler is called because device creation dirtifies all states).

Jan. 1, 2010

LsaLookupNames2 allocated buffers

by Nikolay Sivov

Currently valgrind reports leaks after that calls, cause returned buffers contains data pointers too, including SIDs. So the question is about LsaFreeMemory usage - should advapi track allocated structures and then free properly depending on passed pointer or caller is responsible for cleanup?

Jan. 1, 2010

RE: WineTestBot changes

by Greg Geldorp

> I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows > executables you can now also submit patch files to the bot. The bot will > apply the patch files to a clean git tree, cross-compile the test and run the > test on Windows VMs. You'll also be able to download the cross-compiled test > executable to test it on different Windows machines. I've had to reverse this change for now as it causes major problems. Ge.

Jan. 1, 2010

Tango Icons Ready to Go

by Joel Holdsworth

Hi All, I've spoken to the authors of the two icons that needed their licenses resolving. They've agreed to relicense them, so the Tango icons are ready to go. I've sent a pull request to wine-patches. Best Regards Joel Holdsworth

Jan. 1, 2010

[rfc] initial conformance test for programs/cmd

by Dan Kegel

How's this look? I've only tested it lightly, but it should be pretty close; with this, "make test" ought to recurse down into programs/cmd/tests and run the cmd tests, too. Shortcomings: - I don't think I need chomp() in tests/cmd.c anymore, that was a workaround - I think I can turn on echo again in tests/*.cmd, that was another workaround - I have yet to add a way to specify that a test is todo_wine Feedback welcome. I'll try to submit something tomorrow that takes care of the above known issues and any issues anyone else points out. (I'm actually kind of amazed the build machinery changes work, I didn't really take the time to understand all of the gears and pulleys.)

Jan. 1, 2010