October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20). sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20).

Oct. 31, 2010

up for a quick challenge? "Test Drive Unlimited 2" open beta this weekend only...

by Dan Kegel

and installs ok with dotnet20... but it's stuck on "Checking files, please wait". http://appdb.winehq.org/objectManager.php?sClass=version&iId=21811 http://en.wikipedia.org/wiki/Test_Drive_Unlimited_2 (Wikipedia says it will require .net 3.5, ugh.) While it's sitting, it outputs stuff like fixme:thread:NtQueryInformationThread info class 16 not supported yet fixme:ole:Context_CC_ContextCallback (0x4956060/0x4956064)->(0x79f277a5, 0x2a7e4e8, {d7174f82-36b8-4aa8-800a-e963ab2dfab9}, 2, (nil)) fixme:thread:NtQueryInformationThread info class 16 not supported yet I guess the next step is to look at the packets on the wire on windows and see if it's getting stuck trying to phone home...

Oct. 31, 2010

Re: comctl32/treeview: Make item data layout partially compatible with native one

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6609 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === No test summary line found === W2KPROSP4 (32 bit treeview) === No test summary line found

Oct. 31, 2010

Re: Purist keyword?

by Stefan Dösinger

Am 30.10.2010 um 22:30 schrieb Maarten Lankhorst: > I really don't see what 'purist' adds, if a game fails because a > builtin dll is missing a function, why would it matter if the game > installs a native dll by default or not? The bug is still in the > builtin dll, whether you use the builtin dll or not. ;) At some point we'll probably change the DLL load order for that particular DLL from native,builtin to builtin, native(via changing DLL_WINE_PREATTACH). In that case all those bugs would turn in to real bugs. Besides, there are situations when you'd prefer not to use any Microsoft redistributable DLLs due to license reasons. Even if they came with the game.

Oct. 31, 2010

RFC: quartz: Don't block indefinitely when pausing after end of stream

by Vladimir Panteleev

The attached patch attempts to fix http://bugs.winehq.org/show_bug.cgi?id=24869 , but due to my limited knowledge of DirectShow I'm not certain about its correctness. Can anyone point out if there's anything wrong with it?

Oct. 31, 2010

Re: Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken.

by Vitaliy Margolen

On 10/30/2010 06:12 AM, Sami Aario wrote: > Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken. > > From: Sami Aario <saempy(a)hima.(none)> Your e-mail isn't set correctly in git configuration. > dlls/ntdll/nt.c | 63 ++++++++++++++++++++++++++++++++++++++++ > include/wine/server_protocol.h | 18 +++++++++++- > server/protocol.def | 6 ++++ > server/request.h | 5 +++ > server/token.c | 36 +++++++++++++++++++++++ > server/trace.c | 10 ++++++ Please don't include changes to automatically generated files (server_protocol.h, request.h, trace.c). > + SERVER_START_REQ( set_token_sid ) > + { > + SID *sid = ((TOKEN_OWNER *)TokenInformation)->Owner; > + WORD size; > + > + if (sid) size = RtlLengthRequiredSid(sid->SubAuthorityCount); > + else size = 0; > + > + TRACE("size=%d\n", size); > + > + req->handle = wine_server_obj_handle( TokenHandle ); > + req->which_sid = TokenInformationClass; > + wine_server_add_data( req, sid, size ); > + ret = wine_server_call( req ); > + } > + SERVER_END_REQ; Please get everything outside of SERVER_START_REQ()/SERVER_END_REQ except actual wine_server function calls and handling of returned result(s). Some functions can do their own server calls and you will have a deadlock. > + case TokenOwner: > + free( token->user ); > + token->user = NULL; > + > + if (sid_len) > + token->user = memdup( sid, sid_len ); > + break; This is wrong, you can't clear token user - it always have to be set, or you risking an assert in get_token_sid. Which means you have to validate the data user passes in. Vitaliy.

Oct. 30, 2010

re: Purist keyword?

by Dan Kegel

The keyword might be useful for a pragmatist looking for bugs to fix, who didn't want to fix bugs masked by a bundled native DLL. I don't know how many such people there are, though. Best to wait until somebody says they need the keyword before we add it... until then, we can just use the word 'purist' in the body of the bug as we've started doing.

Oct. 30, 2010

Re: Purist keyword?

by Maarten Lankhorst

Hi Austin, 2010/10/30 Austin English <austinenglish(a)gmail.com>: > On Saturday, October 30, 2010, Shachar Shemesh <shachar(a)shemesh.biz> wrote: >> On 30/10/10 19:25, Austin English wrote: >> >> I meant bugs that only occur by manually removing native dlls. The >> report summaries are usually clear enough, I was hoping to get an easy >> way to search for them and separate them from 'normal' bugs. >> >> >> >> >> I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) >> >> Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the >> ".dll.so" extension. > > No, I mean native. Some applications install native redistibutables, > e.g. msvcr80 or d3dx9_36. > >> To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? > > Sure. I forget not everyone follows wine-bugs, so this was unclear. > See http://bugs.winehq.org/show_bug.cgi?id=24510. Blur runs out of the > box, but if you remove the bundled native dll (being a purist) the > game fails, because wine is missing a dozen or so functions. There are > several similar bugs. I really don't see what 'purist' adds, if a game fails because a builtin dll is missing a function, why would it matter if the game installs a native dll by default or not? The bug is still in the builtin dll, whether you use the builtin dll or not. ;) Cheers, Maarten

Oct. 30, 2010

Re: Purist keyword?

by Austin English

On Saturday, October 30, 2010, Shachar Shemesh <shachar(a)shemesh.biz> wrote: > On 30/10/10 19:25, Austin English wrote: > > I meant bugs that only occur by manually removing native dlls. The > report summaries are usually clear enough, I was hoping to get an easy > way to search for them and separate them from 'normal' bugs. > > > > > I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) > > Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the > ".dll.so" extension. No, I mean native. Some applications install native redistibutables, e.g. msvcr80 or d3dx9_36. > To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? Sure. I forget not everyone follows wine-bugs, so this was unclear. See http://bugs.winehq.org/show_bug.cgi?id=24510. Blur runs out of the box, but if you remove the bundled native dll (being a purist) the game fails, because wine is missing a dozen or so functions. There are several similar bugs. -- -Austin

Oct. 30, 2010

Re: Purist keyword?

by Shachar Shemesh

On 30/10/10 19:25, Austin English wrote: > I meant bugs that only occur by manually removing native dlls. The > report summaries are usually clear enough, I was hoping to get an easy > way to search for them and separate them from 'normal' bugs. > > I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the ".dll.so" extension. To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

Oct. 30, 2010

Re: Purist keyword?

by Austin English

On Saturday, October 30, 2010, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Austin English <austinenglish(a)gmail.com> wrote: > >> I see quite a few people filing bugs that are only exposed when bundled >> native dlls are removed. I think it would be good to be able to group these >> bugs, perhaps with a 'purist' keyword. Anyone opposed? > > Personally I don't see the point. The less keywords is the better IMO. Why not > clarify the problem in the subject, like "xxx doesn't install without native > yyy.dll" ? I meant bugs that only occur by manually removing native dlls. The report summaries are usually clear enough, I was hoping to get an easy way to search for them and separate them from 'normal' bugs. -- -Austin

Oct. 30, 2010

Re: Purist keyword?

by Dmitry Timoshkov

Austin English <austinenglish(a)gmail.com> wrote: > I see quite a few people filing bugs that are only exposed when bundled > native dlls are removed. I think it would be good to be able to group these > bugs, perhaps with a 'purist' keyword. Anyone opposed? Personally I don't see the point. The less keywords is the better IMO. Why not clarify the problem in the subject, like "xxx doesn't install without native yyy.dll" ? -- Dmitry.

Oct. 30, 2010

re: WINE Performance and Evernote 4.0 Windows Client

by Dan Kegel

Hi Martin, > http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks for letting us know. Looking at that thread, your message, and the appdb entry http://appdb.winehq.org/objectManager.php?sClass=version&iId=21775 it looks like people are reporting four or so problems: - autoupdate doesn't work - pdf preview hangs or is slow - switching notebooks is slow - clicking on menu is slow It would probably help to have Wine bug reports at http://bugs.winehq.org for each individual problem, with clear instructions for non-Evernote users on how to reproduce them. (I'd file a couple myself, but I don't have time to experiment at the moment.) - Dan

Oct. 30, 2010

ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel

by David Adam

Any problem with this patch? A+ David

Oct. 30, 2010

WINE Performance and Evernote 4.0 Windows Client

by Martin Packer

Evernote are in the process of releasing 4.0 of their Windows client. This is completely rewritten to avoid the use of things that would stop it running under WINE. (This WASN'T their target - it was more about device drivers that had been problematic.) It runs reasonably well on the latest WINE. However it runs slowly (in a way it doesn't under "real" Windows) and also the autoupdater doesn't seem to work. Is anyone here willing to work with them and us to help it run faster? (I haven't got commitment from Evernote to make changes but I have got their attention now.) :-) Hopefully you can see this thread on the Evernote bulletin board: http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks, Martin Martin Packer, Mainframe Performance Consultant, zChampion Worldwide Banking Center of Excellence, IBM +44-7802-245-584 email: martin_packer(a)uk.ibm.com Twitter / Facebook IDs: MartinPacker Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Oct. 30, 2010

Purist keyword?

by Austin English

I see quite a few people filing bugs that are only exposed when bundled native dlls are removed. I think it would be good to be able to group these bugs, perhaps with a 'purist' keyword. Anyone opposed?

Oct. 30, 2010

Re: Linux kernel and game performance?

by Tom Spear

For the first reference, I have a WoW install. I haven't seen fps below 60 except in areas of the game where there are a lot of other players, but that was under OpenGL back before the latest patch. I haven't tried since Blizzard has disabled all high end settings in OpenGL mode for both Windows and Linux, and I've heard nothing but bad performance on D3D recently. I could give it a shot though. What is needed to make a kernel realtime other than adding CONFIG_SCHED_DEBUG and adding the sysctl settings? Thanks Tom On Mon, Oct 25, 2010 at 6:26 PM, Dan Kegel <dank(a)kegel.com> wrote: > Hey folks, > I've run into two web sites that claim that the Linux kernel causes > performance > problems in particular games (see below). Anybody know of others? > > And has anybody found concrete improvements in performance > of a particular app (other than an audio workstation app) from using > a realtime kernel? > > Thanks! > - Dan > > First: > > http://wiki.archlinux.org/index.php/World_of_Warcraft#Kernel_Timing_Bug > says in a section dated September 2008: > "If you are having problems with choppy video every 15 seconds or so, > it is related to the kernel scheduler... > to fix, add CONFIG_SCHED_DEBUG=y to your kernel config, then set > kernel.sched_features=21 > kernel.sched_batch_wakeup_granularity_ns=25000000 > kernel.sched_min_granularity_ns=4000000 > in /etc/sysctl.cfg." > > Yikes. Any truth to that rumor? > > Second: > > http://hisouten.koumakan.jp/wiki/Linux_support#Resolved_bugs > says > > "The game runs too slowly > Symptoms: > Instead of running at about 60-62fps, like the game is supposed to, > it'll run closer to 53fps. This is not ideal. > The bug: > This is a Linux timing issue. The game runs a secondary timing thread > with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms > and sends events to the main thread to tell it that a new frame is > needed. On Linux the necessary timing accuracy is not available, so it > wavers between 16ms and 20ms. > The fix: > I hacked around this by setting the timer period to 14ms. This leads > to a steady 62-63fps. Which is close enough for use, really. For a > constant 60fps turn on vsync in your video drivers." > > >

Oct. 29, 2010

Re: Windows Installer change in behaviour Wine 1.3.5.

by James Mckenzie

Damian Dixon <damian.dixon(a)gmail.com> wrote: {Please send replies only to the Wine Devel mailing list.} > >I have installed my application under Wine 1.3.5 however with this version >of Wine the registry is not updated by the installer. Name of application, Linux distribution please. Also please file a bug report, if one does not exist. > >The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as >it has worked before with older versions of Wine. > Looks like a regression to me. However, 1.3.6 is about to be released (maybe today.) Would have been great to catch this. James McKenzie

Oct. 29, 2010

Re: [3/3] gdi32: Make AddFontToList return a pointer to first loaded face.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 35 ++++++++++++++++++++--------------- > 1 files changed, 20 insertions(+), 15 deletions(-) You are lucky, it turns out that I screwed up and committed your original patch by mistake ;-) But I still don't see why you are returning that pointer, could you please send the code that makes use of this? -- Alexandre Julliard julliard(a)winehq.org

Oct. 29, 2010

Re: Crash bug in Wine 1.3.5 in advapi32/service.c

by Hans Leidekker

On Fri, 2010-10-29 at 17:55 +0100, Damian Dixon wrote: > In file dlls/advapi32/service.c, line 1135 a memory copy occurs, > however the lpservicestatus is not checked to see if the value is > NULL. > > This causes a crash in an application that has worked before under > wine. > > My naive change is: > > if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData, It's more likely that QueryServiceStatus returns failure when lpservicestatus is NULL. Please open a bug for this and the other problem you observed.

Oct. 29, 2010

Windows Installer change in behaviour Wine 1.3.5.

by Damian Dixon

Hi, I have installed my application under Wine 1.3.5 however with this version of Wine the registry is not updated by the installer. The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as it has worked before with older versions of Wine. I've not had the time to investigate but thought someone my be interested. Regards Damian

Oct. 29, 2010

Crash bug in Wine 1.3.5 in advapi32/service.c

by Damian Dixon

Hi, In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the lpservicestatus is not checked to see if the value is NULL. This causes a crash in an application that has worked before under wine. My naive change is: if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData, sizeof(SERVICE_STATUS)) ; Regards Damian

Oct. 29, 2010

Re: [4/5] msxml3: Add XSLPattern nodeType() method

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6591 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === WVISTAADM (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PRO (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (64 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1

Oct. 29, 2010

Re: [5/5] msxml3: Implement XSLPattern collection methods

by Alexandre Julliard

Adam Martinson <amartinson(a)codeweavers.com> writes: > From d7dfd1e50a295c9bae15f83ed418cfa5f0890d58 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <amartinson(a)codeweavers.com> > Date: Thu, 28 Oct 2010 20:22:22 -0500 > Subject: [PATCH 8/8] msxml3: Implement XSLPattern collection methods > To: wine-patches <wine-patches(a)winehq.org> This one causes some scary warnings: bison -p xslpattern_ -o xslpattern.tab.c -d xslpattern.y xslpattern.y: conflicts: 14 shift/reduce, 42 reduce/reduce xslpattern.y:298.31-42: warning: rule useless in parser due to conflicts: PrimaryExpr: FunctionCall -- Alexandre Julliard julliard(a)winehq.org

Oct. 29, 2010

Re: [1/3] include: Better distinguish ARM's endianess

by Paul Chitescu

On Friday 29 October 2010 05:34:31 pm André Hentschel wrote: > --- > include/basetsd.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 6ce0102..aa6e86d 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -291,7 +291,11 @@ typedef ULONG_PTR KAFFINITY, *PKAFFINITY; > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS > -#elif defined(__arm__) > +#elif defined(__ARMEB__) > +# define WORDS_BIGENDIAN > +# define BITFIELDS_BIGENDIAN > +# undef ALLOW_UNALIGNED_ACCESS > +#elif defined(__ARMEL__) > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS Not relevant just here but please note that in little endian ARM the hardware coprocessor compatible double type is cross endian (octets are: 5 6 7 8=MSB 1=LSB 2 3 4) while big endian is normal (8=MSB 7 6 5 4 3 2 1=LSB). The processor swaps octets in the 32 bit halves of the type but not the halves themselves. On Linuxes compiled for FP emulator the above octet order is used. If soft floats are used the usual little endian is used on doubles too. Not sure what the WinCE ABI does.

Oct. 29, 2010

Re: [PATCH 2/3] wer: Add stubs for WerReportCreate + WerReportCloseHandle

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -2,6 +2,7 @@ MODULE = wer.dll > IMPORTLIB = wer > > C_SRCS = \ > - main.c > + main.c \ > + report.c I don't think we need multiple source files at this point. -- Alexandre Julliard julliard(a)winehq.org

Oct. 29, 2010

Re: [2/3] msxml3: Add error code definitions (resend)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6586 Your paranoid android. === WVISTAADM (32 bit domdoc) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Oct. 29, 2010

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

by Greg Geldorp

Hi Chip, > From: Charles Davis > > On 10/27/10 8:43 PM, (Marvin) wrote: > > === WINEBUILD (build) === > > Failure running script in VM: Exceeded timeout limit of 300 sec > > Huh? I've never seen that happen before. I can't tell why my patch would > cause this. Ge? Your thoughts? Your patch contained a change to the configure script. Because of that, the bot rebuilt a lot of stuff. Rebuilding a lot of stuff takes time and caused the timeout limit to be exceeded. I've adjusted the build script to handle changes to configure better. Greg.

Oct. 29, 2010

Re: [1/3] msxml3: Add a function to validate a tree against a schema cache (try 2)

by Nikolay Sivov

On 10/29/2010 10:27, Adam Martinson wrote: > + #if LIBXML_VERSION>= 20621 > + xmlSchemaSetValidStructuredErrors(svctx, validate_serror, NULL); > + #endif I think a common and preferable way is to add configure define and check for presence of this call.

Oct. 29, 2010

Re: advapi32: Implement EnumServicesStatusExA/W.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6585 Your paranoid android. === WINEBUILD (build) === Performing reconfig in include dir Making build dependencies Making test executable Performing reconfig in include dir Making build dependencies Making test executable

Oct. 29, 2010

Re: [PATCH] kernel32/tests: Fix the mixed-case short path test to actually test something.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6579 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

Oct. 28, 2010

Re: [1/4] msxml3/tests: Some encoding switching tests

by Nikolay Sivov

On 10/29/2010 04:31, (Marvin) wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=6578 > > Your paranoid android. > > > === WINEBUILD (build) === > Making test executable > Making test executable This is about some recent changes in bot output/logic. Patch page seems to check for non-empty output to give it an OK mark, now patch list indicates failures while bot job is clean https://testbot.winehq.org/JobDetails.pl?Key=6578 .

Oct. 28, 2010

Re: [1/4] msxml3/tests: Some encoding switching tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6578 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

Oct. 28, 2010

Re: [PATCH 3/3] wer/tests: Add initial tests for WerReportCreate + WerReportCloseHandle

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6575 Your paranoid android. === WINEBUILD (build) === Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable

Oct. 28, 2010

Re: [2/4] msxml3: add a function to validate a tree against a schema cache (resend)

by Adam Martinson

On 10/28/2010 05:42 AM, Alexandre Julliard wrote: > Adam Martinson<amartinson(a)codeweavers.com> writes: > > >> --- >> dlls/msxml3/msxml_private.h | 1 + >> dlls/msxml3/schema.c | 75 >> +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 76 insertions(+), 0 deletions(-) >> > This doesn't build on Leopard (libxml 2.6.16): > > ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm > Undefined symbols: > "_xmlSchemaSetValidStructuredErrors", referenced from: > _SchemaCache_validate_tree in schema.o > ld: symbol(s) not found > > OK, looks like xmlSchemaSetValidStructuredErrors() was added in 2.6.21.

Oct. 28, 2010

Re: usp10/tests: update test_ScriptStringXtoCP_CPtoX to test both rtl and ltr characters

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6574 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

Oct. 28, 2010

Re: Sane.ds units

by Yaron Shahrabani

On Wed, Oct 27, 2010 at 1:31 PM, Marcus Meissner <meissner(a)suse.de> wrote: > On Wed, Oct 27, 2010 at 11:58:22AM +0200, Yaron Shahrabani wrote: > > Can someone please explain the units in the twain module (sane.ds)? > > There are: > > px - pixels > > b - ? (bytes) > > dpi - dots per inch > > mm - milimeters > > % - percent > > ns - ? (nanosecond) > > > > I will add comments to the file so it will be clearer for other > translators, > > thanks! > > Yaron Shahrabani > > It maps Sane defines... > > /usr/include/sane/sane.h: > > SANE_UNIT_NONE = 0, /* the value is unit-less (e.g., # of scans) > */ > SANE_UNIT_PIXEL, /* value is number of pixels */ > SANE_UNIT_BIT, /* value is number of bits */ > SANE_UNIT_MM, /* value is millimeters */ > SANE_UNIT_DPI, /* value is resolution in dots/inch */ > SANE_UNIT_PERCENT, /* value is a percentage */ > SANE_UNIT_MICROSECOND /* value is micro seconds */ > > So apparently "ns" might be wrong, and dpi and mm might be switched even... > > Aric? > I'll be waiting for his comment as well... I must say the ns thing look very suspicious at first look ☺ > > Ciao, Marcus >

Oct. 28, 2010

Re: (resend)[3/4]winegstreamer: add gstreamer mp3 transform filter

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/winegstreamer/gst_guids.h | 1 + > dlls/winegstreamer/gst_private.h | 1 + > dlls/winegstreamer/gsttffilter.c | 125 > ++++++++++++++++++++++++++++++++++++++ > dlls/winegstreamer/main.c | 35 +++++++++++ > 4 files changed, 162 insertions(+), 0 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M qedit.dll -T ../../.. -p qedit_test.exe.so ../../../../wine/dlls/qedit/tests/mediadet.c && touch mediadet.ok mediadet.c:151: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:162: Test failed: IMediaDet_get_StreamMediaType mediadet.c:214: Test failed: IMediaDet_get_StreamMediaType mediadet.c:222: Test failed: IMediaDet_get_FrameRate mediadet.c:223: Test failed: IMediaDet_get_FrameRate mediadet.c:238: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:243: Test failed: IMediaDet_get_OutputStreams mediadet.c:259: Test failed: IMediaDet_put_CurrentStream mediadet.c:264: Test failed: IMediaDet_get_CurrentStream mediadet.c:283: Test failed: IMediaDet_get_StreamMediaType mediadet.c:291: Test failed: IMediaDet_get_CurrentStream make: *** [mediadet.ok] Error 11 -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2010

WineAPI wiki progress

by Max TenEyck Woodbury

The repository summary pages exist but in most cases are incomplete. These pages can serve as a map of the repository contents. There are categories for translations. The category indexes should provide complete lists of identifiable translations for each language. There are summaries of all .spec files with sortable tables. There is a top level index for the APIs with seperate indexes for each initial letter. These are in alphabetical order so it should be possible to determine if Wine knows about a particular API. Indexes for C++ name spaces are scheduled to the next phase of implementation. There is ONE API description page at this point. If any of you would care to look at it and send me comments, I will read them. I will be setting up analytic scripts for the individual API pages after the name space indexes are in place. Max

Oct. 28, 2010

Re: ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6564 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

Oct. 28, 2010

Re: ddraw [try 2]: Add tests for the foreground window set by SetCooperativeLevel

by Alexandre Julliard

David Adam <david.adam.cnrs(a)gmail.com> writes: > + hwnd2=createwindow(); > + hwnd=createwindow(); > + > + if (hwnd) > + { > + skip("Failed to create the main window\n"); > + return; > + } I don't think that's quite what you intended... -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2010

Re: [2/4] msxml3: add a function to validate a tree against a schema cache (resend)

by Nikolay Sivov

On 10/28/2010 14:42, Alexandre Julliard wrote: > Adam Martinson<amartinson(a)codeweavers.com> writes: > >> --- >> dlls/msxml3/msxml_private.h | 1 + >> dlls/msxml3/schema.c | 75 >> +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 76 insertions(+), 0 deletions(-) > This doesn't build on Leopard (libxml 2.6.16): > > ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm > Undefined symbols: > "_xmlSchemaSetValidStructuredErrors", referenced from: > _SchemaCache_validate_tree in schema.o > ld: symbol(s) not found True, it's available starting 2.6.21.

Oct. 28, 2010

Re: [2/4] msxml3: add a function to validate a tree against a schema cache (resend)

by Alexandre Julliard

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/schema.c | 75 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+), 0 deletions(-) This doesn't build on Leopard (libxml 2.6.16): ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm Undefined symbols: "_xmlSchemaSetValidStructuredErrors", referenced from: _SchemaCache_validate_tree in schema.o ld: symbol(s) not found -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2010

Re: [2/2] msxml3: fix XSLPattern namespace handling

by Alexandre Julliard

Adam Martinson <amartinson(a)codeweavers.com> writes: > #define U(str) BAD_CAST str > -#define DBG(str) wine_dbgstr_a((char const*)str) > +#define DBG(args...) wine_dbg_sprintf((char const*)args) > +#define RULE(name, args...) TRACE("Got "#name": %s\n", DBG(args)) Again, you can't use varargs macros. You have a tendency to abuse macros, please try to avoid them as much as possible. In this case, replacing a standard TRACE by a file-specific macro is not an improvement, even if it saves a little typing. People must be able to understand your code without having to look up a ton of obscure #defines. -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2010

Re: loader: On Mac, reserve the process's original thread for the frameworks.

by Alexandre Julliard

Ken Thomases <ken(a)codeweavers.com> writes: > Hold off on this one. I've encountered a strange issue after sending it (that I didn't encounter in earlier testing). > > err:process:start_wineboot failed to start wineboot, err 1359 > > Apparently, there's a failure of an execve() system call in a child > process. It's getting EFAULT. Probably unrelated, but note that in Mac OS until recently, execve failed if there was more than one thread. That's going to break the process startup. -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2010

Re: About the Gallium Direct3D 10/11 work

by abraham vargas moreno

galllund3 how long it takes to have dx 10 and 11 and ubuntu natively, all the world want to have a minimum release date for this wonderful work they are dealing with the DX.

Oct. 28, 2010

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

by Vitaliy Margolen

On 10/27/2010 09:47 PM, Charles Davis wrote: > On 10/27/10 9:21 PM, Vitaliy Margolen wrote: >> On 10/27/2010 07:46 PM, Charles Davis wrote: >>> + /* Now try it on mixed case short names */ >> What's the point of the test anyway? You know that Wine already handles >> all files as case-insensitive. Short file name isn't any different. > Don't blame me; this was AJ's idea. He told me, "you should probably > first write more tests with various case and short names combinations," > when he was critiquing patch 2 in this series. I'm just "following orders." Sorry about that, read AJ's message after writing this e-mail. Boss is always right :) Vitaliy.

Oct. 27, 2010

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

by Charles Davis

On 10/27/10 9:21 PM, Vitaliy Margolen wrote: > On 10/27/2010 07:46 PM, Charles Davis wrote: >> + sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); > Could you please put some spaces after each coma everywhere in your patch? > Please use snprintf(). I was just following the surrounding style. But yeah, I guess I should use snprintf() on a fixed-size buffer. > >> + GetShortPathNameA(buf,shortbuf,MAX_PATH); > Use sizeof(buf) instead of MAX_PATH to guarantee that's what it means. Good point. > >> + hndl = >> CreateFileA(shortbuf,GENERIC_READ|GENERIC_WRITE,0,NULL,OPEN_EXISTING,0,NULL); >> >> + ok(hndl!=INVALID_HANDLE_VALUE,"CreateFileA failed\n"); > It's nice to know LastError and the full filename if it fails. The other tests don't do this. That'll teach me to go against my better judgment. > >> + for(i=0;i<MAX_PATH&& shortbuf[i];i++) > You getting past the filename size in the buffer. > >> + shortbuf[i]=(rand() % 2) ? tolower(shortbuf[i]) : >> toupper(shortbuf[i]); > Please don't use any sort of random stuff in tests. They should always > be the same every time on every platform. I forgot about that rule. I'll change it to alternate upper and lowercase. > >> + /* Now try it on mixed case short names */ > What's the point of the test anyway? You know that Wine already handles > all files as case-insensitive. Short file name isn't any different. Don't blame me; this was AJ's idea. He told me, "you should probably first write more tests with various case and short names combinations," when he was critiquing patch 2 in this series. I'm just "following orders." Chip

Oct. 27, 2010

Re: [PATCH 1/3] configure: Check for the getattrlist() function and the <sys/attr.h> header (resend).

by Vitaliy Margolen

On 10/27/2010 07:46 PM, Charles Davis wrote: > --- a/configure > +++ b/configure Please exclude changes to configure from your patches. AJ regenerates it himself. > @@ -1866,6 +1867,7 @@ AC_CHECK_FUNCS(\ > ftruncate \ > futimes \ > futimesat \ > + getattrlist \ > getdirentries \ > getopt_long \ > getpagesize \ Incorrect indentation - should be a tab, not 4 spaces. Vitaliy.

Oct. 27, 2010

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

by Vitaliy Margolen

On 10/27/2010 07:46 PM, Charles Davis wrote: > + sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); Could you please put some spaces after each coma everywhere in your patch? Please use snprintf(). > + GetShortPathNameA(buf,shortbuf,MAX_PATH); Use sizeof(buf) instead of MAX_PATH to guarantee that's what it means. > + hndl = CreateFileA(shortbuf,GENERIC_READ|GENERIC_WRITE,0,NULL,OPEN_EXISTING,0,NULL); > + ok(hndl!=INVALID_HANDLE_VALUE,"CreateFileA failed\n"); It's nice to know LastError and the full filename if it fails. > + for(i=0;i<MAX_PATH&& shortbuf[i];i++) You getting past the filename size in the buffer. > + shortbuf[i]=(rand() % 2) ? tolower(shortbuf[i]) : toupper(shortbuf[i]); Please don't use any sort of random stuff in tests. They should always be the same every time on every platform. > + /* Now try it on mixed case short names */ What's the point of the test anyway? You know that Wine already handles all files as case-insensitive. Short file name isn't any different. Vitaliy.

Oct. 27, 2010