October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] problem with color management with mscms and gdi

by André Hentschel

Hi and welcome to wine development, your patch is wrapped. see the gdi part of it at http://source.winehq.org/patches/. so you should check your mailclient. Further you might want to split it per module (gdi and mscms, one patch each) -- Best Regards, André Hentschel

Oct. 16, 2010

Re: [PATCH] Compiling Wine at Ubuntu 10.10

by Alexandre Julliard

Gerold Jens Wucherpfennig <gjwucherpfennig(a)gmx.net> writes: > You will need this patch to compile Wine at Ubuntu 10.10, > because of the new Xorg Server 1.9. > If you still get a compilation error in dlls/winex11.drv you > will need to add the flag "-lXxf86vm". We can't do that. What did they change that breaks the build? -- Alexandre Julliard julliard(a)winehq.org

Oct. 16, 2010

Re: [2/6] msxml3: IXMLDOMSchemaCollection/XMLSchemaCache backend

by Nikolay Sivov

On 10/15/2010 18:25, Adam Martinson wrote: > > Implemented on top of libxml's hash table. > --- > dlls/msxml3/schema.c | 376 > +++++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 326 insertions(+), 50 deletions(-) > +static LONG cache_entry_release(cache_entry* entry) > { > - schema_t *This = impl_from_IXMLDOMSchemaCollection( iface ); > + LONG ref = InterlockedDecrement(&entry->ref); > + TRACE("%p new ref %d\n", entry, ref); > > - TRACE("(%p)->(%s %p)\n", This, debugstr_guid( riid ), ppvObject ); > + if (ref == 0) > + { > + if (entry->type == SCHEMA_TYPE_XSD) > + { > + xmldoc_release(entry->doc); > + entry->schema->doc = NULL; > + xmlSchemaFree(entry->schema); > + heap_free(entry); > + } > + else /* SCHEMA_TYPE_XDR */ > + { > + xmldoc_release(entry->doc); > + heap_free(entry); > + } > + } > + return ref; > +} Looks a but redundant. xmldoc_release() and heap_free(entry) are always used, so only xmlSchemaFree() and doc reset before it should be under condition. > + xmlNodePtr root; > + if (schema) > + root = xmlDocGetRootElement(schema); > + if (root&& root->ns) > + { root uninitialized? If this never happens practically then remove if (schema) condition. > - IXMLDOMSchemaCollection_AddRef( iface ); > + IXMLDOMSchemaCollection_AddRef(iface); > > return S_OK; > } > > -static ULONG WINAPI schema_cache_AddRef( IXMLDOMSchemaCollection *iface ) > +static ULONG WINAPI schema_cache_AddRef(IXMLDOMSchemaCollection *iface) No need for such changes here and later in this patch, even some new added lines use white-spaces in such cases. > + IXMLDOMNode* domnode = NULL; > + IDispatch_QueryInterface(V_DISPATCH(&var),&IID_IXMLDOMNode, (void**)&domnode); > + > + if (domnode) > + doc = xmlNodePtr_from_domnode(domnode, XML_DOCUMENT_NODE)->doc; Not sure about that, I'd say it's better to test for hr == S_OK and return value from QueryInterface, is this branch tested?

Oct. 16, 2010

Re: [1/6] msxml3: add a function to initialize xmlDoc->_private data

by Nikolay Sivov

On 10/15/2010 18:25, Adam Martinson wrote: > > Needed to associate an internal ref count, etc with a xmlDoc > outside of domdoc.c, without creating the whole domdoc struct. > --- > dlls/msxml3/domdoc.c | 6 ++++++ > dlls/msxml3/msxml_private.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Why not use this helper in DOMDocument_create() ?

Oct. 16, 2010

[PATCH] Compiling Wine at Ubuntu 10.10

by Gerold Jens Wucherpfennig

You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. If you still get a compilation error in dlls/winex11.drv you will need to add the flag "-lXxf86vm". With kind regards, Gerold Jens Wucherpfennnig

Oct. 16, 2010

Re: [Website] Foundation of the Hebrew website

by James McKenzie

On 10/15/10 8:44 PM, Yaron Shahrabani wrote: > On Fri, Oct 15, 2010 at 10:54 PM, Yaron Shahrabani <sh.yaron(a)gmail.com > <mailto:sh.yaron(a)gmail.com>> wrote: > > On Fri, Oct 15, 2010 at 4:39 PM, James McKenzie > <jjmckenzie51(a)earthlink.net <mailto:jjmckenzie51(a)earthlink.net>> > wrote: > > On 10/11/10 9:28 AM, Yaron Shahrabani wrote: >> Started some translation work, there is still much more >> RTLing work to do so we will settle for an LTR for now and I >> will handle it soon. >> Yaron Shahrabani >> >> <Hebrew translator> >> >> >> >> > Yaron: > > Since the web site works runs on a Web Server, should you not > be building the work RTL rather than LTR? > > Its a bit of a problem because I don't have a platform to run the > website so I can't really RTL myself at the moment... > > I was thinking about RTLing after translating, in my case it would > a little easier (there are things you can't see when the site > appears in a different language including things you don't see..) > > Thanks alot for the offer, I'll start working on the CSS once I'll > see the site working (can we have some additions to the css to the > RTL languages?) > > Kind regards, > Yaron Shahrabani. > > > Just a thought, mind you and it might save work later. > > James McKenzie > > I prepared a screenshot, I can't get this style though since I created > it with Chromium inspector... > Are there any specific CSS files or instructions for RTL site? > I like it, but I'm not a that familiar with where the Wine project wants to go with RTL web pages. That will be up to the web team. If this is how it should look, that is fantastic (great, stupendous, etc.) I did notice that your initial web site was accepted. Congratulations are in order. Questions about the design of the web site should be addressed to the Development team at large and not directly to me from this point forward. James McKenzie

Oct. 16, 2010

Re: [6/6] msxml3: implement schema_cache_addCollection()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

Oct. 16, 2010

Re: [5/6] msxml3: implement schema_cache_remove()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

Oct. 16, 2010

Re: [4/6] msxml3: implement schema_cache_get_length()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6211 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

Oct. 16, 2010

Re: [3/6] msxml3/tests: internal schema doc storage tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6210 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

Oct. 16, 2010

Re: [Website] Foundation of the Hebrew website

by Yaron Shahrabani

On Fri, Oct 15, 2010 at 10:54 PM, Yaron Shahrabani <sh.yaron(a)gmail.com>wrote: > On Fri, Oct 15, 2010 at 4:39 PM, James McKenzie < > jjmckenzie51(a)earthlink.net> wrote: > >> On 10/11/10 9:28 AM, Yaron Shahrabani wrote: >> >> Started some translation work, there is still much more RTLing work to do >> so we will settle for an LTR for now and I will handle it soon. >> Yaron Shahrabani >> >> <Hebrew translator> >> >> >> >> Yaron: >> >> Since the web site works runs on a Web Server, should you not be building >> the work RTL rather than LTR? >> > Its a bit of a problem because I don't have a platform to run the website > so I can't really RTL myself at the moment... > > I was thinking about RTLing after translating, in my case it would a little > easier (there are things you can't see when the site appears in a different > language including things you don't see..) > > Thanks alot for the offer, I'll start working on the CSS once I'll see the > site working (can we have some additions to the css to the RTL languages?) > > Kind regards, > Yaron Shahrabani. > >> >> Just a thought, mind you and it might save work later. >> >> James McKenzie >> > I prepared a screenshot, I can't get this style though since I created it with Chromium inspector... Are there any specific CSS files or instructions for RTL site?

Oct. 15, 2010

Re: [Website] Foundation of the Hebrew website

by Yaron Shahrabani

On Fri, Oct 15, 2010 at 4:39 PM, James McKenzie <jjmckenzie51(a)earthlink.net>wrote: > On 10/11/10 9:28 AM, Yaron Shahrabani wrote: > > Started some translation work, there is still much more RTLing work to do > so we will settle for an LTR for now and I will handle it soon. > Yaron Shahrabani > > <Hebrew translator> > > > > Yaron: > > Since the web site works runs on a Web Server, should you not be building > the work RTL rather than LTR? > Its a bit of a problem because I don't have a platform to run the website so I can't really RTL myself at the moment... I was thinking about RTLing after translating, in my case it would a little easier (there are things you can't see when the site appears in a different language including things you don't see..) Thanks alot for the offer, I'll start working on the CSS once I'll see the site working (can we have some additions to the css to the RTL languages?) Kind regards, Yaron Shahrabani. > > Just a thought, mind you and it might save work later. > > James McKenzie > > > > >

Oct. 15, 2010

Re: Updated Norwegian translation.

by Trygve Vea

2010/10/15 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>: > Fredag 15 oktober 2010 05:05:46 skrev Austin English : >> 2010/10/14 Trygve Vea <trygve.vea(a)gmail.com>: >> > Hello, >> > >> > This is my first patch to Wine - this one fixes some translation >> > errors - and adds some new translations. >> > I hope this is not the last patch I will send to Wine. >> > >> > Any feedback is welcome. >> >> Hello Trygve, >> >> Thanks for the translations. However, patches should be split, 1 patch >> per module. In other words, one patch for dlls/crypt32, one for >> dlls/jscript, and so on. I've sendt new patches, where these are split up. > It's great to see that someone else is contributing to the Norwegian > translation. :) > > Your contribution is of a high quality; I only have a few comments: Thank you for nice feedback, much appreciated :) > General: > > For some files, it looks like you're only changing the character encoding. If > so you should change to UTF-8, and add #pragma code_page(65001) at the > beginning of the file, and then there's no reason to add copyright info. > > In some files you are adding copyright info when you're just fixing one or two > typos. This is not necessary. Noted. I haven't changed the encoding in any of the files, though. The files that are encoded UTF8 already have the #pragma code_page(65001) in there, and the other files are ISO8859-1: tv(a)moe:~/git/wine$ file $(git diff b20e75f5e903e5e785f0e4c6d53efe0cf2cfb74a | egrep '^--- a' | cut -c 7-) dlls/crypt32/crypt32_No.rc: UTF-8 Unicode C program text dlls/cryptdlg/cryptdlg_No.rc: UTF-8 Unicode C program text dlls/jscript/jscript_No.rc: UTF-8 Unicode C program text dlls/msi/msi_No.rc: ISO-8859 C program text dlls/oleaut32/oleaut32_No.rc: ISO-8859 C program text dlls/oledlg/oledlg_No.rc: ISO-8859 C program text dlls/shell32/shell32_No.rc: UTF-8 Unicode C program text dlls/user32/resources/user32_No.rc: ISO-8859 C program text dlls/wineps.drv/wps_No.rc: ISO-8859 C program text programs/wineboot/wineboot_No.rc: UTF-8 Unicode C program text programs/wineconsole/wineconsole_No.rc: ISO-8859 C program text tv(a)moe:~/git/wine$ grep pragma $(git diff b20e75f5e903e5e785f0e4c6d53efe0cf2cfb74a | egrep '^--- a' | cut -c 7-) | awk '{ print $1 }' dlls/crypt32/crypt32_No.rc:#pragma dlls/cryptdlg/cryptdlg_No.rc:#pragma dlls/jscript/jscript_No.rc:#pragma dlls/shell32/shell32_No.rc:#pragma programs/wineboot/wineboot_No.rc:#pragma > jscript > This change should be discarded; in my opinion the original is better > (although I'm biased, since I wrote it :p ) I personally consider terminating and ending a string two different things - hence my change. We may have to agree to disagree (?) :) > msiexec > - "Register MSI Service:\n" \ > + "Registrer MSI tjeneste:\n" \ > You should use a hyphen: MSI-tjeneste > "\t/y\n" \ > - "Unregister MSI Service:\n" \ > + "Avregistrer MSI tjeneste:\n" \ > Same as above > "\t/z\n" \ > - "Display this help:\n" \ > + "Vis denne hjelp:\n" \ > Maybe "Vis denne hjelpeteksten"? You're right. I'll submit a new patch for this. > oleaut32_No.rc > It looks like you're only changing the character encoding? If so you should > change to UTF-8, and add #pragma code_page(65001) at the beginning of the > file. > And in that case, there is no reason to add copyright info. I haven't touched the encoding - it seems that this file might have been automatically converted or something from before, and the correct character 'å' wasn't properly converted. It's a simple correction. > oledlg_No.rc > - IDS_BROWSE "Bla" > + IDS_BROWSE "Bla gjennom" > "Bla gjennom" is indeed a better translation, but in some places I have > shortened the text because buttons are too small. Is this not the case here? As far as I can tell, IDS_BROWSE is only used for the titlebar of the window, which should have room for it. Other translations have also concluded that there is room for 11 characters here. > + IDS_PS_PASTE_LINK_DATA "Setter innholdet fra > utklippstavlen inn i dokumentet som %s. Det kobles til kildefilen s� endrer i > denne ogs� skjer i dokumentet." > "endrer" should be "endringer" (yes, this is also wrong in the original > version :) ) Gotcha'. Will submit a new patch. > shell32_No.rc > - IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'. > \n\nDo you want to replace it?" > + IDS_OVERWRITEFILE_TEXT "Denne mappen inneholder allerede en fil med navn > '%1'.\n\nVil du erstatte den?" > You should use « and » for quotation marks. Even when the English version does not? > - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named > '%1'.\n\n"\ > - "If the files in the destination folder have the same names as files > in the\n"\ > - "selected folder they will be replaced. Do you still want to move or > copy\n"\ > - "the folder?" > + IDS_OVERWRITEFOLDER_TEXT "Denne katalogen inneholder allerede en katalog > med navn '%1'.\n\n"\ > + "Hvis filene i katalogen du kopierer til heter det samme som filene i > katalogen du\n"\ > + "kopierer fra, vil disse bli erstattet. Ønsker du fortsatt å flytte > eller kopiere\n"\ > + "denne mappen?" > You should be conssitent with the translation of "folder". Normally "folder" = > "mappe" and "directory" = "katalog" Agreed, that's a mistake I've made. I'll create a new patch for this. > wineconsole_No.rc > - GROUPBOX "Control", -1, 75, 11, 125, 44, BS_GROUPBOX > - LTEXT "Popup menu", -1, 79, 23, 40, 10 > - AUTOCHECKBOX "&Control", IDC_OPT_CONF_CTRL, 129, 23, 60, 10, WS_TABSTOP > - AUTOCHECKBOX "S&hift", IDC_OPT_CONF_SHIFT, 129, 33, 60, 10, WS_TABSTOP > + GROUPBOX "Kontroll", -1, 75, 11, 125, 44, BS_GROUPBOX > + LTEXT "Popup-meny", -1, 79, 23, 40, 10 > "Popup" is not a Norwegian word. You could simply write "Meny" http://i18n.skulelinux.no/nb/Fellesordl.eng-no.html#popup_menu I like Hurtigmeny. I'll submit a new patch. -- Trygve Vea

Oct. 15, 2010

Re: [Website] Foundation of the Hebrew website

by James McKenzie

On 10/11/10 9:28 AM, Yaron Shahrabani wrote: > Started some translation work, there is still much more RTLing work to > do so we will settle for an LTR for now and I will handle it soon. > Yaron Shahrabani > > <Hebrew translator> > > > > Yaron: Since the web site works runs on a Web Server, should you not be building the work RTL rather than LTR? Just a thought, mind you and it might save work later. James McKenzie

Oct. 15, 2010

RTL in console windows

by Yaron Shahrabani

Hi there guys, My name is Yaron Shahrabani and I'm an active translator of Wine to Hebrew. As probably some of you may know Hebrew is written from right-to-left meaning that the GUI and text rendering should work in a reversed/mirror order as opposed to Latin text. Due to some recent work doen by Alexander (Thanks! AJ, great work!), Hebrew is better supported now by wine GUI mechanism but as a translator I ran into some dillemas about the translation of strings that appear in console window, well apparently this is a tough question. Paul (Vriens) sent me 2 screenshots the other day that showed the way Hebrew is handled by the different command line platforms: The first one is the VTE (Virtual Terminal Emulator) which most of us know as gnome-vte or gnome-terminal, this app emulates a command line interface for X11. As opposed to Konsole (The same app only for KDE) gnome's vte cannot handle Hebrew correctly (is there any need to attach bugs or you'll just believe me?). gnome-terminal can show the Hebrew glyphs but they all appear in reversed order, same thing happens for wine apps that present a command line output (such as reg, ipconfig, etc.) when running via gnome-terminal. The other option to display and work with a CLI app is via wineconsole, since wineconsole does not support Hebrew our of the box we have to install the msttcorefonts package in order to do so. At the second screenshot that Paul sent me with the wineconsole screenshot of reg (I translated the app but since I'm not sure how it will work I haven't submitted it to wine-patches yet but I will send it here if needed) Ive seen some blanks with ":" at the end meaning that the glyphs were missing, few minutes later Paul sent me an updated screenshot after installing the missing glyphs, the Hebrew looked absolutely perfect, the only problem was that the semicolon still appeared to the right of the text instead of to the left (where the sentence ends in Hebrew). So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... I would love to clarify any misclarifications. Thank you all, Kind regards, Yaron Shahrabani <Hebrew translator>

Oct. 15, 2010

Re: oleaut32: Updated Norwegian translation.

by Alexander Nicolaysen Sørnes

Fredag 15 oktober 2010 07:48:17 skrev Trygve Vea : > What is being changed here? Alexander N. Sørnes

Oct. 15, 2010

Re: jscript: Updated Norwegian translation.

by Alexander Nicolaysen Sørnes

Fredag 15 oktober 2010 07:46:51 skrev Trygve Vea : > This should be discarded. I've made some comments to the patch that contained all the translations in one, and the overall quality of the patches is good. Alexander N. Sørnes

Oct. 15, 2010

Re: Updated Norwegian translation.

by Alexander Nicolaysen Sørnes

Fredag 15 oktober 2010 05:05:46 skrev Austin English : > 2010/10/14 Trygve Vea <trygve.vea(a)gmail.com>: > > Hello, > > > > This is my first patch to Wine - this one fixes some translation > > errors - and adds some new translations. > > I hope this is not the last patch I will send to Wine. > > > > Any feedback is welcome. > > Hello Trygve, > > Thanks for the translations. However, patches should be split, 1 patch > per module. In other words, one patch for dlls/crypt32, one for > dlls/jscript, and so on. > > I can't judge the rest, I don't speak Norweigan :-). > > Cheers, > -Austin It's great to see that someone else is contributing to the Norwegian translation. :) Your contribution is of a high quality; I only have a few comments: General: For some files, it looks like you're only changing the character encoding. If so you should change to UTF-8, and add #pragma code_page(65001) at the beginning of the file, and then there's no reason to add copyright info. In some files you are adding copyright info when you're just fixing one or two typos. This is not necessary. Specific: crypt32_No.rc cryptdlg_No.rc It's really nice that you're implroving these ones :) jscript This change should be discarded; in my opinion the original is better (although I'm biased, since I wrote it :p ) msiexec - "Register MSI Service:\n" \ + "Registrer MSI tjeneste:\n" \ You should use a hyphen: MSI-tjeneste "\t/y\n" \ - "Unregister MSI Service:\n" \ + "Avregistrer MSI tjeneste:\n" \ Same as above "\t/z\n" \ - "Display this help:\n" \ + "Vis denne hjelp:\n" \ Maybe "Vis denne hjelpeteksten"? oleaut32_No.rc It looks like you're only changing the character encoding? If so you should change to UTF-8, and add #pragma code_page(65001) at the beginning of the file. And in that case, there is no reason to add copyright info. oledlg_No.rc - IDS_BROWSE "Bla" + IDS_BROWSE "Bla gjennom" "Bla gjennom" is indeed a better translation, but in some places I have shortened the text because buttons are too small. Is this not the case here? + IDS_PS_PASTE_LINK_DATA "Setter innholdet fra utklippstavlen inn i dokumentet som %s. Det kobles til kildefilen s� endrer i denne ogs� skjer i dokumentet." "endrer" should be "endringer" (yes, this is also wrong in the original version :) ) shell32_No.rc - IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'. \n\nDo you want to replace it?" + IDS_OVERWRITEFILE_TEXT "Denne mappen inneholder allerede en fil med navn '%1'.\n\nVil du erstatte den?" You should use « and » for quotation marks. - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ - "If the files in the destination folder have the same names as files in the\n"\ - "selected folder they will be replaced. Do you still want to move or copy\n"\ - "the folder?" + IDS_OVERWRITEFOLDER_TEXT "Denne katalogen inneholder allerede en katalog med navn '%1'.\n\n"\ + "Hvis filene i katalogen du kopierer til heter det samme som filene i katalogen du\n"\ + "kopierer fra, vil disse bli erstattet. Ønsker du fortsatt å flytte eller kopiere\n"\ + "denne mappen?" You should be conssitent with the translation of "folder". Normally "folder" = "mappe" and "directory" = "katalog" wineconsole_No.rc - GROUPBOX "Control", -1, 75, 11, 125, 44, BS_GROUPBOX - LTEXT "Popup menu", -1, 79, 23, 40, 10 - AUTOCHECKBOX "&Control", IDC_OPT_CONF_CTRL, 129, 23, 60, 10, WS_TABSTOP - AUTOCHECKBOX "S&hift", IDC_OPT_CONF_SHIFT, 129, 33, 60, 10, WS_TABSTOP + GROUPBOX "Kontroll", -1, 75, 11, 125, 44, BS_GROUPBOX + LTEXT "Popup-meny", -1, 79, 23, 40, 10 "Popup" is not a Norwegian word. You could simply write "Meny" Alexander N. Sørnes

Oct. 15, 2010

Re: Updated Norwegian translation.

by Austin English

2010/10/14 Trygve Vea <trygve.vea(a)gmail.com>: > Hello, > > This is my first patch to Wine - this one fixes some translation > errors - and adds some new translations. > I hope this is not the last patch I will send to Wine. > > Any feedback is welcome. Hello Trygve, Thanks for the translations. However, patches should be split, 1 patch per module. In other words, one patch for dlls/crypt32, one for dlls/jscript, and so on. I can't judge the rest, I don't speak Norweigan :-). Cheers, -Austin

Oct. 14, 2010

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

by Erich Hoover

If you guys would mind looking over this revised patchset I would greatly appreciate it, I believe I've appropriately included your corrections. Please note that mswsock.h and ws2ipdef.h will be submitted as separate patches. Thanks in advance! Erich Hoover ehoover(a)mines.edu

Oct. 14, 2010

Re: Accessibility in wine

by Seth Shelnutt

Reece, I have to agree with you on the idea of just using UIAutomation and then using the MSAA bridge/proxy for MSAA support in the end. This leaves only one implementation in wine, requires only one to be implemented. It's likely that eventually MSAA will be phased out. Although since MSAA is already partially implemented would it be worth it to finish it up first? Then there would be support for most accessibility application while we work toward UIAutomation support. Tying into ATK/AT-SPI or other a11y protocols so that there is native support for wine and those using it is a great idea! Although I think getting MSAA/UIAutomation is the first step, I think supporting both is a great idea. Another thought is to look at mono accessibility and it's goal of bridging UIAutomation and AT-SPI. I'm not really sure how far along they are or where they have gotten with it, but it should provide some good ideas. I don't think we should rely on it, but using it as a reference can't hurt. -Seth On Tue, Oct 12, 2010 at 10:55 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > > The current wine implementation supports GetRoleText and the like on > oleacc.dll, but does not support IAccessible (MSAA) or UIAutomation > functionality on the Win32 objects (windows, list boxes, text edit > controls, buttons, etc.). > > UIAutomation consists of 4 parts: > 1/ a COM API to the accessibility functionality > 2/ UIAutomation support for all Win32 controls > 3/ an MSAA <=> UIAutomation bridge (for applications that use MSAA) > 4/ a .NET binding to the UIAutomation objects > > To get MSAA working in wine, you will need to (minimally): > 1/ complete the IAccessible core support -- LresultToObject and friends > 2/ add a WM_GETOBJECT handler to all the Win32 controls and expose > IAccessible COM objects (with tests!) > 3/ implement/flesh out the WinEvents API to get the IAccessible > objects for the events > > Given the move to UIAutomation, it would be easier in terms of > implementation to: > 1/ expose UIAutomation objects via the WM_GETOBJECT message > 2/ use the MSAA <=> UIAutomation bridge to support MSAA > > A question here is whether the wine MSAA/WinEvents/UIAutomation > implementation should bind to the Gnome/KDE accessibility APIs > (GAIL/???). The benefit here is that the Windows applications will > integrate into the native Linux a11y technologies. The problems here > are (a) getting Alexandre's buy in to use the GAIL APIs if present and > (b) whether these are going to change in the move over to Gnome3. > > In terms of applications to test, Firefox supports at least MSAA > bindings as do Qt applications. Others will to, to varying degrees > (some relying on the native Win32 support), but FF and Qt implement > their own IAccessible bindings. > > In terms of testing this via applications (in addition to the > regression tests that will need to be provided), there are various > assistive technologies that make use of MSAA/UIAutomation -- JAWS, > Dragon Naturally Speaking, etc. I am not familiar with NVDA. > > - Reece >

Oct. 14, 2010

Re: msi/tests: Move test coverage for standard actions to a separate module.

by Greg Geldorp

> From: Hans Leidekker <hans(a)codeweavers.com> > > This is to get rid of the remaining timeouts on testbot. We now have > a clean test run: > > http://testbot.winehq.org/JobDetails.pl?Key=6167 > > On platforms where we need to create a restore point the install tests > still take over two minutes, so depending on the load on testbot we > might still see some timeouts. This is great! If needed, I can probably turn off System Restore, which disables creation of restore points altogether. Greg.

Oct. 14, 2010

Re: msi/tests: Move test coverage for standard actions to a separate module.

by Hans Leidekker

On Thu, 2010-10-14 at 13:55 +0200, Paul Vriens wrote: > On 10/14/2010 01:12 PM, Hans Leidekker wrote: > > This is to get rid of the remaining timeouts on testbot. We now have > > a clean test run: > > > > http://testbot.winehq.org/JobDetails.pl?Key=6167 > > > > On platforms where we need to create a restore point the install tests > > still take over two minutes, so depending on the load on testbot we > > might still see some timeouts. > > > > Maybe it's a good idea to not use the restore facility on most (all?) of > the testbot servers? Perhaps, but it would be better if we didn't have to tweak our test platforms in order to run the tests reliably. Lets first wait and see how this works out.

Oct. 14, 2010

Re: msi/tests: Move test coverage for standard actions to a separate module.

by Paul Vriens

On 10/14/2010 01:12 PM, Hans Leidekker wrote: > This is to get rid of the remaining timeouts on testbot. We now have > a clean test run: > > http://testbot.winehq.org/JobDetails.pl?Key=6167 > > On platforms where we need to create a restore point the install tests > still take over two minutes, so depending on the load on testbot we > might still see some timeouts. > Maybe it's a good idea to not use the restore facility on most (all?) of the testbot servers? -- Cheers, Paul.

Oct. 14, 2010

RE: [PATCH 4/5] d3d10core: Add a stub ID3D10Texture3D implementation.

by Greg Geldorp

> From: Henri Verbeet > > Looks like the bot is using "patch" instead of "git apply" to apply > patches, and missed the rename in patch 3/5. Yes, you're right. I'll look into it. Greg.

Oct. 14, 2010

Re: [PATCH 4/5] d3d10core: Add a stub ID3D10Texture3D implementation.

by Henri Verbeet

On 14 October 2010 13:05, Marvin <testbot(a)testbot.winehq.org> wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=6168 > > patching file dlls/d3d10core/texture.c > Hunk #1 FAILED at 242. > 1 out of 1 hunk FAILED -- saving rejects to file dlls/d3d10core/texture.c.rej Looks like the bot is using "patch" instead of "git apply" to apply patches, and missed the rename in patch 3/5.

Oct. 14, 2010

Re: msi/tests: Move test coverage for standard actions to a separate module.

by Hans Leidekker

This is to get rid of the remaining timeouts on testbot. We now have a clean test run: http://testbot.winehq.org/JobDetails.pl?Key=6167 On platforms where we need to create a restore point the install tests still take over two minutes, so depending on the load on testbot we might still see some timeouts.

Oct. 14, 2010

Re: [PATCH 4/5] d3d10core: Add a stub ID3D10Texture3D implementation.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6168 Your paranoid android. === WINEBUILD (build) === Patch failed

Oct. 14, 2010

Re: Google Summer of Code Mentors?

by Stefan Dösinger

Am 14.10.2010 um 07:48 schrieb Kai Blin: > The mentor summit is a great opportunity to meet developers from a wide > range of open source projects, it's probably one of the best > cross-sections of open source know-how you can find in a weekend. I can > only recommend going. I can second that. Interesting open source developers from every place and every project. I've been to the summit last year. This year I didn't mentor, my time is limited and I just came back from the bay area, otherwise I'd have taken the opportunity to go to the mentor summit for sure :-)

Oct. 14, 2010

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

by Rolf Kalbermatter

On Tue, Oct 13, 2010 at 16:30 PM, Erich Hoover <ehoover(a)mines.edu> wrote: >> ... >> + int newsize = (int)*maxsize; >> + >> + /* Make sure there is at least enough room for this entry */ >> + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); >> + if (newsize < 0) >> + return 0; >> + *maxsize = (ULONG)newsize; >> Just declare it as a ULONG/size_t so you don't have to cast. > >I can obviously change this around a little bit, but the reason for this conversion is that as a >ULONG the "if (newsize < 0)" comparison is not going to work. Then following code would work better: ULONG newsize = sizeof(WSACMSGHDR) + CMSG_ALIGN(len); /* Make sure there is at least enough room for this entry */ if (newsize > *maxsize) return 0; /* else */ *maxsize -= newsize; Rolf Kalbermatter

Oct. 14, 2010

Re: Google Summer of Code Mentors?

by Kai Blin

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2010-10-14 01:39, Jeremy White wrote: > Did we have an 'official' leader for GSOC this past year? Actually, Maarten was doing all the admin work for Wine this year. > If not, could I ask someone (*cough* Kai *cough*) to nominate themselves? I'm already traveling to the Mentor summit on a Samba slot. > We need to coordinate getting some information to the SFC so that > we can collect the mentor stipend from Google. Technically, everybody who signed up as a mentor with the Google web-app this year can go, no matter if you had a student to mentor or not. We get to send two mentors. The mentor summit is a great opportunity to meet developers from a wide range of open source projects, it's probably one of the best cross-sections of open source know-how you can find in a weekend. I can only recommend going. See http://gsoc-wiki.osuosl.org/index.php/Main_Page#Mentor_Summits for the notes from the last years. Cheers, Kai - -- Kai Blin Worldforge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAky2mYwACgkQEKXX/bF2FpQQRQCfWhBk+2Hzb8XnE1ZEk+AnFa4g wQsAnAikfDsr8MaLAn4m5hfFgfR7LPBD =NlAN -----END PGP SIGNATURE-----

Oct. 14, 2010

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

by Mike Kaplinskiy

On Wed, Oct 13, 2010 at 10:30 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > > Is it acceptable to just add a parameter for WS2_recvfrom() or should > this function get renamed? This function currently mirrors > WSARecvFrom exactly. > Feel free to change the name if you want, I don't have any problems with it (although I can't speak for Alexandre). Mike.

Oct. 13, 2010

Re: Ongoing Debian package maintenance.

by Scott Ritchie

On 10/12/2010 10:59 PM, Austin English wrote: > On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein <shacklein(a)gmail.com> wrote: >> Hello everyone, >> >> My health has not improved at all since my last call for help with the >> Debian package management. I really need someone to take over from me, or at >> least some help to devise a new set of (semi-)automated build scripts. Any >> volunteers? > > Since it appears this hasn't gone anywhere, do you still need a > volunteer? If so, I can, just email me the scripts/other info off > list. > I should step up here and offer to take over the whole thing. I'd like for the Ubuntu and Debian packages to be as identical as possible. Many of the issues are the same as well. I will admit I don't use Debian much but that can easily change. In general Ubuntu developers like for things to be done in Debian when possible, since we share so much. For instance we still don't have a package making use of Wine 1.2's 64 bit support because of the multiarch situation (which I believe is finally starting to turn around now). -Scott

Oct. 13, 2010

Google Summer of Code Mentors?

by Jeremy White

Did we have an 'official' leader for GSOC this past year? If not, could I ask someone (*cough* Kai *cough*) to nominate themselves? We need to coordinate getting some information to the SFC so that we can collect the mentor stipend from Google. Cheers, Jeremy

Oct. 13, 2010

Re: Removal of very very old versions from bugzilla?

by Austin English

On Wed, Oct 13, 2010 at 9:24 PM, Scott Ritchie <scott(a)open-vote.org> wrote: > Wise idea or no? No. It would delete those bugs from bz, unless you move them all to some new version (e.g., 'pre-0.9'), but that would cause a ton of spam for no good reason. > If not is there at least a way to hide them from the report bug page? > I'm talking about the 2001-era version numbers, before 0.9 even. I'm not sure if bugzilla allows it, but I'd say it's a good idea if possible (I assume you mean the page to file new bugs?). -- -Austin

Oct. 13, 2010

Removal of very very old versions from bugzilla?

by Scott Ritchie

Wise idea or no? If not is there at least a way to hide them from the report bug page? I'm talking about the 2001-era version numbers, before 0.9 even. -Scott Ritchie

Oct. 13, 2010

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

by Erich Hoover

On Tue, Oct 12, 2010 at 10:12 PM, Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> wrote: > ... > + int newsize = (int)*maxsize; > + > + /* Make sure there is at least enough room for this entry */ > + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); > + if (newsize < 0) > + return 0; > + *maxsize = (ULONG)newsize; > Just declare it as a ULONG/size_t so you don't have to cast. I can obviously change this around a little bit, but the reason for this conversion is that as a ULONG the "if (newsize < 0)" comparison is not going to work. > ... > + memset(cmsg_win, 0x00, sizeof(WSACMSGHDR)); /* Don't use garbage > data if no headers are found */ > I think in general that is discouraged at wine (don't quote me on > that). You should just initialize the values manually. This is actually superfluous (gone in next revision), as if no headers are found the length returned is zero. > + msg->dwFlags |= WINE_MSG_HASCTRL; > + memcpy(buftmp, msg->lpBuffers, msg->dwBufferCount * sizeof(WSABUF)); > + buftmp[msg->dwBufferCount] = msg->Control; > + ret = WS2_recvfrom( s, buftmp, msg->dwBufferCount, lpNumberOfBytesRecvd, > + &msg->dwFlags, msg->name, &msg->namelen, > + lpOverlapped, lpCompletionRoutine ); > You shouldn't add internal flags like that. Just rewrite WS2_recvfrom > to allow returning message headers instead of hacking around it. Is it acceptable to just add a parameter for WS2_recvfrom() or should this function get renamed? This function currently mirrors WSARecvFrom exactly. > + s1=socket(AF_INET, SOCK_DGRAM, 0); > + ok(s1!=INVALID_SOCKET, "socket() failed error: %d\n", > WSAGetLastError()); > Spaces around = & != would make me happy (and below). Also you don't > error out correctly if socket creation fails. I was trying to match test_so_reuseaddr(), I'll change this. Erich Hoover ehoover(a)mines.edu

Oct. 13, 2010

Re: [PATCH] jscript/tests: add tests for ActiveScriptSite_OnScriptError and IActiveScriptError. [try 3]

by Reece Dunn

On 9 October 2010 15:51, Reece Dunn <msclrhd(a)googlemail.com> wrote: > try 1 -- initial series (1-3) > try 2 -- revised test infrastructure based on Jacek's comments > try 3 -- fleshed out the tests to complete the test coverage for > IActiveScriptError Any reason this has not been committed yet? Thanks, - Reece

Oct. 13, 2010

Re: [5/5] msi/tests: Don't create a nested restore point on recent versions of MSI.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6155 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout === W2K3R2SESP2 (32 bit install) === Timeout

Oct. 13, 2010

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory. (try 2)

by Alexandre Julliard

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This shouldn't introduce a failure if Mono is missing. I'm afraid it does: ../../../tools/runtest -q -P wine -M fusion.dll -T ../../.. -p fusion_test.exe.so fusion.c && touch fusion.ok wine: Install the Windows version of Mono to run .NET executables fusion.c:193: Test failed: Expected S_OK, got 80131700 fusion.c:194: Test failed: Expected "C:\windows\assembly\NativeImages_el32.dll_32", got "nochange" make: *** [fusion.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Oct. 13, 2010

Re: Ongoing Debian package maintenance.

by Austin English

On Tue, Oct 12, 2010 at 11:28 PM, Lei Zhang <thestig(a)google.com> wrote: > On Tue, Oct 12, 2010 at 10:59 PM, Austin English > <austinenglish(a)gmail.com> wrote: >> On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein <shacklein(a)gmail.com> wrote: >>> Hello everyone, >>> >>> My health has not improved at all since my last call for help with the >>> Debian package management. I really need someone to take over from me, or at >>> least some help to devise a new set of (semi-)automated build scripts. Any >>> volunteers? >> >> Since it appears this hasn't gone anywhere, do you still need a >> volunteer? If so, I can, just email me the scripts/other info off >> list. > > I've been busy, and I never got Ben's debian/ directory. If you can, that'd be good. I use my debian machine rarely, but a cron job wouldn't be hard. There's been a few users in #winehq recently asking about debian/wine, so thought I'd try to bump it along... -- -Austin

Oct. 13, 2010

Re: Ongoing Debian package maintenance.

by Lei Zhang

On Tue, Oct 12, 2010 at 10:59 PM, Austin English <austinenglish(a)gmail.com> wrote: > On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein <shacklein(a)gmail.com> wrote: >> Hello everyone, >> >> My health has not improved at all since my last call for help with the >> Debian package management. I really need someone to take over from me, or at >> least some help to devise a new set of (semi-)automated build scripts. Any >> volunteers? > > Since it appears this hasn't gone anywhere, do you still need a > volunteer? If so, I can, just email me the scripts/other info off > list. I've been busy, and I never got Ben's debian/ directory.

Oct. 13, 2010

Re: Ongoing Debian package maintenance.

by Austin English

On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein <shacklein(a)gmail.com> wrote: > Hello everyone, > > My health has not improved at all since my last call for help with the > Debian package management. I really need someone to take over from me, or at > least some help to devise a new set of (semi-)automated build scripts. Any > volunteers? Since it appears this hasn't gone anywhere, do you still need a volunteer? If so, I can, just email me the scripts/other info off list. Thanks! Austin

Oct. 13, 2010

RFC: Fixing imagelist control tests for 16bpp

by Austin Lund

It seems that the imagelist control on XP has some strange device dependence even though the tests use device independent bitmaps. Attached is a patch to try and correct the test for what is broken. Is this the right approach?

Oct. 13, 2010

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

by Mike Kaplinskiy

On Tue, Oct 12, 2010 at 8:01 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > While searching for something else I discovered a bug relevant to the > interface-bound UDP broadcast patches I've been working on. Apparently, > IP_PKTINFO does work on Windows when used with the special WSARecvMsg > function (Bug #19493). The attached patch addresses this issue by > implementing WSARecvMsg through WS2_recvfrom and by converting the Unix > IP_PKTINFO response to the Windows equivalent. > ChangeLog: > ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO. > > > > Sorry I must have missed the RFC when reading my mail. These comments are purely mine, and may not have any value for getting your patch in :). +static inline WSACMSGHDR *create_control_message(int level, int type, WSACMSGHDR *current, ULONG *maxsize, void *data, int len) This doesn't seem like a "create", more like a "fill" or "write". + int newsize = (int)*maxsize; + + /* Make sure there is at least enough room for this entry */ + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); + if (newsize < 0) + return 0; + *maxsize = (ULONG)newsize; Just declare it as a ULONG/size_t so you don't have to cast. +static inline int convert_control_headers(struct msghdr *hdr, ULONG *maxsize) You shouldn't mix using memory as unix-style CMSGs and windows-style CMSGs. Just allocate something to store the unix messages, read them in and convert them into the user-passed buffer. This seems similar to what we do for address conversion. + memset(cmsg_win, 0x00, sizeof(WSACMSGHDR)); /* Don't use garbage data if no headers are found */ I think in general that is discouraged at wine (don't quote me on that). You should just initialize the values manually. + if (wsa->control && !convert_control_headers(&hdr, wsa->controllen)) + { + /* Insufficient room for control headers */ + errno = EINVAL; + return -1; + } This should probably be in an #ifdef of some sort. + msg->dwFlags |= WINE_MSG_HASCTRL; + memcpy(buftmp, msg->lpBuffers, msg->dwBufferCount * sizeof(WSABUF)); + buftmp[msg->dwBufferCount] = msg->Control; + ret = WS2_recvfrom( s, buftmp, msg->dwBufferCount, lpNumberOfBytesRecvd, + &msg->dwFlags, msg->name, &msg->namelen, + lpOverlapped, lpCompletionRoutine ); You shouldn't add internal flags like that. Just rewrite WS2_recvfrom to allow returning message headers instead of hacking around it. +static int (WINAPI *pWSARecvMsg)(SOCKET,LPWSAMSG,LPDWORD,LPWSAOVERLAPPED,LPWSAOVERLAPPED_COMPLETION_ROUTINE) = 0; +GUID WSARecvMsg_GUID = WSAID_WSARECVMSG; For one reason or another the convention is to get it during your test function (see AcceptEx & ConnectEx). (This does have some merit as SIO_GET_EXTENSION_FUNCTION_POINTER can vary with the socket that's passed) + s1addr.sin_family = AF_INET; + s1addr.sin_port = htons(9375); + s2addr.sin_family = AF_INET; + s2addr.sin_port = htons(9375); You should probably bind to 0 and then use getsockname to get the actual port you bound to. + s1=socket(AF_INET, SOCK_DGRAM, 0); + ok(s1!=INVALID_SOCKET, "socket() failed error: %d\n", WSAGetLastError()); Spaces around = & != would make me happy (and below). Also you don't error out correctly if socket creation fails. diff --git a/include/mswsock.h b/include/mswsock.h index 322ab20..5749e59 100644 --- a/include/mswsock.h +++ b/include/mswsock.h This should be a separate patch. diff --git a/include/ws2ipdef.h b/include/ws2ipdef.h index 11b3689..ec0b85a 100644 --- a/include/ws2ipdef.h +++ b/include/ws2ipdef.h Same here. Mike.

Oct. 12, 2010

Re: [transl] Deal with WS_EX_LAYOUTRTL for RTL languages

by Yaron Shahrabani

On Tue, Oct 12, 2010 at 11:08 AM, Paul Vriens <paul.vriens.wine(a)gmail.com>wrote: > Hi, > > This patch makes sure that a missing WS_EX_LAYOUTRTL for EXSTYLE is flagged > for RTL languages and that it's ignored if present. > > It's not ideal yet as the potential errors shown on the webpage do not > fully explain the issue/error. More changes are needed to get that into > place but this patch at least makes sure that the real errors are catched > and don't get lost in the multitude of errors we have now (for Hebrew for > example). > > Changelog > Deal with WS_EX_LAYOUTRTL for RTL languages > Hey Paul, I think these should apply to several other languages: Divehi Syriac Urdu (There are several other languages but I took the following out of the following list: http://source.winehq.org/transl/) Another language which I'm not sure about is Pujabi since it has 3 popular scripts: Gurmukhi and Devanagari are RTL written while Shahmukhi is RTL, Wikipedia in written in the RTL script while Ubuntu is translated using the LTR scripts (can't determine which though). Its all about location, Pakistanies are writing in RTL whille all others write with the LTR scripts, It all depends on who you ask :) Your patch to the translation check is working great, thanks alot! Yaron Shahrabani <Hebrew translator> > > -- > Cheers, > > Paul. > > > >

Oct. 12, 2010

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory.

by Vincent Povirk

Hang on, this one will also introduce a failure. On Tue, Oct 12, 2010 at 12:51 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

Oct. 12, 2010

Re: [PATCH 5/5] shlwapi/tests: Add more tests

by Piotr Caban

On 10/12/10 16:56, (Marvin) wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? My tests are not introducing new failures.

Oct. 12, 2010

Re: [PATCH 5/5] shlwapi/tests: Add more tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6118 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1793: Test failed: got 29 ordinal.c:1843: Test failed: got 29 ordinal.c:1851: Test failed: got 29 ordinal.c:1859: Test failed: got 40, length 41 ordinal.c:1870: Test failed: got 43 === W7PROX64 (64 bit ordinal) === ordinal.c:1787: Test failed: got 10 ordinal.c:1808: Test failed: got 7 ordinal.c:1821: Test failed: got 10 ordinal.c:1829: Test failed: got 10 ordinal.c:1859: Test failed: got 36, length 37 ordinal.c:1870: Test failed: got 39 ordinal.c:1881: Test failed: got 21 ordinal.c:1892: Test failed: got 24

Oct. 12, 2010

Re: Accessibility in wine

by Reece Dunn

On 12 October 2010 14:21, Seth Shelnutt <shelnutt2(a)gmail.com> wrote: > I can't seem to find much info on this. What is wine's support for MSAA or > the newer UIAutomation? I see that there is the oleacc dll which is the main > dll for MSAA. According to the API site, is seems there are still 10 stubs. > Looking at the source code there hasn't been any updates in over a year. We > don't have the UIAutomation dll yet. Does anyone know the status of > MSAA/UIAutomation support in wine? > > I'm trying to get NVDA working and still running into some issues with it > requiring UIAutomation.dll, when according to them, that dll is optional. > After I get that worked out I'm hoping to see what needs to be done to get > MSAA supported under wine. The current wine implementation supports GetRoleText and the like on oleacc.dll, but does not support IAccessible (MSAA) or UIAutomation functionality on the Win32 objects (windows, list boxes, text edit controls, buttons, etc.). UIAutomation consists of 4 parts: 1/ a COM API to the accessibility functionality 2/ UIAutomation support for all Win32 controls 3/ an MSAA <=> UIAutomation bridge (for applications that use MSAA) 4/ a .NET binding to the UIAutomation objects To get MSAA working in wine, you will need to (minimally): 1/ complete the IAccessible core support -- LresultToObject and friends 2/ add a WM_GETOBJECT handler to all the Win32 controls and expose IAccessible COM objects (with tests!) 3/ implement/flesh out the WinEvents API to get the IAccessible objects for the events Given the move to UIAutomation, it would be easier in terms of implementation to: 1/ expose UIAutomation objects via the WM_GETOBJECT message 2/ use the MSAA <=> UIAutomation bridge to support MSAA A question here is whether the wine MSAA/WinEvents/UIAutomation implementation should bind to the Gnome/KDE accessibility APIs (GAIL/???). The benefit here is that the Windows applications will integrate into the native Linux a11y technologies. The problems here are (a) getting Alexandre's buy in to use the GAIL APIs if present and (b) whether these are going to change in the move over to Gnome3. In terms of applications to test, Firefox supports at least MSAA bindings as do Qt applications. Others will to, to varying degrees (some relying on the native Win32 support), but FF and Qt implement their own IAccessible bindings. In terms of testing this via applications (in addition to the regression tests that will need to be provided), there are various assistive technologies that make use of MSAA/UIAutomation -- JAWS, Dragon Naturally Speaking, etc. I am not familiar with NVDA. - Reece

Oct. 12, 2010