October 2010 - Wine-Devel - list.winehq.org

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 5)

by Rudolf Mayerhofer

On Friday 08 October 2010 14:26:28 Alexandre Julliard wrote: > Rudolf Mayerhofer <rm(a)eightyfive.net> writes: > > +/*********************************************************************** > > + * Several methods to retrieve data from SysFS (/sys) > > + * used to retrieve cached_lpi in fill_cpu_info() > > + */ > > +static int sysfs_cpu_exists(int cpu) > > +{ > > + char buf[256]; > > + > > + sprintf(buf, "/sys/devices/system/cpu/cpu%d", cpu); > > + return access(buf, F_OK) == 0; > > +} > > + > > +static int sysfs_cpucache_exists(int cpu, int cache) > > +{ > > + char buf[256]; > > + > > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/cache/index%d", cpu, > > cache); + return access(buf, F_OK) == 0; > > +} > > + > > +static int sysfs_numanode_exists(int node) > > +{ > > + char buf[256]; > > + > > + sprintf(buf, "/sys/devices/system/node/node%d", node); > > + return access(buf, F_OK) == 0; > > +} > > Don't do that sort of thing. You should handle failures to open the > files at the point where you need them instead of doing redundant > checks. That's not the case here, these checks are simply to find out if a cpu,cpu cache or numa node index exists in SysFS. It just makes no sense to try to parse all of the stuff for a specific cpu index if it does not exist in the first place and this is the check for that (it's done the same way as lscpu from util-linux-ng does it). All the parsing functions have their own error handling as well.

Oct. 8, 2010

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 5)

by Alexandre Julliard

Rudolf Mayerhofer <rm(a)eightyfive.net> writes: > +/*********************************************************************** > + * Several methods to retrieve data from SysFS (/sys) > + * used to retrieve cached_lpi in fill_cpu_info() > + */ > +static int sysfs_cpu_exists(int cpu) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d", cpu); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_cpucache_exists(int cpu, int cache) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/cache/index%d", cpu, cache); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_numanode_exists(int node) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/node/node%d", node); > + return access(buf, F_OK) == 0; > +} Don't do that sort of thing. You should handle failures to open the files at the point where you need them instead of doing redundant checks. -- Alexandre Julliard julliard(a)winehq.org

Oct. 8, 2010

Re: [PATCH 2/2 (try2)] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > try2: Rebase on top of [1/2]. > > dlls/shlwapi/tests/url.c | 4 ++++ > dlls/shlwapi/url.c | 6 ++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok cryptnet.c:353: Test failed: File URLs not supported make: *** [cryptnet.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Oct. 8, 2010

Re: crypt32: Avoid relying on PATH_MAX in import_certs_from_dir helper.

by Austin English

On Thu, Oct 7, 2010 at 6:56 PM, Andrew Nguyen <anguyen(a)codeweavers.com> wrote: > > PATH_MAX is not guaranteed to be available on all platforms, and it is > inadequate as a hardcoded buffer size anyway. Also fixes the first compiler error on GNU Hurd. Thanks Andrew! -- -Austin

Oct. 8, 2010

Re: New winetricks 20101008: new verbs abiword, dsound, nvidiasdk9, vd, xinput

by Austin English

On Thu, Oct 7, 2010 at 6:41 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > On Fri, Oct 8, 2010 at 1:51 AM, Dan Kegel <dank(a)kegel.com> wrote: >> - refuse to run in 64-bit WINEPREFIX's > > What's the reasoning behind this? (eg what's broken?) A lot of stuff is broken. E.g., it assumes that system32 is the proper place for 32-bit dlls, installers are always the 32-bit versions (some of which won't run on a 64-bit windows OS), etc. Until Dan or I have time to fix it, it's easier to disable it. Patches welcome, of course. -- -Austin

Oct. 7, 2010

Re: [4/4] msxml3/httprequest: Implement ::get_responseBody()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5972 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1

Oct. 7, 2010

Re: New winetricks 20101008: new verbs abiword, dsound, nvidiasdk9, vd, xinput

by Jerome Leclanche

On Fri, Oct 8, 2010 at 1:51 AM, Dan Kegel <dank(a)kegel.com> wrote: > - refuse to run in 64-bit WINEPREFIX's What's the reasoning behind this? (eg what's broken?) J. Leclanche

Oct. 7, 2010

Re: [2/4] msxml3/httprequest: Implement ::abort()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5971 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1

Oct. 7, 2010

New winetricks 20101008: new verbs abiword, dsound, nvidiasdk9, vd, xinput

by Dan Kegel

Another fortnight-and-a-half, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20100917: Austin English: - add dsound verb. (Issue 175) - add xinput verb - dxsdk_nov2006, add support for quiet install. - fix dotnet installs for wine 1.2 (broken in recent winetricks release) - introduce $appdata_win/$appdata_unix variables, use it for Safari - refuse to run in 64-bit WINEPREFIX's - remove deprecated pbuffer option - update eadm sha1sum - update flash sha1sums - update kde to 0.9.7-0 - update utorrent sha1sum/url Dan Kegel: - add nvidiasdk9 - remove bogus msvcr80 installed by dotnet20; fixes issue 164. - use symbolic variable uniformly in set_videomemorysize - add abiword, ie6_full - fix two spots WINETRICKS_TMP wasn't quoted; this broke WINEPREFIXes containing spaces. Reported by Roberto Neri. - add vd=1024x768, vd=off options. Fixes bug 172. Scott Ritchie: - new verb cjkfonts (individual verb names may still change) - Add Quicktime 7.6, update quicktimes to depend on vcrun2005 Erik Inge Bolsø - reenable mscoree after directx9 install; fixes issue 25.

Oct. 7, 2010

Re: [PATCH 1/3] jscript: test that ActiveScriptSite_OnScriptError is called on script failure. (resend)

by Jacek Caban

On 10/7/10 4:22 PM, Reece Dunn wrote: > On 7 October 2010 14:35, Jacek Caban<jacek(a)codeweavers.com> wrote: >> Hi Reece, >> >> These tests need more thoughts. They should show how jscript exceptions are >> translated into IActiveScriptError. Your code doesn't provide mechanism to >> do so, so I would suggest to wait with sending patches that don't move us >> any forward until you have a clue how it should work. Otherwise you will >> have to deal with eventually bad decisions for no good reason. > Ok, so if I keep the current tests/ActiveScriptSite as they are and > have something like: > > test_script_error(source, scode, description, lineno, charpos, linesource) { > EXPECT CALL ActiveScriptSite_OnScriptError > hres = parse_script_with_error(source); > ok(hres == 0x8012345, ...) > > CHECK CALL ActiveScriptSite_OnScriptError > ok(script_excep.scode == scode, ...) > ok(script_excep.bstrDescription == description, ...) > ok(script_lineno == lineno, ...) > ok(script_charpos == charpos, ...) > ok(script_linesource == linesource, ...) > } > > test_script_errors() { > test_script_error("var foo = new Object();\nfoo.bar;", > 0x8012345, "Object does not support this property", 20, 11, > "foo.bar;") > test_script_error("new<>%^^;", 0x8012322, "Syntax error", 0, 0, > "new<>%^^;") > ... > } > > where parse_script_with_error does the same thing as parse_script, but > uses an ActiveScriptSite implementation that checks OnScriptError > calls and stores the IActiveScriptError object for testing within > test_script_error (like with my 3rd patch, but checking specific > values). > > 1/ Does this look like a sensible approach to you? Yes, this idea sounds good. > 2/ Do we care about the tests working on non-English locales (not > sure how to get the above working on other languages -- specifically > the description text)? Yes, we care. The easiest way to handle it is checking the locale and skipping tests on non-English locales. > 3/ Are we ok with making wine match the error description strings > exactly, given the above tests? We don't really care if strings are exactly the same. It would be nice, however, to test them and the only sane way I can see to achieve it is by making them exactly the same as native and comparing to expected value. I'd expect these values to be the same as in jscript *Error objects, so I'd prefer to extend api.js to check strings. In C part we could make this test optional and use it in very few places just to make sure it matches jscript-visible values. Jacek

Oct. 7, 2010

Re: [PATCH 1/2] shlwapi/tests: Mark Win98 failures as broken

by Jacek Caban

Hi Andrew, Can we please find a way to detect such old (broken) shlwapi and just skip the whole test (preferable all tests in the file)? Failing UrlGetPart would do the trick, hopefully there is better way. This will result in cleaner code and will save us time in future. Jacek

Oct. 7, 2010

Re: ntdll: fix compile on systems without termios.port.c_ispeed/termios.port.c_ospeed structs

by Austin English

On Thu, Oct 7, 2010 at 3:48 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Austin English <austinenglish(a)gmail.com> writes: > >> @@ -498,7 +498,7 @@ static NTSTATUS set_baud_rate(int fd, const SERIAL_BAUD_RATE* sbr) >> return STATUS_NOT_SUPPORTED; >> #endif /* Don't have linux/serial.h or lack TIOCSSERIAL */ >> } >> -#elif !defined(__EMX__) >> +#elif !defined(__EMX__) && defined (_HAVE_STRUCT_TERMIOS_C_ISPEED) && defined (_HAVE_STRUCT_TERMIOS_C_OSPEED) >> switch (sbr->BaudRate) >> { >> case 0: port.c_ospeed = B0; break; > > You'd want to use the cflag method in this case. Which platform needs this? Hm, I'll have to look into that. It's for GNU Hurd, compile is broken without it. I've got a few other patches for it as well, that need cleaning first. -- -Austin

Oct. 7, 2010

Mentor summit for Google Summer of Code - time sensitive

by Jeremy White

As a heads up, Bradley reminds me that the Mentor summit for GSOC: http://gsoc-wiki.osuosl.org/index.php/2010 is coming up; the registration deadline is tomorrow. Google may reimburse travel expenses, so if cost is an issue, we may be able to help with that. If you need such help, let me know, and I'll connect you with Bradley. Cheers, Jeremy

Oct. 7, 2010

Re: [6/6]strmbase: Implement BaseFilter in strmbase

by Aric Stewart

Ok I think I know what is going on. I have some later patches that i think need to be merged into this one and then separated at a different place. -aric On 10/7/10 9:07 AM, Alexandre Julliard wrote: > Aric Stewart<aric(a)codeweavers.com> writes: > >> --- >> dlls/qcap/vfwcapture.c | 134 +++++-------------------- >> dlls/quartz/acmwrapper.c | 20 ++-- >> dlls/quartz/avidec.c | 12 +- >> dlls/quartz/avisplit.c | 6 +- >> dlls/quartz/dsoundrender.c | 223 >> ++++++++++++------------------------------- >> dlls/quartz/filesource.c | 129 +++++-------------------- >> dlls/quartz/mpegsplit.c | 4 +- >> dlls/quartz/nullrenderer.c | 177 ++++++++-------------------------- >> dlls/quartz/parser.c | 156 ++++++++++-------------------- >> dlls/quartz/parser.h | 9 +-- >> dlls/quartz/transform.c | 201 ++++++++------------------------------- >> dlls/quartz/transform.h | 10 +-- >> dlls/quartz/videorenderer.c | 226 >> +++++++++++++------------------------------ >> dlls/quartz/waveparser.c | 4 +- >> dlls/strmbase/Makefile.in | 1 + >> dlls/strmbase/filter.c | 158 ++++++++++++++++++++++++++++++ >> include/wine/strmbase.h | 23 +++++ >> 17 files changed, 517 insertions(+), 976 deletions(-) >> create mode 100644 dlls/strmbase/filter.c > > I'm seeing occasional crashes in the qedit:mediadet test with this > patch. Unfortunately the debugger fails to get a backtrace. >

Oct. 7, 2010

Re: wine_call_on_stack Sparc Edition

by André Hentschel

Oops, wrong address, sry for the noise -- Best Regards, André Hentschel

Oct. 7, 2010

Re: ntdll: fix compile on systems without termios.port.c_ispeed/termios.port.c_ospeed structs

by Alexandre Julliard

Austin English <austinenglish(a)gmail.com> writes: > @@ -498,7 +498,7 @@ static NTSTATUS set_baud_rate(int fd, const SERIAL_BAUD_RATE* sbr) > return STATUS_NOT_SUPPORTED; > #endif /* Don't have linux/serial.h or lack TIOCSSERIAL */ > } > -#elif !defined(__EMX__) > +#elif !defined(__EMX__) && defined (_HAVE_STRUCT_TERMIOS_C_ISPEED) && defined (_HAVE_STRUCT_TERMIOS_C_OSPEED) > switch (sbr->BaudRate) > { > case 0: port.c_ospeed = B0; break; You'd want to use the cflag method in this case. Which platform needs this? -- Alexandre Julliard julliard(a)winehq.org

Oct. 7, 2010

Re: [PATCH 1/3] jscript: test that ActiveScriptSite_OnScriptError is called on script failure. (resend)

by Reece Dunn

On 7 October 2010 14:35, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Reece, > > These tests need more thoughts. They should show how jscript exceptions are > translated into IActiveScriptError. Your code doesn't provide mechanism to > do so, so I would suggest to wait with sending patches that don't move us > any forward until you have a clue how it should work. Otherwise you will > have to deal with eventually bad decisions for no good reason. Ok, so if I keep the current tests/ActiveScriptSite as they are and have something like: test_script_error(source, scode, description, lineno, charpos, linesource) { EXPECT CALL ActiveScriptSite_OnScriptError hres = parse_script_with_error(source); ok(hres == 0x8012345, ...) CHECK CALL ActiveScriptSite_OnScriptError ok(script_excep.scode == scode, ...) ok(script_excep.bstrDescription == description, ...) ok(script_lineno == lineno, ...) ok(script_charpos == charpos, ...) ok(script_linesource == linesource, ...) } test_script_errors() { test_script_error("var foo = new Object();\nfoo.bar;", 0x8012345, "Object does not support this property", 20, 11, "foo.bar;") test_script_error("new <>%^^;", 0x8012322, "Syntax error", 0, 0, "new <>%^^;") ... } where parse_script_with_error does the same thing as parse_script, but uses an ActiveScriptSite implementation that checks OnScriptError calls and stores the IActiveScriptError object for testing within test_script_error (like with my 3rd patch, but checking specific values). 1/ Does this look like a sensible approach to you? 2/ Do we care about the tests working on non-English locales (not sure how to get the above working on other languages -- specifically the description text)? 3/ Are we ok with making wine match the error description strings exactly, given the above tests? NOTE: 2 and 3 can be avoided by just checking the scode and checking that the description is set and non-NULL (as per my 3rd patch). > Also merging parsing_htmlscript is not a good idea. Its purpose is different > than parse_script. Ok, I'll keep them separate. - Reece

Oct. 7, 2010

Re: [6/6]strmbase: Implement BaseFilter in strmbase

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/vfwcapture.c | 134 +++++-------------------- > dlls/quartz/acmwrapper.c | 20 ++-- > dlls/quartz/avidec.c | 12 +- > dlls/quartz/avisplit.c | 6 +- > dlls/quartz/dsoundrender.c | 223 > ++++++++++++------------------------------- > dlls/quartz/filesource.c | 129 +++++-------------------- > dlls/quartz/mpegsplit.c | 4 +- > dlls/quartz/nullrenderer.c | 177 ++++++++-------------------------- > dlls/quartz/parser.c | 156 ++++++++++-------------------- > dlls/quartz/parser.h | 9 +-- > dlls/quartz/transform.c | 201 ++++++++------------------------------- > dlls/quartz/transform.h | 10 +-- > dlls/quartz/videorenderer.c | 226 > +++++++++++++------------------------------ > dlls/quartz/waveparser.c | 4 +- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/filter.c | 158 ++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 23 +++++ > 17 files changed, 517 insertions(+), 976 deletions(-) > create mode 100644 dlls/strmbase/filter.c I'm seeing occasional crashes in the qedit:mediadet test with this patch. Unfortunately the debugger fails to get a backtrace. -- Alexandre Julliard julliard(a)winehq.org

Oct. 7, 2010

Re: psapi/tests: get rid of an ugly test macro

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=108

Oct. 7, 2010

Re: [PATCH] d3d9/tests: Fix test failure for IDirect3D9::CreateDevice in test_set_stream_source

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === W2K8SE (32 bit device) === device.c:2474: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2612: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (32 bit device) === device.c:2474: Test failed: Expected foreground window 0002019A, got 00010092. device.c:2612: Test failed: Expected foreground window 0003019A, got 00010092.

Oct. 7, 2010

Re: usp10: when checking font for shaping the font needs at least 1 of the features but does not need all.

by Dmitry Timoshkov

Aric Stewart <aric(a)codeweavers.com> wrote: > - while (ShapingData[psa->eScript].requiredFeatures[i]) > + while (ShapingData[psa->eScript].requiredFeatures[i] && !found) > { > feature = load_GSUB_feature(hdc, psa, psc, ShapingData[psa->eScript].requiredFeatures[i]); > - if (!feature) > - return USP_E_SCRIPT_NOT_IN_FONT; > + if (feature) > + found = TRUE; Why not return S_OK right away here, and return USP_E_SCRIPT_NOT_IN_FONT right after the while loop? That would eliminate a need for an intermediate variable and simplify the code. -- Dmitry.

Oct. 6, 2010

Test failures on Windows XP Japanese due to fonts selection differences

by Austin Lund

There are a number of test failures due to hardcoded sizes in test which fail for particular platforms, e.g. http://test.winehq.org/data/6e89a61446088dbe029913896dfae467bb8d37a1/xp_wtb… It seems the reason for this is that it is impossible to select the system font with height 16 on this platform. (No idea why, any ideas?) Should these tests be written so that a particular font selection is forced across platforms (e.g. ANSI, 16 point, System), or should the hardcoded values instead be computed for each particular instance?

Oct. 6, 2010

Re: New version of exe-thumbnailer (0.7)

by Nicholas van Oudtshoorn

On 10/04/2010 09:44 PM, Damjan Jovanovic wrote: > On Mon, Oct 4, 2010 at 4:07 AM, Nicholas van Oudtshoorn > <vanoudt(a)gmail.com> wrote: >> On 10/04/2010 08:39 AM, Octavian Voicu wrote: >>> >>> On Fri, Oct 1, 2010 at 11:18 PM, Scott Ritchie<scott(a)open-vote..org >>> <mailto:scott(a)open-vote.org>> wrote: >>> >>> Includes much prettier icons, support for Vista icons (with icoutils >>> 0.29.1) and more. >>> >>> Screenshots and a description are at: >>> http://wiki.winehq.org/exe-thumbnailer >>> >>> >>> Nice! Any plans for Kubuntu / KDE support? :) >>> >>> Octavian >>> >>> >>> >>> >> >> Nice! >> >> Just to note, KDE/Dolphin already has built-in support for thumnbailing exe >> files. (Although, in Fedora at least, it's not enabled by default; just tell >> dolphin to show previews for "Microsoft Windows Executables". >> >> I've also got code on the KDE reviewboard that'll take care of LNK files - >> if it gets picked up, that'll be natively supported by KDE too... >> >> Nicholas > > How does thumbnailing LNK files work? You get a Windows icon path out, > which you have to convert to a *nix path - you'd have to use > ~/.wine/dosdevices and do case-insensitive filename matching, and even > that would only work for LNK files created by Wine, those on a Windows > partition have Windows's idea of drive mappings which is probably > different from Wine. > > Damjan Jovanovic > > > Agreed - the gnome version does look much better at the moment. Thumbnailing LNK files is done by doing a simple parse of the LNK file, and then using wine's winepath command to convert that into a wine path. (Hence "winepath" :) ) Certainly, LNK files on Windows partitions wouldn't work at all (under the current way it's being done.) Nicholas

Oct. 6, 2010

Re: [PATCH 06/10] urlmon: Added IBinding::Abort and binding without callback tests.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5914 Your paranoid android. === W2K8SE (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL === W7PROX64 (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL

Oct. 6, 2010

Re: Translation patches for wine-1.2.1

by Michael Stefaniuc

On 10/06/2010 10:29 PM, Sven Baars wrote: > Michael Stefaniuc wrote: >> Hello Alexandre, >> >> attached is the list with the translation patches to cherry-pick for >> wine-1.2.1. The list was generated with the attached crud patch >> (modified from the version I used for 1.0.1) and then I have manually >> removed all my janitorial patches that didn't produce conflicts. >> >> Though the removal of the unneeded "Remove the ignored common resource >> attributes" patches makes "wrc --verify-translation" produce DIFF >> lines for resources that were added at a later time as those don't >> have the ignored common resource attributes. >> >> bye >> michael > This script doesn't check for updated mc files, so the kernel32 > translation patches didn't get in. This includes for example > > 7fe8c7202345ba04425e3dfefb534bcad8fe76fa > > which was the first commit after wine 1.2 and is a translation update. > Just thought you might want to know this. I know, I already pulled the list of mc file changes. Was busy with work and had no time to test and submit that list. bye michael

Oct. 6, 2010

Re: Translation patches for wine-1.2.1

by Sven Baars

Michael Stefaniuc wrote: > Hello Alexandre, > > attached is the list with the translation patches to cherry-pick for > wine-1.2.1. The list was generated with the attached crud patch > (modified from the version I used for 1.0.1) and then I have manually > removed all my janitorial patches that didn't produce conflicts. > > Though the removal of the unneeded "Remove the ignored common resource > attributes" patches makes "wrc --verify-translation" produce DIFF > lines for resources that were added at a later time as those don't > have the ignored common resource attributes. > > bye > michael This script doesn't check for updated mc files, so the kernel32 translation patches didn't get in. This includes for example 7fe8c7202345ba04425e3dfefb534bcad8fe76fa which was the first commit after wine 1.2 and is a translation update. Just thought you might want to know this. Sven

Oct. 6, 2010

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.

by Jacek Caban

On 10/6/10 4:07 PM, Alexandre Julliard wrote: > Jacek Caban<jacek(a)codeweavers.com> writes: > >> --- >> dlls/urlmon/binding.c | 20 +++++++++++++++++--- >> 1 files changed, 17 insertions(+), 3 deletions(-) > It doesn't work here: Sorry about that. I had a hack in my tree that accidentally prevented the crash. I will send a proper fix. Jacek

Oct. 6, 2010

Re: cryptui: Fix a crash with certification path (resend)

by André Hentschel

Am 06.10.2010 18:08, schrieb Juan Lang: >>>> @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) >>>> */ >>>> tvis.u.item.iImage = 2; >>>> } >>>> - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. >>>> - dwErrorStatus == 0) >>>> + else if (i > 1 && >>>> + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) >>> >>> What is this change for? >>> >> there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain) > > That's a bit different. I wonder if there's a wintrust bug that leads > to this? Any chance of opening a bug and attaching the cert that > produces the crash to it? > --Juan sure, see http://bugs.winehq.org/show_bug.cgi?id=24649 (wasn't able to attach you...) -- Best Regards, André Hentschel

Oct. 6, 2010

Re: cryptui: Fix a crash with certification path (resend)

by Juan Lang

>>> @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) >>> */ >>> tvis.u.item.iImage = 2; >>> } >>> - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. >>> - dwErrorStatus == 0) >>> + else if (i > 1 && >>> + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) >> >> What is this change for? >> > there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain) That's a bit different. I wonder if there's a wintrust bug that leads to this? Any chance of opening a bug and attaching the cert that produces the crash to it? --Juan

Oct. 6, 2010

Re: cryptui: Fix a crash with certification path (resend)

by André Hentschel

Am 06.10.2010 17:41, schrieb Alexandre Julliard: > André Hentschel <nerv(a)dawncrow.de> writes: > >> @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) >> */ >> tvis.u.item.iImage = 2; >> } >> - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. >> - dwErrorStatus == 0) >> + else if (i > 1 && >> + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) > > What is this change for? > there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain) -- Best Regards, André Hentschel

Oct. 6, 2010

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Shouldn't that be a separate thing not related to the problem fixed by > my patch? Sure it should be a separate change. -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: cryptui: Fix a crash with certification path (resend)

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) > */ > tvis.u.item.iImage = 2; > } > - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. > - dwErrorStatus == 0) > + else if (i > 1 && > + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) What is this change for? -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > >> This will cause the stand-alone tray window to not have a title, that > >> doesn't look nice. > > > > What would you suggest? > > Use a separate window for the stand-alone tray. Shouldn't that be a separate thing not related to the problem fixed by my patch? -- Dmitry.

Oct. 6, 2010

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: >> This will cause the stand-alone tray window to not have a title, that >> doesn't look nice. > > What would you suggest? Use a separate window for the stand-alone tray. -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > > The bug #20129 lists one of such applications. > > > > It does FindWindow("Shell_TrayWnd", "") and expects that it returns a valid > > tray window handle. Currently FindWindow() is broken, but my next patch makes > > the above call succeed. > > This will cause the stand-alone tray window to not have a title, that > doesn't look nice. What would you suggest? -- Dmitry.

Oct. 6, 2010

Re: cryptui: Fix a crash with certification path

by André Hentschel

Am 05.10.2010 00:04, schrieb Juan Lang: > Hi André, > I see your patch didn't get committed. In case it's waiting for a > comment from me, it looks fine: I assume you've imported a > certificate that isn't otherwise trusted, and viewing it results in a > crash? I don't see the crash here. > > Thanks, > --Juan Yes. So thanks for the positiv comment, i'll resend the patch. -- Best Regards, André Hentschel

Oct. 6, 2010

Re: [7/7] msi/tests: Fix some test failures on 64-bit.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5900 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10500: Test failed: key not created

Oct. 6, 2010

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The bug #20129 lists one of such applications. > > It does FindWindow("Shell_TrayWnd", "") and expects that it returns a valid > tray window handle. Currently FindWindow() is broken, but my next patch makes > the above call succeed. This will cause the stand-alone tray window to not have a title, that doesn't look nice. -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [2/6]strmbase: move enumpins from quartz to strmbase

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/Makefile.in | 1 - > dlls/qcap/enumpins.c | 186 ------------------------------------- > dlls/qcap/qcap_main.h | 8 -- > dlls/qcap/vfwcapture.c | 28 +++++- > dlls/quartz/Makefile.in | 1 - > dlls/quartz/dsoundrender.c | 26 ++++-- > dlls/quartz/enumpins.c | 211 > ------------------------------------------ > dlls/quartz/filesource.c | 32 +++++-- > dlls/quartz/nullrenderer.c | 25 +++-- > dlls/quartz/parser.c | 29 ++++-- > dlls/quartz/quartz_private.h | 3 - > dlls/quartz/transform.c | 27 ++++-- > dlls/quartz/videorenderer.c | 25 +++-- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/enumpins.c | 207 > +++++++++++++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 6 + > 16 files changed, 346 insertions(+), 470 deletions(-) > delete mode 100644 dlls/qcap/enumpins.c > delete mode 100644 dlls/quartz/enumpins.c > create mode 100644 dlls/strmbase/enumpins.c It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so avisplitter.c && touch avisplitter.ok avisplitter.c:164: Test failed: pins[1] = (nil) avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test make: *** [avisplitter.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [2/7] msi: Use strcmpW instead of lstrcmpW to compare database strings.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > An installer I have here uses \1 and \2 as delimiters in property strings. > It turns out that on Wine lstrcmp("\1", "\2") returns 0, not -1, which causes > the string table implementation to return the wrong value. This should be fixed, > but it's better if database string comparisons do not depend on thread locale. Yes, but isn't it supposed to follow Unicode sorting rules instead of simply comparing code point values? -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [4/7] msi: Add package validation tests.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5898 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10164: Test failed: key not removed install.c:10174: Test failed: key not removed install.c:10185: Test failed: key not removed install.c:10476: Test failed: key not created

Oct. 6, 2010

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 20 +++++++++++++++++--- > 1 files changed, 17 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmllocation.c && touch htmllocation.ok wine: Unhandled page fault on read access to 0x00000110 at address 0x555d325a (thread 001f), starting debugger... Unhandled exception: page fault on read access to 0x00000110 in 32-bit code (0x555d325a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555d325a ESP:0032dfd0 EBP:0032e038 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00ed2bf4 EBX:5561bc84 ECX:002078c0 EDX:555d31c0 ESI:0126f400 EDI:00000000 Stack dump: 0x0032dfd0: 00ed2b98 0032e3a8 0032e008 6ad698bc 0x0032dfe0: 002078b0 00000001 00000001 0032e078 0x0032dff0: 6adbe4f5 002078b0 0032e018 00000000 0x0032e000: 002078b0 6b127f9c 0032e028 6ad697d8 0x0032e010: 002078b0 0032e074 00000001 00000000 0x0032e020: 002078a8 0032e074 0032e068 012ad758 Backtrace: =>0 0x555d325a handle_load+0x9a(iface=0x126f5c0, event=0x12ad758) [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml (0x0032e158) 1 0x6a02f1db in xul (+0x3ef1da) (0x0032e1d8) 2 0x6aca1e00 in xul (+0x1061dff) (0x0032e208) 3 0x6aca1fe1 in xul (+0x1061fe0) (0x0032e258) 4 0x6a047958 in xul (+0x407957) (0x0032e2a8) 5 0x6a04819c in xul (+0x40819b) (0x0032e378) 6 0x69dc9c12 in xul (+0x189c11) (0x0032e408) 7 0x6a53d3a0 in xul (+0x8fd39f) (0x0032e698) 8 0x6a53ced6 in xul (+0x8fced5) (0x0032e718) 9 0x6a5574c8 in xul (+0x9174c7) (0x0032e768) 10 0x6a556567 in xul (+0x916566) (0x0032e798) 11 0x6a556371 in xul (+0x916370) (0x0032e7e8) 12 0x6a555fa2 in xul (+0x915fa1) (0x0032e858) 13 0x69c66091 in xul (+0x26090) (0x0032e898) 14 0x555cbc1b on_stop_nsrequest+0x8a(This=0xed4da0, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8d8) 15 0x555cbc1b on_stop_nsrequest+0x8a(This=0x10, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8e8) 16 0x555cca5f nsChannelBSC_stop_binding+0x1e(bsc=0x126fe08, result=0x555d31c0) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1184] in mshtml (0x0032e928) 17 0x555cb126 BindStatusCallback_OnStopBinding+0x35(iface=0x126fe08, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:360] in mshtml (0x0032e968) 18 0x68f3f838 BindStatusCallback_OnStopBinding+0x87(iface=0x129b090, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindctx.c:178] in urlmon (0x0032e988) 19 0x68f40c5d stop_binding+0x3c(binding=0x129b118, hres=0xffffffff80004004, str=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:221] in urlmon (0x0032e9d8) 20 0x68f41dde InternetProtocolSink_ReportResult+0x8d(iface=0x129b11c, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1149] in urlmon (0x0032ea28) 21 0x68f47abd BPInternetProtocolSink_ReportResult+0xec(iface=0x129b578, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:1184] in urlmon (0x0032ea48) 22 0x68f50b5d report_result+0x3c() in urlmon (0x0032ea58) 23 0x68f50c1d protocol_abort+0x2c(protocol=0x2078c0, reason=0xffffffff80004004) [/home/julliard/wine/wine/dlls/urlmon/protocol.c:439] in urlmon (0x0032ea98) 24 0x68f4cbd4 HttpProtocol_Abort+0x73(iface=0x129b764, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/http.c:445] in urlmon (0x0032eae8) 25 0x68f452b0 ProtocolHandler_Abort+0x5f(iface=0x129b580, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:662] in urlmon (0x0032eb38) 26 0x68f459db BindProtocol_Abort+0x7a(iface=0x129b568, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:429] in urlmon (0x0032eb68) 27 0x68f4140b Binding_Abort+0x5a(iface=0x129b118) [/home/julliard/wine/wine/dlls/urlmon/binding.c:892] in urlmon (0x0032eb88) 28 0x555ca834 set_window_bscallback+0x23(window=0xed2b98, callback=(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1349] in mshtml (0x0032ebd8) 29 0x555c54a1 HTMLWindow2_Release+0x70(iface=0xed2ba8) [/home/julliard/wine/wine/dlls/mshtml/htmlwindow.c:228] in mshtml (0x0032ec18) 30 0x55580881 CustomDoc_Release+0x80(iface=0x129db0) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2021] in mshtml (0x0032ec38) 31 0x5557ea04 HTMLDocument_Release+0x13(iface=0x129ca8) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:376] in mshtml (0x0032fd08) 32 0x686a82f5 perform_test+0xd34(test=0x686c24c3) [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:348] in mshtml_test (0x0032fd38) 33 0x686a838e func_htmllocation+0x3d() [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:360] in mshtml_test (0x0032fd88) 34 0x686b535e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe48) 35 0x686b5557 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:624] in mshtml_test (0x0032fe90) 36 0x686b60dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fea8) 37 0x7b856c4c call_process_entry+0xb() in kernel32 (0x0032fee8) 38 0x7b85914b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 39 0x7bc72b80 call_thread_func+0xb() in ntdll (0x0032ffc8) 40 0x7bc72d50 call_thread_entry_point+0x6f(entry=0x7b8590f0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 41 0x7bc4da6a start_process+0x29(kernel_start=0x7b8590f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x555d325a handle_load+0x9a [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml: movl 0x110(%edi),%eax 226 if(doc_obj->nscontainer->editor_controller) { -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: [PATCH 9/9] urlmon: Added IInternetProtocolEx support to http protocol handler.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5895 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:977: Test failed: hrResult = 800c0005, expected: 00000000 Timeout

Oct. 6, 2010

Re: [PATCH 6/9] urlmon: Added IBinding::Abort and binding without callback tests.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5893 Your paranoid android. === WXPPROSP3 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K3R2SESP2 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === WVISTAADM (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K8SE (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PRO (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (64 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable

Oct. 6, 2010

Re: [PATCH 1/9] urlmon: Return correct error in get_protocol_handler for unknown protocol types.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5892 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:459: Test failed: expected ReportProgress_SENDINGREQUEST

Oct. 6, 2010

Re: [PATCH 3/3] d3d9/tests: Add window proc tests for switching between fullscreen and windowed.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5888 Your paranoid android. === W2K8SE (32 bit device) === device.c:2473: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2611: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (64 bit device) === device.c:2473: Test failed: Expected foreground window 0000000000020198, got 0000000000010092. device.c:2611: Test failed: Expected foreground window 0000000000030198, got 0000000000010092.

Oct. 6, 2010

Re: [1/5] mscoree: Implement ICLRMetaHost_GetRuntime.

by Alexandre Julliard

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This will cause the tests to fail if Mono is not available. We'll have to start providing a Mono package then. -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: cabinet/tests: Reformated output in case of test failure (try 2)

by Alexandre Julliard

Marko Nikolic <grkoma(a)gmail.com> writes: > In case of test failure, expected and received values are traced. > Format for the two values was different, corrected so both values > are traced as hex. Error values are in general more useful in decimal. -- Alexandre Julliard julliard(a)winehq.org

Oct. 6, 2010

Re: crypt32(10/10): Set correct error when encountering unsupported critical extensions in the base and SSL policy

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5874 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

Oct. 6, 2010

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)

by Mike Kaplinskiy

There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }". More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <rm(a)eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >

Oct. 6, 2010