October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20). sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20).

Oct. 31, 2010

up for a quick challenge? "Test Drive Unlimited 2" open beta this weekend only...

by Dan Kegel

and installs ok with dotnet20... but it's stuck on "Checking files, please wait". http://appdb.winehq.org/objectManager.php?sClass=version&iId=21811 http://en.wikipedia.org/wiki/Test_Drive_Unlimited_2 (Wikipedia says it will require .net 3.5, ugh.) While it's sitting, it outputs stuff like fixme:thread:NtQueryInformationThread info class 16 not supported yet fixme:ole:Context_CC_ContextCallback (0x4956060/0x4956064)->(0x79f277a5, 0x2a7e4e8, {d7174f82-36b8-4aa8-800a-e963ab2dfab9}, 2, (nil)) fixme:thread:NtQueryInformationThread info class 16 not supported yet I guess the next step is to look at the packets on the wire on windows and see if it's getting stuck trying to phone home...

Oct. 31, 2010

Re: comctl32/treeview: Make item data layout partially compatible with native one

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6609 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === No test summary line found === W2KPROSP4 (32 bit treeview) === No test summary line found

Oct. 31, 2010

Re: Purist keyword?

by Stefan Dösinger

Am 30.10.2010 um 22:30 schrieb Maarten Lankhorst: > I really don't see what 'purist' adds, if a game fails because a > builtin dll is missing a function, why would it matter if the game > installs a native dll by default or not? The bug is still in the > builtin dll, whether you use the builtin dll or not. ;) At some point we'll probably change the DLL load order for that particular DLL from native,builtin to builtin, native(via changing DLL_WINE_PREATTACH). In that case all those bugs would turn in to real bugs. Besides, there are situations when you'd prefer not to use any Microsoft redistributable DLLs due to license reasons. Even if they came with the game.

Oct. 31, 2010

RFC: quartz: Don't block indefinitely when pausing after end of stream

by Vladimir Panteleev

The attached patch attempts to fix http://bugs.winehq.org/show_bug.cgi?id=24869 , but due to my limited knowledge of DirectShow I'm not certain about its correctness. Can anyone point out if there's anything wrong with it?

Oct. 31, 2010

Re: Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken.

by Vitaliy Margolen

On 10/30/2010 06:12 AM, Sami Aario wrote: > Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken. > > From: Sami Aario <saempy(a)hima.(none)> Your e-mail isn't set correctly in git configuration. > dlls/ntdll/nt.c | 63 ++++++++++++++++++++++++++++++++++++++++ > include/wine/server_protocol.h | 18 +++++++++++- > server/protocol.def | 6 ++++ > server/request.h | 5 +++ > server/token.c | 36 +++++++++++++++++++++++ > server/trace.c | 10 ++++++ Please don't include changes to automatically generated files (server_protocol.h, request.h, trace.c). > + SERVER_START_REQ( set_token_sid ) > + { > + SID *sid = ((TOKEN_OWNER *)TokenInformation)->Owner; > + WORD size; > + > + if (sid) size = RtlLengthRequiredSid(sid->SubAuthorityCount); > + else size = 0; > + > + TRACE("size=%d\n", size); > + > + req->handle = wine_server_obj_handle( TokenHandle ); > + req->which_sid = TokenInformationClass; > + wine_server_add_data( req, sid, size ); > + ret = wine_server_call( req ); > + } > + SERVER_END_REQ; Please get everything outside of SERVER_START_REQ()/SERVER_END_REQ except actual wine_server function calls and handling of returned result(s). Some functions can do their own server calls and you will have a deadlock. > + case TokenOwner: > + free( token->user ); > + token->user = NULL; > + > + if (sid_len) > + token->user = memdup( sid, sid_len ); > + break; This is wrong, you can't clear token user - it always have to be set, or you risking an assert in get_token_sid. Which means you have to validate the data user passes in. Vitaliy.

Oct. 31, 2010

re: Purist keyword?

by Dan Kegel

The keyword might be useful for a pragmatist looking for bugs to fix, who didn't want to fix bugs masked by a bundled native DLL. I don't know how many such people there are, though. Best to wait until somebody says they need the keyword before we add it... until then, we can just use the word 'purist' in the body of the bug as we've started doing.

Oct. 30, 2010

Re: Purist keyword?

by Maarten Lankhorst

Hi Austin, 2010/10/30 Austin English <austinenglish(a)gmail.com>: > On Saturday, October 30, 2010, Shachar Shemesh <shachar(a)shemesh.biz> wrote: >> On 30/10/10 19:25, Austin English wrote: >> >> I meant bugs that only occur by manually removing native dlls. The >> report summaries are usually clear enough, I was hoping to get an easy >> way to search for them and separate them from 'normal' bugs. >> >> >> >> >> I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) >> >> Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the >> ".dll.so" extension. > > No, I mean native. Some applications install native redistibutables, > e.g. msvcr80 or d3dx9_36. > >> To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? > > Sure. I forget not everyone follows wine-bugs, so this was unclear. > See http://bugs.winehq.org/show_bug.cgi?id=24510. Blur runs out of the > box, but if you remove the bundled native dll (being a purist) the > game fails, because wine is missing a dozen or so functions. There are > several similar bugs. I really don't see what 'purist' adds, if a game fails because a builtin dll is missing a function, why would it matter if the game installs a native dll by default or not? The bug is still in the builtin dll, whether you use the builtin dll or not. ;) Cheers, Maarten

Oct. 30, 2010

Re: Purist keyword?

by Austin English

On Saturday, October 30, 2010, Shachar Shemesh <shachar(a)shemesh.biz> wrote: > On 30/10/10 19:25, Austin English wrote: > > I meant bugs that only occur by manually removing native dlls. The > report summaries are usually clear enough, I was hoping to get an easy > way to search for them and separate them from 'normal' bugs. > > > > > I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) > > Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the > ".dll.so" extension. No, I mean native. Some applications install native redistibutables, e.g. msvcr80 or d3dx9_36. > To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? Sure. I forget not everyone follows wine-bugs, so this was unclear. See http://bugs.winehq.org/show_bug.cgi?id=24510. Blur runs out of the box, but if you remove the bundled native dll (being a purist) the game fails, because wine is missing a dozen or so functions. There are several similar bugs. -- -Austin

Oct. 30, 2010

Re: Purist keyword?

by Shachar Shemesh

On 30/10/10 19:25, Austin English wrote: > I meant bugs that only occur by manually removing native dlls. The > report summaries are usually clear enough, I was hoping to get an easy > way to search for them and separate them from 'normal' bugs. > > I suspect your use of the word "native" is different than the one defined by Wine (see, for example, http://www.winehq.org/docs/wineusr-guide/config-wine-main) Native DLLs, in Wine, are DLLs that come from a real Windows system. This as opposed to "built-in DLLs", that are DLLs compiled for Wine as winelib, carrying the ".dll.so" extension. To the best of my knowledge, Wine arrives with no native DLLs at all, and thus one cannot remove any. Can you point to a bug report you might tag as "purist", so we can all get on the same page? Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

Oct. 30, 2010