November 2010 - Wine-Devel - list.winehq.org

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

by Alexander Puzankov

Ok, I missed that MSDN says that the first parameter of the custom I/O procedure is of type LPSTR instead of LPMMIOINFO (could be this an error in the documentation?). I can make cast in mmio_test_IOProc instead, something like: static LRESULT CALLBACK mmio_test_IOProc(LPSTR lpMMIOInfo, UINT uMessage, LPARAM lParam1, LPARAM lParam2) { LPMMIOINFO lpmmioinfo = (LPMMIOINFO) lpMMIOInfo; ... } So should I remove these casts and resend the entire patchset in the right order? Best regards, Alexander Puzankov

Nov. 30, 2010

Re: mshtml: Added beginning ActiveX tests.

by Paul Vriens

On 11/30/2010 03:42 PM, Jacek Caban wrote: > Hi Paul, > > On 11/30/10 2:46 PM, Paul Vriens wrote: >> Changing the lstrcmpW and using A-functions to create the window makes >> the tests succeed on my win98 box (changed activex.c attached). > > Thanks for catching it. How about this version: > http://source.winehq.org/patches/data/68936 > I would prefer to forget about win9x when writing tests, so I've skipped > as much as possible on them. > I guess that's AJ's call? Taking this approach is fine with me but we could then start considering whether we still want to test on Win9x. Microsoft has abandoned those old versions already so maybe we are the only solution for old programs (and we thus need tests?). Or are you only talking about stuff like mshtml/shdocvw ....? -- Cheers, Paul.

Nov. 30, 2010

Re: mshtml: Added beginning ActiveX tests.

by Jacek Caban

Hi Paul, On 11/30/10 2:46 PM, Paul Vriens wrote: > Changing the lstrcmpW and using A-functions to create the window makes > the tests succeed on my win98 box (changed activex.c attached). Thanks for catching it. How about this version: http://source.winehq.org/patches/data/68936 I would prefer to forget about win9x when writing tests, so I've skipped as much as possible on them. Thanks, Jacek

Nov. 30, 2010

Re: mshtml: Added beginning ActiveX tests.

by Paul Vriens

On 11/30/2010 01:56 PM, Paul Vriens wrote: > Hi Jacek, > > On 11/30/2010 01:38 PM, Jacek Caban wrote: >> +static HRESULT WINAPI >> PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) >> +{ >> + if(dispID == DISPID_READYSTATE){ >> + BSTR state; >> + HRESULT hres; >> + >> + static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; >> + >> + hres = IHTMLDocument2_get_readyState(notif_doc,&state); >> + ok(hres == S_OK, "get_readyState failed: %08x\n", hres); >> + >> + if(!lstrcmpW(state, completeW)) > > This will always succeed on Win9x. > >> +static HWND create_container_window(void) >> +{ >> + static const WCHAR wszHTMLDocumentTest[] = >> + {'H','T','M','L','D','o','c','u','m','e','n','t','T','e','s','t',0}; >> + static WNDCLASSEXW wndclass = { >> + sizeof(WNDCLASSEXW), >> + 0, >> + wnd_proc, >> + 0, 0, NULL, NULL, NULL, NULL, NULL, >> + wszHTMLDocumentTest, >> + NULL >> + }; >> + >> + RegisterClassExW(&wndclass); >> + return CreateWindowW(wszHTMLDocumentTest, wszHTMLDocumentTest, >> + WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, >> + 515, 530, NULL, NULL, NULL, NULL); >> +} > > This will not work on Win9x as well. My Win98 box runs IE6 so it will > run these tests I guess (unlike the win98 testbot). > This is what I get on my win9 box: activex.c:480: Test failed: UIActivate failed: 800700b7 activex.c:486: Test failed: Show failed: 800700b7 activex: 24 tests executed (0 marked as todo, 2 failures), 0 skipped Changing the lstrcmpW and using A-functions to create the window makes the tests succeed on my win98 box (changed activex.c attached). -- Cheers, Paul.

Nov. 30, 2010

Translation patches for wine-1.2.2

by Michael Stefaniuc

Hello Alexandre, attached is the list of translation patches for wine-1.2.2. This time I manually checked the changes to the En.rc files if they are indeed a wine-1.2 incompatible change. Thus there are some patches in the list that I missed for wine-1.2.1 with the automatic "stop at first En.rc file change". Some other things to note: - There are 4 of my janitorial patches in; you can skip them like the last time and fix up the patches that don't cherry-pick cleanly. - "winhlp32: Use a standard About dialog, with the proper icon" seemed inconspicuous enough to include and thus allow translation patches for winhlp32 after that commit. - Does it make sense to include the Arab and Hebrew translations? Support for mirroring is only in wine-1.3.x. bye michael

Nov. 30, 2010

Re: mshtml: Added beginning ActiveX tests.

by Paul Vriens

Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: > +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) > +{ > + if(dispID == DISPID_READYSTATE){ > + BSTR state; > + HRESULT hres; > + > + static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; > + > + hres = IHTMLDocument2_get_readyState(notif_doc,&state); > + ok(hres == S_OK, "get_readyState failed: %08x\n", hres); > + > + if(!lstrcmpW(state, completeW)) This will always succeed on Win9x. > +static HWND create_container_window(void) > +{ > + static const WCHAR wszHTMLDocumentTest[] = > + {'H','T','M','L','D','o','c','u','m','e','n','t','T','e','s','t',0}; > + static WNDCLASSEXW wndclass = { > + sizeof(WNDCLASSEXW), > + 0, > + wnd_proc, > + 0, 0, NULL, NULL, NULL, NULL, NULL, > + wszHTMLDocumentTest, > + NULL > + }; > + > + RegisterClassExW(&wndclass); > + return CreateWindowW(wszHTMLDocumentTest, wszHTMLDocumentTest, > + WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, > + 515, 530, NULL, NULL, NULL, NULL); > +} This will not work on Win9x as well. My Win98 box runs IE6 so it will run these tests I guess (unlike the win98 testbot). -- Cheers, Paul.

Nov. 30, 2010

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 > +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec This is showing many deprecated function warnings even on Leopard. We should try to avoid that in new code. -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2010

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.

by Jacek Caban

On 11/29/10 11:41 PM, Paul Vriens wrote: > Hi Jacek, > > On 11/29/2010 12:18 AM, Jacek Caban wrote: >> --- >> dlls/mshtml/tests/htmldoc.c | 111 >> ++++++++++++++++++++++++++++++++++++++++--- >> 1 files changed, 104 insertions(+), 7 deletions(-) > > This one introduced some test failures: > > http://test.winehq.org/data/tests/mshtml:htmldoc.html > > Just a matter of adding 3000024 and 3000025 to the switch in > PropertyNotifySink_OnChanged()? Yes, they should be fine to ignore. Thanks, Jacek

Nov. 30, 2010

Re: shdocvw: Do not annoy user when he disabled winemenubuilder

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -85,6 +85,9 @@ static BOOL run_winemenubuilder( const WCHAR *args ) > GetSystemDirectoryW( app, MAX_PATH - sizeof(menubuilder)/sizeof(WCHAR) ); > strcatW( app, menubuilder ); > > + if( GetFileAttributesW(app) == INVALID_FILE_ATTRIBUTES) > + return FALSE; Checking for file existence doesn't make much sense for builtins. -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2010

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)

by Alexandre Julliard

Peter Urbanec <winehq.org(a)urbanec.net> writes: > +static BOOL load_funcs(void *handle) > +{ > +#define LOAD_FUNCPTR(f) if((p##f = (void*)wine_dlsym(handle, #f, NULL, 0)) == NULL) \ > + { ERR("Can not find " #f "\n"); return FALSE; } else { TRACE("Loaded function " #f "\n"); }; > + > + /* Platform API */ > + LOAD_FUNCPTR(clGetPlatformIDs) > + LOAD_FUNCPTR(clGetPlatformInfo) > + > + /* Device APIs */ > + LOAD_FUNCPTR(clGetDeviceIDs) > + LOAD_FUNCPTR(clGetDeviceInfo) Why are you loading everything dynamically instead of simply linking to it? -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2010