November 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)

by Peter Urbanec

On 30/11/10 05:31, C.W. Betts wrote: > It doesn't look like you look for Apple's OpenCL implementation, which uses<OpenCL/opencl.h>. That was intentional. I have no way of testing on OSX, so rather than including untested code and giving the illusion of it working on OSX, I decided to leave that out. I am also not sure what, if anything, I need to do with autoconf to support OpenCL detection on OSX. My personal preference would be to get the current version accepted in the wine tree and then someone with access to an OSX system can provide a complete patch. Of course, if AJ would prefer the untested #ifdef __APPLE__ variant, I'm happy to resubmit the patch. Cheers, Peter Urbanec

Nov. 30, 2010

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

by Dmitry Timoshkov

Alexander Puzankov <alxpnv(a)gmail.com> wrote: > + lpProc = mmioInstallIOProc(FOURCC_DOS, (LPMMIOPROC)mmio_test_IOProc, MMIO_INSTALLPROC); > + ok(lpProc == (LPMMIOPROC)mmio_test_IOProc, "mmioInstallIOProc error\n"); Please try to avoid this kind of casts, they hide the bugs. Also, if the tests depend on the following patches in sequence to pass, the tests should be sent as a last patch ('make test' should succeed after each patch in the sequence). -- Dmitry.

Nov. 30, 2010

Re: [PATCH 1/5] ddraw/tests: Fix a typo.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7343 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415849

Nov. 30, 2010

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.

by Paul Vriens

Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 111 > ++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures: http://test.winehq.org/data/tests/mshtml:htmldoc.html Just a matter of adding 3000024 and 3000025 to the switch in PropertyNotifySink_OnChanged()? -- Cheers, Paul.

Nov. 29, 2010

Re: [PATCH 3/5] wined3d: Pass an IWineD3DDeviceImpl pointer to drawStridedSlow().

by Henri Verbeet

On 2010-11-29 23:08, Henri Verbeet wrote: > --- > dlls/wined3d/device.c | 12 ++++---- > dlls/wined3d/drawprim.c | 59 ++++++++++++++++++--------------------- > dlls/wined3d/wined3d_private.h | 2 +- > 3 files changed, 34 insertions(+), 39 deletions(-) > I messed up the commit message, this is for drawPrimitive() of course.

Nov. 29, 2010

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 4.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 306 +++++++++++++++++++++++++++++++++---------------- > 1 files changed, 206 insertions(+), 100 deletions(-) This is causing strange crashes during prefix creation on 64-bit (there's no backtrace unfortunately). -- Alexandre Julliard julliard(a)winehq.org

Nov. 29, 2010

Re: Crappy Deb build scripts

by Austin English

On Thu, Nov 11, 2010 at 8:56 AM, Ben Klein <shacklein(a)gmail.com> wrote: > By request of Austin, my crappy build scripts. I finally had the > concentration to bundle all the right files together! I've made a 1.3.8 package for Squeeze i386, and tested it on a second machine. I've only made deb packages a few times before, so if someone could test them to see if they work, that'd be great. If so, I'll work on the other versions/arches, as well as gecko/mono packages. Packages are temporarily on http://austinenglish.com/blah -- -Austin

Nov. 29, 2010

Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)

by C.W. Betts

It doesn't look like you look for Apple's OpenCL implementation, which uses <OpenCL/opencl.h>. You can do this: #ifdef __APPLE__ #include <OpenCL/opencl.h> #else #include <CL/opencl.h> #endif On Nov 29, 2010, at 7:39 AM, Peter Urbanec wrote: > Resending because previous patch was mangled by Thunderbird. > > --- > configure.ac | 13 ++++++++ > dlls/opencl/Makefile.in | 6 ++++ > dlls/opencl/opencl.c | 29 ++++++++++++++++++ > dlls/opencl/opencl.spec | 75 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 123 insertions(+), 0 deletions(-) > create mode 100644 dlls/opencl/Makefile.in > create mode 100644 dlls/opencl/opencl.c > create mode 100644 dlls/opencl/opencl.spec > > > <0001-opencl-Initial-stub-implementation-of-OpenCL-1.0.patch>

Nov. 29, 2010

Re: user32/tests: Remove obsolete comment

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7336 Your paranoid android. === W7PRO (32 bit input) === input.c:817: Test failed: 0 (a4/0): the msg sequence is not complete: expected 0000 - actual c0ae

Nov. 29, 2010

Re: dsound.h: Undefine INTERFACE before using it.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -419,6 +419,7 @@ extern HRESULT WINAPI GetDeviceID(LPCGUID lpGuidSrc, LPGUID lpGuidDest); > /***************************************************************************** > * IDirectSound interface > */ > +#undef INTERFACE > #define INTERFACE IDirectSound > DECLARE_INTERFACE_(IDirectSound,IUnknown) The preferred pattern is to undefine it after use. If there are files that don't do this they should be fixed. -- Alexandre Julliard julliard(a)winehq.org

Nov. 29, 2010