December 2010 - Wine-Devel - list.winehq.org

Re: Another tests milestone hit

by Alexandre Julliard

Greg Geldorp <ggeldorp(a)vmware.com> writes: > A big thank you to all the people who contributed tests and fixed > existing tests. I think a lot of progress has been made in the month > since WineConf and the tests are in much better shape now. Yes, the results page is looking incredibly good lately. It seems that 2011 will be the year where we'll finally see more green than red on that page. Many thanks to Greg and to everyone who has been helping! Happy new year to you all! -- Alexandre Julliard julliard(a)winehq.org

Dec. 31, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by Charles Davis

On 12/31/10 1:11 PM, Ken Thomases wrote: > I should add that this patch seem correct to me. It couldn't hurt to get Charles Davis's input, of course. I agree, for now. He should at least put a comment in to the effect of "if we got this far, there's already media in the drive." > MSDN documents that the purpose of IOCTL_*_CHECK_VERIFY is to check if the media has changed. The Linux and FreeBSD implementations basically just check if there's media in the drive. On Mac OS X, the BSD device file just plain doesn't exist unless and until there's media mounted. There's no permanent BSD device file for the drive itself. So, if CDROM_Verify() is called, which requires that the BSD device file is opened and thus is present, that by itself implies that there's media in the drive. Therefore, CDROM_Verify() should just return success. Makes sense. But the 'right' way to implement this on Mac OS is to ask DiskArbitration to tell us when the media changes. (In fact, the right way to implement this elsewhere is to ask udev or hald the same thing.) Then we can return STATUS_VERIFY_REQUIRED (as documented) when the media actually has changed. For now, though, Loïc's patch is OK. AJ wants to eventually move some (all?) of the disk/CD/DVD/storage IOCTLs into mountmgr anyway, where Wine's fake storage drivers are hosted. Mountmgr already has infrastructure in place to talk to DA on Mac OS and to hald on Linux/FreeBSD, so doing this the 'right' way will be much easier there. Chip

Dec. 31, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by Ken Thomases

On Dec 31, 2010, at 1:38 PM, Ken Thomases wrote: > Why does that matter? The question is, under what circumstances does it end up in CDROM_Verify()? What is the right behavior of CDROM_Verify() and how would that be implemented on Mac OS X? I should add that this patch seem correct to me. It couldn't hurt to get Charles Davis's input, of course. CDROM_Verify() is called when CDROM_DeviceIoControl() gets a IOCTL_*_CHECK_VERIFY request. CDROM_DeviceIoControl() is only called (from NtDeviceIoControlFile()) for the appropriate type of device and that's further verified (on Mac OS X) by the call to get_parent_device(). MSDN documents that the purpose of IOCTL_*_CHECK_VERIFY is to check if the media has changed. The Linux and FreeBSD implementations basically just check if there's media in the drive. On Mac OS X, the BSD device file just plain doesn't exist unless and until there's media mounted. There's no permanent BSD device file for the drive itself. So, if CDROM_Verify() is called, which requires that the BSD device file is opened and thus is present, that by itself implies that there's media in the drive. Therefore, CDROM_Verify() should just return success. Which is basically what Loïc said. :) -Ken

Dec. 31, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by Ken Thomases

On Dec 30, 2010, at 9:36 AM, James McKenzie wrote: > This has been critically examined by several people and if the solution were this simple it would have been put in place a long time ago. Charles Davis has spend over a year looking at how to implement CDROM functionality for MacOSX. Rather than arguing in sweeping generalizations, can we confine ourselves to the technical specifics of this particular case, please? When you say "this has been ... examined", are you referring specifically to CDROM_Verify()? > So, here is my question: How can the community be 100% certain that: > > 1. The device has EXACTLY the same name on every available MacOSX installation? What does the device name have to do with anything? Do you think that Loïc's patch somehow contains an implicit dependence on device names? If so, why? > 2. How can you be 100% certain that if the 'device' exists that the code will end up in CDROM_Verify()? Why does that matter? The question is, under what circumstances does it end up in CDROM_Verify()? What is the right behavior of CDROM_Verify() and how would that be implemented on Mac OS X? Can you explain which aspect of CDROM_Verify()'s behavior is not properly implemented by Loïc's patch? Regards, Ken

Dec. 31, 2010

Another tests milestone hit

by Greg Geldorp

Today we hit another milestone: the first 0-failure run of the 64-bit tests. All tests passed on both the WXPX64 and W2K3R2SEX64 machines. Sadly I missed my personal goal of having all tests pass on at least one VM for every Windows version by the end of the year, we still don't have a Win7 machine that passes all tests. I have a partial fix for msctf:inputprocessor (put a "Sleep(2000);" after the call to test_RegisterCategory()) but in spite of spending quite a bit of time on it haven't made much further progress. So anyone with msctf expertise: your help would be greatly appreciated. Same for ole32:clipboard and ole32:usrmarshal. A big thank you to all the people who contributed tests and fixed existing tests. I think a lot of progress has been made in the month since WineConf and the tests are in much better shape now. Greg.

Dec. 31, 2010

Re: 64-bit Notepad2 crashes

by Hin-Tak Leung

Susan Cragin wrote: >>>> Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >>>> >>>> Otherwise ld might not be able to 'find' it when starting the program. >>>> >>>> James McKenzie >>>> >>> James... >>> You've just exhausted my technical knowledge. How do I do / find that? >> Susan: >> >> For the BASH shell: >> Type in set and look for the LD_LIBRARY_PATH line. >> for the CSH/KSH shell: >> Type in env >> Look for the LD_LIBRARY_PATH line. >> >> Hopefully, /usr/local/lib is there. >> >> BTW, to make Wine work on a Mac, I have to add this line.... >> >> James McKenzie > > Typed "set" > Did word search on "library." > Nothing. for BASH, it should be export | grep LD_LIBRARY_PATH not "set".

Dec. 31, 2010

Re: sound issues (which are not cared since 1.3.1)

by wylda＠volny.cz

> > > > int card, err, capcontrols=0 > > > > otherwise things like: > > > > mixdev[mixnum].chans += capcontrols; > > > > mixdev[mixnum].lines = > > HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > > sizeof(line) * mixdev[mixnum].chans); > > > > > > goes crazy like in > > http://bugs.winehq.org/show_bug.cgi?id=25231#c2. > > well spotted, the patch incorrectly removed the = 0. > > I submitted a patch readding it. Hi again! Many thanks Marcus for the patch and getting it git-official :) I wonder if someone could write a Wiki page about different techniques how beginners like me can spot and easily test for this kind of wine's code problems. Thanks to this bug, Wine-1.3.10 + winecfg's audio tab could be taken as the example and wiki could show how to use different tools (warn+heap, valgrind, gcc options, ...) and what tools' output to expect in case of such bugs. Regards, W. PS: Marcus, i noticed "found by my overflow checking patches" in http://source.winehq.org/patches/data/69925. Are these patches publicly available? ;)

Dec. 31, 2010

Re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by Dan Kegel

On Fri, Dec 31, 2010 at 3:48 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Maybe it's just time to remove the "replace malloc with HeapAlloc" > task from the wiki? Or, at least, add a note to explain that we expect > the current Wine code to be "compliant". Done.

Dec. 31, 2010

Re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by Matteo Bruni

2010/12/30 Dan Kegel <dank(a)kegel.com>: > Yegor wrote: >> it's my first contribution to wine... > > Welcome! > >> so I wanted to start with some simple task. > > Changing memory allocation might not be simple. > > Your patch touches two different DLLs. > You should probably split this patch up, one patch per dll. > > Also, the fact that your change to d3dcompiler_43 only > changes a malloc and not a corresponding free is > interesting. Is there a leak? That string is freed by wpp, which is a native library thus it uses free(). So the code is correct as it is now, with the malloc(). There were already a couple of times people came up with similar patches, I can't find them right now though. Maybe it's just time to remove the "replace malloc with HeapAlloc" task from the wiki? Or, at least, add a note to explain that we expect the current Wine code to be "compliant".

Dec. 31, 2010

Re: oleview: Fix a null pointer crash

by Nikolay Sivov

On 12/31/2010 13:38, Alexandre Julliard wrote: > Nikolay Sivov<nsivov(a)codeweavers.com> writes: > >> Fix a null pointer crash > This is an internal function, the caller should take care of this. True, it was wrong. Thanks.

Dec. 31, 2010

Re: msvcrxx: Forward _setjmp on x86_64

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > needed for ratGPU > --- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- Please fix all the msvcrt dlls, not just these two. -- Alexandre Julliard julliard(a)winehq.org

Dec. 31, 2010

Re: oleview: Fix a null pointer crash

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix a null pointer crash This is an internal function, the caller should take care of this. -- Alexandre Julliard julliard(a)winehq.org

Dec. 31, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>>> Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >>> >>> Otherwise ld might not be able to 'find' it when starting the program. >>> >>> James McKenzie >>> >> James... >> You've just exhausted my technical knowledge. How do I do / find that? >Susan: > >For the BASH shell: >Type in set and look for the LD_LIBRARY_PATH line. >for the CSH/KSH shell: >Type in env >Look for the LD_LIBRARY_PATH line. > >Hopefully, /usr/local/lib is there. > >BTW, to make Wine work on a Mac, I have to add this line.... > >James McKenzie Typed "set" Did word search on "library." Nothing.

Dec. 30, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by James McKenzie

On 12/30/10 12:48 PM, Vitaliy Margolen wrote: > On 12/30/2010 12:23 PM, Travis Athougies wrote: >> Tests to ensure the HLSL compiler won't crash on malformed input. > You still haven't fixed strings spanning multiple lines. Please send a > patch that fixes all incorrect strings first. Then continue on with > the correct style. > > Adding more invalid strings because file already contains some of them > isn't a valid reason for broken code. > And you keep on forgetting to number your tries. It looks like you are up to try six or seven for this, correct? James McKenzie

Dec. 30, 2010

Re: oledb32: Use correct 32/64-bit typedefs

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7981 Your paranoid android. === WNT4WSSP6 (32 bit convert) === Can't copy TestLauncher to VM: Cannot connect to the virtual machine === WVISTAADM (32 bit convert) === No test summary line found === W2K8SE (32 bit convert) === No test summary line found

Dec. 30, 2010

Re: gdi32/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7979 Your paranoid android. === WXPPROSP3 (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === W7PRO (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === WVISTAADM (32 bit pen) === No test summary line found === W2K8SE (32 bit pen) === No test summary line found

Dec. 30, 2010

Re: imagehlp/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === W7PRO (32 bit integrity) === No test summary line found

Dec. 30, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Vitaliy Margolen

On 12/30/2010 12:23 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style. Adding more invalid strings because file already contains some of them isn't a valid reason for broken code. Vitaliy.

Dec. 30, 2010

Re: riched32/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7969 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PRO (32 bit editor) === No test summary line found

Dec. 30, 2010

Re: mscms/tests: Fix test message

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7968 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

IGNORE MY LAST POST. I'm away from home and don't have my glasses with me. >Wine build complete. >susan(a)ubuntu:~/wine$ wine checkinstall >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > > >

Dec. 30, 2010

Re: wininet/tests: Don't call GetLastError() twice

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7966 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>>>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>>> >>contain any dwarf information >>>>> >>maybe you're loading another instance of libwine? >>>>> >>A+ >>>>> >> >>>>> >>-- >>>>> >>Eric Pouech >>>>> > >>>>> >I did a search of the file system. >>>>> > >>>>> >Under /usr/local/lib64 I have >>>>> >libwine.so (link) >>>>> >libwine.so.1 (link) >>>>> >libwine.so.1.0 >>>>> >wine [folder} >>> >>>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>>I got the following error: >>>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> >>Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >> >>Otherwise ld might not be able to 'find' it when starting the program. >> >>James McKenzie >> >susan(a)ubuntu:~$ ldd /usr/local/bin/wine > linux-gate.so.1 => (0xf77c6000) > libwine.so.1 => not found > libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) > libc.so.6 => /lib32/libc.so.6 (0xf762f000) > /lib/ld-linux.so.2 (0xf77c7000) > >Eureka, I think. > Just compiled today's git. Could compile but not install. Here's the message. Wine build complete. susan(a)ubuntu:~/wine$ wine checkinstall wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory

Dec. 30, 2010

re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by Dan Kegel

Yegor wrote: > it's my first contribution to wine... Welcome! > so I wanted to start with some simple task. Changing memory allocation might not be simple. Your patch touches two different DLLs. You should probably split this patch up, one patch per dll. Also, the fact that your change to d3dcompiler_43 only changes a malloc and not a corresponding free is interesting. Is there a leak? Better run this past the author of that code. > The source code could be compiled without problems after applying the patch. Verifying that it compiles isn't enough. You also have to verify by eye that this change doesn't introduce any alloc/free mismatches, and check that it doesn't introduce any conformance test regressions. Since not all tests pass, you need to run the tests first without your change, and then with your change, and understand any differences in the results. Since you're messin' with malloc, you should also do that with WINEDEBUG=+heap. - Dan

Dec. 30, 2010

Re: kernel32/tests: Skip some debugger tests on 64-bit

by Jacek Caban

On 12/30/10 4:31 PM, Greg Geldorp wrote: > I get very different results for the kernel32:debugger tests depending on > which compiler I use. With VS2008, the test runs fine. With mingw64 > 4.4.1-1a (used by the TestBot build VM), the child process that's supposed > to crash keeps running, re-executing the instruction that causes the > exception (an assignment through a NULL pointer) again and again. With > mingw64 4.4.0 (used by Alexandre to build winetest.exe) the child process > terminates, but doesn't launch the debugger. FWIW here are results with GCC 4.5.1, mingw-w64 SVN: http://testbot.winehq.org/JobDetails.pl?Key=7956 It fails as well. > One other observation is that the function table in mingw64-generated > executables seems to be borked (or at least incompatible with what the > Microsoft tools expect). When running "dumpbin /unwindinfo" on > mingw64-generated executables, no unwind info is displayed. Since the > function table/unwind info is closely related to exception handling on > x64, I'm blaming the test failures on mingw64. That's not yet supported by GCC. Proper unwind info as well as SEH exception support is planned for GCC 4.6. Jacek

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

-----Original Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Dec 30, 2010 10:38 AM >To: Susan Cragin <susancragin(a)earthlink.net>, Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >Susan Cragin <susancragin(a)earthlink.net> wrote: >>Sent: Dec 30, 2010 8:30 AM >>To: Marcus Meissner <marcus(a)jet.franken.de> >>Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >>Subject: Re: 64-bit Notepad2 crashes >> >>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>> >>contain any dwarf information >>>> >>maybe you're loading another instance of libwine? >>>> >>A+ >>>> >> >>>> >>-- >>>> >>Eric Pouech >>>> > >>>> >I did a search of the file system. >>>> > >>>> >Under /usr/local/lib64 I have >>>> >libwine.so (link) >>>> >libwine.so.1 (link) >>>> >libwine.so.1.0 >>>> >wine [folder} >> >>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>I got the following error: >>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > >Does this 'path' exist in LD_LIBRARY_PATH or equivilent? > >Otherwise ld might not be able to 'find' it when starting the program. > >James McKenzie > susan(a)ubuntu:~$ ldd /usr/local/bin/wine linux-gate.so.1 => (0xf77c6000) libwine.so.1 => not found libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) libc.so.6 => /lib32/libc.so.6 (0xf762f000) /lib/ld-linux.so.2 (0xf77c7000) Eureka, I think.

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by James Mckenzie

Susan Cragin <susancragin(a)earthlink.net> wrote: >Sent: Dec 30, 2010 8:30 AM >To: Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>> >>contain any dwarf information >>> >>maybe you're loading another instance of libwine? >>> >>A+ >>> >> >>> >>-- >>> >>Eric Pouech >>> > >>> >I did a search of the file system. >>> > >>> >Under /usr/local/lib64 I have >>> >libwine.so (link) >>> >libwine.so.1 (link) >>> >libwine.so.1.0 >>> >wine [folder} > >Then I ran ldconfig on the 64-bit, and then tried wine notepad. >I got the following error: >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory Does this 'path' exist in LD_LIBRARY_PATH or equivilent? Otherwise ld might not be able to 'find' it when starting the program. James McKenzie

Dec. 30, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by James Mckenzie

maury loïc <lmaury(a)gmail.com> wrote: > >Hello Ken and the Wine community, > Please bottom post or post directly to a question. Please do not top post. > >On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > >> Hi Loïc, >> >> On Dec 30, 2010, at 4:20 AM, maury loïc wrote: >> >> > it's my first patch, and it implement the CDROM_Verify() >> > to work on Mac Os. >> >> I think most people are going to need more explanation for why this is a >> legitimate way to implement this function on Mac OS X. :) >> >> Cheers, >> Ken >> >> >For what i understood, The function CDROM_Verify(), verify if the media is >present on the device, and Wine try to open >the device(in Mac Os case), before call the CDROM_Verify(). > >But Mac Os manage the device differently from the other Os. It create the >device, only if the media >is already present. Logically, CDROM_Verify() return success, because when >we are in CDROM_Verify() >we already know the device. > >What do you think ? > This has been critically examined by several people and if the solution were this simple it would have been put in place a long time ago. Charles Davis has spend over a year looking at how to implement CDROM functionality for MacOSX. So, here is my question: How can the community be 100% certain that: 1. The device has EXACTLY the same name on every available MacOSX installation? 2. How can you be 100% certain that if the 'device' exists that the code will end up in CDROM_Verify()? James McKenzie (Another Mac User/Wine Tester.)

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >> >>contain any dwarf information >> >>maybe you're loading another instance of libwine? >> >>A+ >> >> >> >>-- >> >>Eric Pouech >> > >> >I did a search of the file system. >> > >> >Under /usr/local/lib64 I have >> >libwine.so (link) >> >libwine.so.1 (link) >> >libwine.so.1.0 >> >wine [folder} >> > >> >Under /usr/local/lib64/wine I have >> >libwinecrt0.a >> >libwined3d.def >> >> I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. >> And I downloaded yesterday's git. >> And now I'm getting a different error. >> wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> This error is for all wine commands, including wine --version >> >> I have the same files under /usr/local/lib64 >> but under user/local/lib64/wine I have lots of so's and def's. >> ?? > >Is /etc/ld.so.conf listing /usr/local/lib64 ? >Did you try running "ldconfig" once? > >Ciao, Marcus No, it is not listing it. It lists only: include /etc/ld.so.conf.d/*.conf Then I checked ld.so.conf.d, which is a directory containing the following conf files: GL lib32asound2 libasound2 libc x86_64-linux-gnu So, I compared those files to those generated with my 32-bit partition. The last file is replaced by the following: i686-linux-gnu.conf and i-486-linux-gnu.conf Then I ran ldconfig on the 64-bit, and then tried wine notepad. I got the following error: wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory ?Susan

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Marcus Meissner

On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: > >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 > >>if you've compiled wine yourself, it's strange that libwine.so doesn't > >>contain any dwarf information > >>maybe you're loading another instance of libwine? > >>A+ > >> > >>-- > >>Eric Pouech > > > >I did a search of the file system. > > > >Under /usr/local/lib64 I have > >libwine.so (link) > >libwine.so.1 (link) > >libwine.so.1.0 > >wine [folder} > > > >Under /usr/local/lib64/wine I have > >libwinecrt0.a > >libwined3d.def > > I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. > And I downloaded yesterday's git. > And now I'm getting a different error. > wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > This error is for all wine commands, including wine --version > > I have the same files under /usr/local/lib64 > but under user/local/lib64/wine I have lots of so's and def's. > ?? Is /etc/ld.so.conf listing /usr/local/lib64 ? Did you try running "ldconfig" once? Ciao, Marcus

Dec. 30, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by maury loïc

Hello Ken and the Wine community, For what i understood, The function CDROM_Verify(), verify if the media is present on the device, and Wine try to open the device(in Mac Os case), before call the CDROM_Verify(). But Mac Os manage the device differently from the other Os. It create the device, only if the media is already present. Logically, CDROM_Verify() return success, because when we are in CDROM_Verify() we already know the device. What do you think ? merci Loïc On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > Hi Loïc, > > On Dec 30, 2010, at 4:20 AM, maury loïc wrote: > > > it's my first patch, and it implement the CDROM_Verify() > > to work on Mac Os. > > I think most people are going to need more explanation for why this is a > legitimate way to implement this function on Mac OS X. :) > > Cheers, > Ken > >

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>contain any dwarf information >>maybe you're loading another instance of libwine? >>A+ >> >>-- >>Eric Pouech > >I did a search of the file system. > >Under /usr/local/lib64 I have >libwine.so (link) >libwine.so.1 (link) >libwine.so.1.0 >wine [folder} > >Under /usr/local/lib64/wine I have >libwinecrt0.a >libwined3d.def I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. And I downloaded yesterday's git. And now I'm getting a different error. wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory This error is for all wine commands, including wine --version I have the same files under /usr/local/lib64 but under user/local/lib64/wine I have lots of so's and def's. ??

Dec. 30, 2010

Re: [PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by James McKenzie

On 12/30/10 5:02 AM, Yegor Yefremov wrote: > Hello, > > it's my first contribution to wine, so I wanted to start with some > simple task. After fixing the files mentioned in the attached patch, > following files in dlls folder still contain malloc/free calls: > > dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - > config_dir ))) fatal_error( "out of memory\n" ); > dlls/msvcrt/heap.c: * malloc (MSVCRT.@) > dlls/msvcrt/tests/printf.c: str = malloc(1024); > dlls/msvcrt/tests/printf.c: str = malloc(1024); > dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); > dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); > dlls/msvcrt/tests/heap.c: mem = malloc(0); > dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); > dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if > these methods haven't been > > As far as I understand those files test the core functionality and > should use malloc. If this is so, then malloc/free replacement for > dlls is complete. > > The source code could be compiled without problems after applying the patch. > > I'm behind a firewall and couldn't clone the repository even via http > (for some other projects it is functioning). That's why my patch was > made with quilt. See the GitWine page in the Wiki on how to create git exports. James McKenzie

Dec. 30, 2010

[PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by Yegor Yefremov

Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - config_dir ))) fatal_error( "out of memory\n" ); dlls/msvcrt/heap.c: * malloc (MSVCRT.@) dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem = malloc(0); dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if these methods haven't been As far as I understand those files test the core functionality and should use malloc. If this is so, then malloc/free replacement for dlls is complete. The source code could be compiled without problems after applying the patch. I'm behind a firewall and couldn't clone the repository even via http (for some other projects it is functioning). That's why my patch was made with quilt. Best regards, Yegor

Dec. 30, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by Ken Thomases

Hi Loïc, On Dec 30, 2010, at 4:20 AM, maury loïc wrote: > it's my first patch, and it implement the CDROM_Verify() > to work on Mac Os. I think most people are going to need more explanation for why this is a legitimate way to implement this function on Mac OS X. :) Cheers, Ken

Dec. 30, 2010

ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by maury loïc

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >if you've compiled wine yourself, it's strange that libwine.so doesn't >contain any dwarf information >maybe you're loading another instance of libwine? >A+ > >-- >Eric Pouech I did a search of the file system. Under /usr/local/lib64 I have libwine.so (link) libwine.so.1 (link) libwine.so.1.0 wine [folder} Under /usr/local/lib64/wine I have libwinecrt0.a libwined3d.def Do you want copies of so.1.0?

Dec. 29, 2010

Re: shlwapi/tests: Fix typo

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7951 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 29, 2010

Re: msi/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 29, 2010

Re: urlmon/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7948 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Dec. 29, 2010

Re: comdlg32/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7933 Your paranoid android. === WVISTAADM (32 bit filedlg) === No test summary line found === W7PRO (32 bit filedlg) === No test summary line found

Dec. 29, 2010

Re: dsound/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7930 Your paranoid android. === WVISTAADM (32 bit dsound) === No test summary line found

Dec. 29, 2010

Re: setupapi/tests: Don't test function directly when reporting GetLastError() (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7929 Your paranoid android. === WVISTAADM (32 bit devinst) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\setupapi_test.exe, error 32 === W7PRO (32 bit devinst) === Failure running script in VM: Exceeded timeout limit of 315 sec

Dec. 29, 2010

Re: shlwapi/tests: Don't test function directly when reporting GetLastError()

by André Hentschel

Am 29.12.2010 20:19, schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=7932 > > Your paranoid android. > > > === WINEBUILD (build) === > Patch failed to apply If you look into the log you see that Marvin really got confused -- Best Regards, André Hentschel

Dec. 29, 2010

Re: shlwapi/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7932 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 29, 2010

Re: 64-bit Notepad2 crashes

by Eric Pouech

> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of libwine? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Dec. 29, 2010

Re: [PATCH 1/3 resend] jscript: Don't unescape '\v'.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7912 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 29, 2010

Re: [PATCH 1/3] jscript: Don't unescape '\v'.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7908 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 29, 2010

Re: [PATCH 2/3] jscript: Return 'unknown' in typeof operator for native object's values that can't be retrieved

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7909 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 29, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>> >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> >> Stack dump: >> >> 0x000000000022b470: 0000000000000000 0000000000000000 >> >> 0x000000000022b480: 0000000000000000 0000000000000000 >> >> 0x000000000022b490: 0000000000000000 0000000000000000 >> >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >> >[snip] >> >> Backtrace: >> >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) >> > >> >The stack has been blitzed? Or is this local variables (even though >> >PathIsUNCW doesn't have any)? It's hard to know what's going on >> >without a proper stack trace. PathIsUNCW is such a small function, the >> >problem is almost certainly further up the call chain. >> >> Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? >> >> There used to be a place to post log files so people could look at them... but I've forgotten where it is. > >I was not able to reproduce this here on openSUSE 11.3, >using Notepad2-4.1.24-x86-64.zip from http://www.flos-freeware.ch/notepad2.html > >Is this the one you used? > >The sourcecode shows it calling PathIsUNCW just with a stackbuffer in >src/Dialog.c, which should be safe. > >Ciao, Marcus That is the one I used. To be clear about what I did, that file on the download site is an installation exe. I opened the compressed file and just used the program's exe and ini files by copying them to my home directory. I have compiled three logs, all, seh & relay, and have compressed them, and a copy of the program and ini file I used, and have downloaded all to the following. https://www.yousendit.com/download/RlRxT20zT2JYSHhjR0E9PQ I did not configure any special compiler optimizations. I am running Ubuntu's Natty 64-bit Studio with linux 2.6.37-11-generic.

Dec. 29, 2010

Re: 64-bit Notepad2 crashes

by Marcus Meissner

On Tue, Dec 28, 2010 at 07:28:16PM -0500, Susan Cragin wrote: > > > > -----Original Message----- > >From: Austin Lund <austin.lund(a)gmail.com> > >Sent: Dec 28, 2010 6:14 PM > >To: Susan Cragin <susancragin(a)earthlink.net> > >Cc: Wine Developers <wine-devel(a)winehq.org> > >Subject: Re: 64-bit Notepad2 crashes > > > >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: > >> Stack dump: > >> 0x000000000022b470: 0000000000000000 0000000000000000 > >> 0x000000000022b480: 0000000000000000 0000000000000000 > >> 0x000000000022b490: 0000000000000000 0000000000000000 > >> 0x000000000022b4a0: 0000000000000000 0000000000000000 > >> 0x000000000022b4b0: 0000000000000000 0000000000000000 > >[snip] > >> Backtrace: > >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) > > > >The stack has been blitzed? Or is this local variables (even though > >PathIsUNCW doesn't have any)? It's hard to know what's going on > >without a proper stack trace. PathIsUNCW is such a small function, the > >problem is almost certainly further up the call chain. > > Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? > > There used to be a place to post log files so people could look at them... but I've forgotten where it is. I was not able to reproduce this here on openSUSE 11.3, using Notepad2-4.1.24-x86-64.zip from http://www.flos-freeware.ch/notepad2.html Is this the one you used? The sourcecode shows it calling PathIsUNCW just with a stackbuffer in src/Dialog.c, which should be safe. Ciao, Marcus

Dec. 29, 2010

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (msvcr80, 90 and 100 benefits from this) (resend)

by Alexandre Julliard

Arno Teigseth <arnotixe(a)gmail.com> writes: > @@ -47,9 +76,16 @@ static void __cdecl test_invalid_parameter_handler(const wchar_t *expression, > const wchar_t *function, const wchar_t *file, > unsigned line, uintptr_t arg) > { > - /* we just ignore handler calls */ > + /* we USED TO just ignore handler calls */ > + CHECK_EXPECT(invalid_parameter_handler); > + ok(expression == NULL, "expression is not NULL\n"); > + ok(function == NULL, "function is not NULL\n"); > + ok(file == NULL, "file is not NULL\n"); > + ok(line == 0, "line = %u\n", line); > + ok(arg == 0, "arg = %lx\n", (UINT_PTR)arg); msvcrt doesn't allow changing the handler. Invalid parameter tests have to be in msvcr90. -- Alexandre Julliard julliard(a)winehq.org

Dec. 29, 2010

Re: xmllite/tests: Use an iface instead of a vtbl pointer in testinput.

by Michael Stefaniuc

Hello Greg, On 12/29/2010 03:44 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=7894 > > Your paranoid android. > > > === WVISTAADM (32 bit reader) === > No test summary line found > > === W7PRO (32 bit reader) === > No test summary line found something is fishy here. Those two machines that failed have run the user32/win test instead of the xmllite/reader test. thanks bye michael

Dec. 29, 2010

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt take 4 Can't believe I forgot to commit before creating the patch...

by James Mckenzie

Arno Teigseth <arnotixe(a)gmail.com> wrote: > You'll have to resend both parts of the patch for the testbot to recognize them. Use (resend) in the subject line for us humans. James McKenzie

Dec. 28, 2010

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (The function was moved from msvcr90 to msvcrt so that msvcr80, 90 and 100

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7897 Your paranoid android. === WINEBUILD (build) === Make failed

Dec. 28, 2010

Re: xmllite/tests: Use an iface instead of a vtbl pointer in testinput.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7894 Your paranoid android. === WVISTAADM (32 bit reader) === No test summary line found === W7PRO (32 bit reader) === No test summary line found

Dec. 28, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

-----Original Message----- >From: Austin Lund <austin.lund(a)gmail.com> >Sent: Dec 28, 2010 6:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: Wine Developers <wine-devel(a)winehq.org> >Subject: Re: 64-bit Notepad2 crashes > >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> Stack dump: >> 0x000000000022b470: 0000000000000000 0000000000000000 >> 0x000000000022b480: 0000000000000000 0000000000000000 >> 0x000000000022b490: 0000000000000000 0000000000000000 >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >[snip] >> Backtrace: >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) > >The stack has been blitzed? Or is this local variables (even though >PathIsUNCW doesn't have any)? It's hard to know what's going on >without a proper stack trace. PathIsUNCW is such a small function, the >problem is almost certainly further up the call chain. Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? There used to be a place to post log files so people could look at them... but I've forgotten where it is.

Dec. 28, 2010

Re: 64-bit Notepad2 crashes

by Austin Lund

On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: > Stack dump: > 0x000000000022b470: 0000000000000000 0000000000000000 > 0x000000000022b480: 0000000000000000 0000000000000000 > 0x000000000022b490: 0000000000000000 0000000000000000 > 0x000000000022b4a0: 0000000000000000 0000000000000000 > 0x000000000022b4b0: 0000000000000000 0000000000000000 [snip] > Backtrace: > =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) The stack has been blitzed? Or is this local variables (even though PathIsUNCW doesn't have any)? It's hard to know what's going on without a proper stack trace. PathIsUNCW is such a small function, the problem is almost certainly further up the call chain.

Dec. 28, 2010

Re: ntdll/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7877 Your paranoid android. === W7PROX64 (32 bit exception) === No test summary line found === WVISTAADM (32 bit directory) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\ntdll_test.exe, error 32

Dec. 28, 2010

64-bit Notepad2 crashes

by Susan Cragin

I just compiled today's git wine-1.3.10-82-g10b1a7e and tried to run Notepad2's 64-bit version. Below is the crash. Wine's Notepad appears to work fine. Can anyone tell if I should file a wine bug or a Notepad2 bug? I'm on Ubuntu Natty. Thanks. $ wine64 Notepad2 fixme:heap:HeapSetInformation 0x2b4000 0 0x22fce0 4 fixme:commdlg:GetFileName95 Flags 0x02000000 not yet implemented wine: Unhandled page fault on read access to 0x00000026 at address 0x7f3a9dd5cafb (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000026 in 64-bit code (0x00007f3a9dd5cafb). Register dump: rip:00007f3a9dd5cafb rsp:000000000022b470 rbp:000000000022b860 eflags:00010202 ( R- -- I - - - ) rax:0000000000000000 rbx:0000000000000026 rcx:0000000000000026 rdx:0000000000000026 rsi:000000000022bd40 rdi:0000000000000000 r8:000000000022afa0 r9:0000000000000004 r10:0000000000000000 r11:0000000000000246 r12:0000000000000001 r13:0000000000000001 r14:0000000000000000 r15:0000000000000000 Stack dump: 0x000000000022b470: 0000000000000000 0000000000000000 0x000000000022b480: 0000000000000000 0000000000000000 0x000000000022b490: 0000000000000000 0000000000000000 0x000000000022b4a0: 0000000000000000 0000000000000000 0x000000000022b4b0: 0000000000000000 0000000000000000 0x000000000022b4c0: 0000000000000000 0000000000000000 0x000000000022b4d0: 0000000000000000 0000000000000000 0x000000000022b4e0: 0000000000000000 0000000000000000 0x000000000022b4f0: 0000000000000000 0000000000000000 0x000000000022b500: 0000000000000000 0000000000000000 0x000000000022b510: 0000000000000026 000000000022bd40 0x000000000022b520: 0000000000000000 00007f3a9dd5e951 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) 0x00007f3a9dd5cafb PathIsUNCW+0x7b in shlwapi: cmpw $5c,(%rbx) Modules: Module Address Debug info Name (83 modules) ELF 7b800000- 7bbb5000 Deferred kernel32<elf> \-PE 7b820000- 7bbb5000 \ kernel32 ELF 7be00000- 7c103000 Deferred <wine-loader> PE 140000000- 140167000 Deferred notepad2 ELF 7f3a978cd000- 7f3a97ae0000 Deferred msimg32<elf> \-PE 7f3a978d0000- 7f3a97ae0000 \ msimg32 ELF 7f3a97ae0000- 7f3a97ce9000 Deferred librt.so.1 ELF 7f3a97ce9000- 7f3a97eed000 Deferred libgpg-error.so.0 ELF 7f3a97eed000- 7f3a98108000 Deferred libresolv.so.2 ELF 7f3a98108000- 7f3a9830b000 Deferred libkeyutils.so.1 ELF 7f3a9830b000- 7f3a9854f000 Deferred libdbus-1.so.3 ELF 7f3a9854f000- 7f3a987c9000 Deferred libgcrypt.so.11 ELF 7f3a987c9000- 7f3a989da000 Deferred libtasn1.so.3 ELF 7f3a989da000- 7f3a98be2000 Deferred libkrb5support.so.0 ELF 7f3a98be2000- 7f3a98de6000 Deferred libcom_err.so.2 ELF 7f3a98de6000- 7f3a9900d000 Deferred libk5crypto.so.3 ELF 7f3a9900d000- 7f3a992d1000 Deferred libkrb5.so.3 ELF 7f3a992d1000- 7f3a994e2000 Deferred libavahi-client.so.3 ELF 7f3a994e2000- 7f3a996ee000 Deferred libavahi-common.so.3 ELF 7f3a996ee000- 7f3a9998f000 Deferred libgnutls.so.26 ELF 7f3a9998f000- 7f3a99bc4000 Deferred libgssapi_krb5.so.2 ELF 7f3a99bc4000- 7f3a99e14000 Deferred libcups.so.2 ELF 7f3a99e76000- 7f3a9a0b0000 Deferred uxtheme<elf> \-PE 7f3a99e80000- 7f3a9a0b0000 \ uxtheme ELF 7f3a9a0b0000- 7f3a9a2b6000 Deferred libxfixes.so.3 ELF 7f3a9a2b6000- 7f3a9a4c0000 Deferred libxcursor.so.1 ELF 7f3a9a4c0000- 7f3a9a6c3000 Deferred libxcomposite.so.1 ELF 7f3a9a6c3000- 7f3a9a8cc000 Deferred libxrandr.so.2 ELF 7f3a9a8cc000- 7f3a9aad6000 Deferred libxrender.so.1 ELF 7f3a9aad6000- 7f3a9acdc000 Deferred libxxf86vm.so.1 ELF 7f3a9acdc000- 7f3a9aedf000 Deferred libxinerama.so.1 ELF 7f3a9aedf000- 7f3a9b0e5000 Deferred libxdmcp.so.6 ELF 7f3a9b0e5000- 7f3a9b2e8000 Deferred libxau.so.6 ELF 7f3a9b2e8000- 7f3a9b505000 Deferred libxcb.so.1 ELF 7f3a9b505000- 7f3a9b70a000 Deferred libuuid.so.1 ELF 7f3a9b70a000- 7f3a9b925000 Deferred libice.so.6 ELF 7f3a9b925000- 7f3a9bc5c000 Deferred libx11.so.6 ELF 7f3a9bc5c000- 7f3a9be6e000 Deferred libxext.so.6 ELF 7f3a9be6e000- 7f3a9c076000 Deferred libsm.so.6 ELF 7f3a9c093000- 7f3a9c358000 Deferred winex11<elf> \-PE 7f3a9c0b0000- 7f3a9c358000 \ winex11 ELF 7f3a9c3c7000- 7f3a9c5f0000 Deferred libexpat.so.1 ELF 7f3a9c5f0000- 7f3a9c826000 Deferred libfontconfig.so.1 ELF 7f3a9c826000- 7f3a9ca3e000 Deferred libz.so.1 ELF 7f3a9ca3e000- 7f3a9ccc5000 Deferred libfreetype.so.6 ELF 7f3a9cce2000- 7f3a9cf24000 Deferred winspool<elf> \-PE 7f3a9ccf0000- 7f3a9cf24000 \ winspool ELF 7f3a9cf24000- 7f3a9d1e9000 Deferred comdlg32<elf> \-PE 7f3a9cf30000- 7f3a9d1e9000 \ comdlg32 ELF 7f3a9d1e9000- 7f3a9d410000 Deferred imm32<elf> \-PE 7f3a9d1f0000- 7f3a9d410000 \ imm32 ELF 7f3a9d410000- 7f3a9d6a3000 Deferred rpcrt4<elf> \-PE 7f3a9d420000- 7f3a9d6a3000 \ rpcrt4 ELF 7f3a9d6a3000- 7f3a9da23000 Deferred ole32<elf> \-PE 7f3a9d6d0000- 7f3a9da23000 \ ole32 ELF 7f3a9da23000- 7f3a9dd1e000 Deferred comctl32<elf> \-PE 7f3a9da30000- 7f3a9dd1e000 \ comctl32 ELF 7f3a9dd1e000- 7f3a9dfae000 Export shlwapi<elf> \-PE 7f3a9dd30000- 7f3a9dfae000 \ shlwapi ELF 7f3a9dfae000- 7f3a9e3e8000 Deferred shell32<elf> \-PE 7f3a9dfc0000- 7f3a9e3e8000 \ shell32 ELF 7f3a9e3e8000- 7f3a9e601000 Deferred version<elf> \-PE 7f3a9e3f0000- 7f3a9e601000 \ version ELF 7f3a9e601000- 7f3a9e87d000 Deferred advapi32<elf> \-PE 7f3a9e610000- 7f3a9e87d000 \ advapi32 ELF 7f3a9e87d000- 7f3a9eb44000 Deferred gdi32<elf> \-PE 7f3a9e890000- 7f3a9eb44000 \ gdi32 ELF 7f3a9eb44000- 7f3a9eedb000 Deferred user32<elf> \-PE 7f3a9eb60000- 7f3a9eedb000 \ user32 ELF 7f3a9f17f000- 7f3a9f38c000 Deferred libnss_files.so.2 ELF 7f3a9f38c000- 7f3a9f598000 Deferred libnss_nis.so.2 ELF 7f3a9f598000- 7f3a9f7b2000 Deferred libnsl.so.1 ELF 7f3a9f7b2000- 7f3a9f9bb000 Deferred libnss_compat.so.2 ELF 7f3a9f9bb000- 7f3a9fbd1000 Deferred libgcc_s.so.1 ELF 7f3a9fbd1000- 7f3a9fe55000 Deferred libm.so.6 ELF 7f3a9fe55000- 7f3aa0145000 Deferred ntdll<elf> \-PE 7f3a9fe70000- 7f3aa0145000 \ ntdll ELF 7f3aa0148000- 7f3aa034c000 Deferred libdl.so.2 ELF 7f3aa034c000- 7f3aa06cf000 Deferred libc.so.6 ELF 7f3aa06d0000- 7f3aa08ee000 Deferred libpthread.so.0 ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 ELF 7f3aa0c3f000- 7f3aa0e61000 Deferred ld-linux-x86-64.so.2 ELF 7fffd69ff000- 7fffd6a00000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\susan\Notepad2.exe 0000001b 0 00000009 0 <== 0000000e services.exe 00000016 0 00000015 0 00000014 0 00000010 0 0000000f 0 00000011 winedevice.exe 00000018 0 00000017 0 00000013 0 00000012 0 00000019 explorer.exe 0000001a 0 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) err:seh:setup_exception stack overflow 2560 bytes in thread 0009 eip 00007f3a9fe9ce7b esp 0000000000130c00 stack 0x130000-0x131000-0x230000

Dec. 28, 2010

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value [try 2]

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -49,6 +49,7 @@ echo %UNKNOWN%S > echo P%UNKNOWN% > echo P%UNKNOWN%S > echo %ERRORLEVEL > +cmd /c exit 0 > echo %ERRORLEVEL% > echo %ERRORLEVEL%%ERRORLEVEL% > echo %ERRORLEVEL%ERRORLEVEL% It already has a defined value. What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.org

Dec. 28, 2010

Re: msvcrt: Implement _fcvt_s. (resend)

by Alexandre Julliard

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > @@ -1127,9 +1127,9 @@ int CDECL _ecvt_s( char *buffer, MSVCRT_size_t length, double number, int ndigit > /* special case - inf */ > if(number == HUGE_VAL || number == -HUGE_VAL) > { > - memset(buffer, '0', ndigits); > + memset(buffer, '0', max(ndigits, 0)); > memcpy(buffer, infret, min(ndigits, sizeof(infret) - 1 ) ); > - buffer[ndigits] = '\0'; > + buffer[max(ndigits, 0)] = '\0'; You'd have to fix the memcpy too, though the whole thing doesn't make much sense if ndigits is negative. Probably needs to be rethought, with some test cases. -- Alexandre Julliard julliard(a)winehq.org

Dec. 28, 2010

Re: [PATCH 4/8] jscript: Ensure that the whole script is parsed

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7868 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 28, 2010

Re: [PATCH 1/8] jscript: Better syntax error tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7867 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 28, 2010

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox

by Henri Verbeet

On 28 December 2010 11:25, David Adam <david.adam.cnrs(a)gmail.com> wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) > +/************************************************************************* > + * D3DXCreateMeshFVF > + */ > +HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 pDevice, FLOAT fWidth, FLOAT fHeight, FLOAT fDepth, LPD3DXMESH *ppMesh, LPD3DXBUFFER *ppAdjacency) Seriously.

Dec. 28, 2010

Re: 64-bit works but Notepad takes a long time to come up, using today's git

by Susan Cragin

>On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: >> I maybe should have filed this as a bug. >> I know Wine had a regression in 64-bit, and that such regression received a patch. >> I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. >> wine-1.3.10-48-g1288078 > > >Was the the first try or the second? >wineboot after a new version might take a bit. >It takes nearly no time here. > >Could you bisect to the slow down? Perhaps some printer stuff? > >Ciao, Marcus I think I've solved what is probably my problem. Notepad when started with the command "wine64" runs quickly. Notepad started with "wine" ran very slowly on one 64-bit partition that I've fiddled with a lot, and not at all on a cleaner 64-bit partition. Sorry for the confusion.

Dec. 27, 2010

Re: [PATCH 1/2] mshtml: COM cleanup for the nsIWebBrowserChrome iface.

by Michael Stefaniuc

Forgot to mention that this patch applies on top of Jacek's "mshtml: Fixed unsafe cast in CreateChromeWindow2 implementation" patch. On 12/27/2010 11:27 PM, Michael Stefaniuc wrote: > --- > dlls/mshtml/mshtml_private.h | 3 +- > dlls/mshtml/nsembed.c | 97 +++++++++++++++++++++-------------------- > dlls/mshtml/nsio.c | 8 ++-- > 3 files changed, 55 insertions(+), 53 deletions(-) bye michael

Dec. 27, 2010

Re: 64-bit works but Notepad takes a long time to come up, using today's git

by Marcus Meissner

On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: > I maybe should have filed this as a bug. > I know Wine had a regression in 64-bit, and that such regression received a patch. > I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. > wine-1.3.10-48-g1288078 Was the the first try or the second? wineboot after a new version might take a bit. It takes nearly no time here. Could you bisect to the slow down? Perhaps some printer stuff? Ciao, Marcus

Dec. 27, 2010

64-bit works but Notepad takes a long time to come up, using today's git

by Susan Cragin

I maybe should have filed this as a bug. I know Wine had a regression in 64-bit, and that such regression received a patch. I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. wine-1.3.10-48-g1288078

Dec. 27, 2010

Re: spoolss/tests: Skip tests on Win7

by Paul Vriens

On 12/27/2010 12:47 PM, Greg Geldorp wrote: >> From: Paul Vriens >> But that means we will skip on Wine as well (when/if implemented). Is >> that OK? > > We skip if UnloadDriver is NOT present. It is present on Wine, so the tests > do run on Wine. Win7 is the only platform where the function is not present. > > Greg. Duh, I think I call it a year and start again fresh in 2011 ;) -- Cheers, Paul.

Dec. 27, 2010

Re: [PATCH 2/2] jscript: Added ScriptEngine*Version functions implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7836 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 27, 2010

Re: [PATCH 1/2] jscript: Added ScriptEngine() implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7835 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 27, 2010

Re: mshtml: COM cleanup for the IHTMLWindow2 iface.

by Jacek Caban

On 12/27/10 12:50 PM, Michael Stefaniuc wrote: > --- > Jacek, I don't like the usage of impl_from_IHTMLWindow2() in > HTMLWindow_invoke() as that isn't a method of the IHTMLWindow2 vtbl. Can > you please cross check that and clean it up if necessary? That's fine itself, the IUnknown passed there is defined by HTMLWindow object and it's IHTMLWindow2 iface in this case. However it can be done better and we can avoid this particular impl_from_IHTMLWindow2 call. I will send a patch after your patch will be in Git. Thanks, Jacek

Dec. 27, 2010

RE: spoolss/tests: Skip tests on Win7

by Greg Geldorp

> From: Paul Vriens > But that means we will skip on Wine as well (when/if implemented). Is > that OK? We skip if UnloadDriver is NOT present. It is present on Wine, so the tests do run on Wine. Win7 is the only platform where the function is not present. Greg.

Dec. 27, 2010

Re: spoolss/tests: Skip tests on Win7

by Paul Vriens

On 12/27/2010 12:35 PM, Greg Geldorp wrote: > --- > dlls/spoolss/tests/spoolss.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > But that means we will skip on Wine as well (when/if implemented). Is that OK? -- Cheers, Paul.

Dec. 27, 2010

Re: Hebrew version of Wine History

by Paul Vriens

On 12/24/2010 01:32 AM, Yaron Shahrabani wrote: > Hey, I translated the Wine History into Hebrew several weeks ago and I > noticed that although the patches are in, when I click on Wine's History > on the Hebrew website I'm being taken to the English version of the > document in Wine's wiki. That's actually because the link on the Hebrew 'about' page points to the wiki: 20 <li><a href="http://wiki.winehq.org/WineHistory">היסטוריית מיזם Wine</a></li> Granted, when one goes to http://www.winehq.org/history one is also redirected to the wiki (.htaccess magic I guess). > > Wine's history is pretty important to the Israeli community in various > aspects, can it be fixed? So, I'm not sure how to 'fix' this. To be able to use the Hebrew history template the .htaccess has to be 'fixed' but I think that the English version was deprecated in favor of the wiki one. So maybe introduce some Hebrew to the wiki and point to there instead? -- Cheers, Paul.

Dec. 27, 2010

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7830 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 73 (got '0', wanted '5') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2KPROSP4 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WXPPROSP3 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K3R2SESP2 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WVISTAADM (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K8SE (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PRO (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (64 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55')

Dec. 26, 2010

Feature Request: winefile: some way to open terminal in current folder

by Ilya Basin

A typical scenario: - download a file with uTorrent - select "Open containing folder" - ??? - use a native program to work with the downloaded file I think, it would be convenient to add a button to start a terminal or do "xdg-open ."

Dec. 26, 2010

Re: sound issues (which are not cared since 1.3.1)

by Marcus Meissner

On Sat, Dec 25, 2010 at 11:22:48PM +0100, wylda(a)volny.cz wrote: > > Hi guys, > > there are bug reports showing random crashes with audio on, during > winecfg etc. I was bit by those too... There is probably something > wrong how regressions are handled here, which goes on and thus there > are unneeded bugreports which cost everyone's time to read, > evaluate, search, mark, retest... Why don't you use revert more > offen like kernel guys? > > > Back to the sound issue - my zero programming skill standing just on > sound despair, i guess in dlls/winealsa.drv/mixer.c ALSA_MixerInit() > should be > > int card, err, capcontrols=0 > > otherwise things like: > > mixdev[mixnum].chans += capcontrols; > > mixdev[mixnum].lines = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(line) * mixdev[mixnum].chans); > > mixdev[mixnum].controls = HeapAlloc(GetProcessHeap(), > HEAP_ZERO_MEMORY, sizeof(control) * > CONTROLSPERLINE*mixdev[mixnum].chans); > > > goes crazy like in http://bugs.winehq.org/show_bug.cgi?id=25231#c2. > Could someone review this piece of code, please? well spotted, the patch incorrectly removed the = 0. I submitted a patch readding it. This specific regression I did not hear about it yet, if someone sees such a regression on bisect, please get the right people in the bugzilla (like the author of the patch) and/or post to the list pointing out the regression. The point is ... speak up if you see such a clear regression. Ciao, Marcus

Dec. 26, 2010

sound issues (which are not cared since 1.3.1)

by wylda＠volny.cz

Hi guys, there are bug reports showing random crashes with audio on, during winecfg etc. I was bit by those too... There is probably something wrong how regressions are handled here, which goes on and thus there are unneeded bugreports which cost everyone's time to read, evaluate, search, mark, retest... Why don't you use revert more offen like kernel guys? Back to the sound issue - my zero programming skill standing just on sound despair, i guess in dlls/winealsa.drv/mixer.c ALSA_MixerInit() should be int card, err, capcontrols=0 otherwise things like: mixdev[mixnum].chans += capcontrols; mixdev[mixnum].lines = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(line) * mixdev[mixnum].chans); mixdev[mixnum].controls = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(control) * CONTROLSPERLINE*mixdev[mixnum].chans); goes crazy like in http://bugs.winehq.org/show_bug.cgi?id=25231#c2. Could someone review this piece of code, please? Thanks, W.

Dec. 25, 2010

Re:

by wylda＠volny.cz

My WinXP AntiVirus just says "Exploit JavaScript Obfuscation" ;) Maybe harmless for linux users... W. ----- PŮVODNÍ ZPRÁVA ----- Od: "Tom Wickline" <twickline(a)gmail.com> Komu: "paulo lesgaz" <jeremielapuree(a)yahoo.fr> Předmět: Re: Datum: 25.12.2010 - 15:12:30 > Don't go to the link below... > > Reported Attack Page! > > This web page at 2nax.awardspace.com has been > reported as an attack page and > has been blocked based on your security > preferences. > > Attack pages try to install programs that steal > private information, use > your computer to attack others, or damage your > system. > > Some attack pages intentionally distribute harmful > software, but many are > compromised without the knowledge or permission of > their owners. > > paulo lesgaz, you need to get a life :) > > Cheers, > Tom > > On Sat, Dec 25, 2010 at 10:07 PM, paulo lesgaz > <jeremielapuree(a)yahoo.fr> > wrote: > > > > ***2nax.awardspace.com*** > > > > > > > > > > -- > Wine is not a conclusion but a process... >

Dec. 25, 2010

Re:

by Tom Wickline

Don't go to the link below... Reported Attack Page! This web page at 2nax.awardspace.com has been reported as an attack page and has been blocked based on your security preferences. Attack pages try to install programs that steal private information, use your computer to attack others, or damage your system. Some attack pages intentionally distribute harmful software, but many are compromised without the knowledge or permission of their owners. paulo lesgaz, you need to get a life :) Cheers, Tom On Sat, Dec 25, 2010 at 10:07 PM, paulo lesgaz <jeremielapuree(a)yahoo.fr> wrote: > > ***2nax.awardspace.com*** > > > -- Wine is not a conclusion but a process...

Dec. 25, 2010

None

by paulo lesgaz

http://2nax.awardspace.com/page.php

Dec. 25, 2010

Re: d3dxcreatebox

by Stefan Dösinger

Am Freitag 24 Dezember 2010, 12:43:30 schrieb David Adam: > Hello, > > is there any problem with the patch for D3DXCreateBox? > I think it was not commited. I guess I should have reviewed it, but didn't :-/ Anyway, here is what I found: * There are some whitespace issues, like trailing spaces and a newline inserted in struct vertex * ((DWORD *)ID3DXBuffer_GetBufferPointer(*ppAdjacency))[i] = adjacency[i]; I'd store the buffer pointer in a local variable to make the line simpler * There are formating changes in D3DXCreateSphere and D3DXCreateCylinder, although I guess they're ok to keep the formating of those functions similar to D3DXCreateBox * expected_adjacency in the test could be made static const * in the test, memset(..., 0, ...) is prefered over ZeroMemory * The test doesn't destroy the d3d object if window creation fails. * The test doesn't delete the buffer it creates with D3DXCreateBuffer

Dec. 25, 2010

Re: [2/2]setupapi/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7825 Your paranoid android. === WNT4WSSP6 (32 bit misc) === No test summary line found

Dec. 24, 2010

Re: Eryk Wieliczko : msvcrt/tests: Add _fcvt_s tests.

by Alexandre Julliard

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > Quick question: why todo_wine? It fails otherwise. Failing tests can't be committed. -- Alexandre Julliard julliard(a)winehq.org

Dec. 24, 2010

Re: Eryk Wieliczko : msvcrt/tests: Add _fcvt_s tests.

by Eryk Wieliczko

Quick question: why todo_wine? Respectfully, Eryk Wieliczko 2010/12/23 Alexandre Julliard <julliard(a)winehq.org>: > Module: wine > Branch: master > Commit: b74ef16d99f3c2f7e4a0a7e453c71b6da2c70310 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b74ef16d99f3c2f7e4a0a7e45… > > Author: Eryk Wieliczko <ewdevel(a)gmail.com> > Date: Wed Dec 22 23:10:56 2010 +0100 > > msvcrt/tests: Add _fcvt_s tests. > > --- > > dlls/msvcrt/tests/printf.c | 29 +++++++++++++++++++++++++++-- > 1 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c > index 87efd16..d32ef73 100644 > --- a/dlls/msvcrt/tests/printf.c > +++ b/dlls/msvcrt/tests/printf.c > @@ -40,6 +40,8 @@ static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, > __ms_va_list valist); > static int (__cdecl *p__ecvt_s)(char *buffer, size_t length, double number, > int ndigits, int *decpt, int *sign); > +static int (__cdecl *p__fcvt_s)(char *buffer, size_t length, double number, > + int ndigits, int *decpt, int *sign); > > static void init( void ) > { > @@ -49,6 +51,7 @@ static void init( void ) > p__vscwprintf = (void *)GetProcAddress(hmod, "_vscwprintf"); > p__vsnwprintf_s = (void *)GetProcAddress(hmod, "_vsnwprintf_s"); > p__ecvt_s = (void *)GetProcAddress(hmod, "_ecvt_s"); > + p__fcvt_s = (void *)GetProcAddress(hmod, "_fcvt_s"); > } > > static void test_sprintf( void ) > @@ -799,7 +802,7 @@ static void test_xcvt(void) > "_fcvt() decimal point wrong, got %d expected %d\n", decpt, > test_cvt_testcases[i].expdecpt_f); > ok( sign == test_cvt_testcases[i].expsign, > - "_ecvt() sign wrong, got %d expected %d\n", sign, > + "_fcvt() sign wrong, got %d expected %d\n", sign, > test_cvt_testcases[i].expsign); > } > > @@ -823,7 +826,29 @@ static void test_xcvt(void) > free(str); > } > else > - win_skip("_ecvt_s not available\n"); > + win_skip("_ecvt_s not available\n"); > + > + if (p__fcvt_s) > + { > + str = malloc(1024); > + for( i = 0; strcmp( test_cvt_testcases[i].expstr_e, "END"); i++){ > + decpt = sign = 100; > + err = p__fcvt_s(str, 1024, test_cvt_testcases[i].value, test_cvt_testcases[i].nrdigits, &decpt, &sign); > + ok(err == 0, "_fcvt_s() failed with error code %d", err); > + ok( 0 == strncmp( str, test_cvt_testcases[i].expstr_f, 15), > + "_fcvt_s() bad return, got \n'%s' expected \n'%s'\n", str, > + test_cvt_testcases[i].expstr_e); > + ok( decpt == test_cvt_testcases[i].expdecpt_f, > + "_fcvt_s() decimal point wrong, got %d expected %d\n", decpt, > + test_cvt_testcases[i].expdecpt_e); > + ok( sign == test_cvt_testcases[i].expsign, > + "_fcvt_s() sign wrong, got %d expected %d\n", sign, > + test_cvt_testcases[i].expsign); > + } > + free(str); > + } > + else > + todo_wine win_skip("_fcvt_s not available\n"); > } > > static int __cdecl _vsnwprintf_wrapper(wchar_t *str, size_t len, const wchar_t *format, ...) > > > >

Dec. 24, 2010

d3dxcreatebox

by David Adam

Hello, is there any problem with the patch for D3DXCreateBox? I think it was not commited. Thanks in advance for any feedback? A+ David

Dec. 24, 2010

Dear friend!

by paulo lesgaz

Dear friend, How are you recently? I bought a laptop from a website: www.yedew.com last week. I have got the product. Its quality is very good and the price is competitive. They also sell phones, TV, psp, motor and so on. By the way, they import product from Korea and sell new and original products. They have good reputation and have many good feedbacks. If you need these products, look at this website will be a clever choice. I am sure you will get many surprise and benefits. Greetings!

Dec. 24, 2010

Hebrew version of Wine History

by Yaron Shahrabani

Hey, I translated the Wine History into Hebrew several weeks ago and I noticed that although the patches are in, when I click on Wine's History on the Hebrew website I'm being taken to the English version of the document in Wine's wiki. Wine's history is pretty important to the Israeli community in various aspects, can it be fixed? Kind regards, Yaron Shahrabani <Hebrew translator>

Dec. 23, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Travis Athougies

To address, the C string literals issue, this is the same format I have used for the other test strings. It would seem inconsistent to break this now. Maybe a later patch can address this. I've used IUnknown_Release in other places to free ID3D10Blobs, so it also seems inconsistent to use ID3D10Blob_Release here. However, I did not cast it those other times, so I will remove the casts in my next attempt And yes, compiled is NULL if the compile failed. Travis. 2010/12/23 Rico Schüller <kgbricola(a)web.de>: > Am 23.12.2010 00:37, schrieb Michael Stefaniuc: >> >> Hello Travis, >> >> On 12/22/2010 10:31 PM, Travis Athougies wrote: >>> >>> Tests to ensure the HLSL compiler won't crash on malformed input. >>> >>> --- >>> dlls/d3dcompiler_43/tests/hlsl.c | 87 >>> ++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 87 insertions(+), 0 deletions(-) >>> >>> diff --git a/dlls/d3dcompiler_43/tests/hlsl.c >>> b/dlls/d3dcompiler_43/tests/hlsl.c >>> index 1f8e31c..a6a6099 100644 >>> --- a/dlls/d3dcompiler_43/tests/hlsl.c >>> +++ b/dlls/d3dcompiler_43/tests/hlsl.c >>> @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, >>> IDirect3DVertexBuffer9 *quad_geo >>> } >>> } >>> >>> +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 >>> *qquad_geometry, >>> + IDirect3DVertexShader9 *vshader_passthru) >>> +{ >>> + static const char *undefined_variable_shader = >>> + "float4 test(float2 pos: TEXCOORD0) : COLOR \ >>> + { \ >>> + return y; \ >>> + }"; >> >> please use proper C string literals. Escaping the newline is a gcc >> extension. You can use string literal concatenation to split the string >> on multiple lines. Something like this would do: >> "float4 test(float2 pos: TEXCOORD0) : COLOR" >> "{" >> " return y;" >> "}"; >> >> bye >> michael >> >> >> > You probably may use ID3D10Blob_Release() instead of IUnknown_Release(). > This way you could drop the cast. > > What happens to the ID3D10Blob *compiled? Is it still NULL after each call > to D3DCompile or is it an valid blob which has to be released? > > Cheers > Rico > -- Travis Athougies

Dec. 23, 2010

(no subject)

by Greg Geldorp

Ok, it didn't last very long, but for a brief period we had only greens for 4 different Windows versions on http://test.winehq.org, see attached screenshot. Nice to see some progress J Greg.

Dec. 23, 2010

Re: uninstaller: Run msiexec if the WindowsInstaller value is set.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > programs/uninstaller/main.c | 23 +++++++++++++++++++---- > 1 files changed, 19 insertions(+), 4 deletions(-) Note that appwiz.cpl will need the same change (of course uninstaller should really be calling appwiz.cpl in the first place). -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH] Added function _ui64tow_s to MSVCRT (sorry sent the last mail from the wrong address)

by Alexandre Julliard

Arno Teigseth <arnotixe(a)gmail.com> writes: > --- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 2 deletions(-) Please add it to all the msvcrt versions that need it, not only to msvcr90. -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH 2/2] shell32: Add IInputObject stub to ExplorerBrowser. (try 2)

by Alexandre Julliard

David Hedberg <david.hedberg(a)gmail.com> writes: > + hr = IInputObject_TranslateAcceleratorIO(pio, &msg_a); > + todo_wine ok(hr == found ? S_OK : S_FALSE, "Got 0x%08x (%04x)\n", hr, i); That doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Rico Schüller

Am 23.12.2010 00:37, schrieb Michael Stefaniuc: > Hello Travis, > > On 12/22/2010 10:31 PM, Travis Athougies wrote: >> Tests to ensure the HLSL compiler won't crash on malformed input. >> >> --- >> dlls/d3dcompiler_43/tests/hlsl.c | 87 >> ++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 87 insertions(+), 0 deletions(-) >> >> diff --git a/dlls/d3dcompiler_43/tests/hlsl.c >> b/dlls/d3dcompiler_43/tests/hlsl.c >> index 1f8e31c..a6a6099 100644 >> --- a/dlls/d3dcompiler_43/tests/hlsl.c >> +++ b/dlls/d3dcompiler_43/tests/hlsl.c >> @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, >> IDirect3DVertexBuffer9 *quad_geo >> } >> } >> >> +static void test_fail(IDirect3DDevice9 *device, >> IDirect3DVertexBuffer9 *qquad_geometry, >> + IDirect3DVertexShader9 *vshader_passthru) >> +{ >> + static const char *undefined_variable_shader = >> + "float4 test(float2 pos: TEXCOORD0) : COLOR \ >> + { \ >> + return y; \ >> + }"; > please use proper C string literals. Escaping the newline is a gcc > extension. You can use string literal concatenation to split the string > on multiple lines. Something like this would do: > "float4 test(float2 pos: TEXCOORD0) : COLOR" > "{" > " return y;" > "}"; > > bye > michael > > > You probably may use ID3D10Blob_Release() instead of IUnknown_Release(). This way you could drop the cast. What happens to the ID3D10Blob *compiled? Is it still NULL after each call to D3DCompile or is it an valid blob which has to be released? Cheers Rico

Dec. 23, 2010

Re: Death to win9x?

by Saulius Krasuckas

* On Wed, 22 Dec 2010, Jacek Caban wrote: > > dropping win9x tests has nothing to do with dropping win9x support. It has, but in a small degree -- if win9x support regresses now, these existing few cases of testing win9x specifics won't do their job. > These test results weren't helpful nor useful anyways. And how is the project going to get rid of win9x specifics in the winetest? Some of them were being skip()ed, some broken() and some of them were left just as valid (eg. ERROR_NOT_LOGGED_ON). You will you let them rot? But I see the pluses too. Now if I stuck upon some win9x-specifics, I can change WinAPI function without even needing a test case. Because it won't be tested anyway, right? :) I guess more patches are going to go through since<g>. S.

Dec. 23, 2010

Phoronix benchmarked opengl games on wine...

by Dan Kegel

http://www.phoronix.com/scan.php?page=article&item=wine_win7_2010 "With this testing we ran eight games/benchmarks natively under Ubuntu 10.10, the Windows binaries under the stable Wine 1.2.1, the Windows binaries under the Wine 1.3.9 development snapshot, and then finally under Microsoft Windows 7 Professional. The test profiles used had included OpenArena, Urban Terror, Warsow, Nexuiz, Lightsmark, Unigine Sanctuary, Unigine Tropics, and Unigine Heaven. The OpenGL renderer was used with all of them... >From this first round of 2010 Wine vs. Ubuntu vs. Windows 7 testing it is tough to draw any conclusions. About the only conclusion to draw would be that you cannot draw any definitive conclusions about the Wine performance compared to the native performance on either Linux or Windows. ... Stay tuned for our expanded Wine testing and to see how the Linux performance compares with some more popular Windows-only Direct3D-rendered games."

Dec. 22, 2010

Re: shell32/tests: Fix a typo

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7800 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2

Dec. 22, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Michael Stefaniuc

Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. > > --- > dlls/d3dcompiler_43/tests/hlsl.c | 87 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dcompiler_43/tests/hlsl.c b/dlls/d3dcompiler_43/tests/hlsl.c > index 1f8e31c..a6a6099 100644 > --- a/dlls/d3dcompiler_43/tests/hlsl.c > +++ b/dlls/d3dcompiler_43/tests/hlsl.c > @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geo > } > } > > +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *qquad_geometry, > + IDirect3DVertexShader9 *vshader_passthru) > +{ > + static const char *undefined_variable_shader = > + "float4 test(float2 pos: TEXCOORD0) : COLOR \ > + { \ > + return y; \ > + }"; please use proper C string literals. Escaping the newline is a gcc extension. You can use string literal concatenation to split the string on multiple lines. Something like this would do: "float4 test(float2 pos: TEXCOORD0) : COLOR" "{" " return y;" "}"; bye michael

Dec. 22, 2010