December 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Travis Athougies

To address, the C string literals issue, this is the same format I have used for the other test strings. It would seem inconsistent to break this now. Maybe a later patch can address this. I've used IUnknown_Release in other places to free ID3D10Blobs, so it also seems inconsistent to use ID3D10Blob_Release here. However, I did not cast it those other times, so I will remove the casts in my next attempt And yes, compiled is NULL if the compile failed. Travis. 2010/12/23 Rico Schüller <kgbricola(a)web.de>: > Am 23.12.2010 00:37, schrieb Michael Stefaniuc: >> >> Hello Travis, >> >> On 12/22/2010 10:31 PM, Travis Athougies wrote: >>> >>> Tests to ensure the HLSL compiler won't crash on malformed input. >>> >>> --- >>> dlls/d3dcompiler_43/tests/hlsl.c | 87 >>> ++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 87 insertions(+), 0 deletions(-) >>> >>> diff --git a/dlls/d3dcompiler_43/tests/hlsl.c >>> b/dlls/d3dcompiler_43/tests/hlsl.c >>> index 1f8e31c..a6a6099 100644 >>> --- a/dlls/d3dcompiler_43/tests/hlsl.c >>> +++ b/dlls/d3dcompiler_43/tests/hlsl.c >>> @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, >>> IDirect3DVertexBuffer9 *quad_geo >>> } >>> } >>> >>> +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 >>> *qquad_geometry, >>> + IDirect3DVertexShader9 *vshader_passthru) >>> +{ >>> + static const char *undefined_variable_shader = >>> + "float4 test(float2 pos: TEXCOORD0) : COLOR \ >>> + { \ >>> + return y; \ >>> + }"; >> >> please use proper C string literals. Escaping the newline is a gcc >> extension. You can use string literal concatenation to split the string >> on multiple lines. Something like this would do: >> "float4 test(float2 pos: TEXCOORD0) : COLOR" >> "{" >> " return y;" >> "}"; >> >> bye >> michael >> >> >> > You probably may use ID3D10Blob_Release() instead of IUnknown_Release(). > This way you could drop the cast. > > What happens to the ID3D10Blob *compiled? Is it still NULL after each call > to D3DCompile or is it an valid blob which has to be released? > > Cheers > Rico > -- Travis Athougies

Dec. 23, 2010

(no subject)

by Greg Geldorp

Ok, it didn't last very long, but for a brief period we had only greens for 4 different Windows versions on http://test.winehq.org, see attached screenshot. Nice to see some progress J Greg.

Dec. 23, 2010

Re: uninstaller: Run msiexec if the WindowsInstaller value is set.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > programs/uninstaller/main.c | 23 +++++++++++++++++++---- > 1 files changed, 19 insertions(+), 4 deletions(-) Note that appwiz.cpl will need the same change (of course uninstaller should really be calling appwiz.cpl in the first place). -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH] Added function _ui64tow_s to MSVCRT (sorry sent the last mail from the wrong address)

by Alexandre Julliard

Arno Teigseth <arnotixe(a)gmail.com> writes: > --- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 2 deletions(-) Please add it to all the msvcrt versions that need it, not only to msvcr90. -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH 2/2] shell32: Add IInputObject stub to ExplorerBrowser. (try 2)

by Alexandre Julliard

David Hedberg <david.hedberg(a)gmail.com> writes: > + hr = IInputObject_TranslateAcceleratorIO(pio, &msg_a); > + todo_wine ok(hr == found ? S_OK : S_FALSE, "Got 0x%08x (%04x)\n", hr, i); That doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

Dec. 23, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Rico Schüller

Am 23.12.2010 00:37, schrieb Michael Stefaniuc: > Hello Travis, > > On 12/22/2010 10:31 PM, Travis Athougies wrote: >> Tests to ensure the HLSL compiler won't crash on malformed input. >> >> --- >> dlls/d3dcompiler_43/tests/hlsl.c | 87 >> ++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 87 insertions(+), 0 deletions(-) >> >> diff --git a/dlls/d3dcompiler_43/tests/hlsl.c >> b/dlls/d3dcompiler_43/tests/hlsl.c >> index 1f8e31c..a6a6099 100644 >> --- a/dlls/d3dcompiler_43/tests/hlsl.c >> +++ b/dlls/d3dcompiler_43/tests/hlsl.c >> @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, >> IDirect3DVertexBuffer9 *quad_geo >> } >> } >> >> +static void test_fail(IDirect3DDevice9 *device, >> IDirect3DVertexBuffer9 *qquad_geometry, >> + IDirect3DVertexShader9 *vshader_passthru) >> +{ >> + static const char *undefined_variable_shader = >> + "float4 test(float2 pos: TEXCOORD0) : COLOR \ >> + { \ >> + return y; \ >> + }"; > please use proper C string literals. Escaping the newline is a gcc > extension. You can use string literal concatenation to split the string > on multiple lines. Something like this would do: > "float4 test(float2 pos: TEXCOORD0) : COLOR" > "{" > " return y;" > "}"; > > bye > michael > > > You probably may use ID3D10Blob_Release() instead of IUnknown_Release(). This way you could drop the cast. What happens to the ID3D10Blob *compiled? Is it still NULL after each call to D3DCompile or is it an valid blob which has to be released? Cheers Rico

Dec. 23, 2010

Re: Death to win9x?

by Saulius Krasuckas

* On Wed, 22 Dec 2010, Jacek Caban wrote: > > dropping win9x tests has nothing to do with dropping win9x support. It has, but in a small degree -- if win9x support regresses now, these existing few cases of testing win9x specifics won't do their job. > These test results weren't helpful nor useful anyways. And how is the project going to get rid of win9x specifics in the winetest? Some of them were being skip()ed, some broken() and some of them were left just as valid (eg. ERROR_NOT_LOGGED_ON). You will you let them rot? But I see the pluses too. Now if I stuck upon some win9x-specifics, I can change WinAPI function without even needing a test case. Because it won't be tested anyway, right? :) I guess more patches are going to go through since<g>. S.

Dec. 23, 2010

Phoronix benchmarked opengl games on wine...

by Dan Kegel

http://www.phoronix.com/scan.php?page=article&item=wine_win7_2010 "With this testing we ran eight games/benchmarks natively under Ubuntu 10.10, the Windows binaries under the stable Wine 1.2.1, the Windows binaries under the Wine 1.3.9 development snapshot, and then finally under Microsoft Windows 7 Professional. The test profiles used had included OpenArena, Urban Terror, Warsow, Nexuiz, Lightsmark, Unigine Sanctuary, Unigine Tropics, and Unigine Heaven. The OpenGL renderer was used with all of them... >From this first round of 2010 Wine vs. Ubuntu vs. Windows 7 testing it is tough to draw any conclusions. About the only conclusion to draw would be that you cannot draw any definitive conclusions about the Wine performance compared to the native performance on either Linux or Windows. ... Stay tuned for our expanded Wine testing and to see how the Linux performance compares with some more popular Windows-only Direct3D-rendered games."

Dec. 23, 2010

Re: shell32/tests: Fix a typo

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7800 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2

Dec. 23, 2010

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

by Michael Stefaniuc

Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. > > --- > dlls/d3dcompiler_43/tests/hlsl.c | 87 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dcompiler_43/tests/hlsl.c b/dlls/d3dcompiler_43/tests/hlsl.c > index 1f8e31c..a6a6099 100644 > --- a/dlls/d3dcompiler_43/tests/hlsl.c > +++ b/dlls/d3dcompiler_43/tests/hlsl.c > @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geo > } > } > > +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *qquad_geometry, > + IDirect3DVertexShader9 *vshader_passthru) > +{ > + static const char *undefined_variable_shader = > + "float4 test(float2 pos: TEXCOORD0) : COLOR \ > + { \ > + return y; \ > + }"; please use proper C string literals. Escaping the newline is a gcc extension. You can use string literal concatenation to split the string on multiple lines. Something like this would do: "float4 test(float2 pos: TEXCOORD0) : COLOR" "{" " return y;" "}"; bye michael

Dec. 22, 2010