December 2010 - Wine-Devel - list.winehq.org

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by maury loïc

Hello Ken and the Wine community, For what i understood, The function CDROM_Verify(), verify if the media is present on the device, and Wine try to open the device(in Mac Os case), before call the CDROM_Verify(). But Mac Os manage the device differently from the other Os. It create the device, only if the media is already present. Logically, CDROM_Verify() return success, because when we are in CDROM_Verify() we already know the device. What do you think ? merci Loïc On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > Hi Loïc, > > On Dec 30, 2010, at 4:20 AM, maury loïc wrote: > > > it's my first patch, and it implement the CDROM_Verify() > > to work on Mac Os. > > I think most people are going to need more explanation for why this is a > legitimate way to implement this function on Mac OS X. :) > > Cheers, > Ken > >

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>contain any dwarf information >>maybe you're loading another instance of libwine? >>A+ >> >>-- >>Eric Pouech > >I did a search of the file system. > >Under /usr/local/lib64 I have >libwine.so (link) >libwine.so.1 (link) >libwine.so.1.0 >wine [folder} > >Under /usr/local/lib64/wine I have >libwinecrt0.a >libwined3d.def I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. And I downloaded yesterday's git. And now I'm getting a different error. wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory This error is for all wine commands, including wine --version I have the same files under /usr/local/lib64 but under user/local/lib64/wine I have lots of so's and def's. ??

Dec. 30, 2010

Re: [PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by James McKenzie

On 12/30/10 5:02 AM, Yegor Yefremov wrote: > Hello, > > it's my first contribution to wine, so I wanted to start with some > simple task. After fixing the files mentioned in the attached patch, > following files in dlls folder still contain malloc/free calls: > > dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - > config_dir ))) fatal_error( "out of memory\n" ); > dlls/msvcrt/heap.c: * malloc (MSVCRT.@) > dlls/msvcrt/tests/printf.c: str = malloc(1024); > dlls/msvcrt/tests/printf.c: str = malloc(1024); > dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); > dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); > dlls/msvcrt/tests/heap.c: mem = malloc(0); > dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); > dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if > these methods haven't been > > As far as I understand those files test the core functionality and > should use malloc. If this is so, then malloc/free replacement for > dlls is complete. > > The source code could be compiled without problems after applying the patch. > > I'm behind a firewall and couldn't clone the repository even via http > (for some other projects it is functioning). That's why my patch was > made with quilt. See the GitWine page in the Wiki on how to create git exports. James McKenzie

Dec. 30, 2010

[PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder

by Yegor Yefremov

Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - config_dir ))) fatal_error( "out of memory\n" ); dlls/msvcrt/heap.c: * malloc (MSVCRT.@) dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem = malloc(0); dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if these methods haven't been As far as I understand those files test the core functionality and should use malloc. If this is so, then malloc/free replacement for dlls is complete. The source code could be compiled without problems after applying the patch. I'm behind a firewall and couldn't clone the repository even via http (for some other projects it is functioning). That's why my patch was made with quilt. Best regards, Yegor

Dec. 30, 2010

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by Ken Thomases

Hi Loïc, On Dec 30, 2010, at 4:20 AM, maury loïc wrote: > it's my first patch, and it implement the CDROM_Verify() > to work on Mac Os. I think most people are going to need more explanation for why this is a legitimate way to implement this function on Mac OS X. :) Cheers, Ken

Dec. 30, 2010

ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by maury loïc

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

Dec. 30, 2010

Re: 64-bit Notepad2 crashes

by Susan Cragin

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >if you've compiled wine yourself, it's strange that libwine.so doesn't >contain any dwarf information >maybe you're loading another instance of libwine? >A+ > >-- >Eric Pouech I did a search of the file system. Under /usr/local/lib64 I have libwine.so (link) libwine.so.1 (link) libwine.so.1.0 wine [folder} Under /usr/local/lib64/wine I have libwinecrt0.a libwined3d.def Do you want copies of so.1.0?

Dec. 30, 2010

Re: shlwapi/tests: Fix typo

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7951 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 30, 2010

Re: msi/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Dec. 30, 2010

Re: urlmon/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7948 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Dec. 30, 2010