December 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value [try 2]

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -49,6 +49,7 @@ echo %UNKNOWN%S > echo P%UNKNOWN% > echo P%UNKNOWN%S > echo %ERRORLEVEL > +cmd /c exit 0 > echo %ERRORLEVEL% > echo %ERRORLEVEL%%ERRORLEVEL% > echo %ERRORLEVEL%ERRORLEVEL% It already has a defined value. What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.org

Dec. 28, 2010

Re: msvcrt: Implement _fcvt_s. (resend)

by Alexandre Julliard

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > @@ -1127,9 +1127,9 @@ int CDECL _ecvt_s( char *buffer, MSVCRT_size_t length, double number, int ndigit > /* special case - inf */ > if(number == HUGE_VAL || number == -HUGE_VAL) > { > - memset(buffer, '0', ndigits); > + memset(buffer, '0', max(ndigits, 0)); > memcpy(buffer, infret, min(ndigits, sizeof(infret) - 1 ) ); > - buffer[ndigits] = '\0'; > + buffer[max(ndigits, 0)] = '\0'; You'd have to fix the memcpy too, though the whole thing doesn't make much sense if ndigits is negative. Probably needs to be rethought, with some test cases. -- Alexandre Julliard julliard(a)winehq.org

Dec. 28, 2010

Re: [PATCH 4/8] jscript: Ensure that the whole script is parsed

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7868 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 28, 2010

Re: [PATCH 1/8] jscript: Better syntax error tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7867 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Dec. 28, 2010

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox

by Henri Verbeet

On 28 December 2010 11:25, David Adam <david.adam.cnrs(a)gmail.com> wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) > +/************************************************************************* > + * D3DXCreateMeshFVF > + */ > +HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 pDevice, FLOAT fWidth, FLOAT fHeight, FLOAT fDepth, LPD3DXMESH *ppMesh, LPD3DXBUFFER *ppAdjacency) Seriously.

Dec. 28, 2010

Re: 64-bit works but Notepad takes a long time to come up, using today's git

by Susan Cragin

>On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: >> I maybe should have filed this as a bug. >> I know Wine had a regression in 64-bit, and that such regression received a patch. >> I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. >> wine-1.3.10-48-g1288078 > > >Was the the first try or the second? >wineboot after a new version might take a bit. >It takes nearly no time here. > >Could you bisect to the slow down? Perhaps some printer stuff? > >Ciao, Marcus I think I've solved what is probably my problem. Notepad when started with the command "wine64" runs quickly. Notepad started with "wine" ran very slowly on one 64-bit partition that I've fiddled with a lot, and not at all on a cleaner 64-bit partition. Sorry for the confusion.

Dec. 28, 2010

Re: [PATCH 1/2] mshtml: COM cleanup for the nsIWebBrowserChrome iface.

by Michael Stefaniuc

Forgot to mention that this patch applies on top of Jacek's "mshtml: Fixed unsafe cast in CreateChromeWindow2 implementation" patch. On 12/27/2010 11:27 PM, Michael Stefaniuc wrote: > --- > dlls/mshtml/mshtml_private.h | 3 +- > dlls/mshtml/nsembed.c | 97 +++++++++++++++++++++-------------------- > dlls/mshtml/nsio.c | 8 ++-- > 3 files changed, 55 insertions(+), 53 deletions(-) bye michael

Dec. 27, 2010

Re: 64-bit works but Notepad takes a long time to come up, using today's git

by Marcus Meissner

On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: > I maybe should have filed this as a bug. > I know Wine had a regression in 64-bit, and that such regression received a patch. > I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. > wine-1.3.10-48-g1288078 Was the the first try or the second? wineboot after a new version might take a bit. It takes nearly no time here. Could you bisect to the slow down? Perhaps some printer stuff? Ciao, Marcus

Dec. 27, 2010

64-bit works but Notepad takes a long time to come up, using today's git

by Susan Cragin

I maybe should have filed this as a bug. I know Wine had a regression in 64-bit, and that such regression received a patch. I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. wine-1.3.10-48-g1288078

Dec. 27, 2010

Re: spoolss/tests: Skip tests on Win7

by Paul Vriens

On 12/27/2010 12:47 PM, Greg Geldorp wrote: >> From: Paul Vriens >> But that means we will skip on Wine as well (when/if implemented). Is >> that OK? > > We skip if UnloadDriver is NOT present. It is present on Wine, so the tests > do run on Wine. Win7 is the only platform where the function is not present. > > Greg. Duh, I think I call it a year and start again fresh in 2011 ;) -- Cheers, Paul.

Dec. 27, 2010