February 2010 - Wine-Devel - list.winehq.org

PeekMsg/MsgWaitForMultipleObjects question

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, hopefully somebody familiar with messaging can immediately spot what's wrong with the code below. The winmm/midi tests currently in git, using PeekMsg, show that the messages (from CALLBACK_WINDOW) are almost always immediately available. Yet the code below, based on MsgWaitFor... times out multiple times during each test run. Why? This seems to affect only the messages 3c9/3ca (MOM_DONE and MOM_CALLBACK). "Bad wait 102 0": 0x102 is WAIT_TIMEOUT. That should never happen. diff --git a/dlls/winmm/tests/midi.c b/dlls/winmm/tests/midi.c index 15e02e2..a23fa19 100644 --- a/dlls/winmm/tests/midi.c +++ b/dlls/winmm/tests/midi.c @@ -67,8 +67,27 @@ static void test_notification(HWND hwnd, const char* command, UINT m1, DWORD_PTR if (hwnd) { /* msg.wParam is hmidiout, msg.lParam is the mhdr (or 0) */ BOOL seen; +#if 0 do { seen = PeekMessageA(&msg, hwnd, 0, 0, PM_REMOVE); } while(seen && spurious_message(&msg)); +#else + seen=0; + if (m1 && !seen) { + /* We observe intermittent delayed notification. Perhaps + * the OS preempts the player thread after setting MHDR_DONE + * or clearing INQUEUE, before calling DriverCallback. */ + DWORD x; + trace("Waiting for delayed message %x from %s\n", m1, command); + SetLastError(0xDEADBEEF); +#if 0 + x=MsgWaitForMultipleObjects(0, NULL, FALSE, 9999, QS_POSTMESSAGE); +#else + x=MsgWaitForMultipleObjects(0, NULL, FALSE, /*INFINITE*/9999, QS_ALLINPUT); +#endif + ok(x==WAIT_OBJECT_0,"Bad wait %x %d\n",x, GetLastError()); + seen = PeekMessageA(&msg, hwnd, 0, 0, PM_REMOVE); + } +#endif if (seen) { trace("Message %x, wParam=%lx, lParam=%lx from %s\n", msg.message, msg.wParam, msg.lParam, command); Thanks for your help, Jörg Höhle

Feb. 23, 2010

Re: Another aspiring GSoC applicant..

by Mikołaj Zalewski

David Hedberg pisze: > I've also looked a bit at implementing support for IFileDialog, and > the Explorer, but I have yet to dig too deep into either of them. Are > there currently any known applications out there that uses IFileDialog > explicitly? I've looked a bit, probably not enough, but I haven't been > able to find anything except example code. Also, are there any > applications that fail to run because explorer is missing > functionality, or would the end-result of that suggested project > function mainly as an end-user utility? > In older version of Gnome, Gnome was not using the freedesktop.org standard trash directory, what caused files deleted under Wine not to show up in Gnome Trash. As we have in Wine a Trash virtual folder, I was thinking about fixing it by implementing a IShellBrowser (single explorer window) to show it to the users. However, as this is fixed in newer Gnomes, this is probably not that useful anymore. Still, if anyone is interested, I attach the skeleton code I have written (written under Windows XP x64, to be ported to Wine once finished possibly fixing some bugs) that does some logging and may be useful as a starting point. Apart from the 'shellbrowser' folder, I also put the 'shellfolder' one that I've used when implementing the recycle bin folder that may be useful if one needs logs from "the other side" (i.e. from a custom folder inside the true Explorer). Mikołaj > Thanks, > David > > >

Feb. 23, 2010

Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on code from Luis Busquets)

by Christian Costa

Henri Verbeet a écrit : > On 22 February 2010 15:15, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > >> More generally I would say that over-reviewing is not a good thing. It does >> not bring much in term of >> quality and slow down development. Thrust is the base of a community. >> > Sure, but that trust has to be justified. I can certainly stop looking > at your patches, I have enough other stuff to do, but I doubt that's > going to speed up getting them accepted. It's perhaps also worth > noting that I've fixed plenty of bugs that could have easily been > avoided if the original author of the code had been more careful, or > had bothered to write tests. > > Seriously, the general principle is that you add a test when you > implement some new functionality or fix a bug, unless that's not > feasible for some reason. That's certainly not the case here, writing > tests for this function is trivial. > > The goal was to implement the IConstantTable interface. I intended to write tests at this level along with new patch series for this interface. D3DXFindShaderComment was not needed directly by a particular app but just to be reused by D3DXGetShaderConstantTableEx as the next patch shows. But since it's better to do it in this patch, I will add some tests to it then.

Feb. 23, 2010

Re: [PATCH] shlwapi/tests: skip SHCreateStreamOnFileA/W configurations not supported on Win98 SE.

by Reece Dunn

On 23 February 2010 07:33, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 02/23/2010 01:28 AM, Reece Dunn wrote: >> >> + if (ret == E_INVALIDARG) /* Win98 SE */ { >> + skip("Not supported\n"); >> + return; >> + } > > Hi Reece, > > Could you turn that (and the other one) into a win_skip() ? Done, thanks. - Reece

Feb. 23, 2010

Re: dns-sd dll implementation -- Needs work

by Dmitry Timoshkov

"C.W. Betts" <computers57(a)hotmail.com> wrote: > What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®. Looks like this is not a part of Windows or PSDK, so Wine shouldn't include it either. -- Dmitry.

Feb. 23, 2010

Re: [PATCH] shlwapi/tests: skip SHCreateStreamOnFileA/W configurations not supported on Win98 SE.

by Paul Vriens

On 02/23/2010 01:28 AM, Reece Dunn wrote: > + if (ret == E_INVALIDARG) /* Win98 SE */ { > + skip("Not supported\n"); > + return; > + } Hi Reece, Could you turn that (and the other one) into a win_skip() ? -- Cheers, Paul.

Feb. 23, 2010

Re: dns-sd dll implementation -- Needs work

by Juan Lang

Hi C.W., > I know there's probably a patches mailing list, but I put this here for feedback. This is the appropriate place to ask about patches that aren't ready to commit yet. +#include <dns_sd.h> At the least, you'll need to add configure checks for this header file. I imagine you'll need to load the library dynamically, too. On at least one of my systems, /usr/lib/libdns_sd.so is available, but <dns_sd.h> is not. I'm not sure how common that would be, but you might want to provide a private copy of the .h file too. --Juan

Feb. 23, 2010

dns-sd dll implementation -- Needs work

by C.W. Betts

What do you guys think? it's a wrapper for multicast DNS, aka Bonjour®. I know there's probably a patches mailing list, but I put this here for feedback.

Feb. 23, 2010

[PATCH] server: Fix console create function

by XueFeng Chang

Check create_event return value. --- server/console.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/console.c b/server/console.c index a79dc67..3758a71 100644 --- a/server/console.c +++ b/server/console.c @@ -294,7 +294,7 @@ static struct object *create_console_input( struct thread* renderer ) console_input->win = 0; console_input->event = create_event( NULL, NULL, 0, 1, 0, NULL ); - if (!console_input->history || !console_input->evt) + if (!console_input->history || !console_input->evt || !console_input->event) { release_object( console_input ); return NULL; -- 1.6.0.4

Feb. 23, 2010

Re: Trouble compiling Wine tests with Cygwin

by Alex Villacís Lasso

El 22/02/10 12:41, Austin English escribió: > On Mon, Feb 22, 2010 at 11:03 AM, Alex Villacís Lasso > <a_villacis(a)palosanto.com> wrote: > >> I have a VB6 application that requires oledb32 to convert from >> DBTYPE_VARIANT to DBTYPE_BYTES, and fails with builtin oledb32 since >> conversions to DBTYPE_BYTES are unimplemented. I set up a VirtualBox VM with >> Windows XP and the latest Cygwin in order to add a oledb32 test to show me >> what should be done for these conversions to DBTYPE_BYTES. However, I have >> trouble when running "make test" on dlls/oledb32/tests. I get the following: >> > It's not quite the answer to your question, but why not use mingw on > your native OS and run the mingw created exe on windows? > > Thanks. I will try that. However, the Cygwin-on-Windows method used to work, and I have tried some test patches with it, so it is surprising for me that it does not work anymore.

Feb. 22, 2010