February 2010 - Wine-Devel - list.winehq.org

Re: msi: Don't fail if the service to start is already running.

by Hans Leidekker

On Monday 01 February 2010 16:20:56 Paul Vriens wrote: > On 02/01/2010 09:55 AM, Hans Leidekker wrote: > > + > > + scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > > + ok(scm != NULL, "Failed to open the SC Manager\n"); > > + > > + service = OpenService(scm, "TermService", SC_MANAGER_ALL_ACCESS); > > + ok(service != NULL, "Failed to open TermService\n"); > > Hi Hans, > > Win9x/WinMe don't have the notion of services. 'TermService' is not > available on all platforms. We could use 'Spooler' and bail out if we > get ERROR_SERVICE_DOES_NOT_EXIST? > > Let me know and I'll create/send a patch. Win9x is already detected in install.c so lets just use that. It's not a problem if TermService is not available everywhere. -Hans

Feb. 1, 2010

Re: msi: Don't fail if the service to start is already running.

by Paul Vriens

On 02/01/2010 09:55 AM, Hans Leidekker wrote: > + > + scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > + ok(scm != NULL, "Failed to open the SC Manager\n"); > + > + service = OpenService(scm, "TermService", SC_MANAGER_ALL_ACCESS); > + ok(service != NULL, "Failed to open TermService\n"); Hi Hans, Win9x/WinMe don't have the notion of services. 'TermService' is not available on all platforms. We could use 'Spooler' and bail out if we get ERROR_SERVICE_DOES_NOT_EXIST? Let me know and I'll create/send a patch. -- Cheers, Paul.

Feb. 1, 2010

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range

by Henri Verbeet

On 1 February 2010 13:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > On Monday 01 February 2010 11:27:48 Henri Verbeet wrote: >> On 30 January 2010 12:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> > + const struct wined3d_gl_info *gl_info = >> > &device->adapter->gl_info; >> >> I think you should retrieve gl_info from the context where possible. > Done > Missed the one in buffer_Unmap().

Feb. 1, 2010

Re: oleaut32: rewrite RollUdate to be easier to change and to support more conversions

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > Old version of that function only used if-statements which is not the best solution for a math problem. It doesn't work here: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok vartest.c:1759: Test failed: expected 1, 29189, got 1, 29159 make[2]: *** [vartest.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Feb. 1, 2010

Re: includes: Add amaudio.h

by Henri Verbeet

On 31 January 2010 20:34, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID riid, void** ppvObject) Looking at some other headers this seems a common thing to do, but is there really a reason to use STDMETHOD_(HRESULT,QueryInterface) over just STDMETHOD(QueryInterface)?

Feb. 1, 2010

Re: dwmapi: add a stub for DwmDefWindowProc

by Reece Dunn

On 1 February 2010 11:11, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 2/1/2010 07:35, Austin English wrote: >> >> See http://bugs.winehq.org/show_bug.cgi?id=20443 >> >> + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); > > Also don't forget to correct format here. Austin fixed that in the updated version as well. - Reece

Feb. 1, 2010

Re: dwmapi: add a stub for DwmDefWindowProc

by Nikolay Sivov

On 2/1/2010 07:35, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=20443 > > > + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); > Also don't forget to correct format here.

Feb. 1, 2010

Re: wined3d: Add newer ATI/AMD cards vendor recognition

by Stefan Dösinger

Am 01.02.2010 um 11:35 schrieb Henri Verbeet: > On 31 January 2010 14:59, Luca Bennati <lucak3(a)gmail.com> wrote: >> As seen in bug #21515, newer ATI cards used with radeon open driver return a >> GL_VENDOR string not present in wined3d_guess_vendor(). >> This oneliner merely adds that so that the function return VENDOR_MESA >> instead of VENDOR_WINE that could make apps crash. >> > I think this patch is ok. > > We will need to distinguish between card vendor and GL implementation > vendor, but that's beyond the scope of this patch, I'll fix that. Just > reporting VENDOR_ATI here without making that distinction first would > mean we potentially apply fglrx quirks for Mesa Agreed

Feb. 1, 2010

Re: d3dx9: Implement point filtering of ARGB surface data in D3DXLoadSurfaceFromMemory

by Henri Verbeet

On 31 January 2010 13:00, Tony Wasserka <tony.wasserka(a)freenet.de> wrote: > - the other filters basically do the same, but the end effect looks > nice, so we can fallback to point filtering for linear, triangle and box > filters for now. > - apparently, D3DERR_INVALIDCALL gets returned if the specified > destination rect exceeds the actual surface boundaries > It looks like this patch is doing a couple of different things, you should probably split it up.

Feb. 1, 2010

Re: wined3d: Add newer ATI/AMD cards vendor recognition

by Henri Verbeet

On 31 January 2010 14:59, Luca Bennati <lucak3(a)gmail.com> wrote: > As seen in bug #21515, newer ATI cards used with radeon open driver return a > GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA > instead of VENDOR_WINE that could make apps crash. > I think this patch is ok. We will need to distinguish between card vendor and GL implementation vendor, but that's beyond the scope of this patch, I'll fix that. Just reporting VENDOR_ATI here without making that distinction first would mean we potentially apply fglrx quirks for Mesa.

Feb. 1, 2010