February 2010 - Wine-Devel - list.winehq.org

Re: [3/5] d3d9: Test buffer lock flags (try 2)

by Henri Verbeet

On 30 January 2010 12:38, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static HMODULE d3d9_handle = 0; That's still redundant. Note that the variable doesn't have to be static in the first place though, you can just pass it to init_d3d9().

Feb. 1, 2010

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range

by Henri Verbeet

On 30 January 2010 12:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; I think you should retrieve gl_info from the context where possible.

Feb. 1, 2010

Re: [1/5] WineD3D: Add GL_ARB_map_buffer_range

by Henri Verbeet

On 30 January 2010 12:35, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +/* GL_ARB_map_buffer_range */ > +#ifndef GL_ARB_map_buffer_range > +#define GL_ARB_map_buffer_range > +typedef GLvoid *(WINE_GLAPI *PGLFNMAPBUFFERRANGE)(GLenum target, GLintptr offset, GLsizeiptr length, GLbitfield access); > +typedef void (WINE_GLAPI *PGLFNFLUSHMAPPEDBUFFERRANGE)(GLenum target, GLintptr offset, GLsizeiptr length); > +#define GL_MAP_READ_BIT 0x0001 > +#define GL_MAP_WRITE_BIT 0x0002 > +#define GL_MAP_INVALIDATE_RANGE_BIT 0x0004 > +#define GL_MAP_INVALIDATE_BUFFER_BIT 0x0008 > +#define GL_MAP_FLUSH_EXPLICIT_BIT 0x0010 > +#define GL_MAP_UNSYNCHRONIZED_BIT 0x0020 > +#endif Please keep these definitions consistent with the rest of the file, I just fixed all of them.

Feb. 1, 2010

Re: dwmapi: add a stub for DwmDefWindowProc

by Austin English

On Mon, Feb 1, 2010 at 4:10 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > On 1 February 2010 04:35, Austin English <austinenglish(a)gmail.com> wrote: > > + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, > LPARAM lParam, LRESULT *plResult) > > Minor nitpick here -- there is a space before the BOOL return type. Fixed. > +{ > + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); > + > + return E_NOTIMPL; > > But more importantly, you are returning a HRESULT instead of a BOOL > return value. MSDN > (http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx) > says that it is a BOOL and should return FALSE if the message was not > handled. Ah, good point. Yeah, was still a bit tired when I sent that one....the FIXME was wrong too, which is also corrected here. -- -Austin

Feb. 1, 2010

Re: wined3d: Add newer ATI/AMD cards vendor recognition

by Stefan Dösinger

Am 31.01.2010 um 14:59 schrieb Luca Bennati: > As seen in bug #21515, newer ATI cards used with radeon open driver return a GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA instead of VENDOR_WINE that could make apps crash. > <0001-wined3d-Add-newer-ATI-AMD-cards-vendor-recognition.txt> I think VENDOR_ATI would be better here. VENDOR_MESA is later replaced with VENDOR_NVIDIA and a generic NVIDIA card is found. Besides this we should make sure that intel cards driven by the mesa driver are always reported as VENDOR_INTEL, and older ATI cards with the r200 and r300 driver are reported as VENDOR_ATI as well. Obviously we'll also need a function to roughly match the Rxyz GPU IDs to card PCI IDs. Can you post a backtrace of an app crashing due to VENDOR_WINE? Such an app would be pretty buggy, or we're not watching out properly in wined3d somewhere.

Feb. 1, 2010

Re: dwmapi: add a stub for DwmDefWindowProc

by Reece Dunn

On 1 February 2010 04:35, Austin English <austinenglish(a)gmail.com> wrote: + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, LRESULT *plResult) Minor nitpick here -- there is a space before the BOOL return type. +{ + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); + + return E_NOTIMPL; But more importantly, you are returning a HRESULT instead of a BOOL return value. MSDN (http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx) says that it is a BOOL and should return FALSE if the message was not handled. - Reece

Feb. 1, 2010

Re: [PATCH 4/5] d3drm: Add some tests

by Paul Vriens

On 02/01/2010 08:56 AM, Stefan Dösinger wrote: > On Monday 01 February 2010 08:18:42 Christian Costa wrote: >> +void Test(void) >> +{ >> ... >> Test(); > I think the function name Test() won't be too helpful once more tests are > added. You can also make it static, unless you plan to call it from another .c > file. > > +#define D3DRM_GET_PROC(func) \ + p ## func = (void*)GetProcAddress(d3drm_handle, #func); \ + if(!p ## func) { \ + trace("GetProcAddress(%s) failed\n", #func); \ A win_skip() would probably be better here. + FreeLibrary(d3drm_handle); \ + return FALSE; \ + } + +static BOOL InitFunctionPtrs(void) +{ + d3drm_handle = LoadLibraryA("d3drm.dll"); + + if(!d3drm_handle) + { + skip("Could not load d3drm.dll\n"); And here as well. -- Cheers, Paul.

Feb. 1, 2010

Re: [PATCH 4/5] d3drm: Add some tests

by Stefan Dösinger

On Monday 01 February 2010 08:18:42 Christian Costa wrote: > +void Test(void) > +{ > ... > Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file.

Feb. 1, 2010