February 2010 - Wine-Devel - list.winehq.org

Re: shell32[2/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try4]

by Mikołaj Zalewski

Juan Lang pisze: > Hi Mikolaj, this one was rejected due to formatting, I imagine because > of C++ comments in the tests: > > + // Setting the same value will not set IsDirty... > > Would you mind fixing and resending? Thanks, > --Juan > Yes, I've sent the old patch with C++ comments (and a typo). I should be able to generate a correct one today. Mikołaj

Feb. 24, 2010

Re: Regression? in first-run of Dragon NaturallySpeaking

by Austin English

On Wed, Feb 24, 2010 at 9:48 AM, Susan Cragin <susancragin(a)earthlink.net> wrote: > I haven't been installing Dragon NaturallySpeaking every day for over a week, but I did try it today, and noticed that a bug has apparently crept in. > Here's what happens: > Installation runs fine. > Then I try running the program for the first time. > The microphone level test is fine, and the test for microphone accuracy. > But then the window that brings up the training dialogue freezes. > I imagine it's probably been noticed, but wanted to make sure before I investigated and filed a bug or did a regression test. I haven't seen anything on bugzilla yet. For what it's worth, while I'm sure others use it pretty often, you're the main source of bug/testing reports on it. It's great to see someone really devoted to their applications. Good/quick bug reports are always appreciated :-). -- -Austin

Feb. 24, 2010

Re: Bad usage of ok() macro in tests

by Austin English

On Wed, Feb 24, 2010 at 9:25 AM, Yann Droneaud <yann(a)droneaud.fr> wrote: > Le mercredi 24 février 2010 à 15:47 +0100, Yann Droneaud a écrit : >> Hi, >> >> While trying to manage to fix warning about unused values, I've found a >> problem about some usages of ok() macro. >> >> ok() macros is defined in include/wine/test.h as: >> >> #define ok_(file, line) (winetest_set_location(file, line), >> 0) ? 0 : winetest_ok >> #define ok ok_(__FILE__, __LINE__) >> > >> Hopefully, this is only of limited use in wine test suite: find . -type >> d -name tests | xargs grep -r '[=\!][[:space:](]*ok[[:space:]]*(' >> returns only four cases: >> > > In fact, it seems there's no more than those construct which use ok() > return value. > > Try : > > find . -type d -and -name 'tests' | xargs grep -nr > 'if[[:space:]]*([[:space:]]*\!\?[[:space:](]*ok[[:space:]]*(' > find . -type d -and -name 'tests' | xargs grep -r '[=\!]\ > +[[:space:](]*ok[[:space:]]*(' > > > So I think it's a good opportunity to simplify ok() and let's it return > void: > > #define ok winetest_set_location(__FILE__, __LINE__), winetest_ok Nice catch! Seems Alexandre fixed these issues: http://source.winehq.org/git/wine.git/?a=commitdiff;h=69ee0ad151b4ae14fa017… http://source.winehq.org/git/wine.git/?a=commitdiff;h=fbbac38e4ed9fd95d5ab3… http://source.winehq.org/git/wine.git/?a=commitdiff;h=2432b0f6b91e57e886dfe… http://source.winehq.org/git/wine.git/?a=commitdiff;h=d5a54642f478a530cf767… http://source.winehq.org/git/wine.git/?a=commitdiff;h=d279227538a32130c437b… -- -Austin

Feb. 24, 2010

Re: shell32[2/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try4]

by Juan Lang

Hi Mikolaj, this one was rejected due to formatting, I imagine because of C++ comments in the tests: + // Setting the same value will not set IsDirty... Would you mind fixing and resending? Thanks, --Juan

Feb. 24, 2010

Re: [2/2] wordpad: Number of preview pages to show when unzoomed is persistent.

by Dylan Smith

On Wed, Feb 24, 2010 at 9:04 AM, James Mckenzie <jjmckenzie51(a)earthlink.net>wrote: > >Either one or two pages may be shown in print preview when zoomed out. > >This value is stored in the registry in native wordpad, and preserved > >while opening and closing the print preview. Zooming in will only show > one > >page, but the pages shown value must be saved because it will return to > the > >preview pages shown value after unzooming completely. If two pages should > >be shown when there is only one page of text, then a second blank page is > >shown. > > Dylan: > > The Windows version of Wordpad also stores the last font values (name/point > sized) used in the Registry as well. Is this needed/desired with the Wine > version? > > First of all this would be a separate issue from my patch. Secondly I do not see these values in the registry for wordpad, and font name and points size seem to be the same when starting up wordpad regardless of any font changes I make to the text the preview time wordpad was run. I am testing using Windows XP, so perhaps this has changed with newer version of wordpad. Perhaps this could also be related to some system font default which would be independent of wordpad.

Feb. 24, 2010

Regression? in first-run of Dragon NaturallySpeaking

by Susan Cragin

I haven't been installing Dragon NaturallySpeaking every day for over a week, but I did try it today, and noticed that a bug has apparently crept in. Here's what happens: Installation runs fine. Then I try running the program for the first time. The microphone level test is fine, and the test for microphone accuracy. But then the window that brings up the training dialogue freezes. I imagine it's probably been noticed, but wanted to make sure before I investigated and filed a bug or did a regression test. Susan

Feb. 24, 2010

Re: Bad usage of ok() macro in tests

by Yann Droneaud

Le mercredi 24 février 2010 à 15:47 +0100, Yann Droneaud a écrit : > Hi, > > While trying to manage to fix warning about unused values, I've found a > problem about some usages of ok() macro. > > ok() macros is defined in include/wine/test.h as: > > #define ok_(file, line) (winetest_set_location(file, line), > 0) ? 0 : winetest_ok > #define ok ok_(__FILE__, __LINE__) > > Hopefully, this is only of limited use in wine test suite: find . -type > d -name tests | xargs grep -r '[=\!][[:space:](]*ok[[:space:]]*(' > returns only four cases: > In fact, it seems there's no more than those construct which use ok() return value. Try : find . -type d -and -name 'tests' | xargs grep -nr 'if[[:space:]]*([[:space:]]*\!\?[[:space:](]*ok[[:space:]]*(' find . -type d -and -name 'tests' | xargs grep -r '[=\!]\ +[[:space:](]*ok[[:space:]]*(' So I think it's a good opportunity to simplify ok() and let's it return void: #define ok winetest_set_location(__FILE__, __LINE__), winetest_ok Regards -- Yann Droneaud

Feb. 24, 2010

Re: user32: Use whole window rectangle for UpdateLayeredWindow

by Nikolay Sivov

On 2/24/2010 15:57, Alexandre Julliard wrote: > Shouldn't you map prcDirty to window coordinates before intersecting? > Of course, see try3.

Feb. 24, 2010

Bad usage of ok() macro in tests

by Yann Droneaud

Hi, While trying to manage to fix warning about unused values, I've found a problem about some usages of ok() macro. ok() macros is defined in include/wine/test.h as: #define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok #define ok ok_(__FILE__, __LINE__) One good example: ok( val != NULL, "Invalid value\n"); is expanded as (winetest_set_location(file, line), 0) ? 0 : winetest_ok(val != NULL, "Invalid value\n"); One bad example: if (!ok( val != NULL, "Invalid value\n")) is expanded as if (!(winetest_set_location(file, line), 0) ? 0 : winetest_ok(val != NULL, "Invalid value\n")) And is then evaluated as 1) if ( !(0) ? 0 : winetest_ok(val != NULL, "Invalid value\n")) 2) if ( 1 ? 0 : winetest_ok(val != NULL, "Invalid value\n")) ^ ouch ! 3) if (0) So this is pretty useless. Hopefully, this is only of limited use in wine test suite: find . -type d -name tests | xargs grep -r '[=\!][[:space:](]*ok[[:space:]]*(' returns only four cases: ./dlls/user32/tests/scroll.c: if ( !ok( hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n" ) ) ./dlls/kernel32/tests/file.c: !ok( UnlockFile( handle, 100, 0, 10, 0 ), "UnlockFile 100,10 failed\n" ); ./dlls/comctl32/tests/treeview.c: if ( !ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n") ) ./dlls/shell32/tests/autocomplete.c: if(!ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n")) There's only 3 case with a real problem. The fourth is something very strange: the !ok() in ./dlls/kernel32/tests/file.c seems to be a typo, or someone wanted to disable the test. Regards. -- Yann Droneaud

Feb. 24, 2010

Re: ntdll/tests: Add more tests for registry symlinks.

by Alexandre Julliard

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Hi Alexandre, > > This one made my Vista (Ultimate SP2) box starting to crash (the box > itself not just the test). Another Vista Ultimate SP2 system doesn't > show this issue. Both boxes are VMware guests btw though on different > hosts. > > The attached patch shows the culprit but I'm not sure if the preceding > NtOpenKey block should be skipped as well. > > We can just "if (0)" this whole block but we will never be sure how > many systems were affected. Does the fact that one of my boxes crashes > warrant the skipping of this particular test? Sure, the test following it already had to be commented out because it crashes the kernel on most versions. It's just not something apps would be doing. -- Alexandre Julliard julliard(a)winehq.org

Feb. 24, 2010