April 2010 - Wine-Devel - list.winehq.org

Re: [7/9] msi: Implement the UnregisterMIMEInfo standard action.

by Hans Leidekker

On Tue, 2010-04-27 at 08:55 +0200, Vincent Pelletier wrote: > Backtrace: > =>0 0x7ecf3750 ACTION_UnregisterMIMEInfo+0x260(package=0x131f00) > [/home/vincent/git/wine/dlls/msi/classes.c:1516] in msi (0x0033f998) > 1 0x7ecda25e ACTION_HandleStandardAction+0x1dd(package=<is not available>, > action="UnregisterMIMEInfo", rc=0x33f9cc, force=0x0001) > [/home/vincent/git/wine/dlls/msi/action.c:7089] in msi (0x0033f9e8) > > Note: of-by-one line count, as I added a WARN to log mime->Extension value, > which confirms the problem (3rd line): > > warn:msi:ACTION_UnregisterMIMEInfo Unregistering MIME type L"application/pdf" > warn:msi:ACTION_UnregisterMIMEInfo Failed to delete MIME key 2 > warn:msi:ACTION_UnregisterMIMEInfo mime->Extension = (nil) > > I believe the mime->InstallMe condition is too relaxed, as it does check mime- > >Extension, but with || (reindented code, for wordwrap): > > + mime->InstallMe = (mime->InstallMe || > > + (mime->Class && mime->Class->Installed) || > > + (mime->Extension && mime->Extension->Installed)); Well, the Extension_ column of the MIME table is not nullable, so mime->Extension should not be null here. Can you send me the msi file?

April 27, 2010

Re: [PATCH] Remove variable dbgtext which is not really used frommake_number.

by Dmitry Timoshkov

James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > Could you help us who are trying to match up what has changed by putting > the module name in braces like this: > > [riched20] > > somewhere in the title? Better to follow a commonly used patch naming convention instead: http://wiki.winehq.org/SubmittingPatches -- Dmitry.

April 27, 2010

Re: [7/9] msi: Implement the UnregisterMIMEInfo standard action.

by Vincent Pelletier

Le vendredi 02 avril 2010 10:40:07, Hans Leidekker a écrit : > + MSI_RecordSetStringW( uirow, 2, mime->Extension->Extension ); I have a segfault on this line when executing GOG.com embedded Adobe Reader installer (as of duke_nukem_manhattan_project.exe, SHA1SUM 98e6056472368867d302f5dc00c6a317de96e713 at least): wine: Unhandled page fault on read access to 0x00000008 at address 0x7ecf3750 (thread 0042), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7ecf3750). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ecf3750 ESP:0033f8e0 EBP:0033f938 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7ed72e80 ECX:00000000 EDX:00000000 ESI:005630d8 EDI:00563028 Stack dump: 0x0033f8e0: 00000002 7ed7f4f8 7ed5dfc6 7ed5ddeb 0x0033f8f0: 00000000 f76df7e1 7ed2e89b 7ed72e80 0x0033f900: 00131f00 0055eae0 7ed5ddeb 7ed5dfc6 0x0033f910: 7ed5dfa0 00563370 7ed5df60 00131f60 0x0033f920: 7ed7f4b8 7ed7f4b8 7ecf34fb 7ed72e80 0x0033f930: 00522dc0 00000044 0033f998 7ecda25e Backtrace: =>0 0x7ecf3750 ACTION_UnregisterMIMEInfo+0x260(package=0x131f00) [/home/vincent/git/wine/dlls/msi/classes.c:1516] in msi (0x0033f998) 1 0x7ecda25e ACTION_HandleStandardAction+0x1dd(package=<is not available>, action="UnregisterMIMEInfo", rc=0x33f9cc, force=0x0001) [/home/vincent/git/wine/dlls/msi/action.c:7089] in msi (0x0033f9e8) Note: of-by-one line count, as I added a WARN to log mime->Extension value, which confirms the problem (3rd line): warn:msi:ACTION_UnregisterMIMEInfo Unregistering MIME type L"application/pdf" warn:msi:ACTION_UnregisterMIMEInfo Failed to delete MIME key 2 warn:msi:ACTION_UnregisterMIMEInfo mime->Extension = (nil) I believe the mime->InstallMe condition is too relaxed, as it does check mime- >Extension, but with || (reindented code, for wordwrap): > + mime->InstallMe = (mime->InstallMe || > + (mime->Class && mime->Class->Installed) || > + (mime->Extension && mime->Extension->Installed)); Regards, -- Vincent Pelletier

April 27, 2010

Re: [PATCH] Remove variable dbgtext which is not really used frommake_number.

by James McKenzie

Gerald Pfeifer wrote: > >From 722b0215c6e767d516844bdd492b479831f98557 Mon Sep 17 00:00:00 2001 > From: Gerald Pfeifer <gerald(a)pfeifer.com> > Date: Sat, 24 Apr 2010 12:13:33 +0200 > > > Gerald: Could you help us who are trying to match up what has changed by putting the module name in braces like this: [riched20] somewhere in the title? Thank you. James McKenzie

April 27, 2010

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

by Wolfram Sang

> === W98SE (32 bit dib) === > dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] [...] > === WNT4WSSP6 (32 bit dib) === > dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] Probably 16-bit display depth again?

April 27, 2010

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1754 Your paranoid android. === W98SE (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] === WNT4WSSP6 (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)]

April 27, 2010

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1753 Your paranoid android. === W98SE (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] === WNT4WSSP6 (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)]

April 27, 2010

Re: [PATCH 4/5] wgl: improve wglDeleteContext threading behavior

by Roderick Colenbrander

You caught me! I guess Ge will kill me. Roderick On Mon, Apr 26, 2010 at 9:05 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 04/26/2010 08:29 PM, Roderick Colenbrander wrote: >> >> This is actually patch 1/2 and the other 2/2. I should submit patches >> in another way next time (either use --annotate, or edit them or >> whatever). >> >> Roderick >> >> > > It's a good way to bypass the testbot though ;) > > -- > Cheers, > > Paul. >

April 26, 2010

Google Summer of Code 2010: Let the bonding begin!

by Austin English

Howdy all, Wine has 5 Summer of Code students this year: Alexander Soernes, Improving Wine's Internet Explorer GUI, mentored by Maarten Lankhorst David Hedberg, Implementing IExplorerBrowser, mentored by Eric Durbin Mariusz Plucinski, Implementation of Windows Game Explorer equivalent, mentored by Vincent Povirk Thomas Mullaly, Implementing the IUri interface, mentored by Jacek Caban Wilbert Ho, Wine cmd improvements, mentored by Maarten Lankhorst Welcome students, and best of luck coding on Wine! For more details, see: http://socghop.appspot.com/gsoc/org/home/google/gsoc2010/wine -- -Austin

April 26, 2010

Re: [PATCH 4/5] wgl: improve wglDeleteContext threading behavior

by Roderick Colenbrander

This is actually patch 1/2 and the other 2/2. I should submit patches in another way next time (either use --annotate, or edit them or whatever). Roderick

April 26, 2010