May 2010 - Wine-Devel - list.winehq.org

Re: 3dmark2000, 3dmark06 results on both Wine and Vista

by Scott Ritchie

One note of caution is that video card manufacturers have been known to blatantly cheat on these tests by rigging their drivers with special hacks when they detect 3dmark is running. As far as I know the code may still be there. Since the Linux drivers probably don't have these hacks, if they are indeed still enabled you wouldn't get an Apples:Apples comparison even on the same hardware. Thanks, Scott Ritchie On 05/01/2010 11:08 AM, Dan Kegel wrote: > I did some apples-to-apples 3d benchmarking today on a dual boot system. > It looks offhand like Windows is about twice as fast as Wine on these > benchmarks on my system. > > cpu: e8400 > ram: 4GB > video card: nvidia GT 240 > Ubuntu 32 10.04 video drivers: 195.36.15 > Vista 64 video drivers: 8.17.11.9713 > > Test procedure: > > On Ubuntu, grab latest wine from git, apply patch from > http://bugs.winehq.org/show_bug.cgi?id=9210 > so 3dmark06 will run. > On Windows, install cygwin and a few of its packages (cabextract, > wget, svn, etc.) > Then on both systems do > svn checkout http://winezeug.googlecode.com/svn/trunk/ winezeug > sh winezeug > sh yagmarktest > > That will run the tests in a loop and save a report for each run in > the current directory. > > Results at http://kegel.com/wine/yagmarkdata/e8400/ > > Summary: > Ubuntu: 6 runs > 3dmark2000: min 4145, median 4154, max 4170 > 3dmark2001: min 18884, median 19261, max 19520 > 3dmark2006: min 17315, median 18154, max 18498 > > Vista: 2 runs: > 3dmark2000: 8206, 8219 > 3dmark2006: 30278, 32384 > > Notes: > 1) 3dmark2001 hangs for me on vista 64 bits, so no results for that > test on that OS, I had to > edit yagmarktest to remove it from the loop. Does it work for anyone else? > 2) nvidia drivers occasionally crash X when running or quitting > 3dmark2000 or 3dmark06; it's happened to me three times. > 3) test script is fragile, don't touch the mouse or keyboard while it's running > 4) shadows appear to be missing on wine in firefly forest in 3dmark06 > and giant mecha truck test in 3dmark01? > 5) format of my log files is ugly and will change. > >

May 1, 2010

Re: user32: Focus editboxes when the context menu is opened. (try 3)

by Paul Vriens

On 05/01/2010 08:52 PM, Vincent Povirk wrote: > We can't skip the EndMenu call because that would cause the test to > hang waiting for the menu to finish. > > Unless there's some other way we can programmatically close the popup > menu on win95, I think we'll have to skip the whole test. I'll give the MSDN suggestion a try: "If a platform does not support EndMenu, send the owner of the active menu a WM_CANCELMODE message." -- Cheers, Paul.

May 1, 2010

Re: user32: Focus editboxes when the context menu is opened. (try 3)

by Vincent Povirk

We can't skip the EndMenu call because that would cause the test to hang waiting for the menu to finish. Unless there's some other way we can programmatically close the popup menu on win95, I think we'll have to skip the whole test. On Sat, May 1, 2010 at 1:49 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 04/24/2010 10:08 PM, Vincent Povirk wrote: >> >> + case WM_CAPTURECHANGED: >> + if (hWnd != (HWND)lParam) >> + { >> + got_wm_capturechanged = 1; >> + EndMenu(); >> + } >> + break; > > Hi Vincent, > > EndMenu is not available on Win95 so no user32 tests are run on that > platform at the moment. > > Can we skip just this call to EndMenu on Win95, should we skip this whole > new test (test_contextmenu_focus) on Win95 or is there an alternative? > > -- > Cheers, > > Paul. > > >

May 1, 2010

Re: user32: Focus editboxes when the context menu is opened. (try 3)

by Paul Vriens

On 04/24/2010 10:08 PM, Vincent Povirk wrote: > + case WM_CAPTURECHANGED: > + if (hWnd != (HWND)lParam) > + { > + got_wm_capturechanged = 1; > + EndMenu(); > + } > + break; Hi Vincent, EndMenu is not available on Win95 so no user32 tests are run on that platform at the moment. Can we skip just this call to EndMenu on Win95, should we skip this whole new test (test_contextmenu_focus) on Win95 or is there an alternative? -- Cheers, Paul.

May 1, 2010

3dmark2000, 3dmark06 results on both Wine and Vista

by Dan Kegel

I did some apples-to-apples 3d benchmarking today on a dual boot system. It looks offhand like Windows is about twice as fast as Wine on these benchmarks on my system. cpu: e8400 ram: 4GB video card: nvidia GT 240 Ubuntu 32 10.04 video drivers: 195.36.15 Vista 64 video drivers: 8.17.11.9713 Test procedure: On Ubuntu, grab latest wine from git, apply patch from http://bugs.winehq.org/show_bug.cgi?id=9210 so 3dmark06 will run. On Windows, install cygwin and a few of its packages (cabextract, wget, svn, etc.) Then on both systems do svn checkout http://winezeug.googlecode.com/svn/trunk/ winezeug sh winezeug sh yagmarktest That will run the tests in a loop and save a report for each run in the current directory. Results at http://kegel.com/wine/yagmarkdata/e8400/ Summary: Ubuntu: 6 runs 3dmark2000: min 4145, median 4154, max 4170 3dmark2001: min 18884, median 19261, max 19520 3dmark2006: min 17315, median 18154, max 18498 Vista: 2 runs: 3dmark2000: 8206, 8219 3dmark2006: 30278, 32384 Notes: 1) 3dmark2001 hangs for me on vista 64 bits, so no results for that test on that OS, I had to edit yagmarktest to remove it from the loop. Does it work for anyone else? 2) nvidia drivers occasionally crash X when running or quitting 3dmark2000 or 3dmark06; it's happened to me three times. 3) test script is fragile, don't touch the mouse or keyboard while it's running 4) shadows appear to be missing on wine in firefly forest in 3dmark06 and giant mecha truck test in 3dmark01? 5) format of my log files is ugly and will change.

May 1, 2010

Re: Minor dlls/localspl/tests/localmon.c simplificiation

by Nikolay Sivov

On 5/1/2010 21:52, Gerald Pfeifer wrote: > On Sat, 24 Apr 2010, Nikolay Sivov wrote: > >>> ChangeLog: >>> Remove variable res which is not really used from test_XcvClosePort. >>> >> We should better test for return value than remove it. >> > Okay. Is this something you can look into (or do you have a hint > on how you'd like such a test to look like)? It would be great > could you make this change, but if you have guidance I will do my > best to give it a try, too. > > Gerald > This is a primitive thing, try it if you didn't before. All you need is to add some lines like: --- ok(res == ERROR_SUCCESS /*a proper code here*/, "expected ERROR_SUCCESS, got %d\n", res); --- After that run a test on Windows and Wine (using a bot for example) and make corrections if needed.

May 1, 2010

Re: Minor dlls/localspl/tests/localmon.c simplificiation

by Gerald Pfeifer

On Sat, 24 Apr 2010, Nikolay Sivov wrote: >> ChangeLog: >> Remove variable res which is not really used from test_XcvClosePort. > We should better test for return value than remove it. Okay. Is this something you can look into (or do you have a hint on how you'd like such a test to look like)? It would be great could you make this change, but if you have guidance I will do my best to give it a try, too. Gerald

May 1, 2010

Re: Minor dlls/mshtml/htmlbody.c simplification (RESEND)

by Nikolay Sivov

On 5/1/2010 04:04, Gerald Pfeifer wrote: > On Wed, 28 Apr 2010, Nikolay Sivov wrote: > >> Please follow wine-devel comments: >> >> http://www.winehq.org/pipermail/wine-devel/2010-April/083175.html >> > Ouch, I had missed this message -- certainly did not mean to ignore > the good feedback. > > Is the following what you had in mind? > > Gerald > > > ChangeLog: > Fix return value for HTMLBodyElement_get_text. > > --- > dlls/mshtml/htmlbody.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index 5c66e65..65aa549 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -443,7 +443,7 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > HTMLBodyElement *This = HTMLBODY_THIS(iface); > nsAString text; > nsresult nsres; > - HRESULT hres; > + HRESULT hres = S_OK; > > TRACE("(%p)->(%p)\n", This, p); > > @@ -462,7 +462,7 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > > nsAString_Finish(&text); > > - return S_OK; > + return hres; > } > > static HRESULT WINAPI HTMLBodyElement_put_link(IHTMLBodyElement *iface, VARIANT v) > Yes, but you don't have to initialize it to S_OK.

May 1, 2010

Re: LinuxTag Berlin - call for projects

by Kai Blin

On Thu, 2010-04-29 at 10:12 +0200, Jan Gerrit Möltgen wrote: > Hello together, > > the Wine project is accepted for LinuxTag. I'm verry sorry, in the period of > the day linux I have no time unexpectedly and at this moment my time looks > bad, too. Is anyone here, who can manage the Wine on LinuxTag and would be at > this time in Berlin. > If no one is there, I will discard the stand unfortunately. Until when do you need to know? Cheers, Kai

May 1, 2010