June 2010 - Wine-Devel - list.winehq.org

Re: ntdll: try to not raise exceptions when checking for atl thunks

by Alexandre Julliard

Markus Amsler <markus.amsler(a)oribi.org> writes: > + * Windows checks the following conditions before emulating an ATL thunk: > + * - DEP policy allows emulating > + * - thunk has memory type MEM_PRIVATE and is readable > + * - jmp func is executable > + * - thunk signature (movl, jmp) matches > + * - a "secret" flag is set: > + * The flag gets set before calling WndProc and cleared after WndProc > + * or a thunk was emulated. > + * In Windows XP SP 3 this flag is located at TEB+0xfb4. > */ Where does that information come from? -- Alexandre Julliard julliard(a)winehq.org

June 16, 2010

Re: PGO and wine

by Peter Davies

On 16 June 2010 02:37, Dan Kegel <dank(a)kegel.com> wrote: > But does PGO improve performance measurably? > Probably, to test it I need a program that runs wine like a typical program, that I can run autonomously. Anyone have any ideas? Peter

June 16, 2010

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2695 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W7PROX64 (64 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

June 16, 2010

Re: winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to close a window

by Vitaliy Margolen

On 06/15/2010 05:36 AM, Paul Chitescu wrote: > Changelog: > winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to > close a window > + GetCursorPos( &pt ); > + PostMessageW( hwnd, WM_SYSCOMMAND, SC_CLOSE, MAKELPARAM( pt.x, pt.y ) ); You can't do that. Cursor can be anywhere, even outside Wine when WM decides to remove Wine's window. According to MSDN (which means it requires validation) you can pass either -1 or 0 for lparam here. Otherwise I think WM_SYSCOMMAN should be the correct behavior. Vitaliy.

June 16, 2010

Help with simple winelib dll

by Seth Burleigh

Im attempting to build a dll which a windows program running under wine can dynamically load. The dll will be a wrapper around a linux library. In preparation ive tried to follow the instructions here http://www.winehq.org/docs/winelib-guide/bindlls with a simple example but have not succeeded. Below is the contents of the files in my directory and the commands i executed. Can anyone help out? Thanks! MyLinuxFunc.c int MyLinuxFunc(int a,int b) { return a+b; } ----------------------------- MyLinuxFunc.h int MyLinuxFunc(int,int); ----------------------------- libMyLinuxFunc.so ----------------------------- MyWin.dll.spec 2 stdcall MyWinFunc (long long) MyProxyWinFunc ----------------------------- MyWin.c #include <MyLinuxFunc.h> #include <windef.h> int WINAPI MyProxyWinFunc (int a,int b) { return MyLinuxFunc(a,b); } ----------------------------- winemaker . --nosource-fix --dll --single-target MyWin --nomfc -I"." -L"." -iMyLinuxFunc make winegcc -o MyWin.so MyLinuxFunc.o MyWin.o -L. -lMyLinuxFunc MyWin.o: In function `MyProxyWinFunc': MyWin.c:(.text+0x20): undefined reference to `MyLinuxFunc' /usr/lib/wine/libwinecrt0.a(exe_main.o): In function `main': (.text+0xa0): undefined reference to `WinMain' collect2: ld returned 1 exit status winegcc: i486-linux-gnu-gcc failed make: *** [MyWin.so] Error 2

June 16, 2010

Re: [PATCH] winspool: Return ERROR_MORE_DATA, when the app probe for the needed buffersize [BUG 19624]

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2686 Your paranoid android. === WINEBUILD (build) === Can't determine base name

June 16, 2010

Re: propsys: mention that the functions are stubs

by Francois Gouget

On Tue, 15 Jun 2010, James Mckenzie wrote: [...] > >I'd say we need turn those into traces and add fixmes for the > >unimplemented parts, if needed. > > > This actually might be better, but don't TRACES only appear if you are > running in debug mode? We do want to inform our user base that a > failure happened due to partially implemented code rather than give > them the impression that we don't care or only implement code to make > certain programs work (hacky code...) Calling a pseudo stub may *or may not* result in an application failure. Usually they are added precisely because they avoid an application failure. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

June 15, 2010

Re: avifil32: Update English resource

by Frédéric Delanoy

> So whoever accepts or rejects the patches Alexandre Julliard is the commit imperator >, you may as well reject all of > mine (if you haven't already). I'll send them again once I'm on the right > track. > > Thanks all.

June 15, 2010

Re: avifil32: Update English resource

by Ken Sharp

On 15/06/10 20:26, Michael Stefaniuc wrote: > On 06/15/2010 08:53 PM, Ken Sharp wrote: >> >> >> On 15/06/10 10:28, Michael Stefaniuc wrote: >> >>> That's just an artifact of how the translation statistics tool works. >>> But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no >>> SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them >>> prone for bitrotting. >>> > >> I was told that US English = Default and British English = Neutral, and >> that all the other English sublangs pick up Neutral except en_US. >> >> So, are you saying what actually happens is that it first looks for >> NEUTRAL, and if it doesn't find that it looks for DEFAULT? And that >> NEUTRAL should be British English? If so, why is there a DEFAULT at all? > I was saying that LANG_ENGLISH SUBLANG_DEFAULT is special aka the > ultimate fallback for *all* other languages. So if a resource isn't > available in a language (neither in the country specific sublang nor in > the neutral sublang) it will eventually fall back to LANG_ENGLISH > SUBLANG_DEFAULT. That includes also the other English sublangs; thus > there is no point in duplicating the LANG_ENGLISH SUBLANG_DEFAULT > resources in LANG_ENGLISH SUBLANG_NEUTRAL as the result is the exact > same, achieved with less code. OK, that makes sense. If no resources for that LANG/SUBLANG is available it falls back to LANG_ENGLISH SUBLANG_DEFAULT.. that's fine. And so it's safe to say that SUBLANG_DEFAULT is US English (the translation page says it is) and the other sublangs pick up SUBLANG_NEUTRAL (I don't know where this is defined but testing the patches agrees with what the translation stats page says). So, the only time SUBLANG_NEUTRAL needs to be added is if the language varies from US English (such as colour, favour, minimise, etc.). ENGLISH_CAN then picks up NEUTRAL but sometimes the language varies again, so that needs to be added to correct that. Also, ENGLISH_PHILIPPINES always uses US English, so should pick up DEFAULT by default to reduce the amount of translation required (Bug 23124). And of course if there are any other sublangs that differ from the NEUTRAL they should be added too (most follow the same rules so this will probably never be necessary). This is how I originally did it but I got phased my the translation stats. I'll do a couple of small patches later to see if I can get it right this time! I've got a couple of Welsh and Gaelic patches too, but they are very small. > >> I wondered why there was also a ENGLISH_US in kernel32/nls. > The NLS files are not really a translation, they are the "localization" > part even though they do contain some translations. > >> If it actually looks for NEUTRAL first it would save a lot of >> duplication and would make the translations easier. >> >> Hope that makes sense. > Not really. Please have a look at http://wiki.winehq.org/SublangNeutral > it describes how the fallback works in Windows. Why they did it that way > you probably have to ask them; Wine just has to follow it. I read all that before but it didn't make any sense until now. Thanks for clarifying. > > bye > michael > So whoever accepts or rejects the patches, you may as well reject all of mine (if you haven't already). I'll send them again once I'm on the right track. Thanks all.

June 15, 2010

Re: avifil32: Update English resource

by Ken Sharp

On 15/06/10 20:34, André Hentschel wrote: > BTW: Placing your Copyrights in the translation files for some text copying is somehow naughty... > I asked about that in #winehackers and I was told I should add my own copyright. Personally, I couldn't care less.

June 15, 2010

Re: avifil32: Update English resource

by André Hentschel

Am 15.06.2010 21:47, schrieb Ken Sharp: > > > On 15/06/10 20:34, André Hentschel wrote: > >> BTW: Placing your Copyrights in the translation files for some text >> copying is somehow naughty... >> > > I asked about that in #winehackers and I was told I should add my own > copyright. Personally, I couldn't care less. > Ok, sorry, i thought it was your very intention. -- Best Regards, André Hentschel

June 15, 2010

Re: avifil32: Update English resource

by André Hentschel

Am 15.06.2010 20:53, schrieb Ken Sharp: > > > On 15/06/10 10:28, Michael Stefaniuc wrote: > >> That's just an artifact of how the translation statistics tool works. >> But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no >> SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them >> prone for bitrotting. >> >> bye >> michael >> > > I was told that US English = Default and British English = Neutral, and > that all the other English sublangs pick up Neutral except en_US. > > So, are you saying what actually happens is that it first looks for > NEUTRAL, and if it doesn't find that it looks for DEFAULT? And that > NEUTRAL should be British English? If so, why is there a DEFAULT at all? > > I wondered why there was also a ENGLISH_US in kernel32/nls. > > If it actually looks for NEUTRAL first it would save a lot of > duplication and would make the translations easier. > > Hope that makes sense. > > BTW: Placing your Copyrights in the translation files for some text copying is somehow naughty... -- Best Regards, André Hentschel

June 15, 2010

Re: avifil32: Update English resource

by Michael Stefaniuc

On 06/15/2010 08:53 PM, Ken Sharp wrote: > > > On 15/06/10 10:28, Michael Stefaniuc wrote: > >> That's just an artifact of how the translation statistics tool works. >> But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no >> SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them >> prone for bitrotting. >> > I was told that US English = Default and British English = Neutral, and > that all the other English sublangs pick up Neutral except en_US. > > So, are you saying what actually happens is that it first looks for > NEUTRAL, and if it doesn't find that it looks for DEFAULT? And that > NEUTRAL should be British English? If so, why is there a DEFAULT at all? I was saying that LANG_ENGLISH SUBLANG_DEFAULT is special aka the ultimate fallback for *all* other languages. So if a resource isn't available in a language (neither in the country specific sublang nor in the neutral sublang) it will eventually fall back to LANG_ENGLISH SUBLANG_DEFAULT. That includes also the other English sublangs; thus there is no point in duplicating the LANG_ENGLISH SUBLANG_DEFAULT resources in LANG_ENGLISH SUBLANG_NEUTRAL as the result is the exact same, achieved with less code. > I wondered why there was also a ENGLISH_US in kernel32/nls. The NLS files are not really a translation, they are the "localization" part even though they do contain some translations. > If it actually looks for NEUTRAL first it would save a lot of > duplication and would make the translations easier. > > Hope that makes sense. Not really. Please have a look at http://wiki.winehq.org/SublangNeutral it describes how the fallback works in Windows. Why they did it that way you probably have to ask them; Wine just has to follow it. bye michael

June 15, 2010

Re: propsys: mention that the functions are stubs

by James Mckenzie

Hans Leidekker <hans(a)codeweavers.com> wrote: > >On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > >> Just to confirm what André said, if the FIXME does not contain the word >> 'stub', then apistats has no way to know it's a (pseudo-)stub. > >Wouldn't it be sufficient for our purposes to just count every first >fixme in a WINAPI function as a stub? As it is now there's a large >percentage of fixmes that don't include the 'stub' keyword. > I tend to disagree. Stubs should be identified, if possible, for each call. Some calls will not activate a specific sequence of FIXMEs and in some cases, users have become confused as they don't have the technical knowledge to determine why their program is failing. > >> I would further argue that even a human reading the log would have no >> way to know as quite a few implemented functions still dump their parameters. >> So even for humans it's better to add 'stub' to the FIXME message. > >I'd say we need turn those into traces and add fixmes for the >unimplemented parts, if needed. > This actually might be better, but don't TRACES only appear if you are running in debug mode? We do want to inform our user base that a failure happened due to partially implemented code rather than give them the impression that we don't care or only implement code to make certain programs work (hacky code...) Note: This is only a statement of opinion, not a request for direction within the project. If a fixme had 'stub' that means that we have implemented code to 'fake' windows functionality, whereas a real fixme means there is a problem with the code and it needs to be corrected. James McKenzie

June 15, 2010

Re: avifil32: Update English resource

by Ken Sharp

On 15/06/10 10:28, Michael Stefaniuc wrote: > That's just an artifact of how the translation statistics tool works. > But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no > SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them > prone for bitrotting. > > bye > michael > I was told that US English = Default and British English = Neutral, and that all the other English sublangs pick up Neutral except en_US. So, are you saying what actually happens is that it first looks for NEUTRAL, and if it doesn't find that it looks for DEFAULT? And that NEUTRAL should be British English? If so, why is there a DEFAULT at all? I wondered why there was also a ENGLISH_US in kernel32/nls. If it actually looks for NEUTRAL first it would save a lot of duplication and would make the translations easier. Hope that makes sense.

June 15, 2010

Gcov and PGO

by Peter Davies

After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRACFLAGS=-fprofile-generate LDFLAGS=-fprofile-generate" Run sample program (test suite is inappropriate because it doesn't represent normal usage). Run "make clean" Run "make EXTRACFLAGS=-fprofile-use LDFLAGS=-fprofile-use" Peter

June 15, 2010

Re: propsys: mention that the functions are stubs

by Juan Lang

> Can you show me at least 3 stub functions with a fixme and without the stub keyword grep can do that for you. One file alone will do this: dlls/itss/protocol.c. There are many more. --Juan

June 15, 2010

Re: propsys: mention that the functions are stubs

by André Hentschel

Am 15.06.2010 11:25, schrieb Hans Leidekker: > Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. Can you show me at least 3 stub functions with a fixme and without the stub keyword -- Best Regards, André Hentschel

June 15, 2010

Re: Anotated 'make test' log

by Max TenEyck Woodbury

Dan wrote: > OK. I'd suggest starting by looking at > http://bugs.winehq.org/show_bug.cgi?id=15435 > "Wine logs too verbose, quieter fixme's needed" and sending > in a patch to make one of the overly-verbose fixme's a bit > quieter. Thanks. I'll look at it. > Also, check your mail system; I can't email to you directly, > it bounces. And that's going to be a problem communicating > with other developers. A system disk failed this past weekend and I've been trying to get everything back up. I got test messages through starting about two hours ago. I've been checking the mailing list archive. (Yes, messages do not get properly threaded that way.) I'm also in the process of reinstalling much software. That machine is not very fast... - Max

June 15, 2010

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android. === WINEBUILD (build) === Can't determine base name

June 15, 2010

Re: Anotated 'make test' log

by Dan Kegel

Max wrote: > A little reassurance that I am not crazy and > have the social skills needed to contribute to the community > are what I need at the moment. OK. I'd suggest starting by looking at http://bugs.winehq.org/show_bug.cgi?id=15435 "Wine logs too verbose, quieter fixme's needed" and sending in a patch to make one of the overly-verbose fixme's a bit quieter. Also, check your mail system; I can't email to you directly, it bounces. And that's going to be a problem communicating with other developers. - Dan

June 15, 2010

Re: propsys: mention that the functions are stubs

by Francois Gouget

On Tue, 15 Jun 2010, Hans Leidekker wrote: [...] > Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. > > > I would further argue that even a human reading the log would have no > > way to know as quite a few implemented functions still dump their parameters. > > So even for humans it's better to add 'stub' to the FIXME message. > > I'd say we need turn those into traces and add fixmes for the > unimplemented parts, if needed. I agree with the turning these to TRACE()s part. In all the other places I have seen they are TRACE()s, not FIXME()s. But they need the 'stub' keyword either way to not be ambiguous. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

June 15, 2010

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.

by Alexandre Julliard

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT notification, UINT_PTR param1, UINT_PTR param2 ) > { > + static int has_extracted; > + This is not reentrant. Also you need to point out which bugs these patches are fixing that justifies putting them in during code freeze. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2010

Re: propsys: mention that the functions are stubs

by Hans Leidekker

On Tue, 2010-06-15 at 12:41 +0100, Peter Davies wrote: > > Wouldn't it be sufficient for our purposes to just count every first > > fixme in a WINAPI function as a stub? As it is now there's a large > > percentage of fixmes that don't include the 'stub' keyword. > > A FIXME doesn't neccesarily indicate a stub. It sometimes is like > "Flag FOO unsupported", which is not the same as a stub. Maybe we > could have STUB macro to be called in stub functions. Sure, we would overestimate the number of stubs a little but I don't think we need such accurate statistics, it's certainly not worth the addition of a new macro. You could even catch most of those false positives by ignoring fixmes which are preceded by a trace.

June 15, 2010

Re: propsys: mention that the functions are stubs

by Peter Davies

> Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. A FIXME doesn't neccesarily indicate a stub. It sometimes is like "Flag FOO unsupported", which is not the same as a stub. Maybe we could have STUB macro to be called in stub functions. Peter

June 15, 2010

Re: Changes to enable the use of gcov

by Peter Davies

> Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? I think my mail client (gmail) line wraps. I discovered when trying to apply it myself. > As an aside, if gcov compilation finally starts working that means we > can build Wine using GCC's Profile Guided Optimization. In other > applications this has made a very significant boost in performance, and > it's basically "free". The changes to enable gcov are trivial, all we have to do is have winegcc let the relevent options through. I'll resend the patch and make sure it helps with PGA. Peter

June 15, 2010

Re: avifil32: Update English resource

by Michael Stefaniuc

Ken Sharp wrote: > > > On 15/06/10 09:00, Alexandre Julliard wrote: >> Ken Sharp<kennybobs(a)o2.co.uk> writes: >> >>> @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE >>> IDS_AVIFILETYPE "Wine AVI-default-filehandler" >>> IDS_UNCOMPRESSED "uncompressed" >>> } >>> + >>> +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL >>> +/* Same as SUBLANG_DEFAULT */ >> >> If they are the same there's no reason to duplicate them. >> >> Also you should never submit 60 patches in one go; 10-15 is the maximum >> for a patch series, and that's only if you are absolutely confident that >> they are correct. Otherwise send only a couple until you are sure to get >> it right on the first try. >> > > It will set the statistics to 100% for all the English languages: > they're currently at 7%. > http://source.winehq.org/transl/ > > 100% seems to be what other FOSS projects are aiming for. There is no > way to say SUBLANG_NEUTRAL = SUBLANG_DEFAULT at the moment. That's just an artifact of how the translation statistics tool works. But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them prone for bitrotting. bye michael

June 15, 2010

Re: propsys: mention that the functions are stubs

by Hans Leidekker

On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > Just to confirm what André said, if the FIXME does not contain the word > 'stub', then apistats has no way to know it's a (pseudo-)stub. Wouldn't it be sufficient for our purposes to just count every first fixme in a WINAPI function as a stub? As it is now there's a large percentage of fixmes that don't include the 'stub' keyword. > I would further argue that even a human reading the log would have no > way to know as quite a few implemented functions still dump their parameters. > So even for humans it's better to add 'stub' to the FIXME message. I'd say we need turn those into traces and add fixmes for the unimplemented parts, if needed.

June 15, 2010

Re: avifil32: Update English resource

by Ken Sharp

On 15/06/10 09:00, Alexandre Julliard wrote: > Ken Sharp<kennybobs(a)o2.co.uk> writes: > >> @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE >> IDS_AVIFILETYPE "Wine AVI-default-filehandler" >> IDS_UNCOMPRESSED "uncompressed" >> } >> + >> +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL >> +/* Same as SUBLANG_DEFAULT */ > > If they are the same there's no reason to duplicate them. > > Also you should never submit 60 patches in one go; 10-15 is the maximum > for a patch series, and that's only if you are absolutely confident that > they are correct. Otherwise send only a couple until you are sure to get > it right on the first try. > It will set the statistics to 100% for all the English languages: they're currently at 7%. http://source.winehq.org/transl/ 100% seems to be what other FOSS projects are aiming for. There is no way to say SUBLANG_NEUTRAL = SUBLANG_DEFAULT at the moment.

June 15, 2010

Re: New Wine stuff in FreeWear.org

by Ismael Barros²

Hi again, As the design seems to be liked, we just made the garments available for sale. As always, you can find them at http://www.freewear.org/?org=Wine Cheers! Ismael

June 15, 2010

Re: propsys: mention that the functions are stubs

by Francois Gouget

On Mon, 14 Jun 2010, André Hentschel wrote: > Am 14.06.2010 22:01, schrieb Hans Leidekker: > > On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > > > >> Hans might have missed that > > > > No, to me a fixme that prints a parameter list without further > > explanation implies that the function is a stub. > > > > > That's somehow true, but for easier reading it is better i guess. > Also i think the apistats parser also checks for something like > "FIXME(.*)stub" and calls it pseudo stubs if i remember correctly. > Even if apistats dont work we should keep that style. Just to confirm what André said, if the FIXME does not contain the word 'stub', then apistats has no way to know it's a (pseudo-)stub. I would further argue that even a human reading the log would have no way to know as quite a few implemented functions still dump their parameters. So even for humans it's better to add 'stub' to the FIXME message. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

June 15, 2010

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it

by Alexandre Julliard

Marcus Meissner <marcus(a)jet.franken.de> writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is, it doesn't really prove anything. Also please use sizeof and friends instead of hardcoded numbers. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2010

Re: avifil32: Update English resource

by Alexandre Julliard

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE > IDS_AVIFILETYPE "Wine AVI-default-filehandler" > IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate them. Also you should never submit 60 patches in one go; 10-15 is the maximum for a patch series, and that's only if you are absolutely confident that they are correct. Otherwise send only a couple until you are sure to get it right on the first try. -- Alexandre Julliard julliard(a)winehq.org

June 15, 2010

Re: Updating the 1.2 release announcement text

by Peter Urbanec

On 14/06/10 18:12, Edward Savage wrote: > I'm looking to try and fill out a WWN for this friday I really think it would be very beneficial to go into some detail on the 64-bit support. In particular, it would be a good idea to outline the expected user experience when running a 64-bit app.

June 15, 2010

Re:Anotated 'make test' log

by Max TenEyck Woodbury

Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to start, so I started at the top of the log. I expect that to change once I become more sure that I have the mechanics correct. There are several things I'm trying to do. First is to find the place where each 'bit of noise' is generated. I seem to be doing that right. Then I look at why the noise was generated and to show that I've understood why, I wrote a note on how the 'noise' could be turned off without changing the test. I labelled these 'fixup:'. I then looked at the test code and added 'Note:'s where I thought the test could be improved. > While that's a noble quest, and I'd like to encourage people > to improve the tests, it might be more productive to do so > around areas of pain for users. > For instance, you could look at bugs in bugzilla that have > patches attached that aren't committed yet because tests are > needed, and write those tests. > - Dan That sounds useful. I also have a few issues I'd like fixed too. However, it's been more than five years since I've done serious coding; things happened that destroyed my self-confidence. A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

June 15, 2010

Re: Changes to enable the use of gcov

by Scott Ritchie

On 06/14/2010 08:04 PM, James McKenzie wrote: > Peter Davies wrote: >> To use gcov you must pass --coverage at both compile and link time. >> This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", >> "make test", >> "gcov file.c" is sufficient generate .gcov files. >> >> > Peter: > > Somehow this patch got munged in transit and will not apply to current > git. Can you update it and send it again? > > James McKenzie > As an aside, if gcov compilation finally starts working that means we can build Wine using GCC's Profile Guided Optimization. In other applications this has made a very significant boost in performance, and it's basically "free". Thanks, Scott Ritchie

June 15, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Scott Ritchie

On 06/14/2010 11:02 AM, Ing. Simone. Giustetti wrote: > How about 64 bit packages with Wow64 ? This feature is described as a major one > for Wine release 1.2, but as far as I know no x86_64 package was released yet. > I've been using it since release 1.1.44 for testing purposes and it seems pretty > stable. > If there are no objections, I'll upload i486 and x86_64 packages and announce it > in Slackaware related communities asking for reviews / regressions. > On the Ubuntu side this isn't going to happen until Maverick due to changes in the underlying handling of 64-bit libraries. Or, put differently, it's too big a change for a stable release update of Wine in Lucid (1.2 will be fit for stable release update, however, exactly because of all this regression-fixing we're doing). Thanks, Scott Ritchie

June 15, 2010

Re: Two enhancement requests for winetricks

by James McKenzie

Jan Hoogenraad wrote: > James Mckenzie wrote: >> Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >>> OK. New version of the script: it also finds uppercase filename >>> matches. >>> It also removed: >>> >>> 131072 1999-01-15 04:37 system32/MAPISTUB.DLL >>> 70656 2008-10-06 23:30 system32/MSVCIRT.DLL >>> 326656 2008-10-06 23:30 system32/MSVCRT40.DLL >>> 492304 2008-10-06 23:30 system32/OLEAUT32.DLL >> >> These are the files that Wine creates. You may have broken your Wine >> install now. >> >> OLEAUT32.DLL contains partial code that links to a file >> OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) >> >> James McKenzie >> > > Mind the timestamps & sizes. In this case, these files were installed > with the installation of an application or winetricks. > I am now trying to get rid of as much of this old stuff, in order to > be as much wine as possible. You are correct. Just be very careful and not remove any of the 'fake' dlls inserted by Wine. One cannot be TOO careful! Thank you for pointing out the dates and times. This looks like more VB6 run time 'stuff'. Interesting that to OLEAUT32.DLL file installed. James McKenzie

June 15, 2010

Re: Changes to enable the use of gcov

by James McKenzie

Peter Davies wrote: > To use gcov you must pass --coverage at both compile and link time. > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test", > "gcov file.c" is sufficient generate .gcov files. > > Peter: Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? James McKenzie

June 15, 2010

Re: msvcrt: Add _wmakepath_s implementation

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2647 Your paranoid android. === WINEBUILD (build) === Make failed

June 15, 2010

Re: Two enhancement requests for winetricks

by Jan Hoogenraad

Mind the timestamps & sizes. In this case, these files were installed with the installation of an application or winetricks. I am now trying to get rid of as much of this old stuff, in order to be as much wine as possible. James Mckenzie wrote: > Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >> OK. New version of the script: it also finds uppercase filename matches. >> It also removed: >> >> 131072 1999-01-15 04:37 system32/MAPISTUB.DLL >> 70656 2008-10-06 23:30 system32/MSVCIRT.DLL >> 326656 2008-10-06 23:30 system32/MSVCRT40.DLL >> 492304 2008-10-06 23:30 system32/OLEAUT32.DLL > > These are the files that Wine creates. You may have broken your Wine install now. > > OLEAUT32.DLL contains partial code that links to a file OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) > > James McKenzie > -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht

June 14, 2010

RFC: Standardize paths in shell32.SHChangeNotify [Bug 18606]

by Andrew Eikum

Hey folks, I have a fix here for bug 18606. I think it's decent, but I could use another few sets of eyes to make sure I didn't miss anything, or even that I'm not way on the wrong track. The problem and solution are described in patch 3. In brief, SHChangeNotify notifies windows when a change to the filesystem occurs that the window asked to be notified about. For example, a window might tell SHChangeNotifyRegister "Inform me about changes to C:\". Bug 18606 occurs because the new directory is passed to SHChangeNotify as '/home/user/.wine/drive_c/New Directory', which doesn't match the IDList created for 'C:\'. This patchset fixes that by converting all paths in SHChangeNotify to UNIX paths, resolving symlinks etc, and comparing the ID lists created from those paths. That way, the paths being compared are standardized and compared fairly. Unfortunately, this is hard to write tests for. You'd have to make an ID list that is significantly different from the one SHChangeNotifyRegister will create, but that actually refers to the same directory. This is easy in Wine, but less obvious in Windows. Suggestions for how to accomplish this are welcome. Logically, though, I think the problem and solution make sense. Please take a look. Any feedback is appreciated. Andrew

June 14, 2010

Re: propsys: mention that the functions are stubs

by André Hentschel

Am 14.06.2010 22:01, schrieb Hans Leidekker: > On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > >> Hans might have missed that > > No, to me a fixme that prints a parameter list without further > explanation implies that the function is a stub. > > That's somehow true, but for easier reading it is better i guess. Also i think the apistats parser also checks for something like "FIXME(.*)stub" and calls it pseudo stubs if i remember correctly. Even if apistats dont work we should keep that style. -- Best Regards, André Hentschel

June 14, 2010

Re: propsys: mention that the functions are stubs

by Hans Leidekker

On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > Hans might have missed that No, to me a fixme that prints a parameter list without further explanation implies that the function is a stub.

June 14, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Marcus Meissner

On Mon, Jun 14, 2010 at 08:02:08PM +0200, Ing. Simone. Giustetti wrote: > How about 64 bit packages with Wow64 ? This feature is described as a major one > for Wine release 1.2, but as far as I know no x86_64 package was released yet. > I've been using it since release 1.1.44 for testing purposes and it seems pretty > stable. > If there are no objections, I'll upload i486 and x86_64 packages and announce it > in Slackaware related communities asking for reviews / regressions. openSUSE Factory which will become openSUSE 11.3 contains this setup already. While 11.3 is in betatesting, which might mean less bugreports, I have not heard of any yet. Ciao, Marcus

June 14, 2010

Portuguese translations of Wine back at 100%

by Paul Vriens

Hi, Just a note to thank Ricardo for getting the Portuguese translations back to 100%. -- Cheers, Paul.

June 14, 2010

Polish translations of Wine at 100%

by Paul Vriens

Hi, Łukasz did it, Polish translations of Wine reached the 100% mark !!! Great job done. -- Cheers, Paul.

June 14, 2010

Re: Make depend

by Reece Dunn

On 14 June 2010 18:54, Peter Davies <ultratwo(a)gmail.com> wrote: > On 14 June 2010 18:40, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: >> >> Since around 2-3 months ago, you don't need to run "make depend" at all :-). >> >> Damjan >> > > Then why is it still there? When you run `make`, `make depend` is called automatically so you don't need to call it explicitly. - Reece

June 14, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Ing. Simone. Giustetti

How about 64 bit packages with Wow64 ? This feature is described as a major one for Wine release 1.2, but as far as I know no x86_64 package was released yet. I've been using it since release 1.1.44 for testing purposes and it seems pretty stable. If there are no objections, I'll upload i486 and x86_64 packages and announce it in Slackaware related communities asking for reviews / regressions. Bye Simone > On Sun, Jun 13, 2010 at 10:00 AM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: > >> How close are we to release? Maybe it'd be worth > >> it to publicise the upcoming wine release by > >> flogging rc3 in various news sites and getting more people to > >> look for regressions. > > > > +1. > > OK, I've posted something to linuxtoday and lwn.net. > I wanted to include something about how many > bugs have been fixed etc., but I didn't have those > statistics handy, so I just said "many more apps > should work with 1.2 than with 1.0". > > > I'm getting a fresh git and fixing/running and then submitting the > > EM_FORMATRANGE patches today. > > Thanks! > - Dan > > > > -- Simone Giustetti Tel: 340-3425647 e-mail: studiosg(a)giustetti.net ------------------------------------------------- This mail sent through IMP: http://horde.org/imp/

June 14, 2010

Re: Make depend

by Octavian Voicu

On Mon, Jun 14, 2010 at 8:54 PM, Peter Davies <ultratwo(a)gmail.com> wrote: > Then why is it still there? I think it's still used internally. If you run `make depend' then 'make' you'll see it will go a bit faster because the dependencies are already precomputed. Octavian

June 14, 2010

Re: Make depend

by Peter Davies

On 14 June 2010 18:40, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > > Since around 2-3 months ago, you don't need to run "make depend" at all :-). > > Damjan > Then why is it still there? Peter

June 14, 2010

Re: Make depend

by Damjan Jovanovic

On Mon, Jun 14, 2010 at 6:52 PM, Peter Davies <ultratwo(a)gmail.com> wrote: > How often do I need to run "make depend"? > > Peter > > > Since around 2-3 months ago, you don't need to run "make depend" at all :-). Damjan

June 14, 2010

Make depend

by Peter Davies

How often do I need to run "make depend"? Peter

June 14, 2010

Re: mshtml: Check if event_table entry is allocated before using it in remove_event_handler.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2632 Your paranoid android. === W2K3R2SESP2 (32 bit events) === events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 === W7PRO (32 bit events) === events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 === W7PROX64 (32 bit events) === events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 === W7PROX64 (64 bit events) === events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0

June 14, 2010

Re: Two enhancement requests for winetricks

by James Mckenzie

Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >OK. New version of the script: it also finds uppercase filename matches. >It also removed: > > 131072 1999-01-15 04:37 system32/MAPISTUB.DLL > 70656 2008-10-06 23:30 system32/MSVCIRT.DLL > 326656 2008-10-06 23:30 system32/MSVCRT40.DLL > 492304 2008-10-06 23:30 system32/OLEAUT32.DLL These are the files that Wine creates. You may have broken your Wine install now. OLEAUT32.DLL contains partial code that links to a file OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) James McKenzie

June 14, 2010

Re: Two enhancement requests for winetricks

by Jan Hoogenraad

OK. New version of the script: it also finds uppercase filename matches. It also removed: 131072 1999-01-15 04:37 system32/MAPISTUB.DLL 70656 2008-10-06 23:30 system32/MSVCIRT.DLL 326656 2008-10-06 23:30 system32/MSVCRT40.DLL 492304 2008-10-06 23:30 system32/OLEAUT32.DLL Now, is seems that the following files belong to that pack as well: >> 924432 2008-10-06 23:30 MFC40.DLL >> 499712 2008-10-06 23:30 msvcp71.dll >> 21936 2008-10-06 23:30 help.exe >> 995383 2008-10-06 23:30 MFC42.DLL Are they in any way harmful if they stay in system32 ? Or do they contain additional functionality, not yet included in wine ? James McKenzie wrote: > Jan Hoogenraad wrote: >> Attached a simple script which at least removes those files that were >> installed by another application (possibly winetricks) and are now >> provided by wine. >> >> On my computer, it removed the following files (of which I am unsure >> of its origins). >> 17680 1998-08-06 12:43 psapi.dll >> 131072 1999-01-15 04:37 mapi32.dll >> 348160 2008-10-06 23:30 msvcr71.dll >> 258352 2008-10-06 23:30 unicows.dll >> 65304 2010-06-08 16:58 winhlp32.exe >> >> >> .. based on the date match, I suspect the files below as well. >> However, there are no files with the same name in the wine directory, >> and thus my simple script is unable to judge them as being superseded: >> 924432 2008-10-06 23:30 MFC40.DLL >> 499712 2008-10-06 23:30 msvcp71.dll >> 326656 2008-10-06 23:30 MSVCRT40.DLL >> 492304 2008-10-06 23:30 OLEAUT32.DLL >> 21936 2008-10-06 23:30 help.exe >> 995383 2008-10-06 23:30 MFC42.DLL >> 70656 2008-10-06 23:30 MSVCIRT.DLL >> > VB6, possibly? > > James McKenzie > -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht

June 14, 2010

Re: [2/2] msi: Add tests for MsiLocateComponent and make them pass.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2626 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:1622: Test failed: Expected C:\imapath, got msi.c:1629: Test failed: Expected C:\imapath, got msi.c:1648: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1649: Test failed: Expected C:\imapath, got msi.c:1650: Test failed: Expected 10, got 260 msi.c:1655: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1656: Test failed: Expected C:\imapath, got msi.c:1657: Test failed: Expected 10, got 260 msi.c:1666: Test failed: Expected C:\imapath, got msi.c:1672: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1673: Test failed: Expected C:\imapath, got msi.c:1674: Test failed: Expected 10, got 260 msi.c:1712: Test failed: Expected C:\imapath, got msi.c:1719: Test failed: Expected C:\imapath, got msi.c:1738: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1739: Test failed: Expected C:\imapath, got msi.c:1740: Test failed: Expected 10, got 260 msi.c:1745: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1746: Test failed: Expected C:\imapath, got msi.c:1747: Test failed: Expected 10, got 260 msi.c:1756: Test failed: Expected C:\imapath, got msi.c:1762: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1763: Test failed: Expected C:\imapath, got msi.c:1764: Test failed: Expected 10, got 260 msi.c:1822: Test failed: Expected C:\imapath, got msi.c:1829: Test failed: Expected C:\imapath, got msi.c:1848: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1849: Test failed: Expected C:\imapath, got msi.c:1850: Test failed: Expected 10, got 260 msi.c:1855: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1856: Test failed: Expected C:\imapath, got msi.c:1857: Test failed: Expected 10, got 260 msi.c:1866: Test failed: Expected C:\imapath, got msi.c:1872: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1873: Test failed: Expected C:\imapath, got msi.c:1874: Test failed: Expected 10, got 260 msi.c:1931: Test failed: Expected C:\imapath, got msi.c:1937: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1938: Test failed: Expected C:\imapath, got msi.c:1939: Test failed: Expected 10, got 260 msi.c:1948: Test failed: Expected C:\imapath, got msi.c:1954: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1955: Test failed: Expected C:\imapath, got msi.c:1956: Test failed: Expected 10, got 260 msi.c:2008: Test failed: Expected C:\imapath, got msi.c:2014: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:2015: Test failed: Expected C:\imapath, got msi.c:2016: Test failed: Expected 10, got 260 msi.c:2025: Test failed: Expected C:\imapath, got msi.c:2031: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:2032: Test failed: Expected C:\imapath, got msi.c:2033: Test failed: Expected 10, got 260 msi.c:2129: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2147: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2162: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2177: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2195: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2224: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2242: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2257: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2272: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2290: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2371: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2377: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2401: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2408: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2442: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2471: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2478: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:7467: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7536: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7603: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7827: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7829: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7888: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7906: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7924: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7926: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7942: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7944: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7961: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7963: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7982: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7984: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8001: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8003: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8119: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8121: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8166: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8168: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8192: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8194: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7827: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7829: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7888: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7906: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7924: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7926: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7942: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7944: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7961: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7963: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7982: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7984: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8001: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8003: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8119: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8121: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8166: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8168: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8192: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8194: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7827: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7829: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7888: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7906: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7924: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7926: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7942: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7944: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7961: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7963: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7982: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7984: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8001: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8003: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8119: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8121: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8166: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8168: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8192: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8194: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8445: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8447: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8567: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8569: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8614: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8616: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8640: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8642: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8445: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8447: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8567: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8569: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8614: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8616: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8640: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8642: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8937: Test failed: Expected patchcode to be unchanged, got {2B8A9453-54F5-4090-A3A4-951258440C67} msi.c:8939: Test failed: Expected targetprod to be unchanged, got {A549CAF1-986B-4834-AD1A-3744EFAB33EC} msi.c:9008: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9010: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9053: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9055: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9599: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9642: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9819: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple"

June 14, 2010

Re: [PATCH] atl: Do not fail on Wine64

by Alexandre Julliard

Marcus Meissner <marcus(a)jet.franken.de> writes: > It seems to input 248 in my case. Probably it will not get 240, > but _ATL_MODULEW (or better, the ATL_MODULE C++ class) has some other > difference. > > Question is really how to find out more, as atl.dll is written in C++ > and documentation scarce. > > -> so for starters I just would suggest to ignore failure. It wouldn't be hard to write a test to at least determine which sizes are accepted. We need the correct value for ATLVer1Size too. -- Alexandre Julliard julliard(a)winehq.org

June 14, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > On 6/13/2010 18:53, Dan Kegel wrote: >> How close are we to release? > Not closely related to a beta testing, but for quality it is - it > would be nice to have valgrind tests logs as you did some months ago. > I think it's possible to catch something new that is easy to fix for 1.2. It's a little late for that. At this point we need to concentrate on bugs that affect real applications, and preferably regressions. -- Alexandre Julliard julliard(a)winehq.org

June 14, 2010

RE: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

by Greg Geldorp

> From: Reece Dunn <msclrhd(a)googlemail.com> > > msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not > registered. This does not fail on the test page, as the msxml3 tests > are skipped when msxml3.dll is not present. > > It would probably be better to issue a win_skip in this instance, but > it is not relevant to your change. TestBot uses a different algorithm to check if a test should be skipped. Winetest.exe checks the name of the test and obtains the name of the DLL being tested from that (msxml3_test.exe => msxml3.dll). If that DLL is not present, winetest.exe skips the test. TestBot checks the import table of the test executable, and if any of the statically imported DLLs are missing it skips the test. In this case, msxml3.dll is not statically linked, so it will not be skipped by TestBot on NT4. TestBot should probably check the test name too. Ge.

June 14, 2010

Re: Two enhancement requests for winetricks

by Francois Gouget

On Sat, 12 Jun 2010, Jan Hoogenraad wrote: [...] > Can wine handle multiple instances of the server for the different > directories, when applications from different start directories are running in > parallel ? Yes. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

June 14, 2010

Re: Updating the 1.2 release announcement text

by Edward Savage

On Mon, Jun 14, 2010 at 6:00 PM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > On 14 June 2010 08:49, Edward Savage <epssyis(a)gmail.com> wrote: >> I've emailed a couple of people today to get an idea of what has >> changed between 1.0 and 1.2 so we can start to compile the important >> improvements. Hopefully this can be expanded upon pretty quickly. > > Collating and looking at the main features/updates in the release > announcements (the 5/6 bullet items at the top) that Alexandre > produces might be a good start. > Already done. I'm looking to try and fill out a WWN for this friday and then use the information from it as the basis to add to the release page. Plus just compiling the list isn't enough, many of the points need clarification so you have to go through the patch list to see who contributed what and contact them. When I've done it I'll add it to that page though it is pretty low priority for me. Also if any one knows anything about the WineTestBot could they have a go at turning the section on it at http://wiki.winehq.org/RecentNewsQueue into a news item. It is definitely worth mentioning for 1.2 but I'm not interested enough to investigate it. I'm happy to reformat what you write in to a more 'news looking' story if needed.

June 14, 2010

Re: Updating the 1.2 release announcement text

by Reece Dunn

On 14 June 2010 08:49, Edward Savage <epssyis(a)gmail.com> wrote: > On Mon, Jun 14, 2010 at 3:16 AM, Dan Kegel <dank(a)kegel.com> wrote: >> http://wiki.winehq.org/Wine1.2Announcement could use some work >> if anyone has time... > > I've emailed a couple of people today to get an idea of what has > changed between 1.0 and 1.2 so we can start to compile the important > improvements. Hopefully this can be expanded upon pretty quickly. Collating and looking at the main features/updates in the release announcements (the 5/6 bullet items at the top) that Alexandre produces might be a good start. - Reece

June 14, 2010

Re: Updating the 1.2 release announcement text

by Edward Savage

On Mon, Jun 14, 2010 at 3:16 AM, Dan Kegel <dank(a)kegel.com> wrote: > http://wiki.winehq.org/Wine1.2Announcement could use some work > if anyone has time... > I've emailed a couple of people today to get an idea of what has changed between 1.0 and 1.2 so we can start to compile the important improvements. Hopefully this can be expanded upon pretty quickly.

June 14, 2010

Re: [PATCH] atl: Do not fail on Wine64

by Marcus Meissner

On Mon, Jun 14, 2010 at 03:07:39AM +0200, Maarten Lankhorst wrote: > Hi Marcus, > > 2010/6/13 Marcus Meissner <marcus(a)jet.franken.de>: > > Hi, > > > > The size is 248 on Wine64 ... (expected 240), so we miss > > perhaps a pointer or some alignment. > > > > Its not fully clear what. > > > > It at least does not crash when ignoring the size change. > Seems wrong to me, does it allow size 240 on 64-bits, or does it allow 248 only? It seems to input 248 in my case. Probably it will not get 240, but _ATL_MODULEW (or better, the ATL_MODULE C++ class) has some other difference. Question is really how to find out more, as atl.dll is written in C++ and documentation scarce. -> so for starters I just would suggest to ignore failure. ciao, Marcus

June 14, 2010

Re: [PATCH] atl: Do not fail on Wine64

by Maarten Lankhorst

Hi Marcus, 2010/6/13 Marcus Meissner <marcus(a)jet.franken.de>: > Hi, > > The size is 248 on Wine64 ... (expected 240), so we miss > perhaps a pointer or some alignment. > > Its not fully clear what. > > It at least does not crash when ignoring the size change. Seems wrong to me, does it allow size 240 on 64-bits, or does it allow 248 only? ~Maarten

June 14, 2010

Re: [PATCH 4/6] shdocvw: Silence QueryService traces in non-interactive runs.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2620 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === Timeout === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:295: Test failed: unexpected nsCmdID 28

June 14, 2010

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

by Reece Dunn

On 13 June 2010 20:46, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 6/13/2010 22:55, (Marvin) wrote: >> >> Hi, >> >> While running your changed tests on Windows, I think I found new failures. >> Being a bot and all I'm not very good at pattern recognition, so I might >> be >> wrong, but could you please double-check? >> Full results can be found at >> http://testbot.winehq.org/JobDetails.pl?Key=2617 >> >> Your paranoid android. >> >> >> === WNT4WSSP6 (32 bit domdoc) === >> domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should >> have succeeded instead of failing with 0x80040154 > > This is not related to my patch obviously, a sporadic failure it seems. msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not registered. This does not fail on the test page, as the msxml3 tests are skipped when msxml3.dll is not present. It would probably be better to issue a win_skip in this instance, but it is not relevant to your change. - Reece

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Dan Kegel

Nikolay Sivov wrote: > ... it would > be nice to have valgrind tests logs as you did some months ago. > I think it's possible to catch something new that is easy to fix for 1.2. You're right. I'll try to find them time to fire that up again.

June 13, 2010

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

by Nikolay Sivov

On 6/13/2010 22:55, (Marvin) wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=2617 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit domdoc) === > domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should have succeeded instead of failing with 0x80040154 > This is not related to my patch obviously, a sporadic failure it seems.

June 13, 2010

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid android. === WNT4WSSP6 (32 bit domdoc) === domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should have succeeded instead of failing with 0x80040154

June 13, 2010

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph

by James McKenzie

Austin English wrote: > On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: > >> This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change >> any of the code but moves code from ME_WrapMarkedParagraphs to >> ME_WrapTextParagraph. >> >> The bug report #6254, which this is a solution to is marked as needed for >> Wine 1.2 >> >> Thanks to Dylan Smith who helped segegrate and clean up the original code >> proposed by Tony Rollo and further worked on by Lei Zhang and myself. >> > > You forgot the patch. > > > Austin: Fixed....(Stupid Thunderbird messes up patches and I have to manually add the patch...) James McKenzie

June 13, 2010

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph

by Austin English

On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change > any of the code but moves code from ME_WrapMarkedParagraphs to > ME_WrapTextParagraph. > > The bug report #6254, which this is a solution to is marked as needed for > Wine 1.2 > > Thanks to Dylan Smith who helped segegrate and clean up the original code > proposed by Tony Rollo and further worked on by Lei Zhang and myself. You forgot the patch. -- -Austin

June 13, 2010

Re: msi: Print more information on error

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > i had that case with > err:msi:ACTION_CallDllFunction GetProcAddress for function L"findApplications" in dll L"C:\\users\\dawncrow\\Temp\\msi94eb.tmp" failed > so you see that just the function is not info enough. I don't see that. The name of the temp file is not meaningful. -- Alexandre Julliard julliard(a)winehq.org

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Nikolay Sivov

On 6/13/2010 18:53, Dan Kegel wrote: > How close are we to release? Not closely related to a beta testing, but for quality it is - it would be nice to have valgrind tests logs as you did some months ago. I think it's possible to catch something new that is easy to fix for 1.2.

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Dan Kegel

On Sun, Jun 13, 2010 at 10:00 AM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: >> How close are we to release? Maybe it'd be worth >> it to publicise the upcoming wine release by >> flogging rc3 in various news sites and getting more people to >> look for regressions. > > +1. OK, I've posted something to linuxtoday and lwn.net. I wanted to include something about how many bugs have been fixed etc., but I didn't have those statistics handy, so I just said "many more apps should work with 1.2 than with 1.0". > I'm getting a fresh git and fixing/running and then submitting the > EM_FORMATRANGE patches today. Thanks! - Dan

June 13, 2010

Updating the 1.2 release announcement text

by Dan Kegel

http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by James McKenzie

Edward Savage wrote: > On Mon, Jun 14, 2010 at 12:53 AM, Dan Kegel <dank(a)kegel.com> wrote: > >> How close are we to release? Maybe it'd be worth >> it to publicise the upcoming wine release by >> flogging rc3 in various news sites and getting more people to >> look for regressions. >> >> > > If it's still a couple of weeks off I could write up a request to put > in WWN for people to fire up Wine and test their favourite apps. I've > just finished my last grueling assignment set for the semester so I > want to get on to putting out another WWN on the road to release. > Regardless I'll try and have some thing out for this friday. > > > > Great idea and good luck on finishing another semester of school. Hopefully, your grades were good and you learned a lot. James McKenzie

June 13, 2010

Re: Release plans

by James McKenzie

Michael Stefaniuc wrote: > On 06/13/2010 10:39 AM, wylda(a)volny.cz wrote: >> >> Hi, another week and Sunday gone so time for simple numbers... >> >> 340 regressions<-- release announcement >> 356 regressions<-- release announcement + 1week >> 339 regressions<-- release announcement + 2weeks(rc1) >> 322 regressions<-- release announcement + 3weeks(rc2) >> 325 regressions<-- release announcement + 4weeks >> 326 regressions<-- release announcement + 5weeks(rc3) >> >> List of fixed bugs on rc3 release was long and impressive. Unfortunately >> for regressions there is a stagnation. > Regression bugs do get fixed too but "new" regressions are added at > the same rate. A lot of the of the newly reported regressions happened > before 1.2-rc1; it looks like people are using the release candidates > to test their favorite app with and report the regression they find. > And that is good; just screws up the statistics ;) > I'll second this as there have been "My application works with Wine 1.0.1, but does not with Wine-1.2-rc(x)' messages in Wine Users. Of course, this leads to bug reports. I'll start looking at regressions as soon as I can. James McKenzie

June 13, 2010

Re: Two enhancement requests for winetricks

by James McKenzie

Jan Hoogenraad wrote: > Attached a simple script which at least removes those files that were > installed by another application (possibly winetricks) and are now > provided by wine. > > On my computer, it removed the following files (of which I am unsure > of its origins). > 17680 1998-08-06 12:43 psapi.dll > 131072 1999-01-15 04:37 mapi32.dll > 348160 2008-10-06 23:30 msvcr71.dll > 258352 2008-10-06 23:30 unicows.dll > 65304 2010-06-08 16:58 winhlp32.exe > > > .. based on the date match, I suspect the files below as well. > However, there are no files with the same name in the wine directory, > and thus my simple script is unable to judge them as being superseded: > 924432 2008-10-06 23:30 MFC40.DLL > 499712 2008-10-06 23:30 msvcp71.dll > 326656 2008-10-06 23:30 MSVCRT40.DLL > 492304 2008-10-06 23:30 OLEAUT32.DLL > 21936 2008-10-06 23:30 help.exe > 995383 2008-10-06 23:30 MFC42.DLL > 70656 2008-10-06 23:30 MSVCIRT.DLL > VB6, possibly? James McKenzie

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by Edward Savage

On Mon, Jun 14, 2010 at 12:53 AM, Dan Kegel <dank(a)kegel.com> wrote: > How close are we to release? Maybe it'd be worth > it to publicise the upcoming wine release by > flogging rc3 in various news sites and getting more people to > look for regressions. > If it's still a couple of weeks off I could write up a request to put in WWN for people to fire up Wine and test their favourite apps. I've just finished my last grueling assignment set for the semester so I want to get on to putting out another WWN on the road to release. Regardless I'll try and have some thing out for this friday.

June 13, 2010

Re: Inviting users to look for regressions in wine-1.2rc3?

by James McKenzie

Dan Kegel wrote: > How close are we to release? Maybe it'd be worth > it to publicise the upcoming wine release by > flogging rc3 in various news sites and getting more people to > look for regressions. > +1. I'm getting a fresh git and fixing/running and then submitting the EM_FORMATRANGE patches today. James McKenzie

June 13, 2010

Inviting users to look for regressions in wine-1.2rc3?

by Dan Kegel

How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. The thread about Wylda's statistics reminded me about http://wiki.winehq.org/PlatinumRegressionHunt We mentioned that in the first 1.0 rc announcement: http://www.winehq.org/announce/1.0-rc1 but not in http://www.winehq.org/announce/1.2-rc1 How 'bout we mention it in the rc4 release announcement and/or blogs?

June 13, 2010

re: Anotated 'make test' log

by Dan Kegel

What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to do so around areas of pain for users. For instance, you could look at bugs in bugzilla that have patches attached that aren't committed yet because tests are needed, and write those tests. - Dan

June 13, 2010

Re: Release plans

by Michael Stefaniuc

On 06/13/2010 10:39 AM, wylda(a)volny.cz wrote: > > Hi, another week and Sunday gone so time for simple numbers... > > 340 regressions<-- release announcement > 356 regressions<-- release announcement + 1week > 339 regressions<-- release announcement + 2weeks(rc1) > 322 regressions<-- release announcement + 3weeks(rc2) > 325 regressions<-- release announcement + 4weeks > 326 regressions<-- release announcement + 5weeks(rc3) > > List of fixed bugs on rc3 release was long and impressive. Unfortunately > for regressions there is a stagnation. Regression bugs do get fixed too but "new" regressions are added at the same rate. A lot of the of the newly reported regressions happened before 1.2-rc1; it looks like people are using the release candidates to test their favorite app with and report the regression they find. And that is good; just screws up the statistics ;) bye michael

June 13, 2010

Re: Release plans

by wylda＠volny.cz

Hi, another week and Sunday gone so time for simple numbers... 340 regressions <-- release announcement 356 regressions <-- release announcement + 1week 339 regressions <-- release announcement + 2weeks(rc1) 322 regressions <-- release announcement + 3weeks(rc2) 325 regressions <-- release announcement + 4weeks 326 regressions <-- release announcement + 5weeks(rc3) List of fixed bugs on rc3 release was long and impressive. Unfortunately for regressions there is a stagnation.

June 13, 2010

Anotated 'make test' log

by Max TenEyck Woodbury

I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A few reservations: * I started from the top of the log. If I continue, I will be selecting sections that I find interesting. * I am not going to produce patches until someone says that the annotations are going in the right direction. This will change when I become more familiar with the community's opinion of my efforts. ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so cred.c && touch cred.ok Note: This test is expected to produce 2 error reports call is pCredReadA(TEST_TARGET_NAME, -1, 0, &cred) implementation at dll/advavi32/cred.c - CredReadA parameter names: TargetName, Type, Flags, *Credentials conversion to CreadReadW implementation at same - CredReadW fixme:cred:CredReadW unhandled type -1 Fixup: Convert 'if (Type != CRED_TYPE_GENERIC && Type != CRED_TYPE_DOMAIN_PASSWORD)' to a switch(case?) with all known types enumerated. Put unimplemented types at the end with a 'fixup' then fall through to the default case which sets the error code and fails. Note: In other words, don't request fixup for improper type codes. call is pCredReadA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef, &cred) see above for details fixme:cred:CredReadW unhandled flags 0xdeadbeef Fixup: Get a list of all known flags. Build a mask for all of them. Check for any unknown flags set and issue a warning if there are any. Build a mask of all implemented flags (currently none) and issue a fixme if any of those are set. Note: In other words, don't request fixup for undefined flags set. Question: Should this be an failure exit? Alternatively, should there be a list of flags that, if set trigger a failure exit? Note: Only fail if the flags indicate an option that can not be ignored. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredWriteA(&new_cred, 0) implementation at same - CredWriteA parameter names: Credential, Flags new_cred.UserName = 'winetest' new_cred.TargetName = TEST_TARGET_NAME conversion to CredWriteW implementation at same - CredWriteW err:cred:CredWriteW bad username L"winetest" Note: This is an expected error. Note: Should it mention 'syntax' since it is checking for \ and @? Note: No bad flags test - Fixup per CredReadW above. Note: No bad type test - Fixup per CredReadW above. call is pCredWriteA(&new_cred, 0) see above for details. new_cred.UserName = NULL err:cred:CredWriteW bad username (null) Note: This is an expected error. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredDeleteA(TEST_TARGET_NAME, -1, 0) implementation at same - CredDeleteA parameter names: TargetName, Type, Flags conversion to CredDeleteW fixme:cred:CredDeleteW unhandled type -1 Fixup: see CredReadA above call is pCredDeleteA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef) se above for details. fixme:cred:CredDeleteW unhandled flags 0xdeadbeef fixup: see CreadReadA above Note: No sucess tests. Note: Test order is questionable. A better order would be Write, Read then Delete with tests that are expected to succeed added. call is pCredReadDomainCredentialsA(&info, 0, &count, &creds implementation at same - CredReadDomainCredentialsA parameter names: TargetInformation, Flags, *Size, **Credentials conversion to CredReadDomainCredentialsW fixme:cred:CredReadDomainCredentialsW (0x15ddf8, 0x0, 0x33fd18, 0x33fc4c) stub Fixup: No suggestion

June 13, 2010

Re: Two enhancement requests for winetricks

by Jan Hoogenraad

Attached a simple script which at least removes those files that were installed by another application (possibly winetricks) and are now provided by wine. On my computer, it removed the following files (of which I am unsure of its origins). 17680 1998-08-06 12:43 psapi.dll 131072 1999-01-15 04:37 mapi32.dll 348160 2008-10-06 23:30 msvcr71.dll 258352 2008-10-06 23:30 unicows.dll 65304 2010-06-08 16:58 winhlp32.exe .. based on the date match, I suspect the files below as well. However, there are no files with the same name in the wine directory, and thus my simple script is unable to judge them as being superseded: 924432 2008-10-06 23:30 MFC40.DLL 499712 2008-10-06 23:30 msvcp71.dll 326656 2008-10-06 23:30 MSVCRT40.DLL 492304 2008-10-06 23:30 OLEAUT32.DLL 21936 2008-10-06 23:30 help.exe 995383 2008-10-06 23:30 MFC42.DLL 70656 2008-10-06 23:30 MSVCIRT.DLL Dan: Can you attach this to http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" as I have no access to the Google thing ? Dan Kegel wrote: > On Wed, Jun 9, 2010 at 3:03 AM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: >> If you implement a status feature for every trick, you can change the >> main UI into a list of checkboxes, with the installed tricks already >> ticked. > > Right, of course. I had even realized that before. I guess I was > just in 'no' mode... > - Dan > -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht

June 12, 2010

Re: WINE and demoscene products

by Wolfram Sang

On 12/06/10 08:37, Dan Kegel wrote: > Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks > last year, it was very convincing. (Although, frankly, running Cool. > retail DVD-ROM games on day of beta or release is an even more > convincing feat if we can pull it off.) Sure thing - for marketing, games are probably more convincing. For testing though, demos might be quite useful as they are easier to get. > As somebody else pointed out, there are already appdb entries for That somebody was me ;) > (I'm not sure how much overlap there is between demos and > real games, but the idea of a really small graphical app is > appealing, one would expect they'd be easier to diagnose?) Well... can't tell about the overlap. A few of the creators work in the game-buisness, though. And while not all demos are small, the small ones (in size, like 4k) often do nasty tricks to achieve their mission; I have no experience if that makes them harder to debug in reality. Still, there is one major advantage: Most people do talk about their code if asked. So maybe they could point to potential issues or alike. Regards, Wolfram

June 12, 2010

Re: Three year sever outstanding bug requiring minor fix

by Peter Davies

On 12 June 2010 00:23, Aneurin Price <aneurin.price(a)gmail.com> wrote: > Is it a legal requirement that everyone working on WINE must be a > complete arsehole, or just a project requirement? > > Nye Which side are you on? Peter

June 12, 2010

re: WINE and demoscene products

by Dan Kegel

Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks last year, it was very convincing. (Although, frankly, running retail DVD-ROM games on day of beta or release is an even more convincing feat if we can pull it off.) As somebody else pointed out, there are already appdb entries for quite a few demos: http://appdb.winehq.org/objectManager.php?sClass=category&iId=95 It'd be nice if someone filled in any missing ones there. (I'm not sure how much overlap there is between demos and real games, but the idea of a really small graphical app is appealing, one would expect they'd be easier to diagnose?) - Dan

June 12, 2010

Re: Two enhancement requests for winetricks

by Jan Hoogenraad

I can not yet see how the lowest common denominator end-user can use this transparently (i.e. for example from the Ubuntu user interface shell). Just clicking on an installation CD puts everything into ~/.wine. I guess in some instances (e.g. installing add-ons or updates on programs) one needs interaction. Can wine handle multiple instances of the server for the different directories, when applications from different start directories are running in parallel ? If this is not the officially documented, I think one cannot expect an end-user to do this. Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > Jan Hoogenraad wrote: >> Each debugging request for wine states that I should remove all winetricks. > AppDB should request something similar: minimal use of winetricks. >> However I have no way to tell, and no way to safely remove them. > > IMHO one solution to your problem is to learn to use different .wine prefixes. > > Both developers and AppDB users want a repeatable process to make the > app run (or crash). If you install all your software into a single > .wine hierarchy (like you'd do on MS-Windows), then you cannot tell > anyone what you did to make the app work in Wine. All you have is "I > started with Wine-0.9.48, upgraded to wine-1.1.6 at some time, now to > wine-1.2rc2, used "winetricks X" and Y, perhaps I used "winetricks > directx" but I can't remember for sure, I installed apps A, B and C > (they may have installed more components) and I edited the registry a > few times. Given all that, app Z works fine in on my machine." > > This is a mess much like a typical MS-Windows installation. > With Wine, you can do better than that. > > What people want to hear from you is as follows: > - Create a fresh .wine prefix with wine-X.Y; > - Install Indeo Video codecs via "winetricks indeo" because I found out > that the app expects them but does not install them itself; > - Install the app from CD; > - From a DirectX install into a separate .wine-* prefix, > solely copy d3dx9_36.dll into system32/ (or the app's directory) > - Change setting Y in winecfg, e.g. native d3dx9_36; > - App Z works (or crashes like that ...). > That is a minimal instruction set. > > I have like a dozen .wine-* directory hierarchies. I never use .wine > itself except for regression testing, such that I can rm -rf ~/.wine > and create a fresh one at any time. > > That's why I don't need an uninstaller. rm -rf ~/.wine-xyz or > rm -rf ~/wineapps/... *is* the uninstaller (.wine-xyz/drive_c/Programs/Apps/ > symlinks to $HOME/wineapps such that the apps live independently on a particular .wine prefix). > > Regards, > Jörg Höhle > -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht

June 12, 2010

snoop,relay,trace

by Hin-Tak Leung

I am thinking of going barbaric and doing WINEDEBUG=+relay,+snoop,+trace to see how mt.exe get the wrong image size in http://bugs.winehq.org/show_bug.cgi?id=22812 and just grep for the wrong/right sizes (0x "2b000", "176128", 0x "2b200", "176640" ) to see where mt gets it from but none turn up. Since it is a relatively simple command line I thought that would work. or is there any other WINEDEBUG= is worth trying? Also I am thinking since the image size is normally padded to 0x1000, (and it says so), so a PE with an image size that looks like NNNNN200 is automatically wrong, is that correct?

June 12, 2010

WINE and demoscene products

by Wolfram Sang

Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine 1.2-rc2 was recently posted here [2]. Out of 25, 14 are flawless and 4 OK - pretty good numbers IMO. (BTW the demos can be downloaded using the search function of the website.) Regards, Wolfram [1] http://en.wikipedia.org/wiki/Demo_%28computer_programming%29 [2] http://pouet.net/topic.php?which=7400

June 12, 2010

Re: Three year sever outstanding bug requiring minor fix

by Aneurin Price

Is it a legal requirement that everyone working on WINE must be a complete arsehole, or just a project requirement? Nye

June 11, 2010

Re: Test suite success rate

by André Hentschel

Am 11.06.2010 20:43, schrieb Peter Davies: > How do I get the test suite to report it success rate (as a whole) in > a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. > > Peter > > "%d tests executed" will be a huge number! -- Best Regards, André Hentschel

June 11, 2010

Re: Test suite success rate

by Paul Vriens

On 06/11/2010 08:43 PM, Peter Davies wrote: > How do I get the test suite to report it success rate (as a whole) in > a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. > > Peter > > I guess the only way is to parse the report file yourself. The current 'parser' only calculates per module-test (as can been seen on test.winehq.org) -- Cheers, Paul.

June 11, 2010

Test suite success rate

by Peter Davies

How do I get the test suite to report it success rate (as a whole) in a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. Peter

June 11, 2010

Re: gdi32: Add CreateFontIndirectEx implementation (try2)

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try2: function body moved to *Ex call, and CreateFontIndirect use it. You should also print FIXMEs if the ignored data is used by the app. -- Alexandre Julliard julliard(a)winehq.org

June 11, 2010

Re: No test summary line found

by Paul Vriens

On 06/11/2010 02:19 PM, GOUJON Alexandre wrote: > Le 11/06/2010 13:54, Paul Vriens a écrit : >> I don't know if you have an account on the testbot so I tested it for >> you: > "I submitted [to wineTestBot] my patch before sending it to wine-patches" > But many thanks for your help !!! > > In that case, we have to use broken(), haven't we ? broken() can only be used to cater for a wrong return value (or parameter in general). It won't protect against a crash as the test will be run regardless. You need to find a way to detect NT4 (but not by checking the version) and skip those tests that crash. -- Cheers, Paul.

June 11, 2010