June 2010 - Wine-Devel - list.winehq.org

Re: kernel32: Add NERR_UserNotFound to Norweigan winerr

by Austin English

On Mon, Jun 28, 2010 at 1:24 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 06/28/2010 08:15 PM, Austin English wrote: >> >> See http://bugs.winehq.org/show_bug.cgi?id=11168 >> > > Hi Austin, > > Applying the patch gives: > > [paul(a)acer wine-git]$ patch -p 1 -i /home/paul/kernel32_nor.txt > (Stripping trailing CRs from patch.) > patching file dlls/kernel32/nls/winerr_nor.mc > > Compiling gives: > > ../../../wine-git/dlls/kernel32/nls/winerr_nor.mc:3737:2: Error: Unexpected > EOF > make: *** [nls/winerr_nor.mc.rc] Error 1 > > You need to add a '.' at the end of the mc file (see the others). Crap, thanks. Was on a slow machine, didn't test compiling it. I'll resend. -- -Austin

June 28, 2010

Re: kernel32: Add NERR_UserNotFound to Norweigan winerr

by Paul Vriens

On 06/28/2010 08:15 PM, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=11168 > Hi Austin, Applying the patch gives: [paul(a)acer wine-git]$ patch -p 1 -i /home/paul/kernel32_nor.txt (Stripping trailing CRs from patch.) patching file dlls/kernel32/nls/winerr_nor.mc Compiling gives: ../../../wine-git/dlls/kernel32/nls/winerr_nor.mc:3737:2: Error: Unexpected EOF make: *** [nls/winerr_nor.mc.rc] Error 1 You need to add a '.' at the end of the mc file (see the others). -- Cheers, Paul.

June 28, 2010

Re: Wine on cygwin now compiles!

by Steven Edwards

On Sun, Jun 27, 2010 at 4:59 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote: > Is there any real, practical interest in Wine on Windows? For doing a full port, other than the argument of climbing the mountain because it's there, I doubt it. > I've been making some progress in this direction recently (though I think my > approach would be to have a ported, NT-version of wineserver.exe which just > uses native functions of the OS instead of emulating them over cygwin, which > emulates those features using its own code once again; discussable anyway). I think as we have discussed before, taking arwinss, or at least the core parts of it and attempting to make an independent subsystem that runs under Windows has value. I believe there is a worthwhile product based upon your work with arwinss using Wine user32/gdi32/x11drv with the rest of the Windows stack to support remotely displaying Win32 applications over X11 to OS X, Solaris and Linux clients. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

June 28, 2010

Re: Possible patch for #12706

by Maarten Lankhorst

Hi Jeff, 2010/6/25 Jeff Cook <jeff(a)deserettechnology.com>: > This is a patch that makes WINE detect snd_usb_audio mics and assign > them a mixer and working master control. See bug #12706 for more > information about this problem: http://bugs.winehq.org/show_bug.cgi?id=12706 > > I wasn't able to test it completely because I wasn't able to switch my > default input device to the USB mic and no one in IRC is helping with > this, but it might make things work because theoretically the only > problem was that WINE was ignoring devices that looked like > snd_usb_audio's microphones. I suggest that someone who CAN get > snd_usb_audio mic as their default test it out and confirm, I would > really appreciate that. If you really want to force it, do lsmod |grep snd and do modprobe -r over all driver modules, snd-usb-audio and usually snd-hda-intel or something like that. Then modprobe snd-usb-audio and it will be the only audio device, so its always the default. ;) ~Maarten

June 28, 2010

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

by Wolfram Sang

On 28/06/10 13:26, Alexandre Julliard wrote: > Wolfram Sang <wolfram(a)the-dreams.de> writes: > >> According to TestBot (#2851), all non-crashing Windows versions return 0. >> >> Found while working on Bug 21012. Although this patch doesn't cure this >> bug, I think it is still worth adding the check because the pointer >> may come from the (always evil ;)) user-application. > > Do you have an actual application that does this, or is this just hiding > a Wine bug? Nope, no application (yet). As said, I found this flaw while checking #21012. The accompanying tests, which sadly crash some windows versions, backup the changes AFAICS. I can repost after 1.2 if you prefer that. Regards, Wolfram

June 28, 2010

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

by Alexandre Julliard

Reece Dunn <msclrhd(a)googlemail.com> writes: > When running winedbg on bfginstaller.exe (trying to track down > http://bugs.winehq.org/show_bug.cgi?id=14343) winedbg will trap in > the cursoricon.c code (line 771 -- > http://source.winehq.org/git/wine.git/?a=blob;f=dlls/user32/cursoricon.c;h=…) > > 767 /* pre-multiply by alpha */ > 768 for (i = 0, ptr = bits; i < bm.bmWidth * bm.bmHeight; i++, ptr += 4) > 769 { > 770 unsigned int alpha = ptr[3]; > 771 ptr[0] = ptr[0] * alpha / 255; > 772 ptr[1] = ptr[1] * alpha / 255; > 773 ptr[2] = ptr[2] * alpha / 255; > 774 } > > The app itself does not crash there when not running without winedbg, > but is generating an issue later on that does not make sense (which I > am suspecting is a stack corruption issue, possibly triggered by this > issue). That's a DIB exception. Perfectly normal, and nothing whatsoever to do with the patch. -- Alexandre Julliard julliard(a)winehq.org

June 28, 2010

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

by Reece Dunn

On 28 June 2010 12:26, Alexandre Julliard <julliard(a)winehq.org> wrote: > Wolfram Sang <wolfram(a)the-dreams.de> writes: > >> According to TestBot (#2851), all non-crashing Windows versions return 0. >> >> Found while working on Bug 21012. Although this patch doesn't cure this >> bug, I think it is still worth adding the check because the pointer >> may come from the (always evil ;)) user-application. > > Do you have an actual application that does this, or is this just hiding > a Wine bug? When running winedbg on bfginstaller.exe (trying to track down http://bugs.winehq.org/show_bug.cgi?id=14343) winedbg will trap in the cursoricon.c code (line 771 -- http://source.winehq.org/git/wine.git/?a=blob;f=dlls/user32/cursoricon.c;h=…) 767 /* pre-multiply by alpha */ 768 for (i = 0, ptr = bits; i < bm.bmWidth * bm.bmHeight; i++, ptr += 4) 769 { 770 unsigned int alpha = ptr[3]; 771 ptr[0] = ptr[0] * alpha / 255; 772 ptr[1] = ptr[1] * alpha / 255; 773 ptr[2] = ptr[2] * alpha / 255; 774 } The app itself does not crash there when not running without winedbg, but is generating an issue later on that does not make sense (which I am suspecting is a stack corruption issue, possibly triggered by this issue). I'm not sure if this is a wine bug, whether Wolfram's patch gets past the break triggered or whether it addresses the Big Fish Games issue. I'll test the patch tonight. - Reece

June 28, 2010

Re: user32: Make sure the desktop window is created before caps enumeration.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch fixes the problem reported in the bug 21709. That's just hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

June 28, 2010

Re: [PATCH 2/3] shell32: Use more accurate PathIsURL instead of searching for a colon

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c > index 30aea3b..54d13dc 100644 > --- a/dlls/shell32/shfldr_desktop.c > +++ b/dlls/shell32/shfldr_desktop.c > @@ -193,7 +193,7 @@ static HRESULT WINAPI ISF_Desktop_fnParseDisplayName (IShellFolder2 * iface, > *ppidl = pidlTemp; > return S_OK; > } > - else if (strchrW(lpszDisplayName,':')) > + else if (PathIsURLW(lpszDisplayName)) > { A better way would be to check the result of the ParseURLW call. -- Alexandre Julliard julliard(a)winehq.org

June 28, 2010

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

by Alexandre Julliard

Wolfram Sang <wolfram(a)the-dreams.de> writes: > According to TestBot (#2851), all non-crashing Windows versions return 0. > > Found while working on Bug 21012. Although this patch doesn't cure this > bug, I think it is still worth adding the check because the pointer > may come from the (always evil ;)) user-application. Do you have an actual application that does this, or is this just hiding a Wine bug? -- Alexandre Julliard julliard(a)winehq.org

June 28, 2010