July 2010 - Wine-Devel - list.winehq.org

Re: wiki slightly broken still?

by Dimi Paun

On Fri, 2010-07-30 at 08:58 +0200, Francois Gouget wrote: > I have a theory: did the script move the remaining files to another > directory? Yes, it did. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

July 30, 2010

Re: [PATCH 5/5] gameux/tests: Add test of IGameExplorer2 creating

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4065 Your paranoid android. === W98SE (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false) === WNT4WSSP6 (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false) === W2KPROSP4 (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false) === WXPPROSP3 (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false) === W2K3R2SESP2 (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false) === W2K8SE (32 bit gameexplorer) === gameexplorer.c:43: Test failed: IGameExplorer creating failed (result false)

July 30, 2010

Re: [PATCH 1/5] gameux/tests: Add test of IGameExplorer creating

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4063 Your paranoid android. === W98SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WNT4WSSP6 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2KPROSP4 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WXPPROSP3 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K3R2SESP2 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K8SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)

July 30, 2010

Re: [PATCH 5/9] mciqtz32: Fix window visibility

by Alexandre Julliard

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -757,15 +757,12 @@ static DWORD MCIQTZ_mciWindow(UINT wDevID, DWORD dwFlags, LPMCI_DGV_WINDOW_PARMS > return 0; > > if (dwFlags & MCI_DGV_WINDOW_HWND && (IsWindow(lpParms->hWnd) || !lpParms->hWnd)) { > - LONG style = 0; > TRACE("Setting hWnd to %p\n", lpParms->hWnd); > IVideoWindow_put_Visible(wma->vidwin, OAFALSE); > - IVideoWindow_get_WindowStyle(wma->vidwin, &style); > - style &= ~WS_CHILD; > if (lpParms->hWnd) > - IVideoWindow_put_WindowStyle(wma->vidwin, style|WS_CHILD); > + IVideoWindow_put_WindowStyle(wma->vidwin, WS_CHILD); > else > - IVideoWindow_put_WindowStyle(wma->vidwin, style); > + IVideoWindow_put_WindowStyle(wma->vidwin, 0); This doesn't look right. Why do you want to clear all the style bits? -- Alexandre Julliard julliard(a)winehq.org

July 30, 2010

Re: shdocvw: Add Italian translation

by Paul Vriens

Hi Luca, You need to add the UTF-8 pragma: Warning: string "&Proprietà..." seems to be UTF-8 but codepage 1252 is in use. -- Cheers, Paul.

July 30, 2010

Creation of the Wine API wiki on SourceForge

by Max TenEyck Woodbury

A wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php has been created for documenting the API interface of WINE (as opposed to Microsoft Windows). It is in the planning stage at this point. - Max

July 30, 2010

[PATCH 3/9] mciqtz32: Fix mciSeek

by Joerg-Cyril.Hoehle＠t-systems.com

Maarten, @@ -331,16 +331,14 @@ static DWORD MCIQTZ_mciSeek(UINT wDevID, DWORD dwFlags, LPMCI_SEEK_PARMS lpParms - MCIQTZ_mciStop(wDevID, MCI_WAIT, NULL); is there a reason why you remove that? The MCI devices (mciwave, sequencer, avivideo, quartz with .avi, quartz with midi, quartz with .wav) all stop playing when seeking. How do you handle that in mciqtz? Is it delegated to the individual renderers? I don't see where. IIRC, I believe once found one exception but I can't remember where that was (perhaps mcicda? mcicda is quite a different beast, as it continues playing even after the application closes the device and exits, unlike the other MCI devices). Regards, Jörg Höhle

July 30, 2010

Re: shlwapi/tests: Fix some test failures on RTL enabled boxes

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4059 Your paranoid android. === W98SE (32 bit ordinal) === ordinal.c:616: Test failed: GetShellSecurityDescriptor should fail, got 0096F808 === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1783: Test failed: got 13 ordinal.c:1789: Test failed: got 25 ordinal.c:1804: Test failed: got 10 ordinal.c:1817: Test failed: got 13 ordinal.c:1825: Test failed: got 13 ordinal.c:1847: Test failed: got 25 ordinal.c:1855: Test failed: got 37, length 38 ordinal.c:1866: Test failed: got 40 ordinal.c:1877: Test failed: got 23 ordinal.c:1888: Test failed: got 26 === W7PROX64 (32 bit ordinal) === ordinal.c:1789: Test failed: got 24 ordinal.c:1839: Test failed: got 24 ordinal.c:1847: Test failed: got 24 ordinal.c:1855: Test failed: got 33, length 34 ordinal.c:1866: Test failed: got 36 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 10 ordinal.c:1804: Test failed: got 7 ordinal.c:1817: Test failed: got 10 ordinal.c:1825: Test failed: got 10 ordinal.c:1855: Test failed: got 33, length 34 ordinal.c:1866: Test failed: got 36 ordinal.c:1877: Test failed: got 20 ordinal.c:1888: Test failed: got 23

July 30, 2010

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

by Alexandre Julliard

Misha Koshelev <misha680(a)gmail.com> writes: > + for (i = 0; i < number_of_vertices; i++) > + { > + ok(compare_vec3(vertices[i].position, mesh->vertices[i].position), "Test %s, vertex position %d, result (%g, %g, %g), expected (%g, %g, %g)\n", name, i, vertices[i].position.x, vertices[i].position.y, vertices[i].position.z, mesh->vertices[i].position.x, mesh->vertices[i].position.y, mesh->vertices[i].position.z); > + ok(compare_vec3(vertices[i].normal, mesh->vertices[i].normal), "Test %s, vertex normal %d, result (%g, %g, %g), expected (%g, %g, %g)\n", name, i, vertices[i].normal.x, vertices[i].normal.y, vertices[i].normal.z, mesh->vertices[i].normal.x, mesh->vertices[i].normal.y, mesh->vertices[i].normal.z); Please add some line breaks occasionally. 100 chars is a reasonable limit, a bit more is tolerated, but 300 is too much. > + /* free lookup tables */ > + free_sincos_table(&phi); > + free_sincos_table(&theta); > + > + /* success */ > + return TRUE; There's no need for that sort of comments, the purpose of that code is obvious. -- Alexandre Julliard julliard(a)winehq.org

July 30, 2010

GetVolumeInformationA: please test this on MS-Windows

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, The binary from https://testbot.winehq.org/JobDetails.pl?Key=4014 passes all tests on native win95 w2k SP4 wxp SR3 and inside vmware on win98SE (Andrew Eikum) Jeff Zaroyko writes: >I ran your test binary in my MinGW shell (as part >of msysgit) under Windows Vista SP2 32bit. I can imagine two possible reasons why it fails on your Vista machine a) Testbot's mingw compiled binary running in the mingw shell may behave differently than a native bin in a native shell. b) SetEnvironmentVariable("=C:",path) is not usable on/since(?) Vista to modify the per-drive default directory and hence does not manage to establish the precondition needed for the test. Do you get different results when doing the following: # assuming C: is where %WINDOWSDIR% resides C: cd \ X: # which dir on X should not matter Y:\path\to\kernel32_test.exe volume C: cd \windows X: Y:\path\to\kernel32_test.exe volume # X: must not be C:; Y: can be any drive For completion, you could check whether you get different results when invoking the test.exe with current directory a) C:\ # many GetVolumeInfo tests are skipped b) C:\windows # dito c) X:\ with \windows as CD on C: d) X:\anysubdir with \windows as CD on C: e) X:\anysubdir with \ as CD on C: f) X:\ with \ as CD on C: I think that if SetEnv has no effect you'll get different failures. I.e. this batch file C: CD \ Y:\path\to\kernel32_test.exe volume CD windows Y:\path\to\kernel32_test.exe volume X: CD \ Y:\path\to\kernel32_test.exe volume CD \anysubdir Y:\path\to\kernel32_test.exe volume C: CD \ X: Y:\path\to\kernel32_test.exe volume CD \ Y:\path\to\kernel32_test.exe volume Thank you, Jörg Höhle

July 30, 2010