July 2010 - Wine-Devel - list.winehq.org

Re: explorer: implement X session management

by Paul "TBBle" Hampson

On 30 July 2010 01:30, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: >> Changelog: >> * explorer: implement X session management > Explorer should not have X11 as a dependency. This should be implemented > inside of winex11.drv. A (previously-discussed years ago) model for DirectInput/RawInput handling would have given explorer.exe an X11 dependency since there needs to be a single process for a given wine server that handles direct (XI2-style) input. I assume session shutdown notification works the same way, but haven't read the above patch very hard... Unless you're suggesting implementing it inside winex11.drv and having explorer then provide winex11.drv a non-X11-specific callback for when a session termination message arrives, to be turned into the Win32-equivalent message. (Which seems less correct to me, but not unreasonable) [Apologies for the duplicate, I forget that Gmail is "Reply" by default] -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com

July 30, 2010

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4052 Your paranoid android. === WXPPROSP3 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W2K3R2SESP2 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === WVISTAADM (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W2K8SE (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PRO (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PROX64 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086ahlsl.c:104: this is the last test seen before the exception No test summary line found === W7PROX64 (64 bit hlsl) === Timeout

July 30, 2010

Re: [1/2] richedit: Return correct values when EM_SETTEXTMODE fails.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4043 Your paranoid android. === W7PRO (32 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8

July 30, 2010

Re: wiki slightly broken still?

by Uwe Bonnes

>>>>> "Octavian" == Octavian Voicu <octavian.voicu(a)gmail.com> writes: >> "What is the name for a billion bytes?" Terabyte, at least in germany. Billion -> 10^12. 10^9 -> "Milliarde" So these questions can be tricky... -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

July 29, 2010

Re: wiki slightly broken still?

by Octavian Voicu

On Thu, Jul 29, 2010 at 8:41 PM, Dan Kegel <dank(a)kegel.com> wrote: > I like the idea. It is hard, but here are some possible questions: > > "What is the first name of the Finn who created the Linux operating system?" > "What is the abbreviation for the GNU C Compiler?" > "What is the name of the simple text editor that comes with Windows?" > "Complete the phrase: ____ screen of death" > "What is the name for a billion bytes?" > > I have no idea if those will faze spammers. Those questions will certainly keep away non-geek spammers. We could make a quiz-like anti-spam system with not-so-trivial questions :) Octavian

July 29, 2010

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

by Oldřich Jedlička

Hi Roderick, On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote: > On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger > > <stefandoesinger(a)gmx.at> wrote: > > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > >> DirectX 1 interface allowed creation of explicit back buffers, so move > >> the restrictive checks to DirectX 2+ implementations. > > > > It is still missing testing/handling of AddAttachedSurface > > Oldřich, while you are at it also check what happens if > DDSCAPS_3DDEVICE is used on a standalone backbuffer surface. I'm currently facing problems of missing test machine (no Windows XP), but I will try to get some :-) I want to add some 3DDEVICE creation tests to my test suite. Anyway, we have a real test case for BACKBUFFER + 3DDEVICE, which is a game Warhammer: Dark Omen (bug #9190). It creates a 3D backbuffer too, but fails later while playing with other surfaces - it tries to get some ZBUFFER surface via GetAttachedSurface(), but that doesn't find anything. Oldřich. > > Roderick

July 29, 2010

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.

by David Adam

On a real Vista windows box, tests fail at line 372: test failed: sin: Got 2: unexpected values line 385:test failed: cos: Got 2: unexpected values A+ David

July 29, 2010

Re: [PATCH 3/8] explorerframe/nstc: Add host window and create a treeview.

by David Hedberg

On Thu, Jul 29, 2010 at 9:19 PM, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/explorerframe/explorerframe_main.h | 3 + > dlls/explorerframe/nstc.c | 211 ++++++++++++++++++++++++++++++- > dlls/explorerframe/tests/nstc.c | 49 +++++++- > 3 files changed, 260 insertions(+), 3 deletions(-) > Sorry for the duplicate(s), gmail was (seemingly randomly) rejecting some of my mail.

July 29, 2010

Re: shell32: Initialize memory to zero in IShellItemArray constructor.

by David Hedberg

On Thu, Jul 29, 2010 at 9:16 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > I don't see a reason for this. If you want to zero two remaining fields do > it explicitly. Also this helper doesn't need WINAPI it seems. > Ok, please ignore this one then, I'll try again.

July 29, 2010

Re: shell32: Initialize memory to zero in IShellItemArray constructor.

by Nikolay Sivov

On 7/29/2010 22:21, David Hedberg wrote: > This is needed as we might, if passed an invalid riid, > hit ::Release before we get to initialize array or item_count. > --- > dlls/shell32/shellitem.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c > index 5b01262..a7b2f29 100644 > --- a/dlls/shell32/shellitem.c > +++ b/dlls/shell32/shellitem.c > @@ -765,7 +765,7 @@ static HRESULT WINAPI IShellItemArray_Constructor(IUnknown *pUnkOuter, REFIID ri > if(pUnkOuter) > return CLASS_E_NOAGGREGATION; > > - This = HeapAlloc(GetProcessHeap(), 0, sizeof(IShellItemArrayImpl)); > + This = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IShellItemArrayImpl)); > if(!This) > return E_OUTOFMEMORY; > I don't see a reason for this. If you want to zero two remaining fields do it explicitly. Also this helper doesn't need WINAPI it seems.

July 29, 2010