July 2010 - Wine-Devel - list.winehq.org

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

by Alexandre Julliard

Octavian Voicu <octavian.voicu(a)gmail.com> writes: > @@ -190,25 +190,31 @@ static void test_audioclient(IAudioClient *ac) > hr = IAudioClient_GetMixFormat(ac, NULL); > ok(hr == E_POINTER, "GetMixFormat returns %08x\n", hr); > > + pwfx = (void *)0xdeadbeef; > hr = IAudioClient_GetMixFormat(ac, &pwfx); > ok(hr == S_OK, "Valid GetMixFormat returns %08x\n", hr); > > - trace("Tag: %04x\n", pwfx->wFormatTag); > - trace("bits: %u\n", pwfx->wBitsPerSample); > - trace("chan: %u\n", pwfx->nChannels); > - trace("rate: %u\n", pwfx->nSamplesPerSec); > - trace("align: %u\n", pwfx->nBlockAlign); > - trace("extra: %u\n", pwfx->cbSize); > - ok(pwfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE, "wFormatTag is %x\n", pwfx->wFormatTag); > - if (pwfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > + trace("pwfx: %p\n", pwfx); > + if (pwfx == (void *)0xdeadbeef) pwfx = NULL; > + if (pwfx) That's ugly, you should check the function result, not a magic pointer value. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2010

Re: msi: prevent cryptical errors

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > when accidently using the wrong path then > err:msi:MSI_OpenPackageW can't find L"asf.msi" > is more readable than > err:msi:copy_package_to_temp failed to copy package L"asf.msi" to L"C:\\users\\dawncrow\\Temp\\msi71e7.tmp" (2) Then you should fix that function to display a better error, instead of adding an extra check to every open. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2010

Re: krnl386.exe: Fix last error check for DOS compatibility hack.

by Alexandre Julliard

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1092,7 +1092,7 @@ static BOOL INT21_CreateFile( CONTEXT86 *context, > winMode, winAttributes, 0 ); > /* DOS allows to open files on a CDROM R/W */ > if( winHandle == INVALID_HANDLE_VALUE && > - GetLastError()== ERROR_WRITE_PROTECT) { > + GetLastError() == ERROR_ACCESS_DENIED) { You should keep the old error too. -- Alexandre Julliard julliard(a)winehq.org

July 29, 2010

Re: explorer: implement X session management

by Dmitry Timoshkov

Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * explorer: implement X session management Explorer should not have X11 as a dependency. This should be implemented inside of winex11.drv. -- Dmitry.

July 29, 2010

Right-To-Left (RTL) languages and Wine

by Paul Vriens

Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main window will shows as normal LTR window layout with the menu's left justified as well. So eventhough the locale is set to Arabic it doesn't turn 'everything' into RTL. If we don't change the resource files for the RTL languages, that same logic will give us LTR Wine applications or am I wrong here? -- Cheers, Paul.

July 29, 2010

Re: GetVolumeInformationA: please test this on MS-Windows

by Jeff Zaroyko

On Thu, Jul 29, 2010 at 11:17 PM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: >> >> Andrew, >> >>> Run on a Win98SE VM. The E drive is a CDROM drive. >> >> Thank you very much for the result. I added the broken(GetLastError()) for >> Win9x >> based on your data. >> >> Now is your chance to repeat the test with >> https://testbot.winehq.org/JobDetails.pl?Key=4014 >> (either as .patch file or the binary from testbot). >> This is valuable because testbot skips most new tests, lacking another >> drive, >> giving no proof that the fixed patch indeed works without errors on win9x. >> If it fails, please report to wine-devel as I already submitted the new >> patch. > > Hi Jörg, > > No failures with the testbot executable. Run under the same Win98SE VM, > again from the E: drive. > > Andrew > > > Out of curiosity, I ran your test binary in my MinGW shell (as part of msysgit) under Windows Vista SP2 32bit. Regular winetest doesn't have any additional kernel32 volume test failures, but yours: $ kernel32_test.exe volume volume.c:395: Test failed: GetVolumeInformationA failed, last error 123 volume.c:406: Test failed: GetVolumeInformationA failed, last error 123 volume: 405 tests executed (0 marked as todo, 2 failures), 0 skipped. $ uname -a MINGW32_NT-6.0 JEFFZ-PC 1.0.11(0.46/3/2) 2009-02-27 22:34 i686 unknown jeffz(a)JEFFZ-PC ~/Desktop $ pwd /c/Users/jeffz/Desktop Regards Jeff

July 29, 2010

Re: GetVolumeInformationA: please test this on MS-Windows

by Andrew Eikum

On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Andrew, > >>Run on a Win98SE VM. The E drive is a CDROM drive. > Thank you very much for the result. I added the broken(GetLastError()) for Win9x > based on your data. > > Now is your chance to repeat the test with > https://testbot.winehq.org/JobDetails.pl?Key=4014 > (either as .patch file or the binary from testbot). > This is valuable because testbot skips most new tests, lacking another drive, > giving no proof that the fixed patch indeed works without errors on win9x. > If it fails, please report to wine-devel as I already submitted the new patch. Hi Jörg, No failures with the testbot executable. Run under the same Win98SE VM, again from the E: drive. Andrew

July 29, 2010

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

by Dmitry Timoshkov

Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: > > + SetLastError(0xdeadbeef); > > + ret = GetClassInfoEx(0, "static", NULL); > > Why not the explicit A-function? I see there is already an existing call > in the current tests, but still. An API without a suffix is A by default. > > + ok(!ret, "GetClassInfoEx() should fail\n"); > > + ok(GetLastError() == ERROR_NOACCESS, "expected ERROR_NOACCESS, got %d\n", GetLastError()); > > + > > + SetLastError(0xdeadbeef); > > + ret = GetClassInfoExW(0, staticW, NULL); > > + ok(!ret, "GetClassInfoExW() should fail\n"); > > + ok(GetLastError() == ERROR_NOACCESS || > > + GetLastError() == ERROR_CALL_NOT_IMPLEMENTED, /* win9x */ > > Wouldn't broken() be more appropriate? Probably, but I'd argue that returning ERROR_CALL_NOT_IMPLEMENTED differs from returning actually wrong error code. -- Dmitry.

July 29, 2010

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

by Paul Vriens

On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: > + SetLastError(0xdeadbeef); > + ret = GetClassInfoEx(0, "static", NULL); Why not the explicit A-function? I see there is already an existing call in the current tests, but still. > + ok(!ret, "GetClassInfoEx() should fail\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected ERROR_NOACCESS, got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = GetClassInfoExW(0, staticW, NULL); > + ok(!ret, "GetClassInfoExW() should fail\n"); > + ok(GetLastError() == ERROR_NOACCESS || > + GetLastError() == ERROR_CALL_NOT_IMPLEMENTED, /* win9x */ Wouldn't broken() be more appropriate? -- Cheers, Paul.

July 29, 2010

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4013 Your paranoid android. === W98SE (32 bit class) === class.c:932: Test failed: expected ERROR_NOACCESS, got -559038737 === WNT4WSSP6 (32 bit class) === class.c:932: Test failed: expected ERROR_NOACCESS, got -559038737 class.c:937: Test failed: expected ERROR_NOACCESS, got -559038737

July 29, 2010