August 2010 - Wine-Devel - list.winehq.org

Re: Specifying Reply-To header in patches email using git-send-email?

by Frédéric Delanoy

2010/8/21 Octavian Voicu <octavian.voicu(a)gmail.com>: > 2010/8/21 GOUJON Alexandre <ale.goujon(a)gmail.com>: >> [format] >> headers = "To: wine-patches <wine-patches(a)winehq.org>\nReply-To: >> wine-devel <wine-devel(a)winehq.org>\n" > > As the name of the section suggests, this adds header lines to files > generated with `git format-patch'. If you then send those files with > `git send-email', it should work. If you `git send-email' files > generated before configuring that, then it wouldn't have any effect. > > Initially I thought the mailing list software was configured to add > the Reply-To header automagically, guess I was wrong. > > Octavian OK. By using [format] headers = "Reply-To: wine-devel <wine-devel(a)winehq.org>\n" [sendemail] to = wine-patches <wine-patches(a)winehq.org> I manage to get fully automated sending (yeah!). OTOH, using headers = "wine-patches <wine-patches(a)winehq.org>\nReply-To: wine-devel <wine-devel(a)winehq.org>\n" doesn't work since you're asked to provide the "To:" and you end up with two different "To" headers. I'll update the wiki. Thanks guys for your help. Frédéric

Aug. 21, 2010

Re: [PATCH 2/2] quartz: implement IBaseFilter_FindPin

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4627 Your paranoid android. === WINEBUILD (build) === Make failed

Aug. 21, 2010

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android. === WINEBUILD (build) === Make failed

Aug. 21, 2010

Re: problem with ./configure & libGLU vs. libice-dev

by Austin English

On Fri, Aug 20, 2010 at 4:26 PM, <wylda(a)volny.cz> wrote: > > Hi, > > isn't there a problem with wine's configure script? I'm running on > new Debian Squezee and noticed (luckily), that when libice-dev is > installed, than ./configure can't find "-lGLU". > > But libice-dev doesn't have any influence on file "libGLU.so.1". > > So why configure says me "-lGLU... not found" when file > "/usr/lib/libGLU.so.1" is present? You'll want to check config.log for a more verbose error. -- -Austin

Aug. 21, 2010

Re: Specifying Reply-To header in patches email using git-send-email?

by GOUJON Alexandre

On 08/21/2010 03:35 PM, Frédéric Delanoy wrote: > This is used for git imap-send, and does not work for git-send-email > (I checked). > Following the relevant git send-email section > (http://wiki.winehq.org/GitWine#head-f09f3498e5910648468960a60ecf0f51b0fd4815 > - Sending the patches using smtp), I set "thread" to true, but this > doesn't change anything/has nothing to do with the "Reply-To" header, > rather the "In-Reply-To" header. > > I'm using git 1.7.2.1 > I attached the script I use to send patches to wine + my .git/config file The only drawback is that the "wine-patches <>" is added twice. But it works for me.

Aug. 21, 2010

Re: Specifying Reply-To header in patches email using git-send-email?

by Octavian Voicu

2010/8/21 GOUJON Alexandre <ale.goujon(a)gmail.com>: > [format] > headers = "To: wine-patches <wine-patches(a)winehq.org>\nReply-To: > wine-devel <wine-devel(a)winehq.org>\n" As the name of the section suggests, this adds header lines to files generated with `git format-patch'. If you then send those files with `git send-email', it should work. If you `git send-email' files generated before configuring that, then it wouldn't have any effect. Initially I thought the mailing list software was configured to add the Reply-To header automagically, guess I was wrong. Octavian

Aug. 21, 2010

Re: Specifying Reply-To header in patches email using git-send-email?

by Frédéric Delanoy

2010/8/21 GOUJON Alexandre <ale.goujon(a)gmail.com>: > On 08/21/2010 09:34 AM, Frédéric Delanoy wrote: >> >> Here's how my git config looks like: >> [sendemail] >> <smtp server config> >> from = user<email> >> to = wine-patches<wine-patches(a)winehq.org> >> assume8bitEncoding = UTF-8 >> >> suppresscc = self >> chainreplyto = false >> thread = false >> suppressfrom = true >> > > From > http://wiki.winehq.org/GitWine#head-4051a521ff163340844bba9c78036cd8c594a980 > and according to my .git/config, I think you're missing > > [format] > headers = "To: wine-patches <wine-patches(a)winehq.org>\nReply-To: > wine-devel <wine-devel(a)winehq.org>\n" > This is used for git imap-send, and does not work for git-send-email (I checked). Following the relevant git send-email section (http://wiki.winehq.org/GitWine#head-f09f3498e5910648468960a60ecf0f51b0fd4815 - Sending the patches using smtp), I set "thread" to true, but this doesn't change anything/has nothing to do with the "Reply-To" header, rather the "In-Reply-To" header. I'm using git 1.7.2.1 Frédéric

Aug. 21, 2010

Re: appwiz.cpl: Removed sign comparison warning

by Nikolay Sivov

On 8/21/2010 12:18, Marko Nikolic wrote: > Nikolay Sivov wrote: > >> On 8/20/2010 20:04, Marko Nikolic wrote: >>> Changed variable type to match function return type. >>> --- >>> dlls/appwiz.cpl/appwiz.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c >>> index ffd2b24..1b3370b 100644 >>> --- a/dlls/appwiz.cpl/appwiz.c >>> +++ b/dlls/appwiz.cpl/appwiz.c >>> @@ -406,7 +406,7 @@ static void UpdateButtons(HWND hWnd) >>> { >>> APPINFO *iter; >>> LVITEMW lvItem; >>> - DWORD selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, >>> LVM_GETNEXTITEM, -1, >>> + LRESULT selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, >>> LVM_GETNEXTITEM, -1, >>> LVNI_FOCUSED | LVNI_SELECTED); >>> BOOL enable_modify = FALSE; >>> >> There's no need for that, return value means integer item index. What >> are you fixing with that? > Hi Nikolay, > > The above change suppresses sign comparison warning in the line > > if (selitem != -1) ... > > and two more places below. selitem is declared as unsigned (DWORD), so > comparing with -1 produces warning. Since SendDlgItemMessageW anyway return > LRESULT which is signed integer, patch changes the variable type to match > function result and removes sign warnings. LRESULT is something that supposed to work anyway as I understand it, for this case I think it's better to cast function return value to INT and use INT as a local type. > BR, > > Marko > >

Aug. 21, 2010

Re: dlls/d3dx9_36/bytecodewriter.c oddity

by Gerald Pfeifer

On Thu, 19 Aug 2010, Matteo Bruni wrote: > Hmm, so srcidx is unused. Yes, that piece of code is useless now, it's > a remnant of an older version of that function where the source > register was handled by some ad-hoc code, which I since then replaced > with a call to the generic This->funcs->srcreg(). The function is > correct otherwise, there are some tests to confirm that. > In my opinion you can send the patch as is. Alternatively you can > replace that piece of code with just a check for instr->src[0].regnum > != T[0123]_REG, to keep the WARN, but it's not worth the effort > probably. Thanks a lot Matteo for your guidance! Based on this, I'll formally submit this to wine-patches. Gerald

Aug. 21, 2010

Re: crypt32: Correct CryptVerifyMessageSignature's use of pcbDecoded

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4624 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: appwiz.cpl: Removed sign comparison warning

by Marko Nikolic

Nikolay Sivov wrote: > On 8/20/2010 20:04, Marko Nikolic wrote: >> Changed variable type to match function return type. >> --- >> dlls/appwiz.cpl/appwiz.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c >> index ffd2b24..1b3370b 100644 >> --- a/dlls/appwiz.cpl/appwiz.c >> +++ b/dlls/appwiz.cpl/appwiz.c >> @@ -406,7 +406,7 @@ static void UpdateButtons(HWND hWnd) >> { >> APPINFO *iter; >> LVITEMW lvItem; >> - DWORD selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, >> LVM_GETNEXTITEM, -1, >> + LRESULT selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, >> LVM_GETNEXTITEM, -1, >> LVNI_FOCUSED | LVNI_SELECTED); >> BOOL enable_modify = FALSE; >> > There's no need for that, return value means integer item index. What > are you fixing with that? Hi Nikolay, The above change suppresses sign comparison warning in the line if (selitem != -1) ... and two more places below. selitem is declared as unsigned (DWORD), so comparing with -1 produces warning. Since SendDlgItemMessageW anyway return LRESULT which is signed integer, patch changes the variable type to match function result and removes sign warnings. BR, Marko

Aug. 21, 2010

Re: Specifying Reply-To header in patches email using git-send-email?

by GOUJON Alexandre

On 08/21/2010 09:34 AM, Frédéric Delanoy wrote: > Here's how my git config looks like: > [sendemail] > <smtp server config> > from = user<email> > to = wine-patches<wine-patches(a)winehq.org> > assume8bitEncoding = UTF-8 > > suppresscc = self > chainreplyto = false > thread = false > suppressfrom = true > >From http://wiki.winehq.org/GitWine#head-4051a521ff163340844bba9c78036cd8c594a980 and according to my .git/config, I think you're missing [format] headers = "To: wine-patches <wine-patches(a)winehq.org>\nReply-To: wine-devel <wine-devel(a)winehq.org>\n"

Aug. 21, 2010

Specifying Reply-To header in patches email using git-send-email?

by Frédéric Delanoy

I've tried for some time to specify the wine-devel Reply-To using git-send-email, with little success so far Any idea how this might be done? Here's how my git config looks like: [sendemail] <smtp server config> from = user <email> to = wine-patches <wine-patches(a)winehq.org> assume8bitEncoding = UTF-8 suppresscc = self chainreplyto = false thread = false suppressfrom = true Frédéric

Aug. 21, 2010

Re: [PATCH 5/5] shell32: Implement IExplorerBrowser::SetRect.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4604 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 4/5] shell32: Implement IExplorerBrowser::Initialize.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4603 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 3/5] shell32: Add IShellBrowser stub.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4602 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 2/5] shell32/tests: Add initial tests for the IExplorerBrowser control.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4601 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH] ntdll/tests: Add tests for RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 5]

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4600 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: advpakc/tests: Removed sign comparison warning in advpack tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4599 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 7/8] msvcp90/tests: Added basic_string<char> tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4597 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 2/2] d3dcompiler: Add D3DCreateBlob() test.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4596 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH try 2] ntdll: IMAGE_REL_BASED_HIGH, IMAGE_REL_BASED_LOW and IMAGE_REL_BASED_HIGHLOW should be supported on win64.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4595 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [7/7] comctl32/imagelist: Fail to create imagelist with zero or negative image dimensions

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4594 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [6/7] comctl32/imagelist: Fail in ImageList_GetIconSize on null parameters

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4593 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [5/7] comctl32/tests: More imagelist tests to show broken parameter validation

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4592 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010