August 2010 - Wine-Devel - list.winehq.org

Re: [4/7] comctl32/imagelist: Fix failure code for IImageList_Remove()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4591 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [3/7] comctl32/imagelist: Fix failure code for IImageList_Draw()

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4590 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [2/7] comctl32/tests: Use reduced IMAGELISTDRAWPARAMS structure size for tests

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4589 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [1/7] comctl32/tests: Use better names for test functions, discover some new test failures

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4588 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: oleau32: Try both SYS_WIN64 and SYS_WIN32 syskind in QueryPathOfRegTypeLib on win64.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4582 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: gdi32: Properly set ERROR_NOACCESS when GetObject receives invalid arguments

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4581 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 4/4] explorerframe: Some additional basic tests.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4578 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 3/4] explorerframe: Implement EnsureItemVisible.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4577 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH 2/4] explorerframe: Implement HitTest

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4576 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4574 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Re: [5/5] urlmon/tests: Added tests for IUriBuilder_GetFragment

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4571 Your paranoid android. === WINEBUILD (build) === Patch failed

Aug. 21, 2010

Ongoing Debian package maintenance.

by Ben Klein

Hello everyone, My health has not improved at all since my last call for help with the Debian package management. I really need someone to take over from me, or at least some help to devise a new set of (semi-)automated build scripts. Any volunteers? Kind regards, Ben

Aug. 20, 2010

problem with ./configure & libGLU vs. libice-dev

by wylda＠volny.cz

Hi, isn't there a problem with wine's configure script? I'm running on new Debian Squezee and noticed (luckily), that when libice-dev is installed, than ./configure can't find "-lGLU". But libice-dev doesn't have any influence on file "libGLU.so.1". So why configure says me "-lGLU... not found" when file "/usr/lib/libGLU.so.1" is present? Desperate W.

Aug. 20, 2010

Re: [website]Japanese Translation for "About Wine" page

by Jeremy Newman

I'll accept this patch when we also have a JA translation of the Front landing page. No point having other pages translated without at least that. -Newman On 08/17/2010 11:00 PM, kikuchy.h(a)gmail.com wrote: > From: Hiroshi Kikuchi<kikuchy.h(a)gmail.com> > > I want to join wine project. Nice to meet you. > Hiroshi Kikuchi > --- > templates/ja/about.template | 27 +++++++++++++++++++++++++++ > 1 files changed, 27 insertions(+), 0 deletions(-) > create mode 100644 templates/ja/about.template > > diff --git a/templates/ja/about.template b/templates/ja/about.template > new file mode 100644 > index 0000000..b83fad7 > --- /dev/null > +++ b/templates/ja/about.template > @@ -0,0 +1,27 @@ > + > + > + > +<h1 class="title">Wine について</h1> > + > +<p>Wine は、 Windows のソフトウェアを Windows 以外のOSで動作させるものです。Wine を使えば、Windows でするように Windows アプリケーションのインストールと実行が出来るようになります。</p> > + > +<p>Wine は現在活発に開発されています。まだ全てのプログラムが動作する訳ではありませんが、すでに<a href="http://wiki.winehq.org/UsageStatistics" title="Wine Usage Statistics">何人もの人たちが</a> Wine を使ってソフトウェアを動かしています。</p> > + > +<h3>オープンソース、そしてユーザーによる支援</h3> > + > +<p>Wine は未来永劫<a href="http://wiki.winehq.org/Licensing" title="Wine licensing">フリーソフト</a>です。Wine のソースコードのおよそ半分がボランティアによって書かれています。残り半分は商業的利潤のため、特にサポートがあるバージョンの Wine を発売している<a href="http://www.codeweavers.com/products/" title="Codeweavers Crossover Office">Codeweavers</a>によって支えられています。</p> > + > +<p>Wine はユーザーコミュニティに大きく頼っています。ユーザーのテストが私たちの、プログラムの動作状況を記録した<a href="http://appdb.winehq.org/" title="Wine Application Database">アプリケーションデータベース</a>を埋めてくれていますし、<a href="http://forums.winehq.org/" title="WineHQ Forums">フォーラム</a>の質問に対する答えも全てボランティアによるものです。</p> > + > +<h3>こちらもご覧ください:</h3> > +<ul> > +<li><a href="http://wiki.winehq.org/ImportanceOfWine">Wine が重要な理由</a></li> > +<li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Wine にまつわるウソ・ホント</a></li> > +<li><a href="http://wiki.winehq.org/WineHistory">Wine プロジェクトの歴史</a></li> > +<li><a href="http://wiki.winehq.org/ProjectOrganization">Organization and Leadership</a></li> > +</ul> > + > +<hr> > +<div class="link-container"> > +<p class="right-link">Wine の歴史:<a href="{$root}/history">次へ</a></p> > +</div> > > > >

Aug. 20, 2010

Re: appwiz.cpl: Removed sign comparison warning

by Nikolay Sivov

On 8/20/2010 20:04, Marko Nikolic wrote: > Changed variable type to match function return type. > --- > dlls/appwiz.cpl/appwiz.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c > index ffd2b24..1b3370b 100644 > --- a/dlls/appwiz.cpl/appwiz.c > +++ b/dlls/appwiz.cpl/appwiz.c > @@ -406,7 +406,7 @@ static void UpdateButtons(HWND hWnd) > { > APPINFO *iter; > LVITEMW lvItem; > - DWORD selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, LVM_GETNEXTITEM, -1, > + LRESULT selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, LVM_GETNEXTITEM, -1, > LVNI_FOCUSED | LVNI_SELECTED); > BOOL enable_modify = FALSE; > There's no need for that, return value means integer item index. What are you fixing with that?

Aug. 20, 2010

Re: The Test Bot seems to be having issues

by André Hentschel

Am 20.08.2010 17:15, schrieb Greg Geldorp: > Hi Thomas, > >> From: Thomas Mallaly >> >> First off, I'm not sure who should be contacted about this, but, it > appears >> that the test bot has got itself stuck while trying to run tests on a > patch >> submitted last night. > > Sorry, hadn't noticed it got stuck. Usually it doesn't need much > baby-sitting, > so I don't keep a close look on it. > You can always use the "Feedback" link on the TestBot home page. > >> The job in question is here [1], it's been over 12 >> hours since any progress has been made on it and no other submissions have >> run since then. Also, the Windows 98SE has been "reverting" this whole > time, >> so I'm not sure if this is the culprit or not. >> >> I also hate to admit that the job in question is from one of my patches I >> sent in last night (although I'm pretty sure it doesn't have anything to > do >> with the quality of the code in the patch ;-) ). > > The Win9x VMs are on a different (physical) machine, it appears there was a > network problem between the Test Bot host and the machine hosting the Win9x > VMs. The Win98SE VM getting stuck in the "reverting" state is the cause of > the problems, nothing to do with your patch. > >> Anyways, I'm hoping that somebody in charge of the test bot might be able > to >> fix the traffic jam it's causing. > > It's back up and running again, trying to catch up. > > Ge. > > > > Thx, will be a hard weekend for testbot, as today there should be two commits :) -- Best Regards, André Hentschel

Aug. 20, 2010

RE: The Test Bot seems to be having issues

by Greg Geldorp

Hi Thomas, > From: Thomas Mallaly > > First off, I'm not sure who should be contacted about this, but, it appears > that the test bot has got itself stuck while trying to run tests on a patch > submitted last night. Sorry, hadn't noticed it got stuck. Usually it doesn't need much baby-sitting, so I don't keep a close look on it. You can always use the "Feedback" link on the TestBot home page. > The job in question is here [1], it's been over 12 > hours since any progress has been made on it and no other submissions have > run since then. Also, the Windows 98SE has been "reverting" this whole time, > so I'm not sure if this is the culprit or not. > > I also hate to admit that the job in question is from one of my patches I > sent in last night (although I'm pretty sure it doesn't have anything to do > with the quality of the code in the patch ;-) ). The Win9x VMs are on a different (physical) machine, it appears there was a network problem between the Test Bot host and the machine hosting the Win9x VMs. The Win98SE VM getting stuck in the "reverting" state is the cause of the problems, nothing to do with your patch. > Anyways, I'm hoping that somebody in charge of the test bot might be able to > fix the traffic jam it's causing. It's back up and running again, trying to catch up. Ge.

Aug. 20, 2010

CVS gateway down for good

by Alexandre Julliard

Folks, The git->CVS gateway broke again, so I'm going to pull the plug on it. It doesn't make sense for me to spend more time fixing something that sees so little usage at this point. If you are still using CVS, you'll have to switch to git (or volunteer to host the gateway yourself...) Sorry about the inconvenience. -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2010

Re: The Test Bot seems to be having issues

by Thomas Mullaly

On Fri, Aug 20, 2010 at 4:44 AM, GOUJON Alexandre <ale.goujon(a)gmail.com>wrote: > > It's Grep Geldorp but wine-devel is a good place too. > Thanks, hopefully he notices the thread. > There are some <div> and </div> in your patch. > Anyway, the bot applied your patch successfully and began to run some of > your tests. > Hmm... All my patches (coming through wine-patches) seem to end up with those <div> tags in them, but, they've never caused problems. > Now, the only thing to do is waiting... > At this point I would be surprised if the Test bot started randomly working without any assistance. The job has been in the "running" state for 24+ hours already, without any progress being made. -- Thomas Mullaly thomas.mullaly(a)gmail.com

Aug. 20, 2010

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if it does not contain controls. [try 2]

by Alexandre Julliard

"Mikhail Maroukhine" <mikolg(a)yandex.ru> writes: > GetNextDlgTabItem returns hwndDlg if it does not contain controls and > searching next item. > GetNextDlgTabItem returns the first child if next TABSTOP control not > found. > > And returns 0 in both cases if searching prev item It breaks the tests: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so propsheet.c && touch propsheet.ok propsheet.c:312: Test failed: Focus should have been set to the Next button. Expected: 12324, Found: 65535 propsheet.c:363: Test failed: Focus should have been set to the Next button. Expected: 12324, Found: 65535 make[1]: *** [propsheet.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2010

Re: [PATCH] gdi32/enhmfdrv: Do not leak a HDC

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > --- > dlls/gdi32/enhmfdrv/init.c | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) It would be cleaner to move the CreateDCW call where it's needed. -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2010

Re: cmd: Improved a FIXME in WCMD_filesize64

by Alexandre Julliard

"Konrad Wartke" <kwartke(a)googlemail.com> writes: > cmd: Improved a FIXME in WCMD_filesize64 by using a better algorithm. It's not much better. Anyway, this should be done by using one of the existing formatting functions, maybe VarFormatNumber. -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2010

Re: [PATCH 7/8] msvcp90/tests: Added basic_string<char> tests

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -0,0 +1,30 @@ > +/* > + * Copyright 2010 Piotr Caban for CodeWeavers > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +/* basic_string<char, char_traits<char>, allocator<char>> */ > +#define BUF_SIZE_CHAR 16 > +typedef struct _basic_string_char > +{ > + void *allocator; > + union _data { > + char buf[BUF_SIZE_CHAR]; > + char *ptr; > + } data; > + size_t size; > + size_t res; > +} basic_string_char; Unless there's going to be a ton of definitions in there used by many different files, it's better to put that sort of thing directly in the C file to make it easier to build stand-alone. -- Alexandre Julliard julliard(a)winehq.org

Aug. 20, 2010

Re: The Test Bot seems to be having issues

by GOUJON Alexandre

On 08/19/2010 07:56 PM, Thomas Mullaly wrote: > First off, I'm not sure who should be contacted about this It's Grep Geldorp but wine-devel is a good place too. > , but, it appears that the test bot has got itself stuck while trying > to run tests on a patch submitted last night. The job in question is > here [1], it's been over 12 hours since any progress has been made on > it and no other submissions have run since then. Also, the Windows > 98SE has been "reverting" this whole time, so I'm not sure if this is > the culprit or not. There are some <div> and </div> in your patch. Anyway, the bot applied your patch successfully and began to run some of your tests. Now, the only thing to do is waiting...

Aug. 20, 2010

Re: gdi32: Properly set ERROR_NOACCESS when GetObject receives invalid arguments

by Jerome Leclanche

That's what I was going for originally, but AJ on IRC deemed it not necessary. J. Leclanche On Fri, Aug 20, 2010 at 12:27 AM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > On Thu, Aug 19, 2010 at 4:56 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: >> Broken programs will crash on wine if they, for example, pass >> arguments to GetObject in the wrong order. >> This fixes bug #18864. > >> + if (buffer && ((ULONG_PTR)buffer >> 16) == 0) > > Wouldn't a __TRY ... __EXCEPT_PAGE_FAULT be better / safer? > > Octavian > > >

Aug. 19, 2010