August 2010 - Wine-Devel - list.winehq.org

Re: wiki slightly broken still?

by Dimi Paun

On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: > How difficult would it be to use ReCaptcha? > > http://www.google.com/recaptcha Hm, don't know. We could hack our version to support recaptcha, but I'm not familiar with the code base, and I don't have the time right now. But I can take patches if someone is willing to do it. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Aug. 3, 2010

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)

by Vitaliy Margolen

On 08/02/2010 05:48 PM, Jeff Cook wrote: > Moved check to conform with C90. > > + if (mastelem) { > + /* Master control */ ... > + } else { Please follow file's format. Vitaliy

Aug. 3, 2010

Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)

by Vitaliy Margolen

On 08/02/2010 05:50 PM, Jeff Cook wrote: > - > + You adding trailing spaces here. > + } else { > + default_used = 1; > } > Please follow files' format - curly braces go on separate line. Also you don't need braces for one line "else". Vitaliy.

Aug. 3, 2010

Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)

by Vitaliy Margolen

On 08/02/2010 05:49 PM, Jeff Cook wrote: > --- > dlls/winealsa.drv/waveinit.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > - int scan_devices = (fixedpcmdev == -1); > + /* we always want to scan_devices; otherwise, if a default is set and the > + appropriate registry keys are not set, only the default device will be seen > + by wine. This is undesirable, for instance, if you have separate cards for > + capture and playback, like a USB microphone for capture */ > + int scan_devices = 1; Please make it possible to force old behavior via registry. This was done for a reason - some devices were crashing during initialization, some were taking way too long to initialize. Vitaliy

Aug. 3, 2010

Re: [PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)

by Vitaliy Margolen

On 08/02/2010 05:49 PM, Jeff Cook wrote: > --- > dlls/winealsa.drv/waveinit.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > + sprintf(description, "%s %d:%d", snd_pcm_info_get_name(infop), snd_pcm_info_get_card(infop), Please use snprintf to prevent possible buffer overflow. > + memcpy(ww->ds_desc.szDesc, description, > + min( (sizeof(ww->ds_desc.szDesc) - 1), strlen(description)) ); This does not guarantee that ww->ds_desc.szDesc will be \0 terminated. Vitaliy.

Aug. 3, 2010

Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

by Mariusz Pluciński

W dniu 03.08.2010 13:28, Nikolay Sivov pisze: > On 8/3/2010 13:58, Mariusz Pluciński wrote: >> --- >> dlls/gameux/Makefile.in | 1 + >> dlls/gameux/factory.c | 5 ++ >> dlls/gameux/gamestatistics.c | 153 >> ++++++++++++++++++++++++++++++++++++++++++ >> dlls/gameux/gameux_private.h | 1 + >> dlls/gameux/regsvr.c | 9 +++ >> 5 files changed, 169 insertions(+), 0 deletions(-) >> create mode 100644 dlls/gameux/gamestatistics.c >> + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), >> openType, pOpenResult, ppiStats); >> + FIXME("stub\n"); >> + return E_NOTIMPL; > No need for duplicated traces, add one FIXME with full parameter output > in it. > I hope my patches are acceptable despite of this. But in the future I'll avoid it, thanks.

Aug. 3, 2010

Re: wiki slightly broken still?

by Alexandru Băluț

On Thu, Jul 29, 2010 at 18:01, Dimi Paun <dimi(a)lattica.com> wrote: > Now that this issue is fixed, we can look again at the spam > problem. It was suggested that we use a 'TextChas' for non > logged in users: > http://moinmo.in/HelpOnSpam > > But it seems it's not too easy to come up with decent questions. > Should we try it? How difficult would it be to use ReCaptcha? http://www.google.com/recaptcha Thanks, Alex

Aug. 3, 2010

Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)

by Nikolay Sivov

On 8/3/2010 13:58, Mariusz Pluciński wrote: > --- > dlls/gameux/Makefile.in | 1 + > dlls/gameux/factory.c | 5 ++ > dlls/gameux/gamestatistics.c | 153 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/gameux/gameux_private.h | 1 + > dlls/gameux/regsvr.c | 9 +++ > 5 files changed, 169 insertions(+), 0 deletions(-) > create mode 100644 dlls/gameux/gamestatistics.c > + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats); > + FIXME("stub\n"); > + return E_NOTIMPL; No need for duplicated traces, add one FIXME with full parameter output in it.

Aug. 3, 2010

Re: regedit: Added Hebrew translation

by Yaron Shahrabani

How can I compile a single RC file? Yaron Shahrabani <Hebrew translator> On Tue, Aug 3, 2010 at 12:39 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > Yaron Shahrabani <sh.yaron(a)gmail.com> writes: > > > Hope everything is cool this time :) > > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > > + WS_BORDER > > +WS_EX_LAYOUTRTL > > +FONT 8, "MS Shell Dlg" > > That's not valid syntax. Please try to compile at least the files you > are changing, if you can't do a full build. > > -- > Alexandre Julliard > julliard(a)winehq.org >

Aug. 3, 2010

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

by Stefan Dösinger

Am 03.08.2010 um 02:47 schrieb Vitaly Budovski: > The INFINITY macro is part of C99, but for NaN, why not use something > like sqrt(-1) ? We don't use C99 features in Wine, some compilers don't support them. sqrt(-1) may or may not work, but it will be essentially the same as 0.0 / 0.0. Compilers may complain about sqrt(-1) just as they do with the 0.0 / 0.0 division.

Aug. 3, 2010

Re: [PATCH 5/6] winealsa.drv: Don't open the same card on every loop. (resend)

by Alexandre Julliard

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -753,7 +753,7 @@ static int ALSA_ScanDevices(int directhw, > char *pcmname = NULL; > snd_pcm_t *pcm; > > - sprintf(defaultpcmname, "default"); > + sprintf(defaultpcmname, "default:%d", card); We used to do that, but it was changed because it's not correct, cf. bug 10942. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2010

Re: regedit: Added Hebrew translation

by Alexandre Julliard

Yaron Shahrabani <sh.yaron(a)gmail.com> writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > + WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile at least the files you are changing, if you can't do a full build. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2010

Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)

by Alexandre Julliard

David Hedberg <david.hedberg(a)gmail.com> writes: > +static LRESULT resize_namespacetree(NSTC2Impl *This) > +{ > + RECT rc; > + TRACE("%p\n", This); > + > + GetClientRect(This->hwnd_main, &rc); > + SetWindowPos(This->hwnd_tv, HWND_TOP, rc.left, rc.top, > + rc.right, rc.bottom, SWP_SHOWWINDOW); Again, that's not the correct usage of SetWindowPos. You don't want to show or activate it. What you probably want is MoveWindow. -- Alexandre Julliard julliard(a)winehq.org

Aug. 3, 2010

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

by Michael Stefaniuc

Jeff Cook wrote: > What compiler are you running? It works fine for me and I don't see > any errors or warnings. You are passing the compiler the wrong flags: -Wdeclaration-after-statement is set by default in Wine. > On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Jeff Cook <jeff(a)deserettechnology.com> writes: >> >>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>> for (id = 0; id < mmixer->chans; ++id) >>> { >>> line *mline = &mmixer->lines[id]; >>> + if (!mline->elem) >>> + { >>> + break; >>> + } >>> int ofs = CONTROLSPERLINE * id; >> You can't do that: >> >> mixer.c: In function ‘fillcontrols’: >> mixer.c:252: error: ISO C90 forbids mixed declarations and code bye michael

Aug. 3, 2010

Re: GetVolumeInformationA: please test this on MS-Windows

by Jeff Zaroyko

On Mon, Aug 2, 2010 at 9:43 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Jeff Zaroyko wrote: > >>Would you mind supplying a new binary? > Testbot did it for us: job #4154 > https://testbot.winehq.org/JobDetails.pl?Key=4154 > > Regards, > Jörg Höhle This new #4154 binary doesn't have any failures when run from the MinGW shell: volume.c:345: Tests skipped: Please re-run from another device than C: volume: 392 tests executed (0 marked as todo, 0 failures), 1 skipped. Only the earlier binary from #4014 does as per the earlier email. Jeff

Aug. 3, 2010

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)

by Oldřich Jedlička

Hi Stefan, On Tuesday 03 August 2010 04:45:57 testbot(a)testbot.winehq.org wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=4179 > > Your paranoid android. > > > === W2KPROSP4 (32 bit visual) === > visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF this looks like a broken driver and I should fix this by adding a broken() check, right? Oldřich.

Aug. 3, 2010

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4188 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4187 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4186 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx

by Mike Kaplinskiy

On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> wrote: > --- > dlls/ws2_32/tests/sock.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? That's an outdated not working version of the patches. Otherwise I'll resend tomorrow. Sorry, Mike.

Aug. 3, 2010

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4179 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF

Aug. 3, 2010

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4178 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4175 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 2)

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4174 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

Aug. 3, 2010

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

by Vitaly Budovski

On 02/08/2010, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 2 August 2010 13:20, GOUJON Alexandre <ale.goujon(a)gmail.com> wrote: > > Why don't you use math.h NAN macro ? > > A quick search on google gave me > > http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html > > > > That's not portable enough. > The INFINITY macro is part of C99, but for NaN, why not use something like sqrt(-1) ?

Aug. 3, 2010