August 2010 - Wine-Devel - list.winehq.org

Re: shell32: Partial implementation of IShellItem::BindToHandler.

by Nikolay Sivov

On 8/2/2010 02:36, David Hedberg wrote: > +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, IShellFolder **ppsf) > +{ > + IShellFolder *desktop; > + HRESULT ret; > + > + ret = SHGetDesktopFolder(&desktop); > + if (SUCCEEDED(ret)) > + { > + if (_ILIsDesktop(This->pidl)) > + { > + *ppsf = desktop; > + IShellFolder_AddRef(*ppsf); > + } > + else > + { > + ret = IShellFolder_BindToObject(desktop, This->pidl, pbc,&IID_IShellFolder, (void**)ppsf); > + } > + > + IShellFolder_Release(desktop); > + } > + > + return ret; > +} > + > I don't think this explicit check for desktop folder is needed here, as I understand ::BindToObject() it should handle this case internally.

Aug. 2, 2010

Re: wordpad: Added Hebrew translation.

by Paul Vriens

Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: > Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL > for the dialogs, hope that helps. > > Also found out that menus does not need any special RTL property, they > are self aligned according to the app. What do you mean by that? Running Wordpad in Hebrew still gives me LTR menu styles/justification. The global (per process) RTL settings still need to be implemented for our internal apps. > > Kind regards, > Yaron Shahrabani > > <Hebrew translator> > > > > 0002-wordpad-Added-Hebrew-translation.patch > > > From 8f5dfcb55656e7e4d7943d622234fb37753210f7 Mon Sep 17 00:00:00 2001 > From: Yaron Shahrabani<sh.yaron(a)gmail.com> > Date: Sun, 1 Aug 2010 11:48:23 +0300 > Subject: wordpad: Added Hebrew translation. > > --- > programs/wordpad/He.rc | 282 ++++++++++++++++++++++++++++++++++++++++++ > programs/wordpad/Makefile.in | 1 + > 2 files changed, 283 insertions(+), 0 deletions(-) > create mode 100644 programs/wordpad/He.rc > > diff --git a/programs/wordpad/He.rc b/programs/wordpad/He.rc > new file mode 100644 > index 0000000..091ec98 > --- /dev/null > +++ b/programs/wordpad/He.rc > @@ -0,0 +1,282 @@ > +/* > + * Copyright 2004 by Krzysztof Foltman > + * Hebrew Translation by Yaron Shahrabani<sh.yaron(a)gmail.com>, 2010 Minor, but why did you not use the same format (as we see in most files)? So something like: /* * Hebrew Translation of wordpad * * Copyright 2004 by Krzysztof Foltman * Copyright 2010 Yaron Shahrabani<sh.yaron(a)gmail.com> > +IDD_DATETIME DIALOG 30, 20, 130, 80 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL Eventually we probably have to but I'm not sure what Alexandre thinks about introducing it (now). We probably also have to teach our tools (like the translation site) that detects translation differences/issues to cope with this. > +STRINGTABLE > +BEGIN > + STRING_ALIGN_LEFT, "שמאל" > + STRING_ALIGN_RIGHT, "ימין" > + STRING_ALIGN_CENTER, "מרכז" > +END This piece is already defined starting on line 226 and thus leads to: ../../../wine-git/programs/wordpad/He.rc:279:32: Error: Stringtable ID 1416 already in use -- Cheers, Paul.

Aug. 1, 2010

Re: user32: Add a test for GetClassInfo, make it pass under Wine. Take 2.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4119 Your paranoid android. === WNT4WSSP6 (32 bit class) === class.c:939: Test failed: expected ERROR_NOACCESS, got -559038737

Aug. 1, 2010

Re: New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive

by Octavian Voicu

On Sun, Aug 1, 2010 at 2:38 AM, Dan Kegel <dank(a)kegel.com> wrote: > Changes: > > Austin English: > New verbs eufonts [...] Nice, thanks! Octavian

Aug. 1, 2010

Re: New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive

by Dan Kegel

On Sat, Jul 31, 2010 at 4:38 PM, Dan Kegel <dank(a)kegel.com> wrote: > Changes: > > Austin English: > New verbs eadm eufonts gfw (aka xlive) ie8 safari secur32 I should have mentioned: ie8 doesn't quite work yet, but safari works well enough to do light browsing. I asked Austin to add the ie8 verb because some software requires it as a prerequisite, see http://bugs.winehq.org/show_bug.cgi?id=22732

Aug. 1, 2010

New wisotool 20100731: 44 new verbs (aa3, apb, ... masseffect2_demo, ... zen_of_sudoku_demo_steam)

by Dan Kegel

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except it prompts for your password so it can mount the .iso file, and it prompts you to insert the disk if the .iso file is not found). Wisotool currently supports about 145 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. Thanks to everyone who contributed changes for this release. Not all of these games currently work under wine. Workarounds for specific Wine bugs are applied if available. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100618: Austin English If iso isn't present, offer to make one for the user Generic Steam installer New verbs: aa3 (America's Army 3) apb (All Points Bulletin) arx_fatalis_demo_steam bookworm_adventures_deluxe_demo_steam daytona_usa_evolutions dc2ba (Dora's Carnival 2: Boardwalk Adventure) eets_demo_steam fallout3_goty (Fallout 3: Game of the Year edition) ffxivbench (Final Fantasy XIV benchmark) fifa10 fifa10_demo joint_task_force_demo_steam longest_journey_demo_steam lost_planet_dx10_demo_steam lost_planet_dx9_demo_steam metro2033 multiwinia_demo_steam napoleon_total_war_demo_steam painkiller_demo_steam sega_rally_2 singularity ssdd2 (SpongeBob SquarePants Diner Dash 2 Demo) starcraft2 total_war_and_empire_demo_steam twfc (Transformers: War for Cybertron) wowtrial (World of Warcraft trial) zen_of_sudoku_demo_steam Dan Kegel: Allow specifying a .verb file on commandline New verbs: algodoo_demo deadspace lotsn (Monkey Island: Launch of the Screaming Narwhal) masseffect2_demo secondlife_beta Eleazar Galano: New verbs: cnc3_demo (Command and Conquer 3 Demo) cnc4 fifaonline3_beta hphbp, hphbp_demo (Harry Potter Half Blood Prince) lhp (Lego Harry Potter) moh_beta (Medal of Honor) nfsshift nfsshift_demo oblivion sf4bench Jon Angelo: New verb hod3_jp_demo Thai Nguyen: New verb smbx

Aug. 1, 2010