September 2010 - Wine-Devel

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

by Reece Dunn

On 30 September 2010 11:25, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Reece, > > On 9/30/10 12:20 AM, Reece Dunn wrote: >> >> This addresses a fixme in the jscript code that is currently triggered >> when running the Big Fish Games client, with a test. > > if(V_VT(&constr) != VT_DISPATCH) { > - FIXME("throw TypeError\n"); > + hres = throw_type_error(ctx->parser->script, ei, > IDS_OBJECT_EXPECTED, NULL); > VariantClear(&constr); > - return E_FAIL; > + return hres; > > > It would be cleaner to clear constr before throw_type_error so that you can > return its result directly, without storing it in hres. You are correct. I will do this. > exception_test(function() {"test" in null;}, "TypeError", -2146823281); > exception_test(function() {"test" in nullDisp;}, "TypeError", -2146823281); > +exception_test(function() {new null;}, "TypeError", -2146823281); > > > While you're at this, it would be nice to add a test (and fix) for nullDisp > and test some other types (eg. undefined and number). I'll add tests for other types -- nullDisp, undefined, number, etc. with any corresponding fixes. - Reece

Sept. 30, 2010

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

by Jacek Caban

Hi Reece, On 9/30/10 12:20 AM, Reece Dunn wrote: > This addresses a fixme in the jscript code that is currently triggered > when running the Big Fish Games client, with a test. if(V_VT(&constr) != VT_DISPATCH) { - FIXME("throw TypeError\n"); + hres = throw_type_error(ctx->parser->script, ei, IDS_OBJECT_EXPECTED, NULL); VariantClear(&constr); - return E_FAIL; + return hres; It would be cleaner to clear constr before throw_type_error so that you can return its result directly, without storing it in hres. exception_test(function() {"test" in null;}, "TypeError", -2146823281); exception_test(function() {"test" in nullDisp;}, "TypeError", -2146823281); +exception_test(function() {new null;}, "TypeError", -2146823281); While you're at this, it would be nice to add a test (and fix) for nullDisp and test some other types (eg. undefined and number). Jacek

Sept. 30, 2010

Need to retrieve VS_VERSION_INFO for 16, 32, 64 bit windows binaries

by Kapil Arora

Hi, I've created a small executable on windows which calls GetFileVersionInfo() and VerQueryValue() to extract VS_VERSION_INFO from various windows binary files. I want to use this utility under wine on linux system. Everything works fine for most of the files but for some older dlls I'm not getting correct version information. In the wine sources I found some of the functions for previous (16- bit) version info extraction to be stubs. I tried replacing version.dll in $HOME/.wine/drive_c/windows/system32 with the one on my windows XP box but nothing happens. I still don't get complete information. Is there a way to achieve this. Thanks, Kapil.

Sept. 30, 2010

Re: Right-To-Left (RTL) languages and Wine

by Alexandre Julliard

Shachar Shemesh <shachar(a)shemesh.biz> writes: > On 29/09/10 21:59, James Mckenzie wrote: >> >> And Microsoft Office appears different in RTL rather than LTR. I used to work with someone that had the Arabic version of these programs and it would switch from RTL when typing in Arabic to LTR when typing in a Latin-based language. >> >> > I'm sorry, but you are confusing several issues here. The question is > not whether to implement BiDi (yes, provided we find the working hands > to do it) or mirroring (yes, except I don't think we need to bother > with mirroring the window decoration UI components that Windows does, > and I have not heard anyone else weight in on this issue lately). Mirroring is essentially implemented now, modulo some remaining bugs. And yes, the window decorations get mirrored too, it would actually be harder to not do it. -- Alexandre Julliard julliard(a)winehq.org

Sept. 30, 2010

Re: Right-To-Left (RTL) languages and Wine

by James McKenzie

On 9/29/10 2:29 PM, Shachar Shemesh wrote: > On 29/09/10 21:59, James Mckenzie wrote: >> >> And Microsoft Office appears different in RTL rather than LTR. I >> used to work with someone that had the Arabic version of these >> programs and it would switch from RTL when typing in Arabic to LTR >> when typing in a Latin-based language. >> > I'm sorry, but you are confusing several issues here. The question is > not whether to implement BiDi (yes, provided we find the working hands > to do it) or mirroring (yes, except I don't think we need to bother > with mirroring the window decoration UI components that Windows does, > and I have not heard anyone else weight in on this issue lately). The > question is whether Wine's built in application should set a specific > flag to do automatic mirroring. > > Since Word is not a Wine built in application, what it does is > irrelevant for this discussion, not because we don't intend to support > it, but because it is undisputed we do. > Thank you for the clarification on what the thread was all about. I thought it was a general RTL/LTR conversation. Pardon the interruption. Everyone on the thread does have a valid point though and I'll continue to watch rather than shout out a comment where it is not needed. James McKenzie

Sept. 30, 2010

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5608 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 30, 2010

Re: msxml3/httprequest: Add basic bind callback for moniker binding

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5605 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff

Sept. 30, 2010

Re: Right-To-Left (RTL) languages and Wine

by Shachar Shemesh

On 29/09/10 21:52, Alexandre Julliard wrote: > > You can't do that in resources, apart from simple dialogs. Many controls > are created directly in the code, so you need to change the source. > Whether this is to set the process-wide layout or to set WS_EX_LAYOUTRTL > individually on appropriate windows will depend on the app, but it needs > code changes either way. > > Okay. No dispute about that. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

Sept. 29, 2010

Re: Right-To-Left (RTL) languages and Wine

by Shachar Shemesh

On 29/09/10 21:59, James Mckenzie wrote: > > And Microsoft Office appears different in RTL rather than LTR. I used to work with someone that had the Arabic version of these programs and it would switch from RTL when typing in Arabic to LTR when typing in a Latin-based language. > > I'm sorry, but you are confusing several issues here. The question is not whether to implement BiDi (yes, provided we find the working hands to do it) or mirroring (yes, except I don't think we need to bother with mirroring the window decoration UI components that Windows does, and I have not heard anyone else weight in on this issue lately). The question is whether Wine's built in application should set a specific flag to do automatic mirroring. Since Word is not a Wine built in application, what it does is irrelevant for this discussion, not because we don't intend to support it, but because it is undisputed we do. Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

Sept. 29, 2010

Re: Right-To-Left (RTL) languages and Wine

by James Mckenzie

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Sep 29, 2010 11:25 AM >To: Shachar Shemesh <shachar(a)shemesh.biz> >Cc: Paul Vriens <paul.vriens.wine(a)gmail.com>, "'wine-devel(a)winehq.org'" <wine-devel(a)winehq.org> >Subject: Re: Right-To-Left (RTL) languages and Wine > >Shachar Shemesh <shachar(a)shemesh.biz> writes: > >> Did I mention that the automatic mirroring is a broken idea >> implemented in a broken way already? > >What do you consider broken about it? > >> Aside from notepad, for which the difference is very small, and most >> people would regard a default LTR control as the correct behavior >> anyway, what other applications are you concerned over? > >Pretty much all of them. For example, Wordpad has combo boxes in the >toolbars, those won't be RTL without changing the process layout. >Winefile and Regedit have treeviews that would need mirroring, etc. > And Microsoft Office appears different in RTL rather than LTR. I used to work with someone that had the Arabic version of these programs and it would switch from RTL when typing in Arabic to LTR when typing in a Latin-based language. As AJ has stated, there is more to do than just 'mirroring' to get RTL into Wine. I remember this was quite difficult to get into OpenOffice.org as well when I was testing it (I think I still have Hebrew and Arabic test files for Writer in OpenDocument (.odt) format.) James McKenzie

Sept. 29, 2010